usb: phy: signedness bug in suspend/resume

PATCH New Dan Carpenter 1 participant 1 message Sep 14, 2012

Subsystems (3)

USB Kernel janitors OMAP USB support

lore

Share & tools

lore

Dan Carpenter

author

2012-09-14 06:52 UTC #0 lore raw

PATCH 1/1 usb: phy: signedness bug in suspend/resume

"ret" should be signed here for the error handling to work.

Signed-off-by Dan Carpenter <[email protected]>

drivers/usb/phy/omap-usb2.c +2 -2

index 15ab3d6..d36c282 100644
@@ -120,7 +120,7 @@ static int omap_usb_set_peripheral(struct usb_otg *otg,
 
 static int omap_usb2_suspend(struct usb_phy *x, int suspend)
 {
-	u32 ret;
+	int ret;
 	struct omap_usb *phy = phy_to_omapusb(x);
 
 	if (suspend && !phy->is_suspended) {

@@ -223,7 +223,7 @@ static int omap_usb2_runtime_suspend(struct device *dev)
 
 static int omap_usb2_runtime_resume(struct device *dev)
 {
-	u32 ret = 0;
+	int ret;
 	struct platform_device	*pdev = to_platform_device(dev);
 	struct omap_usb	*phy = platform_get_drvdata(pdev);