USB: chipidea: convert to use devm_request_irq
Subsystems (2)
PATCH RESEND v2 1/1 USB: chipidea: convert to use devm_request_irq
--- drivers/usb/chipidea/core.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/usb/chipidea/core.c +2 -3
@@ -486,8 +486,8 @@ static int __devinit ci_hdrc_probe(struct platform_device *pdev) }platform_set_drvdata (pdev, ci); - ret =request_irq (ci->irq, ci_irq,IRQF_SHARED , ci->platdata->name, - ci); + ret =devm_request_irq (dev, ci->irq, ci_irq,IRQF_SHARED , + ci->platdata->name, ci);if (ret) goto stop;
@@ -518,7 +518,6 @@ static int __devexit ci_hdrc_remove(struct platform_device *pdev)flush_workqueue (ci->wq);destroy_workqueue (ci->wq);device_remove_file (ci->dev, &dev_attr_role); -free_irq (ci->irq, ci);ci_role_stop (ci);return 0 ;
Signature · 1 line
1.7.9.5
PATCH RESEND v2 1/1 USB: chipidea: convert to use devm_request_irq
Dear Richard Zhao,
You know, commit message would be nice to have.
Quoted 1 line
Signed-off-by Richard Zhao <[email protected]>
Otherwise
Quoted 20 lines
--- drivers/usb/chipidea/core.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)drivers/usb/chipidea/core.c +2
-2@@ -486,8 +486,8 @@ static int __devinit ci_hdrc_probe(struct platform_device *pdev) }platform_set_drvdata (pdev, ci); - ret =request_irq (ci->irq, ci_irq,IRQF_SHARED , ci->platdata->name, - ci); + ret =devm_request_irq (dev, ci->irq, ci_irq,IRQF_SHARED , + ci->platdata->name, ci);if (ret) goto stop;
drivers/usb/chipidea/core.c static int __devexit ci_hdrc_remove(struct · line 523
Quoted 7 lines
drivers/usb/chipidea/core.c +0
-1@@ -518,7 +518,6 @@ static int __devexit ci_hdrc_remove(struct platform_device *pdev) flush_workqueue(ci->wq);destroy_workqueue (ci->wq);device_remove_file (ci->dev, &dev_attr_role); -free_irq (ci->irq, ci);ci_role_stop (ci);return 0 ;
Best regards,
Marek Vasut
PATCH RESEND v2 1/1 USB: chipidea: convert to use devm_request_irq
Quoted 3 lines · Marek Vasut
Dear Richard Zhao,
You know, commit message would be nice to have.
Yes, but for this one, the title shows obviously what it changed, doesn't it?
Thanks
Richard
Quoted 38 lines
Quoted 2 lines
Signed-off-by Richard Zhao <[email protected]>Otherwise
Reviewed-by Marek Vasut <[email protected]>Quoted 20 lines
--- drivers/usb/chipidea/core.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)drivers/usb/chipidea/core.c +2
-2@@ -486,8 +486,8 @@ static int __devinit ci_hdrc_probe(struct platform_device *pdev) }platform_set_drvdata (pdev, ci); - ret =request_irq (ci->irq, ci_irq,IRQF_SHARED , ci->platdata->name, - ci); + ret =devm_request_irq (dev, ci->irq, ci_irq,IRQF_SHARED , + ci->platdata->name, ci);if (ret) goto stop;drivers/usb/chipidea/core.c static int __devexit ci_hdrc_remove(struct · line 523
Quoted 7 lines
drivers/usb/chipidea/core.c +0
-1@@ -518,7 +518,6 @@ static int __devexit ci_hdrc_remove(struct platform_device *pdev) flush_workqueue(ci->wq);destroy_workqueue (ci->wq);device_remove_file (ci->dev, &dev_attr_role); -free_irq (ci->irq, ci);ci_role_stop (ci);return 0 ;Best regards,
Marek Vasut
PATCH RESEND v2 1/1 USB: chipidea: convert to use devm_request_irq
Quoted 6 lines · Richard Zhao
Quoted 3 lines · Marek Vasut
Dear Richard Zhao,
You know, commit message would be nice to have.
Yes, but for this one, the title shows obviously what it changed, doesn't it?
Alex has the the final word, but I'm also very picky about commit messages. IMHO, all patches should have commit message, even if it sounds obvious.
For example, you could let us know the reasoning behind converting to devm_request_irq().
Signature · 8 lines
balbi -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120919/cd4cf30e/attachment.sig>