Skip to contentSkip to conversation

use a more portable syntax for mktemp. fixes build problem under MacOS X

PATCH New Waldemar Brodkorb 3 participants 4 messages Sep 19, 2012 – Sep 20, 2012

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 use a more portable syntax for mktemp. fixes build problem under MacOS X

Hi Developers,
following patch might be useful, when using buildroot on MacOS X.

---
 support/kconfig/lxdialog/check-lxdialog.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
support/kconfig/lxdialog/check-lxdialog.sh +1 -1
index 969cd4c..fb4d90b 100644
@@ -33,7 +33,7 @@ ccflags()
 }
 
 # Temp file, try to clean up after us
-tmp=$(mktemp)
+tmp=$(mktemp -t yyy)
 trap "rm -f $tmp" 0 1 2 3 15
 
 # Check if we can link to ncurses
Signature · 1 line
1.7.11.1
#1 lore raw

PATCH 1/1 use a more portable syntax for mktemp. fixes build problem under MacOS X

Dear Waldemar Brodkorb,

support/kconfig/lxdialog/check-lxdialog.sh ccflags() · line 39

Quoted 13 lines · Waldemar Brodkorb
support/kconfig/lxdialog/check-lxdialog.sh +1 -1
index 969cd4c..fb4d90b 100644
@@ -33,7 +33,7 @@ ccflags()
 }
 
 # Temp file, try to clean up after us
-tmp=$(mktemp)
+tmp=$(mktemp -t yyy)
 trap "rm -f $tmp" 0 1 2 3 15
 
 # Check if we can link to ncurses

If you make any changes to support/kconfig/, then those changes should also be done in the patches in support/kconfig/patches/ that help us port our changes to later versions of kconfig when we sync kconfig with the latest kernel version.

In your case, changing patch 11 sounds like a good plan. However, does Buildroot really works on Mac OS X? I don't think anybody uses Buildroot on Mac OS X, and I suspect that a lot of things might be broken besides just kconfig, no?

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#2 lore raw

PATCH 1/1 use a more portable syntax for mktemp. fixes build problem under MacOS X

Hi Thomas Petazzoni,

Quoted 16 lines · Thomas Petazzoni

Dear Waldemar Brodkorb,

Quoted 12 lines · Waldemar Brodkorb
support/kconfig/lxdialog/check-lxdialog.sh +1 -1
index 969cd4c..fb4d90b 100644
@@ -33,7 +33,7 @@ ccflags()
 }
 
 # Temp file, try to clean up after us
-tmp=$(mktemp)
+tmp=$(mktemp -t yyy)

trap "rm -f $tmp" 0 1 2 3 15

Quoted 6 lines
Quoted 1 line

# Check if we can link to ncurses

If you make any changes to support/kconfig/, then those changes should also be done in the patches in support/kconfig/patches/ that help us port our changes to later versions of kconfig when we sync kconfig with the latest kernel version.

Okay.

Quoted 4 lines

In your case, changing patch 11 sounds like a good plan. However, does Buildroot really works on Mac OS X? I don't think anybody uses Buildroot on Mac OS X, and I suspect that a lot of things might be broken besides just kconfig, no?

Yes, there are more things broken. But I can successfully build a Qemu MIPS system
and it boots up fine.
- Busybox have a patch in upstream, will be in the next release
http://www.mail-archive.com/busybox at busybox.net/msg17046.html
- uClibc utils/getconf.c does not compile (unresolved)
- there is a kernel patch needed to build the different tools ( I can provide this, if someone is interested, this is used in OpenWrt, too)
- minor patch for echo -e incompatibility

Besides that you need to use GNU sed, GNU xargs and GNU install instead of the MacOS X utils.

best regards
Waldemar

Quoted 8 lines

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#3 lore raw

PATCH 1/1 use a more portable syntax for mktemp. fixes build problem under MacOS X

In reply to Thomas Petazzoni
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Hi,

Quoted 1 line
Quoted 1 line

# Check if we can link to ncurses

Thomas> If you make any changes to support/kconfig/, then those changes Thomas> should also be done in the patches in support/kconfig/patches/ Thomas> that help us port our changes to later versions of kconfig when Thomas> we sync kconfig with the latest kernel version.

Or Yann's new kconfig-frontends package.

Thomas> In your case, changing patch 11 sounds like a good plan. However, does Thomas> Buildroot really works on Mac OS X? I don't think anybody uses Thomas> Buildroot on Mac OS X, and I suspect that a lot of things might be Thomas> broken besides just kconfig, no?

My thoughts exactly.

Signature · 1 line
Bye, Peter Korsgaard