kernel/rcutree.c:1131:41: error: 'flags' undeclared

PATCH In review Fengguang Wu 2 participants 2 messages Sep 20, 2012 Kernel janitors

lore

Share & tools

lore

Fengguang Wu

author

2012-09-20 21:24 UTC #0 lore raw

PATCH 5/78 kernel/rcutree.c:1131:41: error: 'flags' undeclared

Hi Paul,

FYI, kernel build failed on

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git rcu/next
head:   d58ab773ab8bc98c81c7d49c04bc88b6e7968385
commit: 552116942862340a4a0577cbac194ddc6185e4cb [5/78] rcu: Move RCU grace-period cleanup into kthread
config: x86_64-allmodconfig

All related error/warning messages:

kernel/rcutree.c: In function 'rcu_gp_kthread':
kernel/rcutree.c:1131:41: error: 'flags' undeclared (first use in this function) kernel/rcutree.c:1131:41: note: each undeclared identifier is reported only once for each function it appears in kernel/rcutree.c:1131:74: warning: comparison of distinct pointer types lacks a cast [enabled by default] kernel/rcutree.c:1176:74: warning: comparison of distinct pointer types lacks a cast [enabled by default]

vim +1131 kernel/rcutree.c
1125 if (!ACCESS_ONCE(rnp->qsmask) &&
1126 !rcu_preempt_blocked_readers_cgp(rnp))
1127 break;
1128 flush_signals(current);
1129 }
1130

Quoted 1 line

1131 raw_spin_lock_irqsave(&rnp->lock, flags);

1132 gp_duration = jiffies - rsp->gp_start;
1133 if (gp_duration > rsp->gp_max)
1134 rsp->gp_max = gp_duration;

---
0-DAY kernel build testing backend Open Source Technology Centre
Fengguang Wu, Yuanhan Liu Intel Corporation

Paul E. McKenney

2012-09-20 21:58 UTC #1 lore raw

Quoted 24 lines · Fengguang Wu

Hi Paul,
FYI, kernel build failed on
tree:   git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git rcu/next
head:   d58ab773ab8bc98c81c7d49c04bc88b6e7968385
commit: 552116942862340a4a0577cbac194ddc6185e4cb [5/78] rcu: Move RCU grace-period cleanup into kthread
config: x86_64-allmodconfig
All related error/warning messages:
kernel/rcutree.c: In function 'rcu_gp_kthread':
kernel/rcutree.c:1131:41: error: 'flags' undeclared (first use in this function) kernel/rcutree.c:1131:41: note: each undeclared identifier is reported only once for each function it appears in kernel/rcutree.c:1131:74: warning: comparison of distinct pointer types lacks a cast [enabled by default] kernel/rcutree.c:1176:74: warning: comparison of distinct pointer types lacks a cast [enabled by default]
vim +1131 kernel/rcutree.c
1125 if (!ACCESS_ONCE(rnp->qsmask) &&
1126 !rcu_preempt_blocked_readers_cgp(rnp))
1127 break;
1128 flush_signals(current);
1129 }
1130

Quoted 4 lines

Quoted 1 line
1131 raw_spin_lock_irqsave(&rnp->lock, flags);
1132 gp_duration = jiffies - rsp->gp_start;
1133 if (gp_duration > rsp->gp_max)
1134 rsp->gp_max = gp_duration;

I clearly put the raw_spin_lock_irq() conversion in the wrong commit. Fixing, will push the new version shortly.

Thanx, Paul