Skip to contentSkip to conversation

rds: Error on offset mismatch if not loopback

PATCH In review John Jolly 2 participants 3 messages Sep 20, 2012 – Sep 21, 2012

Subsystems (3)
Networking Network drivers RDS - reliable datagram sockets
lore
Share & tools
lore

John Jolly

author
#0 lore raw

PATCH 1/1 rds: Error on offset mismatch if not loopback

Attempting an rds connection from the IP address of an IPoIB interface to itself causes a kernel panic due to a BUG_ON() being triggered. Making the test less strict allows rds-ping to work without crashing the machine.

A local unprivileged user could use this flaw to crash the sytem.

---
 net/rds/ib_send.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
net/rds/ib_send.c +1 -1
index e590949..7920c85 100644
@@ -544,7 +544,7 @@ int rds_ib_xmit(struct rds_connection *conn, struct rds_message *rm,
 	int flow_controlled = 0;
 	int nr_sig = 0;
 
-	BUG_ON(off % RDS_FRAG_SIZE);
+	BUG_ON(!conn->c_loopback && off % RDS_FRAG_SIZE);
 	BUG_ON(hdr_off != 0 && hdr_off != sizeof(struct rds_header));
 
 	/* Do not send cong updates to IB loopback */
Signature · 1 line
1.7.7
maintainer
#1 lore raw

From: John Jolly <[email protected]>
Date: Thu, 20 Sep 2012 01:11:34 -0600

Quoted 5 lines

Attempting an rds connection from the IP address of an IPoIB interface to itself causes a kernel panic due to a BUG_ON() being triggered. Making the test less strict allows rds-ping to work without crashing the machine.

A local unprivileged user could use this flaw to crash the sytem.

Please read Documentation/SubmittingPatches to learn how to properly submit a change, in particular your patch submission was missing a proper signoff.

Thanks.

author
#2 lore raw
Quoted 7 lines · David Miller

From: John Jolly <[email protected]>
Date: Thu, 20 Sep 2012 01:11:34 -0600

Quoted 4 lines

Attempting an rds connection from the IP address of an IPoIB interface to itself causes a kernel panic due to a BUG_ON() being triggered. Making the test less strict allows rds-ping to work without crashing the machine.

Quoted 5 lines
Quoted 1 line

A local unprivileged user could use this flaw to crash the sytem.

Please read Documentation/SubmittingPatches to learn how to properly submit a change, in particular your patch submission was missing a proper signoff.

Thanks for catching that. Resubmitting with proper signoff.

Quoted 8 lines

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/