mx28evk: Remove fecmxc_mii_postcall()
PATCH 1/1 mx28evk: Remove fecmxc_mii_postcall()
fecmxc_mii_postcall() is specific to the KSZ9021 PHY on m28evk and should not be used on mx28evk, which has LAN8270 instead.
--- board/freescale/mx28evk/mx28evk.c | 25 ------------------------- 1 file changed, 25 deletions(-)
board/freescale/mx28evk/mx28evk.c +0 -25
@@ -100,19 +100,6 @@ int board_mmc_init(bd_t *bis)#ifdef CONFIG_CMD_NET -#define MII_OPMODE_STRAP_OVERRIDE 0x16 -#define MII_PHY_CTRL1 0x1e -#define MII_PHY_CTRL2 0x1f - -int fecmxc_mii_postcall (int phy) -{ -miiphy_write ("FEC1" , phy,MII_BMCR ,0x9000 ); -miiphy_write ("FEC1" , phy,MII_OPMODE_STRAP_OVERRIDE ,0x0202 ); -if (phy ==3 ) -miiphy_write ("FEC1" ,3 ,MII_PHY_CTRL2 ,0x8180 ); -return 0 ; -} -int board_eth_init (bd_t *bis) { struct mxs_clkctrl_regs *clkctrl_regs =
@@ -152,24 +139,12 @@ int board_eth_init(bd_t *bis)return -EINVAL ; } - ret =fecmxc_register_mii_postcall (dev, fecmxc_mii_postcall); -if (ret) { -puts ("FEC MXS: Unable to register FEC0 mii postcall\n" ); -return ret; - } - dev =eth_get_dev_by_name ("FEC1" );if (!dev) {puts ("FEC MXS: Unable to get FEC1 device entry\n" );return -EINVAL ; } - ret =fecmxc_register_mii_postcall (dev, fecmxc_mii_postcall); -if (ret) { -puts ("FEC MXS: Unable to register FEC1 mii postcall\n" ); -return ret; - } -return ret; }
Signature · 1 line
1.7.9.5
PATCH 1/1 mx28evk: Remove fecmxc_mii_postcall()
Dear Fabio Estevam,
Quoted 4 lines
fecmxc_mii_postcall()is specific to the KSZ9021 PHY on m28evk and should not be used on mx28evk, which has LAN8270 instead.Signed-off-by Fabio Estevam <[email protected]>
This is a fix, so should go into current release.
Quoted 42 lines
--- board/freescale/mx28evk/mx28evk.c | 25 ------------------------- 1 file changed, 25 deletions(-)(quoted diff) +0
-0
b/board/freescale/mx28evk/mx28evk.cindex d782aea..6e719ff 100644board/freescale/mx28evk/mx28evk.c +0
-19@@ -100,19 +100,6 @@ int board_mmc_init(bd_t *bis)#ifdef CONFIG_CMD_NET -#define MII_OPMODE_STRAP_OVERRIDE 0x16 -#define MII_PHY_CTRL1 0x1e -#define MII_PHY_CTRL2 0x1f - -int fecmxc_mii_postcall (int phy) -{ -miiphy_write ("FEC1" , phy,MII_BMCR ,0x9000 ); -miiphy_write ("FEC1" , phy,MII_OPMODE_STRAP_OVERRIDE ,0x0202 ); -if (phy ==3 ) -miiphy_write ("FEC1" ,3 ,MII_PHY_CTRL2 ,0x8180 ); -return 0 ; -} -int board_eth_init (bd_t *bis) { struct mxs_clkctrl_regs *clkctrl_regs =@@ -152,24 +139,12 @@ int board_eth_init(bd_t *bis)return -EINVAL ; } - ret =fecmxc_register_mii_postcall (dev, fecmxc_mii_postcall); -if (ret) { -puts ("FEC MXS: Unable to register FEC0 mii postcall\n" ); -return ret; - } - dev =eth_get_dev_by_name ("FEC1" );if (!dev) {puts ("FEC MXS: Unable to get FEC1 device entry\n" );return -EINVAL ;
board/freescale/mx28evk/mx28evk.c int board_eth_init(bd_t *bis) · line 149
Quoted 10 lines
board/freescale/mx28evk/mx28evk.c +0
-6} - ret =fecmxc_register_mii_postcall (dev, fecmxc_mii_postcall); -if (ret) { -puts ("FEC MXS: Unable to register FEC1 mii postcall\n" ); -return ret; - } -return ret; }
Best regards,
Marek Vasut
PATCH 1/1 mx28evk: Remove fecmxc_mii_postcall()
In reply to Fabio EstevamQuoted 5 lines · Fabio Estevam
fecmxc_mii_postcall()is specific to the KSZ9021 PHY on m28evk and should not be used on mx28evk, which has LAN8270 instead.Signed-off-by Fabio Estevam <[email protected]>---
Applied to u-boot-imx (fix), thanks.
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================