remoteproc: return -EFAULT on copy_from_user failure

PATCH Applied Dan Carpenter 2 participants 2 messages Sep 25, 2012 – Sep 30, 2012

Subsystems (2)

Kernel janitors Remote processor (remoteproc)

lore

Share & tools

lore

Dan Carpenter

author

2012-09-25 07:05 UTC #0 lore raw

PATCH 3/3 remoteproc: return -EFAULT on copy_from_user failure

copy_from_user() returns the number of bytes remaining to be copied, but we want to return an error code here.

Signed-off-by Dan Carpenter <[email protected]>

drivers/remoteproc/remoteproc_debugfs.c +1 -1

index ea90a56..157a573 100644
@@ -161,7 +161,7 @@ rproc_recovery_write(struct file *filp, const char __user *user_buf,
 
 	ret = copy_from_user(buf, user_buf, count);
 	if (ret)
-		return ret;
+		return -EFAULT;
 
 	/* remove end of line */
 	if (buf[count - 1] = '\n')

Ohad Ben-Cohen

Applied

2012-09-30 09:45 UTC #1 lore raw

Quoted 4 lines · Dan Carpenter

copy_from_user() returns the number of bytes remaining to be copied, but we want to return an error code here.
Signed-off-by Dan Carpenter <[email protected]>

Applied, thanks.