arch/x86/kernel/traps.c:276 do_general_protection() warn: add some parenthesis here?

DISCUSSION Fengguang Wu 3 participants 3 messages Sep 25, 2012 Kernel janitors

lore

Share & tools

lore

Fengguang Wu

author

2012-09-25 08:13 UTC #0 lore raw

Hi Frederic,

FYI, there are new smatch warnings show up in

37bee0638b95bc25ed67ec240eb56e25aef2f3ee x86: Unspaghettize do_general_protection()

All smatch warnings:

+ arch/x86/kernel/traps.c:276 do_general_protection() warn: add some parenthesis here? arch/x86/kernel/traps.c:604 math_state_restore() info: ignoring unreachable code.

vim +276 arch/x86/kernel/traps.c

272
273 tsk->thread.error_code = error_code;
274 tsk->thread.trap_nr = X86_TRAP_GP;
275 if (!notify_die(DIE_GPF, "general protection fault", regs, error_code,

Quoted 1 line

276 X86_TRAP_GP, SIGSEGV) = NOTIFY_STOP)

277 die("general protection fault", regs, error_code);
278 return;
279 }

---
0-DAY kernel build testing backend Open Source Technology Centre
Fengguang Wu, Yuanhan Liu Intel Corporation

Dan Carpenter

2012-09-25 08:21 UTC #1 lore raw

Quoted 11 lines · Fengguang Wu

Hi Frederic,
FYI, there are new smatch warnings show up in
37bee0638b95bc25ed67ec240eb56e25aef2f3ee x86: Unspaghettize do_general_protection()
All smatch warnings:
+ arch/x86/kernel/traps.c:276 do_general_protection() warn: add some parenthesis here? arch/x86/kernel/traps.c:604 math_state_restore() info: ignoring unreachable code.

Quoted 7 lines

vim +276 arch/x86/kernel/traps.c
   272	
   273			tsk->thread.error_code = error_code;
   274			tsk->thread.trap_nr = X86_TRAP_GP;
   275			if (!notify_die(DIE_GPF, "general protection fault", regs, error_code,
Quoted 1 line
276 X86_TRAP_GP, SIGSEGV) = NOTIFY_STOP)

Precedence error. Should != NOTIFY_STOP. Same for the other email.

regards,
dan carpenter

Frederic Weisbecker

2012-09-25 11:03 UTC #2 lore raw

In reply to Fengguang Wu

2012/9/25 Dan Carpenter <[email protected]>:

Quoted 14 lines · Fengguang Wu

Quoted 13 lines
Hi Frederic,
FYI, there are new smatch warnings show up in
37bee0638b95bc25ed67ec240eb56e25aef2f3ee x86: Unspaghettize do_general_protection()
All smatch warnings:
+ arch/x86/kernel/traps.c:276 do_general_protection() warn: add some parenthesis here? arch/x86/kernel/traps.c:604 math_state_restore() info: ignoring unreachable code.
vim +276 arch/x86/kernel/traps.c

Quoted 7 lines

Quoted 5 lines
   272
   273                        tsk->thread.error_code = error_code;
   274                        tsk->thread.trap_nr = X86_TRAP_GP;
   275                        if (!notify_die(DIE_GPF, "general protection fault", regs, error_code,
Quoted 1 line
276 X86_TRAP_GP, SIGSEGV) = NOTIFY_STOP)
Precedence error. Should != NOTIFY_STOP. Same for the other email.

Doh! I'm fixing this. I should stop writing patches in the middle of the night.

Thanks for your report!