drm/i915: BUG() on unexpected HDMI register
Subsystems (2)
PATCH 1/2 drm/i915: BUG() on unexpected HDMI register
From: Paulo Zanoni <[email protected]>
This should never happen, but the silent "return" makes me wonder every time I try to debug InfoFrame bugs, so promote this to BUG() to make sure people will complain if we ever break this.
--- drivers/gpu/drm/i915/intel_hdmi.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/gpu/drm/i915/intel_hdmi.c +2 -0
@@ -377,6 +377,7 @@ static void g4x_set_infoframes(struct drm_encoder *encoder, port =VIDEO_DIP_PORT_C ;break ;default : +BUG ();return ; }
@@ -435,6 +436,7 @@ static void ibx_set_infoframes(struct drm_encoder *encoder, port =VIDEO_DIP_PORT_D ;break ;default : +BUG ();return ; }
Signature · 1 line
1.7.10.4
PATCH 2/2 drm/i915: make sure we write at least 32 DIP bytes
From: Paulo Zanoni <[email protected]>
If we don't write at least 32 DIP bytes the InfoFrame ECC may not be correctly calculated in some cases (e.g., when changing the port), and this will lead to black screens on HDMI monitors. The ECC value is generated by the hardware.
I don't see how this should break anything since we're writing 0 and that should be the correct value, so this patch should be safe.
This patch fixes bug #46761, which is marked as a regression introduced by commit 4e89ee174bb2da341bf90a84321c7008a3c9210d:
drm/i915: set the DIP port on ibx_write_infoframe
Before commit 4e89 we were just failing to send AVI infoframes when we needed to change the port, which can lead to black screens in some cases. After commit 4e89 we started sending infoframes, but with a possibly wrong ECC value. After this patch I hope we start sending correct infoframes.
Cc: [email protected]
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=46761
--- drivers/gpu/drm/i915/intel_hdmi.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
drivers/gpu/drm/i915/intel_hdmi.c +10 -0
@@ -151,6 +151,8 @@ static void g4x_write_infoframe(struct drm_encoder *encoder,I915_WRITE (VIDEO_DIP_DATA , *data); data++; } +for (; i <32 ; i +=4 ) +I915_WRITE (VIDEO_DIP_DATA ,0 );mmiowb (); val |=g4x_infoframe_enable (frame);
@@ -186,6 +188,8 @@ static void ibx_write_infoframe(struct drm_encoder *encoder,I915_WRITE (TVIDEO_DIP_DATA (intel_crtc->pipe), *data); data++; } +for (; i <32 ; i +=4 ) +I915_WRITE (TVIDEO_DIP_DATA (intel_crtc->pipe),0 );mmiowb (); val |=g4x_infoframe_enable (frame);
@@ -224,6 +228,8 @@ static void cpt_write_infoframe(struct drm_encoder *encoder,I915_WRITE (TVIDEO_DIP_DATA (intel_crtc->pipe), *data); data++; } +for (; i <32 ; i +=4 ) +I915_WRITE (TVIDEO_DIP_DATA (intel_crtc->pipe),0 );mmiowb (); val |=g4x_infoframe_enable (frame);
@@ -259,6 +265,8 @@ static void vlv_write_infoframe(struct drm_encoder *encoder,I915_WRITE (VLV_TVIDEO_DIP_DATA (intel_crtc->pipe), *data); data++; } +for (; i <32 ; i +=4 ) +I915_WRITE (VLV_TVIDEO_DIP_DATA (intel_crtc->pipe),0 );mmiowb (); val |=g4x_infoframe_enable (frame);
@@ -292,6 +300,8 @@ static void hsw_write_infoframe(struct drm_encoder *encoder,I915_WRITE (data_reg + i, *data); data++; } +for (; i <32 ; i +=4 ) +I915_WRITE (data_reg + i,0 );mmiowb (); val |=hsw_infoframe_enable (frame);
Signature · 1 line
1.7.10.4
Re: [PATCH 2/2] drm/i915: make sure we write at least 32 DIP bytes
I know almost nothing about hdmi infoframes, but isn't hdmi infoframes limited to 30 bytes + 1 checksum byte?
(From HDMI Spec 8.2 section)
Quoted 83 lines · Paulo Zanoni
From: Paulo Zanoni <[email protected]>
If we don't write at least 32 DIP bytes the InfoFrame ECC may not be correctly calculated in some cases (e.g., when changing the port), and this will lead to black screens on HDMI monitors. The ECC value is generated by the hardware.
I don't see how this should break anything since we're writing 0 and that should be the correct value, so this patch should be safe.
This patch fixes bug #46761, which is marked as a regression introduced by commit
4e89ee174bb2da341bf90a84321c7008a3c9210d:
drm/i915: set the DIP port onibx_write_infoframeBefore commit 4e89 we were just failing to send AVI infoframes when we needed to change the port, which can lead to black screens in some cases. After commit 4e89 we started sending infoframes, but with a possibly wrong ECC value. After this patch I hope we start sending correct infoframes.
Cc: [email protected]
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=46761Signed-off-by Paulo Zanoni <[email protected]>--- drivers/gpu/drm/i915/intel_hdmi.c | 10 ++++++++++ 1 file changed, 10 insertions(+)drivers/gpu/drm/i915/intel_hdmi.c +10
-1@@ -151,6 +151,8 @@ static void g4x_write_infoframe(struct drm_encoder *encoder,I915_WRITE (VIDEO_DIP_DATA , *data); data++; } +for (; i <32 ; i +=4 ) +I915_WRITE (VIDEO_DIP_DATA ,0 );mmiowb (); val |=g4x_infoframe_enable (frame);@@ -186,6 +188,8 @@ static void ibx_write_infoframe(struct drm_encoder *encoder,I915_WRITE (TVIDEO_DIP_DATA (intel_crtc->pipe), *data); data++; } +for (; i <32 ; i +=4 ) +I915_WRITE (TVIDEO_DIP_DATA (intel_crtc->pipe),0 );mmiowb (); val |=g4x_infoframe_enable (frame);@@ -224,6 +228,8 @@ static void cpt_write_infoframe(struct drm_encoder *encoder,I915_WRITE (TVIDEO_DIP_DATA (intel_crtc->pipe), *data); data++; } +for (; i <32 ; i +=4 ) +I915_WRITE (TVIDEO_DIP_DATA (intel_crtc->pipe),0 );mmiowb (); val |=g4x_infoframe_enable (frame);@@ -259,6 +265,8 @@ static void vlv_write_infoframe(struct drm_encoder *encoder,I915_WRITE (VLV_TVIDEO_DIP_DATA (intel_crtc->pipe), *data); data++; } +for (; i <32 ; i +=4 ) +I915_WRITE (VLV_TVIDEO_DIP_DATA (intel_crtc->pipe),0 );mmiowb (); val |=g4x_infoframe_enable (frame);@@ -292,6 +300,8 @@ static void hsw_write_infoframe(struct drm_encoder *encoder,I915_WRITE (data_reg + i, *data); data++; } +for (; i <32 ; i +=4 ) +I915_WRITE (data_reg + i,0 );mmiowb (); val |=hsw_infoframe_enable (frame); --1.7.10.4
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 2 lines
Rodrigo Vivi Blog: http://blog.vivi.eng.br
PATCH 1/1 drm/i915: make sure we write all the DIP data bytes
In reply to Paulo ZanoniFrom: Paulo Zanoni <[email protected]>
... even if the actual infoframe is smaller than the maximum possible size.
If we don't write all the 32 DIP data bytes the InfoFrame ECC may not be correctly calculated in some cases (e.g., when changing the port), and this will lead to black screens on HDMI monitors. The ECC value is generated by the hardware.
I don't see how this should break anything since we're writing 0 and that should be the correct value, so this patch should be safe.
Notice that on IVB and older we actually have 64 bytes available for VIDEO_DIP_DATA, but only bytes 0-31 actually store infoframe data: the others are either read-only ECC values or marked as "reserved". On HSW we only have 32 bytes, and the ECC value is stored on its own separate read-only register. See BSpec.
This patch fixes bug #46761, which is marked as a regression introduced by commit 4e89ee174bb2da341bf90a84321c7008a3c9210d:
drm/i915: set the DIP port on ibx_write_infoframe
Before commit 4e89 we were just failing to send AVI infoframes when we needed to change the port, which can lead to black screens in some cases. After commit 4e89 we started sending infoframes, but with a possibly wrong ECC value. After this patch I hope we start sending correct infoframes.
Version 2:
- Improve commit message
- Try to make the code more clear
Cc: [email protected]
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=46761
--- drivers/gpu/drm/i915/i915_reg.h | 4 ++++ drivers/gpu/drm/i915/intel_hdmi.c | 15 +++++++++++++++ 2 files changed, 19 insertions(+)
drivers/gpu/drm/i915/i915_reg.h +4 -0
@@ -1794,6 +1794,10 @@/* Video Data Island Packet control */ #define VIDEO_DIP_DATA 0x61178 +/* Read the description of VIDEO_DIP_DATA (before Haswel) or VIDEO_DIP_ECC +* (Haswell and newer) to see which VIDEO_DIP_DATA byte corresponds to each byte +* of the infoframe structure specified by CEA-861. */ +#define VIDEO_DIP_DATA_SIZE 32#define VIDEO_DIP_CTL 0x61170/* Pre HSW: */ #define VIDEO_DIP_ENABLE (1 << 31)
drivers/gpu/drm/i915/intel_hdmi.c +15 -0
@@ -151,6 +151,9 @@ static void g4x_write_infoframe(struct drm_encoder *encoder,I915_WRITE (VIDEO_DIP_DATA , *data); data++; } +/* Write every possible data byte to force correct ECC calculation. */ +for (; i <VIDEO_DIP_DATA_SIZE ; i +=4 ) +I915_WRITE (VIDEO_DIP_DATA ,0 );mmiowb (); val |=g4x_infoframe_enable (frame);
@@ -186,6 +189,9 @@ static void ibx_write_infoframe(struct drm_encoder *encoder,I915_WRITE (TVIDEO_DIP_DATA (intel_crtc->pipe), *data); data++; } +/* Write every possible data byte to force correct ECC calculation. */ +for (; i <VIDEO_DIP_DATA_SIZE ; i +=4 ) +I915_WRITE (TVIDEO_DIP_DATA (intel_crtc->pipe),0 );mmiowb (); val |=g4x_infoframe_enable (frame);
@@ -224,6 +230,9 @@ static void cpt_write_infoframe(struct drm_encoder *encoder,I915_WRITE (TVIDEO_DIP_DATA (intel_crtc->pipe), *data); data++; } +/* Write every possible data byte to force correct ECC calculation. */ +for (; i <VIDEO_DIP_DATA_SIZE ; i +=4 ) +I915_WRITE (TVIDEO_DIP_DATA (intel_crtc->pipe),0 );mmiowb (); val |=g4x_infoframe_enable (frame);
@@ -259,6 +268,9 @@ static void vlv_write_infoframe(struct drm_encoder *encoder,I915_WRITE (VLV_TVIDEO_DIP_DATA (intel_crtc->pipe), *data); data++; } +/* Write every possible data byte to force correct ECC calculation. */ +for (; i <VIDEO_DIP_DATA_SIZE ; i +=4 ) +I915_WRITE (VLV_TVIDEO_DIP_DATA (intel_crtc->pipe),0 );mmiowb (); val |=g4x_infoframe_enable (frame);
@@ -292,6 +304,9 @@ static void hsw_write_infoframe(struct drm_encoder *encoder,I915_WRITE (data_reg + i, *data); data++; } +/* Write every possible data byte to force correct ECC calculation. */ +for (; i <VIDEO_DIP_DATA_SIZE ; i +=4 ) +I915_WRITE (data_reg + i,0 );mmiowb (); val |=hsw_infoframe_enable (frame);
Signature · 1 line
1.7.10.4
Re: [PATCH] drm/i915: make sure we write all the DIP data bytes
Quoted 117 lines · Paulo Zanoni
From: Paulo Zanoni <[email protected]>
... even if the actual infoframe is smaller than the maximum possible size.
If we don't write all the 32 DIP data bytes the InfoFrame ECC may not be correctly calculated in some cases (e.g., when changing the port), and this will lead to black screens on HDMI monitors. The ECC value is generated by the hardware.
I don't see how this should break anything since we're writing 0 and that should be the correct value, so this patch should be safe.
Notice that on IVB and older we actually have 64 bytes available for
VIDEO_DIP_DATA, but only bytes 0-31 actually store infoframe data: the others are either read-only ECC values or marked as "reserved". On HSW we only have 32 bytes, and the ECC value is stored on its own separate read-only register. See BSpec.This patch fixes bug #46761, which is marked as a regression introduced by commit
4e89ee174bb2da341bf90a84321c7008a3c9210d:
drm/i915: set the DIP port onibx_write_infoframeBefore commit 4e89 we were just failing to send AVI infoframes when we needed to change the port, which can lead to black screens in some cases. After commit 4e89 we started sending infoframes, but with a possibly wrong ECC value. After this patch I hope we start sending correct infoframes.
Version 2:
- Improve commit message
- Try to make the code more clearCc: [email protected]
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=46761Signed-off-by Paulo Zanoni <[email protected]>--- drivers/gpu/drm/i915/i915_reg.h | 4 ++++ drivers/gpu/drm/i915/intel_hdmi.c | 15 +++++++++++++++ 2 files changed, 19 insertions(+)drivers/gpu/drm/i915/i915_reg.h +4
-0@@ -1794,6 +1794,10 @@/* Video Data Island Packet control */ #define VIDEO_DIP_DATA 0x61178 +/* Read the description of VIDEO_DIP_DATA (before Haswel) or VIDEO_DIP_ECC +* (Haswell and newer) to see which VIDEO_DIP_DATA byte corresponds to each byte +* of the infoframe structure specified by CEA-861. */ +#define VIDEO_DIP_DATA_SIZE 32#define VIDEO_DIP_CTL 0x61170/* Pre HSW: */ #define VIDEO_DIP_ENABLE (1 << 31)drivers/gpu/drm/i915/intel_hdmi.c +15
-1@@ -151,6 +151,9 @@ static void g4x_write_infoframe(struct drm_encoder *encoder,I915_WRITE (VIDEO_DIP_DATA , *data); data++; } +/* Write every possible data byte to force correct ECC calculation. */ +for (; i <VIDEO_DIP_DATA_SIZE ; i +=4 ) +I915_WRITE (VIDEO_DIP_DATA ,0 );mmiowb (); val |=g4x_infoframe_enable (frame);@@ -186,6 +189,9 @@ static void ibx_write_infoframe(struct drm_encoder *encoder,I915_WRITE (TVIDEO_DIP_DATA (intel_crtc->pipe), *data); data++; } +/* Write every possible data byte to force correct ECC calculation. */ +for (; i <VIDEO_DIP_DATA_SIZE ; i +=4 ) +I915_WRITE (TVIDEO_DIP_DATA (intel_crtc->pipe),0 );mmiowb (); val |=g4x_infoframe_enable (frame);@@ -224,6 +230,9 @@ static void cpt_write_infoframe(struct drm_encoder *encoder,I915_WRITE (TVIDEO_DIP_DATA (intel_crtc->pipe), *data); data++; } +/* Write every possible data byte to force correct ECC calculation. */ +for (; i <VIDEO_DIP_DATA_SIZE ; i +=4 ) +I915_WRITE (TVIDEO_DIP_DATA (intel_crtc->pipe),0 );mmiowb (); val |=g4x_infoframe_enable (frame);@@ -259,6 +268,9 @@ static void vlv_write_infoframe(struct drm_encoder *encoder,I915_WRITE (VLV_TVIDEO_DIP_DATA (intel_crtc->pipe), *data); data++; } +/* Write every possible data byte to force correct ECC calculation. */ +for (; i <VIDEO_DIP_DATA_SIZE ; i +=4 ) +I915_WRITE (VLV_TVIDEO_DIP_DATA (intel_crtc->pipe),0 );mmiowb (); val |=g4x_infoframe_enable (frame);@@ -292,6 +304,9 @@ static void hsw_write_infoframe(struct drm_encoder *encoder,I915_WRITE (data_reg + i, *data); data++; } +/* Write every possible data byte to force correct ECC calculation. */ +for (; i <VIDEO_DIP_DATA_SIZE ; i +=4 ) +I915_WRITE (data_reg + i,0 );mmiowb (); val |=hsw_infoframe_enable (frame); --1.7.10.4
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 2 lines
Rodrigo Vivi Blog: http://blog.vivi.eng.br
Daniel Vetter
AppliedRe: [PATCH] drm/i915: make sure we write all the DIP data bytes
Quoted 39 lines · Rodrigo Vivi
Reviewed-by Rodrigo Vivi <[email protected]>Quoted 36 lines · Paulo Zanoni
From: Paulo Zanoni <[email protected]>
... even if the actual infoframe is smaller than the maximum possible size.
If we don't write all the 32 DIP data bytes the InfoFrame ECC may not be correctly calculated in some cases (e.g., when changing the port), and this will lead to black screens on HDMI monitors. The ECC value is generated by the hardware.
I don't see how this should break anything since we're writing 0 and that should be the correct value, so this patch should be safe.
Notice that on IVB and older we actually have 64 bytes available for
VIDEO_DIP_DATA, but only bytes 0-31 actually store infoframe data: the others are either read-only ECC values or marked as "reserved". On HSW we only have 32 bytes, and the ECC value is stored on its own separate read-only register. See BSpec.This patch fixes bug #46761, which is marked as a regression introduced by commit
4e89ee174bb2da341bf90a84321c7008a3c9210d:
drm/i915: set the DIP port onibx_write_infoframeBefore commit 4e89 we were just failing to send AVI infoframes when we needed to change the port, which can lead to black screens in some cases. After commit 4e89 we started sending infoframes, but with a possibly wrong ECC value. After this patch I hope we start sending correct infoframes.
Version 2:
- Improve commit message
- Try to make the code more clearCc: [email protected]
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=46761Signed-off-by Paulo Zanoni <[email protected]>
Applied to -fixes, although I guess I'll push this through 3.7 - infoframes blow up too often.
-Daniel
Quoted 91 lines
Quoted 81 lines
--- drivers/gpu/drm/i915/i915_reg.h | 4 ++++ drivers/gpu/drm/i915/intel_hdmi.c | 15 +++++++++++++++ 2 files changed, 19 insertions(+)drivers/gpu/drm/i915/i915_reg.h +4
-0@@ -1794,6 +1794,10 @@/* Video Data Island Packet control */ #define VIDEO_DIP_DATA 0x61178 +/* Read the description of VIDEO_DIP_DATA (before Haswel) or VIDEO_DIP_ECC +* (Haswell and newer) to see which VIDEO_DIP_DATA byte corresponds to each byte +* of the infoframe structure specified by CEA-861. */ +#define VIDEO_DIP_DATA_SIZE 32#define VIDEO_DIP_CTL 0x61170/* Pre HSW: */ #define VIDEO_DIP_ENABLE (1 << 31)drivers/gpu/drm/i915/intel_hdmi.c +15
-1@@ -151,6 +151,9 @@ static void g4x_write_infoframe(struct drm_encoder *encoder,I915_WRITE (VIDEO_DIP_DATA , *data); data++; } +/* Write every possible data byte to force correct ECC calculation. */ +for (; i <VIDEO_DIP_DATA_SIZE ; i +=4 ) +I915_WRITE (VIDEO_DIP_DATA ,0 );mmiowb (); val |=g4x_infoframe_enable (frame);@@ -186,6 +189,9 @@ static void ibx_write_infoframe(struct drm_encoder *encoder,I915_WRITE (TVIDEO_DIP_DATA (intel_crtc->pipe), *data); data++; } +/* Write every possible data byte to force correct ECC calculation. */ +for (; i <VIDEO_DIP_DATA_SIZE ; i +=4 ) +I915_WRITE (TVIDEO_DIP_DATA (intel_crtc->pipe),0 );mmiowb (); val |=g4x_infoframe_enable (frame);@@ -224,6 +230,9 @@ static void cpt_write_infoframe(struct drm_encoder *encoder,I915_WRITE (TVIDEO_DIP_DATA (intel_crtc->pipe), *data); data++; } +/* Write every possible data byte to force correct ECC calculation. */ +for (; i <VIDEO_DIP_DATA_SIZE ; i +=4 ) +I915_WRITE (TVIDEO_DIP_DATA (intel_crtc->pipe),0 );mmiowb (); val |=g4x_infoframe_enable (frame);@@ -259,6 +268,9 @@ static void vlv_write_infoframe(struct drm_encoder *encoder,I915_WRITE (VLV_TVIDEO_DIP_DATA (intel_crtc->pipe), *data); data++; } +/* Write every possible data byte to force correct ECC calculation. */ +for (; i <VIDEO_DIP_DATA_SIZE ; i +=4 ) +I915_WRITE (VLV_TVIDEO_DIP_DATA (intel_crtc->pipe),0 );mmiowb (); val |=g4x_infoframe_enable (frame);@@ -292,6 +304,9 @@ static void hsw_write_infoframe(struct drm_encoder *encoder,I915_WRITE (data_reg + i, *data); data++; } +/* Write every possible data byte to force correct ECC calculation. */ +for (; i <VIDEO_DIP_DATA_SIZE ; i +=4 ) +I915_WRITE (data_reg + i,0 );mmiowb (); val |=hsw_infoframe_enable (frame); --1.7.10.4
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfxSignature · 6 lines
Rodrigo Vivi Blog: http://blog.vivi.eng.br _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch
This was easy for me, feel free to use:
Quoted 38 lines · Paulo Zanoni
From: Paulo Zanoni <[email protected]>
This should never happen, but the silent "return" makes me wonder every time I try to debug InfoFrame bugs, so promote this to
BUG()to make sure people will complain if we ever break this.Signed-off-by Paulo Zanoni <[email protected]>--- drivers/gpu/drm/i915/intel_hdmi.c | 2 ++ 1 file changed, 2 insertions(+)drivers/gpu/drm/i915/intel_hdmi.c +2
-1@@ -377,6 +377,7 @@ static void g4x_set_infoframes(struct drm_encoder *encoder, port =VIDEO_DIP_PORT_C ;break ;default : +BUG ();return ; }@@ -435,6 +436,7 @@ static void ibx_set_infoframes(struct drm_encoder *encoder, port =VIDEO_DIP_PORT_D ;break ;default : +BUG ();return ; } --1.7.10.4
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 2 lines
Rodrigo Vivi Blog: http://blog.vivi.eng.br
Quoted 3 lines · Rodrigo Vivi
This was easy for me, feel free to use:
Reviewed-by Rodrigo Vivi <[email protected]>
Already merged to dinq before I've seen your r-b, thanks anyway for the review (and the patch obviously too).
I've bikeshedded the actual fix a bit on irc (needs a clearer commit msg since 32 bytes is the limit and a comment explaining what's going on). -Daniel
Quoted 50 lines · Paulo Zanoni
Quoted 38 lines
From: Paulo Zanoni <[email protected]>
This should never happen, but the silent "return" makes me wonder every time I try to debug InfoFrame bugs, so promote this to
BUG()to make sure people will complain if we ever break this.Signed-off-by Paulo Zanoni <[email protected]>--- drivers/gpu/drm/i915/intel_hdmi.c | 2 ++ 1 file changed, 2 insertions(+)drivers/gpu/drm/i915/intel_hdmi.c +2
-1@@ -377,6 +377,7 @@ static void g4x_set_infoframes(struct drm_encoder *encoder, port =VIDEO_DIP_PORT_C ;break ;default : +BUG ();return ; }@@ -435,6 +436,7 @@ static void ibx_set_infoframes(struct drm_encoder *encoder, port =VIDEO_DIP_PORT_D ;break ;default : +BUG ();return ; } --1.7.10.4
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfxSignature · 6 lines
Rodrigo Vivi Blog: http://blog.vivi.eng.br _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch