XHCI Bug discovered in 3.6-RC6 (solution included)
A message that is not in the archive (sent off-list or not yet received): [email protected]
this following function is missing a important NULL check. if DMI is not available or not enabled in the kernel config (which is common in my case, since its a ARM Platform with XHCI support) the xhci-hcd driver will crash due nullpointer access since dmi_get_system_info returns always NULL if DMI support is not enabled.
static bool compliance_mode_recovery_timer_quirk_check(void)
{
const char *dmi_product_name, *dmi_sys_vendor;
dmi_product_name = dmi_get_system_info(DMI_PRODUCT_NAME);
dmi_sys_vendor = dmi_get_system_info(DMI_SYS_VENDOR);
if (!(strstr(dmi_sys_vendor, "Hewlett-Packard")))
return false;
if (strstr(dmi_product_name, "Z420") ||
strstr(dmi_product_name, "Z620") ||
strstr(dmi_product_name, "Z820"))
return true;
return false;
}proposed patch: simply add
if (!dmi_sys_vendor || !dmi_product_name)
return false;
even better. disable the whole quirk handling for this case if CONFIG_DMI is not set
Signature · 24 lines
Mit freundlichen Grüssen / Regards Sebastian Gottschall / CTO NewMedia-NET GmbH - DD-WRT Firmensitz: Berliner Ring 101, 64625 Bensheim Registergericht: Amtsgericht Darmstadt, HRB 25473 Geschäftsführer: Peter Steinhäuser, Christian Scheele http://www.dd-wrt.com email: [email protected] Tel.: +496251-582650 / Fax: +496251-5826565 -- Mit freundlichen Grüssen / Regards Sebastian Gottschall / CTO NewMedia-NET GmbH - DD-WRT Firmensitz: Berliner Ring 101, 64625 Bensheim Registergericht: Amtsgericht Darmstadt, HRB 25473 Geschäftsführer: Peter Steinhäuser, Christian Scheele http://www.dd-wrt.com email:[email protected] Tel.: +496251-582650 / Fax: +496251-5826565
Quoted 25 lines · Sebastian Gottschall (DD-WRT)
this following function is missing a important NULL check. if DMI is not available or not enabled in the kernel config (which is common in my case, since its a ARM Platform with XHCI support) the xhci-hcd driver will crash due nullpointer access since
dmi_get_system_inforeturns always NULL if DMI support is not enabled.static bool
compliance_mode_recovery_timer_quirk_check(void){ const char *dmi_product_name, *dmi_sys_vendor; dmi_product_name = dmi_get_system_info(DMI_PRODUCT_NAME); dmi_sys_vendor = dmi_get_system_info(DMI_SYS_VENDOR); if (!(strstr(dmi_sys_vendor, "Hewlett-Packard"))) return false; if (strstr(dmi_product_name, "Z420") || strstr(dmi_product_name, "Z620") || strstr(dmi_product_name, "Z820")) return true; return false; }
Quoted 7 lines
proposed patch: simply add
if (!dmi_sys_vendor || !dmi_product_name)
return false;even better. disable the whole quirk handling for this case if
CONFIG_DMIis not set
Care to send a patch to fix this up?
thanks,
greg k-h
Hi
I have posted the required patch for this:
usb: host: xhci: Fix Null pointer dereferencing with 71c731a for non-x86 systems
Can we please get that in ?
Quoted 36 lines · Greg KH
Quoted 25 lines · Sebastian Gottschall (DD-WRT)
this following function is missing a important NULL check. if DMI is not available or not enabled in the kernel config (which is common in my case, since its a ARM Platform with XHCI support) the xhci-hcd driver will crash due nullpointer access since
dmi_get_system_inforeturns always NULL if DMI support is not enabled.static bool
compliance_mode_recovery_timer_quirk_check(void){ const char *dmi_product_name, *dmi_sys_vendor; dmi_product_name = dmi_get_system_info(DMI_PRODUCT_NAME); dmi_sys_vendor = dmi_get_system_info(DMI_SYS_VENDOR); if (!(strstr(dmi_sys_vendor, "Hewlett-Packard"))) return false; if (strstr(dmi_product_name, "Z420") || strstr(dmi_product_name, "Z620") || strstr(dmi_product_name, "Z820")) return true; return false; }Quoted 7 lines
proposed patch: simply add
if (!dmi_sys_vendor || !dmi_product_name)
return false;even better. disable the whole quirk handling for this case if
CONFIG_DMIis not setCare to send a patch to fix this up?
Quoted 7 lines
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Thanks
vivek
A: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
Quoted 4 lines · Vivek Gautam
Hi
I have posted the required patch for this:
usb: host: xhci: Fix Null pointer dereferencing with 71c731a for non-x86 systems
You sent this last saturday, a mere 3 days ago, two of them on a weekend, please be patient.
greg k-h
Apologies for that. I should have been rather a bit patient.
Best regards
Vivek
Quoted 16 lines · Greg KH
A: No.
Q: Should I include quotations after my reply?http://daringfireball.net/2007/07/on_top
Quoted 4 lines · Vivek Gautam
Hi
I have posted the required patch for this:
usb: host: xhci: Fix Null pointer dereferencing with 71c731a for non-x86 systemsYou sent this last saturday, a mere 3 days ago, two of them on a weekend, please be patient.
greg k-h