Skip to contentSkip to conversation

ARM: mxs_defconfig: Improve USB related support

PATCH New Fabio Estevam 3 participants 5 messages Sep 25, 2012 – Oct 6, 2012

Subsystems (2)
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/1 ARM: mxs_defconfig: Improve USB related support

From: Fabio Estevam <[email protected]>

Select the following USB related options:

- USB Video Class (webcam)
- USB Ethernet adapter
- Native language support (needed for mounting USB pen drives, for example)

---
 arch/arm/configs/mxs_defconfig |   10 ++++++++++
 1 file changed, 10 insertions(+)
arch/arm/configs/mxs_defconfig +10 -0
index 048aaca..da51790 100644
@@ -61,6 +61,8 @@ CONFIG_MTD_NAND_GPMI_NAND=y
 CONFIG_NETDEVICES=y
 CONFIG_NET_ETHERNET=y
 CONFIG_ENC28J60=y
+CONFIG_USB_USBNET=y
+CONFIG_USB_NET_SMSC95XX=y
 # CONFIG_NETDEV_1000 is not set
 # CONFIG_NETDEV_10000 is not set
 # CONFIG_WLAN is not set
@@ -106,6 +108,10 @@ CONFIG_SND_SOC_I2C_AND_SPI=y
 CONFIG_SND_SOC_SGTL5000=y
 CONFIG_REGULATOR=y
 CONFIG_REGULATOR_FIXED_VOLTAGE=y
+CONFIG_MEDIA_SUPPORT=y
+CONFIG_MEDIA_CAMERA_SUPPORT=y
+CONFIG_MEDIA_USB_SUPPORT=y
+CONFIG_USB_VIDEO_CLASS=y
 CONFIG_FB=y
 CONFIG_FB_MXS=y
 CONFIG_BACKLIGHT_LCD_SUPPORT=y
@@ -158,6 +164,10 @@ CONFIG_NFS_V3=y
 CONFIG_NFS_V3_ACL=y
 CONFIG_NFS_V4=y
 CONFIG_ROOT_NFS=y
+CONFIG_NLS_CODEPAGE_437=y
+CONFIG_NLS_CODEPAGE_850=y
+CONFIG_NLS_ISO8859_1=y
+CONFIG_NLS_ISO8859_15=y
 CONFIG_PRINTK_TIME=y
 CONFIG_FRAME_WARN=2048
 CONFIG_MAGIC_SYSRQ=y
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 ARM: mxs_defconfig: Improve USB related support

Quoted 7 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Select the following USB related options:

- USB Video Class (webcam)
- USB Ethernet adapter
- Native language support (needed for mounting USB pen drives, for example)

I do not want defconfig/zImage get bloated by these features for particular applications. We should try to maintain a minimum feature set that takes care of mxs building and testing coverage. Anything more than that can just be selected by custom configuration.

Shawn

Quoted 44 lines
---
 arch/arm/configs/mxs_defconfig |   10 ++++++++++
 1 file changed, 10 insertions(+)
arch/arm/configs/mxs_defconfig +10 -0
index 048aaca..da51790 100644
@@ -61,6 +61,8 @@ CONFIG_MTD_NAND_GPMI_NAND=y
 CONFIG_NETDEVICES=y
 CONFIG_NET_ETHERNET=y
 CONFIG_ENC28J60=y
+CONFIG_USB_USBNET=y
+CONFIG_USB_NET_SMSC95XX=y
 # CONFIG_NETDEV_1000 is not set
 # CONFIG_NETDEV_10000 is not set
 # CONFIG_WLAN is not set
@@ -106,6 +108,10 @@ CONFIG_SND_SOC_I2C_AND_SPI=y
 CONFIG_SND_SOC_SGTL5000=y
 CONFIG_REGULATOR=y
 CONFIG_REGULATOR_FIXED_VOLTAGE=y
+CONFIG_MEDIA_SUPPORT=y
+CONFIG_MEDIA_CAMERA_SUPPORT=y
+CONFIG_MEDIA_USB_SUPPORT=y
+CONFIG_USB_VIDEO_CLASS=y
 CONFIG_FB=y
 CONFIG_FB_MXS=y
 CONFIG_BACKLIGHT_LCD_SUPPORT=y
@@ -158,6 +164,10 @@ CONFIG_NFS_V3=y
 CONFIG_NFS_V3_ACL=y
 CONFIG_NFS_V4=y
 CONFIG_ROOT_NFS=y
+CONFIG_NLS_CODEPAGE_437=y
+CONFIG_NLS_CODEPAGE_850=y
+CONFIG_NLS_ISO8859_1=y
+CONFIG_NLS_ISO8859_15=y
 CONFIG_PRINTK_TIME=y
 CONFIG_FRAME_WARN=2048
 CONFIG_MAGIC_SYSRQ=y
Signature · 1 line
1.7.9.5
#2 lore raw

PATCH 1/1 ARM: mxs_defconfig: Improve USB related support

Dear Shawn Guo,

Quoted 10 lines · Fabio Estevam
Quoted 8 lines

From: Fabio Estevam <[email protected]>

Select the following USB related options:

- USB Video Class (webcam)
- USB Ethernet adapter
- Native language support (needed for mounting USB pen drives, for example)

Quoted 4 lines

I do not want defconfig/zImage get bloated by these features for particular applications. We should try to maintain a minimum feature set that takes care of mxs building and testing coverage. Anything more than that can just be selected by custom configuration.

You can't mount VFAT-formated flashdisc that way ... so your test-coverage argument is invalid there.

Quoted 51 lines

Shawn

Quoted 49 lines

---

 arch/arm/configs/mxs_defconfig |   10 ++++++++++
 1 file changed, 10 insertions(+)
(quoted diff) +0 -0

b/arch/arm/configs/mxs_defconfig index 048aaca..da51790 100644

arch/arm/configs/mxs_defconfig +2 -0
@@ -61,6 +61,8 @@ CONFIG_MTD_NAND_GPMI_NAND=y
 
 CONFIG_NETDEVICES=y
 CONFIG_NET_ETHERNET=y
 CONFIG_ENC28J60=y
 
+CONFIG_USB_USBNET=y
+CONFIG_USB_NET_SMSC95XX=y
 

# CONFIG_NETDEV_1000 is not set
# CONFIG_NETDEV_10000 is not set
# CONFIG_WLAN is not set

arch/arm/configs/mxs_defconfig +4 -0
@@ -106,6 +108,10 @@ CONFIG_SND_SOC_I2C_AND_SPI=y
 
 CONFIG_SND_SOC_SGTL5000=y
 CONFIG_REGULATOR=y
 CONFIG_REGULATOR_FIXED_VOLTAGE=y
 
+CONFIG_MEDIA_SUPPORT=y
+CONFIG_MEDIA_CAMERA_SUPPORT=y
+CONFIG_MEDIA_USB_SUPPORT=y
+CONFIG_USB_VIDEO_CLASS=y
 

CONFIG_FB=y
CONFIG_FB_MXS=y
CONFIG_BACKLIGHT_LCD_SUPPORT=y

arch/arm/configs/mxs_defconfig +4 -0
@@ -158,6 +164,10 @@ CONFIG_NFS_V3=y
 
 CONFIG_NFS_V3_ACL=y
 CONFIG_NFS_V4=y
 CONFIG_ROOT_NFS=y
 
+CONFIG_NLS_CODEPAGE_437=y
+CONFIG_NLS_CODEPAGE_850=y
+CONFIG_NLS_ISO8859_1=y
+CONFIG_NLS_ISO8859_15=y
 
Quoted 8 lines
Quoted 3 lines

CONFIG_PRINTK_TIME=y
CONFIG_FRAME_WARN=2048
CONFIG_MAGIC_SYSRQ=y

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Best regards,
Marek Vasut

author reviewer
#3 lore raw

PATCH 1/1 ARM: mxs_defconfig: Improve USB related support

In reply to Shawn Guo

Hi Shawn,

Quoted 5 lines · Shawn Guo
Quoted 4 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Select the following USB related options:

Quoted 8 lines
Quoted 3 lines

- USB Video Class (webcam)
- USB Ethernet adapter
- Native language support (needed for mounting USB pen drives, for example)

I do not want defconfig/zImage get bloated by these features for particular applications. We should try to maintain a minimum feature set that takes care of mxs building and testing coverage. Anything more than that can just be selected by custom configuration.

I didn't mean to bloat mxs_defconfig with these settings.

+CONFIG_USB_USBNET=y
+CONFIG_USB_NET_SMSC95XX=

are needed by mx23-olinuxino so that we can have network support and can use NFS with this board.

+CONFIG_NLS_CODEPAGE_437=y
+CONFIG_NLS_CODEPAGE_850=y
+CONFIG_NLS_ISO8859_1=y
+CONFIG_NLS_ISO8859_1

is very useful, so that you can actually mount a USB media. We have these options in imx_v4_v5_defconfig and imx_v6_v7_defconfig.

If you are not happy with the USB webcam config options, then I can remove it.

Is it OK to send a v2 with USBNET and Language support only?

Just trying to make it easier for the end users.

Regards,

Fabio Estevam

#4 lore raw

PATCH 1/1 ARM: mxs_defconfig: Improve USB related support

Quoted 2 lines · Fabio Estevam

Is it OK to send a v2 with USBNET and Language support only?

OK.

Shawn