Skip to contentSkip to conversation

gcc-configure-cross: factor out --enable-threads argument into ${GCCTHREADS}

PATCH Applied Phil Blundell 4 participants 8 messages Sep 26, 2012

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gcc-configure-cross: factor out --enable-threads argument into ${GCCTHREADS}

This allows BSPs for architectures with no thread support to set (for example) "GCCTHREADS=no" without having to override all the other configure parameters.

---
 meta/recipes-devtools/gcc/gcc-configure-common.inc |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta/recipes-devtools/gcc/gcc-configure-common.inc +2 -1
index 908ad3e..504bfaa 100644
@@ -26,12 +26,13 @@ EXTRA_OECONF_INITIAL ?= ""
 EXTRA_OECONF_INTERMEDIATE ?= ""
 
 GCCMULTILIB = "--disable-multilib"
+GCCTHREADS = "posix"
 
 EXTRA_OECONF = "${@['--enable-clocale=generic', ''][d.getVar('USE_NLS', True) != 'no']} \
                 --with-gnu-ld \
                 --enable-shared \
                 --enable-languages=${LANGUAGES} \
-                --enable-threads=posix \
+                --enable-threads=${GCCTHREADS} \
                 ${GCCMULTILIB} \
                 --enable-c99 \
                 --enable-long-long \
Signature · 1 line
1.7.10.4
#1 lore raw
Quoted 30 lines · Phil Blundell

This allows BSPs for architectures with no thread support to set (for example) "GCCTHREADS=no" without having to override all the other configure parameters.

---
 meta/recipes-devtools/gcc/gcc-configure-common.inc |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta/recipes-devtools/gcc/gcc-configure-common.inc +2 -1
index 908ad3e..504bfaa 100644
@@ -26,12 +26,13 @@ EXTRA_OECONF_INITIAL ?= ""
 EXTRA_OECONF_INTERMEDIATE ?= ""
 
 GCCMULTILIB = "--disable-multilib"
+GCCTHREADS = "posix"
 
 EXTRA_OECONF = "${@['--enable-clocale=generic', ''][d.getVar('USE_NLS', True) != 'no']} \
                 --with-gnu-ld \
                 --enable-shared \
                 --enable-languages=${LANGUAGES} \
-                --enable-threads=posix \
+                --enable-threads=${GCCTHREADS} \
                 ${GCCMULTILIB} \
                 --enable-c99 \
                 --enable-long-long \
Signature · 1 line
1.7.10.4

Missing PR bump

Cheers,

Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#2 lore raw
Quoted 11 lines · Martin Jansa
Quoted 10 lines · Phil Blundell
meta/recipes-devtools/gcc/gcc-configure-common.inc +1 -0
index 908ad3e..504bfaa 100644
@@ -26,12 +26,13 @@ EXTRA_OECONF_INITIAL ?= ""
 EXTRA_OECONF_INTERMEDIATE ?= ""
 
 GCCMULTILIB = "--disable-multilib"
+GCCTHREADS = "posix"
 
Quoted 13 lines
Quoted 11 lines
meta/recipes-devtools/gcc/gcc-configure-common.inc +1 -1
 EXTRA_OECONF = "${@['--enable-clocale=generic', ''][d.getVar('USE_NLS', True) != 'no']} \
                 --with-gnu-ld \
                 --enable-shared \
                 --enable-languages=${LANGUAGES} \
-                --enable-threads=posix \
+                --enable-threads=${GCCTHREADS} \
                 ${GCCMULTILIB} \
                 --enable-c99 \
                 --enable-long-long \
Signature · 1 line
1.7.10.4

Missing PR bump

Does it really need one? It doesn't have any impact on the value that EXTRA_OECONF ends up with, and bumping the PRs on all the various .bb files would make the patch about ten times the size. I can do that if you insist but it seems like a bit of a waste of time.

p.

#3 lore raw
Quoted 26 lines · Phil Blundell
Quoted 11 lines · Martin Jansa
Quoted 10 lines · Phil Blundell
meta/recipes-devtools/gcc/gcc-configure-common.inc +1 -0
index 908ad3e..504bfaa 100644
@@ -26,12 +26,13 @@ EXTRA_OECONF_INITIAL ?= ""
 EXTRA_OECONF_INTERMEDIATE ?= ""
 
 GCCMULTILIB = "--disable-multilib"
+GCCTHREADS = "posix"
 
Quoted 13 lines
Quoted 11 lines
meta/recipes-devtools/gcc/gcc-configure-common.inc +1 -1
 EXTRA_OECONF = "${@['--enable-clocale=generic', ''][d.getVar('USE_NLS', True) != 'no']} \
                 --with-gnu-ld \
                 --enable-shared \
                 --enable-languages=${LANGUAGES} \
-                --enable-threads=posix \
+                --enable-threads=${GCCTHREADS} \
                 ${GCCMULTILIB} \
                 --enable-c99 \
                 --enable-long-long \
Signature · 1 line
1.7.10.4

Missing PR bump

Quoted 4 lines

Does it really need one? It doesn't have any impact on the value that EXTRA_OECONF ends up with, and bumping the PRs on all the various .bb files would make the patch about ten times the size. I can do that if you insist but it seems like a bit of a waste of time.

Sorry I haven't noticed that it's the same value as before.

But if it causes different sstate checksum than PR bump would be nice to get new builddir (well maybe not needed after f15f61af77cc4e52a037f509f8e49e1ea530cf35).

Cheers,

Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#4 lore raw
Quoted 4 lines · Martin Jansa

Sorry I haven't noticed that it's the same value as before.

But if it causes different sstate checksum than PR bump would be nice to get new builddir (well maybe not needed after f15f61af77cc4e52a037f509f8e49e1ea530cf35).

OK. In that case I'll leave the patch alone for now and see if Richard will swallow it as it stands.

p.

#5 lore raw
Quoted 8 lines · Phil Blundell
Quoted 4 lines · Martin Jansa

Sorry I haven't noticed that it's the same value as before.

But if it causes different sstate checksum than PR bump would be nice to get new builddir (well maybe not needed after f15f61af77cc4e52a037f509f8e49e1ea530cf35).

OK. In that case I'll leave the patch alone for now and see if Richard will swallow it as it stands.

I've merged it, lets see how that previous commit stands up to this test. I did change it to ?=, not that it matters a great deal.

Cheers,

Richard

#6 lore raw
In reply to Phil Blundell
Quoted 14 lines · Phil Blundell

This allows BSPs for architectures with no thread support to set (for example) "GCCTHREADS=no" without having to override all the other configure parameters.

---
 meta/recipes-devtools/gcc/gcc-configure-common.inc |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta/recipes-devtools/gcc/gcc-configure-common.inc +0 -0
index 908ad3e..504bfaa 100644

meta/recipes-devtools/gcc/gcc-configure-common.inc EXTRA_OECONF_INITIAL ?= "" · line 29

Quoted 4 lines
meta/recipes-devtools/gcc/gcc-configure-common.inc +1 -0
@@ -26,12 +26,13 @@ EXTRA_OECONF_INITIAL ?= ""
 EXTRA_OECONF_INTERMEDIATE ?= ""
 
 GCCMULTILIB = "--disable-multilib"
+GCCTHREADS = "posix"

Hi Phil,

should that not be GCCTHREADS ?=

otherwise I do not see how it could be overwritten from outside.

Bye Henning

#7 lore raw
Quoted 3 lines · Henning Heinold

should that not be GCCTHREADS ?=

otherwise I do not see how it could be overwritten from outside.

Well, a .bbappend can do it (since EXTRA_OECONF isn't assigned :=) or you can use an override GCCTHREADS_pn-gcc-cross = "no" for example. But yes, making it be ?= would be fine with me as well.

p.