Skip to contentSkip to conversation

RFC ath5k: missing break

PATCH New Alan Cox 1 participant 1 message Sep 26, 2012 Atheros ATH5K wireless driver

lore
Share & tools
lore

Alan Cox

author
#0 lore raw

PATCH 1/1 RFC ath5k: missing break

From: Alan Cox <[email protected]>

This code seems to make no sense otherwise for 5MHz mode as it always recomputes the values in the fall through.

[ath5k_hw_set_opmode looks suspicious too btw]

Signed-off-by Alan Cox <[email protected]>

---

 drivers/net/wireless/ath/ath5k/phy.c |    2 ++
 1 file changed, 2 insertions(+)
drivers/net/wireless/ath/ath5k/phy.c +2 -0
index 01c90ed..ab363f3 100644
@@ -1975,11 +1975,13 @@ ath5k_hw_set_spur_mitigation_filter(struct ath5k_hw *ah,
 			spur_delta_phase = (spur_offset << 18) / 25;
 			spur_freq_sigma_delta = (spur_delta_phase >> 10);
 			symbol_width = AR5K_SPUR_SYMBOL_WIDTH_BASE_100Hz / 2;
+			break;
 		case AR5K_BWMODE_5MHZ:
 			/* Both sample_freq and chip_freq are 10MHz (?) */
 			spur_delta_phase = (spur_offset << 19) / 25;
 			spur_freq_sigma_delta = (spur_delta_phase >> 10);
 			symbol_width = AR5K_SPUR_SYMBOL_WIDTH_BASE_100Hz / 4;
+			break;
 		default:
 			if (channel->band == IEEE80211_BAND_5GHZ) {
 				/* Both sample_freq and chip_freq are 40MHz */