h2200: Add support for iPAQ h2200 palmtop
PATCH v3 1/1 h2200: Add support for iPAQ h2200 palmtop
Basic support of HP iPAQ h2200 palmtop. Support includes also USB ethernet gadget.
--- board/h2200/Makefile | 51 ++++++++++++ board/h2200/h2200-header.S | 27 ++++++ board/h2200/h2200.c | 66 +++++++++++++++ boards.cfg | 2 + include/configs/h2200.h | 189 ++++++++++++++++++++++++++++++++++++++++++++ 5 files changed, 335 insertions(+), 0 deletions(-) create mode 100644 board/h2200/Makefile create mode 100644 board/h2200/h2200-header.S create mode 100644 board/h2200/h2200.c create mode 100644 include/configs/h2200.h
board/h2200/Makefile new file +51 -0
@@ -0,0 +1,51 @@ +# +# h2200 Support +# +# Copyright (C) 2012 Lukasz Dalek <[email protected]> +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation; either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 59 Temple Place, Suite 330, Boston, +# MA 02111-1307 USA +# + +include $(TOPDIR)/config.mk + +LIB = $(obj)lib$(BOARD).o + +COBJS := h2200.o + +SRCS := $(COBJS:.o=.c) h2200-header.S +OBJS := $(addprefix $(obj),$(COBJS)) + +ALL: $(LIB) h2200-header.bin + +h2200-header.o: h2200-header.S + $(CC) $(CFLAGS) -c -o $@ $< + +h2200-header.bin: h2200-header.o + $(OBJCOPY) -O binary $< $@ + +all: $(LIB) h2200-header.bin + +$(LIB): $(obj).depend $(OBJS) + $(call cmd_link_o_target, $(OBJS)) + +######################################################################### + +# defines $(obj).depend target +include $(SRCTREE)/rules.mk + +sinclude $(obj).depend + +#########################################################################
board/h2200/h2200-header.S new file +27 -0
@@ -0,0 +1,27 @@ +/* + * iPAQ h2200 header + * + * Copyright (C) 2012 Lukasz Dalek <[email protected]> + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + */ + + .word 0xea0003fe /* b 0x1000 */ + + .org 0x40 + .ascii "ECEC" + + .org 0x1000 - 1 + .byte 0x0
board/h2200/h2200.c new file +66 -0
66 lines not on this page · raw message
boards.cfg +2 -0
@@ -282,6 +282,8 @@ dvlhost arm ixp pdnb3 arm ixp pdnb3 prodrive scpu arm ixp pdnb3 prodrive - pdnb3:SCPU balloon3 arm pxa +h2200 arm pxa +h2200_usbeth arm pxa h2200 - - h2200:H2200_USBETH lubbock arm pxa palmld arm pxa palmtc arm pxa
include/configs/h2200.h new file +189 -0
189 lines not on this page · raw message
Signature · 1 line
1.7.8.6
PATCH 1/1 usb.h: Add udc_disconnect prototype to usb.h
PXA25x gadget implements common function usb_disconnect(). This patch adds this function prototype into usb.h for boards using it.
--- include/usb.h | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-)
include/usb.h +7 -0
@@ -166,6 +166,13 @@ int submit_int_msg(struct usb_device *dev, unsigned long pipe, void *buffer,#define USB_UHCI_VEND_ID 0x8086#define USB_UHCI_DEV_ID 0x7112 +/* +* This isn't host +*/ +#elif defined(CONFIG_USB_GADGET_PXA2XX ) + +extern void udc_disconnect (void ); +#else #error USB Lowlevel not defined#endif
Signature · 1 line
1.7.8.6
PATCH 1/1 usb.h: Add udc_disconnect prototype to usb.h
Dear Lukasz Dalek,
Quoted 2 lines
PXA25x gadget implements common function
usb_disconnect(). This patch adds this function prototype intousb.hfor boards using it.
[...]
Quoted 3 lines
+/*
+ * This isn't host
+ */
The comment doesn't need to be multiline. It'd be cool if it was meaningful ... like "pxa25x can only do gadget mode, thus the following ... etc". Otherwise, we're basically there.
Can you repost the whole patchset please?
include/usb.h int submit_int_msg(struct usb_device *dev, unsigned long pipe, void *buffer, · line 178
Quoted 7 lines
include/usb.h +4
-0+#elif defined(CONFIG_USB_GADGET_PXA2XX ) + +extern void udc_disconnect (void ); +#else #error USB Lowlevel not defined#endif
Best regards,
Marek Vasut
PATCH 1/1 usb.h: Add udc_disconnect prototype to usb.h
Quoted 4 lines · Marek Vasut
Dear Lukasz Dalek,
Quoted 2 lines
PXA25x gadget implements common function
usb_disconnect(). This patch adds this function prototype intousb.hfor boards using it.
Quoted 8 lines
[...]
Quoted 3 lines
+/*
+ * This isn't host
+ */The comment doesn't need to be multiline. It'd be cool if it was meaningful ... like "pxa25x can only do gadget mode, thus the following ... etc". Otherwise, we're basically there.
Ok
Quoted 2 lines
Can you repost the whole patchset please?
Whole? Including ethernet driver, pxa cpu detection etc...? If so, I'll resend them.
?ukasz Da?ek
PATCH 1/1 usb.h: Add udc_disconnect prototype to usb.h
Dear ?ukasz Da?ek,
Quoted 16 lines · Marek Vasut
Quoted 7 lines
Dear Lukasz Dalek,
Quoted 2 lines
PXA25x gadget implements common function
usb_disconnect(). This patch adds this function prototype intousb.hfor boards using it.[...]
Quoted 7 lines
Quoted 3 lines
+/*
+ * This isn't host
+ */The comment doesn't need to be multiline. It'd be cool if it was meaningful ... like "pxa25x can only do gadget mode, thus the following ... etc". Otherwise, we're basically there.
Quoted 6 lines
Ok
Quoted 1 line
Can you repost the whole patchset please?
Whole? Including ethernet driver, pxa cpu detection etc...? If so, I'll resend them.
Yes, in correct order please. We're almost there now.
btw. do you want to hack further on uboot? Maybe some PXA improvements cleanups etc?
Quoted 1 line
?ukasz Da?ek
Best regards,
Marek Vasut
PATCH 1/1 usb.h: Add udc_disconnect prototype to usb.h
Quoted 17 lines · Marek Vasut
Dear ?ukasz Da?ek,
Quoted 15 lines · Marek Vasut
Quoted 4 lines
Dear Lukasz Dalek,
Quoted 2 lines
PXA25x gadget implements common function
usb_disconnect(). This patch adds this function prototype intousb.hfor boards using it.Quoted 8 lines
[...]
Quoted 3 lines
+/*
+ * This isn't host
+ */The comment doesn't need to be multiline. It'd be cool if it was meaningful ... like "pxa25x can only do gadget mode, thus the following ... etc". Otherwise, we're basically there.
Ok
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
Can you repost the whole patchset please?
Whole? Including ethernet driver, pxa cpu detection etc...? If so, I'll resend them.
Yes, in correct order please. We're almost there now.
btw. do you want to hack further on uboot? Maybe some PXA improvements cleanups etc?
Yes, but before I want to complete what I've started with h2200...
?ukasz Da?ek
PATCH 1/1 usb.h: Add udc_disconnect prototype to usb.h
Dear ?ukasz Da?ek,
Quoted 27 lines · Marek Vasut
Quoted 26 lines
Dear ?ukasz Da?ek,
Quoted 23 lines · Marek Vasut
Quoted 8 lines
Dear Lukasz Dalek,
Quoted 3 lines
PXA25x gadget implements common function
usb_disconnect(). This patch adds this function prototype intousb.hfor boards using it.[...]
Quoted 7 lines
Quoted 3 lines
+/*
+ * This isn't host
+ */The comment doesn't need to be multiline. It'd be cool if it was meaningful ... like "pxa25x can only do gadget mode, thus the following ... etc". Otherwise, we're basically there.
Ok
Quoted 1 line
Can you repost the whole patchset please?
Whole? Including ethernet driver, pxa cpu detection etc...? If so, I'll resend them.
Quoted 6 lines
Quoted 4 lines
Yes, in correct order please. We're almost there now.
btw. do you want to hack further on uboot? Maybe some PXA improvements cleanups etc?
Yes, but before I want to complete what I've started with h2200...
You're basically there!
btw sorry if I sound a bit crazy, I've been pretty loaded recently so I might have forgotten what I have told you a few days ago ...
Quoted 1 line
?ukasz Da?ek
Best regards,
Marek Vasut
PATCH 1/1 usb.h: Add udc_disconnect prototype to usb.h
Quoted 22 lines · Marek Vasut
Dear ?ukasz Da?ek,
Quoted 20 lines · Marek Vasut
Quoted 19 lines
Dear ?ukasz Da?ek,
Quoted 17 lines · Marek Vasut
Quoted 5 lines
Dear Lukasz Dalek,
Quoted 3 lines
PXA25x gadget implements common function
usb_disconnect(). This patch adds this function prototype intousb.hfor boards using it.Quoted 8 lines
[...]
Quoted 3 lines
+/*
+ * This isn't host
+ */The comment doesn't need to be multiline. It'd be cool if it was meaningful ... like "pxa25x can only do gadget mode, thus the following ... etc". Otherwise, we're basically there.
Ok
Quoted 1 line
Can you repost the whole patchset please?
Quoted 8 lines
Quoted 7 lines
Quoted 6 lines
Quoted 2 lines
Whole? Including ethernet driver, pxa cpu detection etc...? If so, I'll resend them.
Yes, in correct order please. We're almost there now.
btw. do you want to hack further on uboot? Maybe some PXA improvements cleanups etc?
Yes, but before I want to complete what I've started with h2200...
You're basically there!
What do you mean saying that I am there?
Quoted 3 lines
btw sorry if I sound a bit crazy, I've been pretty loaded recently so I might have forgotten what I have told you a few days ago ...
No problem.
?ukasz Da?ek
PATCH 1/1 usb.h: Add udc_disconnect prototype to usb.h
Dear ?ukasz Da?ek,
Quoted 32 lines · Marek Vasut
Quoted 31 lines
Dear ?ukasz Da?ek,
Quoted 29 lines · Marek Vasut
Quoted 28 lines
Dear ?ukasz Da?ek,
Quoted 17 lines · Marek Vasut
Quoted 8 lines
Dear Lukasz Dalek,
Quoted 3 lines
PXA25x gadget implements common function
usb_disconnect(). This patch adds this function prototype intousb.hfor boards using it.[...]
Quoted 7 lines
Quoted 3 lines
+/*
+ * This isn't host
+ */The comment doesn't need to be multiline. It'd be cool if it was meaningful ... like "pxa25x can only do gadget mode, thus the following ... etc". Otherwise, we're basically there.
Quoted 6 lines
Ok
Quoted 1 line
Can you repost the whole patchset please?
Whole? Including ethernet driver, pxa cpu detection etc...? If so, I'll resend them.
Yes, in correct order please. We're almost there now.
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines
btw. do you want to hack further on uboot? Maybe some PXA improvements cleanups etc?
Yes, but before I want to complete what I've started with h2200...
You're basically there!
What do you mean saying that I am there?
That you've walked most of the journey already, there's only the one small final step for you to do ...
Quoted 6 lines
Quoted 2 lines
btw sorry if I sound a bit crazy, I've been pretty loaded recently so I might have forgotten what I have told you a few days ago ...
No problem.
?ukasz Da?ek
Best regards,
Marek Vasut
PATCH 1/1 usb.h: Add udc_disconnect prototype to usb.h
Quoted 29 lines · Marek Vasut
Dear ?ukasz Da?ek,
Quoted 27 lines · Marek Vasut
Quoted 26 lines
Dear ?ukasz Da?ek,
Quoted 24 lines · Marek Vasut
Quoted 23 lines
Dear ?ukasz Da?ek,
Quoted 11 lines · Marek Vasut
Quoted 10 lines
Dear Lukasz Dalek,
Quoted 3 lines
PXA25x gadget implements common function
usb_disconnect(). This patch adds this function prototype intousb.hfor boards using it.[...]
Quoted 3 lines
+/*
+ * This isn't host
+ */Quoted 8 lines
Quoted 3 lines
The comment doesn't need to be multiline. It'd be cool if it was meaningful ... like "pxa25x can only do gadget mode, thus the following ... etc". Otherwise, we're basically there.
Ok
Quoted 1 line
Can you repost the whole patchset please?
Whole? Including ethernet driver, pxa cpu detection etc...? If so, I'll resend them.
Yes, in correct order please. We're almost there now.
Quoted 7 lines
Quoted 5 lines
Quoted 4 lines
Quoted 3 lines
Quoted 2 lines
btw. do you want to hack further on uboot? Maybe some PXA improvements cleanups etc?
Yes, but before I want to complete what I've started with h2200...
You're basically there!
What do you mean saying that I am there?
That you've walked most of the journey already, there's only the one small final step for you to do ...
Yes, indeed.
?ukasz Da?ek
PATCH v3 1/1 h2200: Add support for iPAQ h2200 palmtop
In reply to Lukasz DalekDear Lukasz Dalek,
Quoted 2 lines
Basic support of HP iPAQ h2200 palmtop. Support includes also USB ethernet gadget.
Two minor nits ... can you extend the patch description?
Review
Quoted 5 lines
Signed-off-by Lukasz Dalek <[email protected]>[...]
(quoted diff) +2
-0+h2200 arm pxa +h2200_usbeth arm pxa h2200 -
Can you not enable USB ethernet by default?
[...]
Best regards,
Marek Vasut
PATCH v3 1/1 h2200: Add support for iPAQ h2200 palmtop
Quoted 6 lines · Marek Vasut
Dear Lukasz Dalek,
Quoted 2 lines
Basic support of HP iPAQ h2200 palmtop. Support includes also USB ethernet gadget.
Two minor nits ... can you extend the patch description?
Quoted 7 lines
Review
Quoted 4 lines
Signed-off-by Lukasz Dalek<[email protected]>[...](quoted diff) +2
-0+h2200 arm pxa +h2200_usbeth arm pxa h2200 -Can you not enable USB ethernet by default?
[...]
I don't understand.
make h2200_config creates config without usb ethernet make h2200_usbeth_config creates config with usb ethernet
?ukasz Da?ek
PATCH v3 1/1 h2200: Add support for iPAQ h2200 palmtop
Dear ?ukasz Da?ek,
Quoted 16 lines · Marek Vasut
Quoted 15 lines
Dear Lukasz Dalek,
Quoted 2 lines
Basic support of HP iPAQ h2200 palmtop. Support includes also USB ethernet gadget.
Two minor nits ... can you extend the patch description?
Review
Quoted 5 lines
Signed-off-by Lukasz Dalek<[email protected]>[...](quoted diff) +2
-0+h2200 arm pxa +h2200_usbeth arm pxa h2200 -Can you not enable USB ethernet by default?
Quoted 6 lines
Quoted 1 line
[...]
I don't understand.
make
h2200_configcreates config without usb ethernet makeh2200_usbeth_configcreates config with usb ethernet
Why not just make config with usb ethernet then?
Quoted 1 line
?ukasz Da?ek
Best regards,
Marek Vasut
PATCH v3 1/1 h2200: Add support for iPAQ h2200 palmtop
Quoted 16 lines · Marek Vasut
Dear ?ukasz Da?ek,
Quoted 14 lines · Marek Vasut
Quoted 13 lines
Dear Lukasz Dalek,
Quoted 2 lines
Basic support of HP iPAQ h2200 palmtop. Support includes also USB ethernet gadget.
Two minor nits ... can you extend the patch description?
Review
Quoted 5 lines
Signed-off-by Lukasz Dalek<[email protected]>[...](quoted diff) +2
-0+h2200 arm pxa +h2200_usbeth arm pxa h2200 -Can you not enable USB ethernet by default?
Quoted 7 lines
Quoted 5 lines
Quoted 1 line
[...]
I don't understand.
make
h2200_configcreates config without usb ethernet makeh2200_usbeth_configcreates config with usb ethernetWhy not just make config with usb ethernet then?
Sorry but I don't understand. You've asked me that can I not enable USB ethernet by default.
When you type make h2200_config it won't be enabled. It will compile simple u-boot with nothing enabled but console and serial.
When you type make h2200_usbeth_config then setup will define CONFIG_H2200_USBETH and compile h2200 with usbeth support.
So by default (with noting defined) it will compile simple h2200 support.
?ukasz Da?ek
PATCH v3 1/1 h2200: Add support for iPAQ h2200 palmtop
Dear ?ukasz Da?ek,
Quoted 24 lines · Marek Vasut
Quoted 23 lines
Dear ?ukasz Da?ek,
Quoted 21 lines · Marek Vasut
Quoted 12 lines
Dear Lukasz Dalek,
Quoted 2 lines
Basic support of HP iPAQ h2200 palmtop. Support includes also USB ethernet gadget.
Two minor nits ... can you extend the patch description?
Quoted 5 lines
Signed-off-by Lukasz Dalek<[email protected]>[...](quoted diff) +2
-0+h2200 arm pxa +h2200_usbeth arm pxa h2200Quoted 5 lines
Quoted 1 line
-
Can you not enable USB ethernet by default?
[...]
I don't understand.
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
make
h2200_configcreates config without usb ethernet makeh2200_usbeth_configcreates config with usb ethernetWhy not just make config with usb ethernet then?
Sorry but I don't understand. You've asked me that can I not enable USB ethernet by default.
I think you misunderstood. I was never against enabling the USB ethernet. I was against enabling it before the USB ethernet code is in, so it won't break bisectability.
If I did really say so, I'm sorry for the confusion.
Quoted 4 lines
When you type make
h2200_configit won't be enabled. It will compile simple u-boot with nothing enabled but console and serial.
Quoted 8 lines
When you type make
h2200_usbeth_configthen setup will defineCONFIG_H2200_USBETHand compile h2200 with usbeth support.So by default (with noting defined) it will compile simple h2200 support.
?ukasz Da?ek
Best regards,
Marek Vasut
PATCH v3 1/1 h2200: Add support for iPAQ h2200 palmtop
Quoted 25 lines · Marek Vasut
Dear ?ukasz Da?ek,
Quoted 23 lines · Marek Vasut
Quoted 22 lines
Dear ?ukasz Da?ek,
Quoted 20 lines · Marek Vasut
Quoted 11 lines
Dear Lukasz Dalek,
Quoted 2 lines
Basic support of HP iPAQ h2200 palmtop. Support includes also USB ethernet gadget.
Two minor nits ... can you extend the patch description?
Quoted 5 lines
Signed-off-by Lukasz Dalek<[email protected]>[...](quoted diff) +2
-0+h2200 arm pxa +h2200_usbeth arm pxa h2200Quoted 4 lines
Quoted 1 line
-Can you not enable USB ethernet by default?
[...]
I don't understand.
make
h2200_configcreates config without usb ethernet makeh2200_usbeth_configcreates config with usb ethernet
Quoted 8 lines
Quoted 3 lines
Quoted 1 line
Why not just make config with usb ethernet then?
Sorry but I don't understand. You've asked me that can I not enable USB ethernet by default.
I think you misunderstood. I was never against enabling the USB ethernet. I was against enabling it before the USB ethernet code is in, so it won't break bisectability.
If I did really say so, I'm sorry for the confusion.
So you want from me to split h2200 patches? I mean to prepare 2 patches:
1st one only adding support for device and 2nd one adding support for ethernet?
?ukasz Da?ek
PATCH v3 1/1 h2200: Add support for iPAQ h2200 palmtop
Dear ?ukasz Da?ek,
Quoted 39 lines · Marek Vasut
Quoted 38 lines
Dear ?ukasz Da?ek,
Quoted 24 lines · Marek Vasut
Quoted 23 lines
Dear ?ukasz Da?ek,
Quoted 21 lines · Marek Vasut
Quoted 12 lines
Dear Lukasz Dalek,
Quoted 2 lines
Basic support of HP iPAQ h2200 palmtop. Support includes also USB ethernet gadget.
Two minor nits ... can you extend the patch description?
Quoted 5 lines
Signed-off-by Lukasz Dalek<[email protected]>[...](quoted diff) +2
-0+h2200 arm pxa +h2200_usbeth arm pxa h2200Quoted 5 lines
Quoted 1 line
-Can you not enable USB ethernet by default?
[...]
I don't understand.
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
make
h2200_configcreates config without usb ethernet makeh2200_usbeth_configcreates config with usb ethernetWhy not just make config with usb ethernet then?
Sorry but I don't understand. You've asked me that can I not enable USB ethernet by default.
I think you misunderstood. I was never against enabling the USB ethernet. I was against enabling it before the USB ethernet code is in, so it won't break bisectability.
Quoted 5 lines
Quoted 1 line
If I did really say so, I'm sorry for the confusion.
So you want from me to split h2200 patches? I mean to prepare 2 patches:
1st one only adding support for device and 2nd one adding support for ethernet?
Oh, that would work nicely, good idea.
Quoted 1 line
?ukasz Da?ek
Best regards,
Marek Vasut
PATCH v3 1/1 h2200: Add support for iPAQ h2200 palmtop
Quoted 35 lines · Marek Vasut
Dear ?ukasz Da?ek,
Quoted 33 lines · Marek Vasut
Quoted 32 lines
Dear ?ukasz Da?ek,
Quoted 18 lines · Marek Vasut
Quoted 17 lines
Dear ?ukasz Da?ek,
Quoted 15 lines · Marek Vasut
Quoted 14 lines
Dear Lukasz Dalek,
Quoted 2 lines
Basic support of HP iPAQ h2200 palmtop. Support includes also USB ethernet gadget.
Two minor nits ... can you extend the patch description?
Review
Quoted 6 lines
Signed-off-by Lukasz Dalek<[email protected]>[...](quoted diff) +2
-0+h2200 arm pxa +h2200_usbeth arm pxa h2200 -Can you not enable USB ethernet by default?
Quoted 8 lines
Quoted 6 lines
Quoted 5 lines
Quoted 1 line
[...]
I don't understand.
make
h2200_configcreates config without usb ethernet makeh2200_usbeth_configcreates config with usb ethernetWhy not just make config with usb ethernet then?
Sorry but I don't understand. You've asked me that can I not enable USB ethernet by default.
I think you misunderstood. I was never against enabling the USB ethernet. I was against enabling it before the USB ethernet code is in, so it won't break bisectability.
Quoted 5 lines
Quoted 4 lines
Quoted 1 line
If I did really say so, I'm sorry for the confusion.
So you want from me to split h2200 patches? I mean to prepare 2 patches:
1st one only adding support for device and 2nd one adding support for ethernet?Oh, that would work nicely, good idea.
Ok, I will prepare them. But not sooner than tommorow.
?ukasz Da?ek
PATCH v3 1/1 h2200: Add support for iPAQ h2200 palmtop
Dear ?ukasz Da?ek,
Quoted 44 lines · Marek Vasut
Quoted 43 lines
Dear ?ukasz Da?ek,
Quoted 41 lines · Marek Vasut
Quoted 39 lines
Dear ?ukasz Da?ek,
Quoted 24 lines · Marek Vasut
Quoted 23 lines
Dear ?ukasz Da?ek,
Quoted 21 lines · Marek Vasut
Quoted 12 lines
Dear Lukasz Dalek,
Quoted 2 lines
Basic support of HP iPAQ h2200 palmtop. Support includes also USB ethernet gadget.
Two minor nits ... can you extend the patch description?
Quoted 5 lines
Signed-off-by Lukasz Dalek<[email protected]>[...](quoted diff) +2
-0+h2200 arm pxa +h2200_usbeth arm pxa h2200Quoted 5 lines
Quoted 1 line
-Can you not enable USB ethernet by default?
[...]
I don't understand.
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
make
h2200_configcreates config without usb ethernet makeh2200_usbeth_configcreates config with usb ethernetWhy not just make config with usb ethernet then?
Sorry but I don't understand. You've asked me that can I not enable USB ethernet by default.
I think you misunderstood. I was never against enabling the USB ethernet. I was against enabling it before the USB ethernet code is in, so it won't break bisectability.
If I did really say so, I'm sorry for the confusion.
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
So you want from me to split h2200 patches? I mean to prepare 2 patches:
1st one only adding support for device and 2nd one adding support for ethernet?Oh, that would work nicely, good idea.
Ok, I will prepare them. But not sooner than tommorow.
Take your time ... PXA won't run anywhere anyway. btw. you're polish? I might actually find you some old PXA device.
Quoted 1 line
?ukasz Da?ek
Best regards,
Marek Vasut
PATCH v3 1/1 h2200: Add support for iPAQ h2200 palmtop
Quoted 38 lines · Marek Vasut
Dear ?ukasz Da?ek,
Quoted 36 lines · Marek Vasut
Quoted 35 lines
Dear ?ukasz Da?ek,
Quoted 33 lines · Marek Vasut
Quoted 32 lines
Dear ?ukasz Da?ek,
Quoted 18 lines · Marek Vasut
Quoted 17 lines
Dear ?ukasz Da?ek,
Quoted 15 lines · Marek Vasut
Quoted 14 lines
Dear Lukasz Dalek,
Quoted 2 lines
Basic support of HP iPAQ h2200 palmtop. Support includes also USB ethernet gadget.
Two minor nits ... can you extend the patch description?
Review
Quoted 6 lines
Signed-off-by Lukasz Dalek<[email protected]>[...](quoted diff) +2
-0+h2200 arm pxa +h2200_usbeth arm pxa h2200 -Can you not enable USB ethernet by default?
Quoted 8 lines
Quoted 6 lines
Quoted 5 lines
Quoted 1 line
[...]
I don't understand.
make
h2200_configcreates config without usb ethernet makeh2200_usbeth_configcreates config with usb ethernetWhy not just make config with usb ethernet then?
Sorry but I don't understand. You've asked me that can I not enable USB ethernet by default.
I think you misunderstood. I was never against enabling the USB ethernet. I was against enabling it before the USB ethernet code is in, so it won't break bisectability.
Quoted 8 lines
Quoted 6 lines
Quoted 5 lines
Quoted 4 lines
Quoted 1 line
If I did really say so, I'm sorry for the confusion.
So you want from me to split h2200 patches? I mean to prepare 2 patches:
1st one only adding support for device and 2nd one adding support for ethernet?Oh, that would work nicely, good idea.
Ok, I will prepare them. But not sooner than tommorow.
Take your time ... PXA won't run anywhere anyway. btw. you're polish? I might actually find you some old PXA device.
Yes, I'm polish. I've one: pxa25x.
?ukasz Da?ek
PATCH v3 1/1 h2200: Add support for iPAQ h2200 palmtop
Dear ?ukasz Da?ek,
Quoted 51 lines · Marek Vasut
Quoted 50 lines
Dear ?ukasz Da?ek,
Quoted 48 lines · Marek Vasut
Quoted 47 lines
Dear ?ukasz Da?ek,
Quoted 44 lines · Marek Vasut
Quoted 31 lines
Dear ?ukasz Da?ek,
Quoted 29 lines · Marek Vasut
Quoted 27 lines
Dear ?ukasz Da?ek,
Quoted 17 lines · Marek Vasut
Quoted 16 lines
Dear Lukasz Dalek,
Quoted 2 lines
Basic support of HP iPAQ h2200 palmtop. Support includes also USB ethernet gadget.
Two minor nits ... can you extend the patch description?
Review
Quoted 6 lines
Signed-off-by Lukasz Dalek<[email protected]>[...](quoted diff) +2
-0+h2200 arm pxa +h2200_usbeth arm pxa h2200 -Can you not enable USB ethernet by default?
Quoted 6 lines
Quoted 1 line
[...]
I don't understand.
make
h2200_configcreates config without usb ethernet makeh2200_usbeth_configcreates config with usb ethernetWhy not just make config with usb ethernet then?
Quoted 8 lines
Quoted 2 lines
Sorry but I don't understand. You've asked me that can I not enable USB ethernet by default.
I think you misunderstood. I was never against enabling the USB ethernet. I was against enabling it before the USB ethernet code is in, so it won't break bisectability.
If I did really say so, I'm sorry for the confusion.
So you want from me to split h2200 patches? I mean to prepare 2
patches: 1st one only adding support for device and 2nd one adding support for ethernet?
Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
Oh, that would work nicely, good idea.
Ok, I will prepare them. But not sooner than tommorow.
Take your time ... PXA won't run anywhere anyway. btw. you're polish? I might actually find you some old PXA device.
Yes, I'm polish. I've one: pxa25x.
I have a pile of PXA boards here ... I think you can make do with the pxa255 for now and I'll see if I can find something for you.
Quoted 1 line
?ukasz Da?ek
Best regards,
Marek Vasut
PATCH v3 1/1 h2200: Add support for iPAQ h2200 palmtop
Quoted 45 lines · Marek Vasut
Dear ?ukasz Da?ek,
Quoted 43 lines · Marek Vasut
Quoted 42 lines
Dear ?ukasz Da?ek,
Quoted 40 lines · Marek Vasut
Quoted 39 lines
Dear ?ukasz Da?ek,
Quoted 37 lines · Marek Vasut
Quoted 25 lines
Dear ?ukasz Da?ek,
Quoted 23 lines · Marek Vasut
Quoted 22 lines
Dear ?ukasz Da?ek,
Quoted 20 lines · Marek Vasut
Quoted 11 lines
Dear Lukasz Dalek,
Quoted 2 lines
Basic support of HP iPAQ h2200 palmtop. Support includes also USB ethernet gadget.
Two minor nits ... can you extend the patch description?
Quoted 5 lines
Signed-off-by Lukasz Dalek<[email protected]>[...](quoted diff) +2
-0+h2200 arm pxa +h2200_usbeth arm pxa h2200Quoted 4 lines
Quoted 1 line
-Can you not enable USB ethernet by default?
[...]
I don't understand.
make
h2200_configcreates config without usb ethernet makeh2200_usbeth_configcreates config with usb ethernetQuoted 8 lines
Quoted 3 lines
Quoted 1 line
Why not just make config with usb ethernet then?
Sorry but I don't understand. You've asked me that can I not enable USB ethernet by default.
I think you misunderstood. I was never against enabling the USB ethernet. I was against enabling it before the USB ethernet code is in, so it won't break bisectability.
If I did really say so, I'm sorry for the confusion.
So you want from me to split h2200 patches? I mean to prepare 2
patches: 1st one only adding support for device and 2nd one adding support for ethernet?
Quoted 7 lines
Quoted 5 lines
Quoted 4 lines
Quoted 2 lines
Quoted 1 line
Oh, that would work nicely, good idea.
Ok, I will prepare them. But not sooner than tommorow.
Take your time ... PXA won't run anywhere anyway. btw. you're polish? I might actually find you some old PXA device.
Yes, I'm polish. I've one: pxa25x.
I have a pile of PXA boards here ... I think you can make do with the pxa255 for now and I'll see if I can find something for you.
Ok, so for now we will focus on pxa255 :-)
?ukasz Da?ek
PATCH v3 1/1 h2200: Add support for iPAQ h2200 palmtop
Dear ?ukasz Da?ek,
Quoted 61 lines · Marek Vasut
Quoted 60 lines
Dear ?ukasz Da?ek,
Quoted 58 lines · Marek Vasut
Quoted 56 lines
Dear ?ukasz Da?ek,
Quoted 44 lines · Marek Vasut
Quoted 43 lines
Dear ?ukasz Da?ek,
Quoted 41 lines · Marek Vasut
Quoted 39 lines
Dear ?ukasz Da?ek,
Quoted 24 lines · Marek Vasut
Quoted 23 lines
Dear ?ukasz Da?ek,
Quoted 21 lines · Marek Vasut
Quoted 12 lines
Dear Lukasz Dalek,
Quoted 2 lines
Basic support of HP iPAQ h2200 palmtop. Support includes also
USB ethernet gadget.Two minor nits ... can you extend the patch description?
Quoted 5 lines
Signed-off-by: Lukasz Dalek<[email protected]>
[...]
+h2200 arm pxa
+h2200_usbeth arm pxa h2200Quoted 5 lines
Quoted 1 line
-
Can you not enable USB ethernet by default?
[...]
I don't understand.
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
make
h2200_configcreates config without usb ethernet makeh2200_usbeth_configcreates config with usb ethernetWhy not just make config with usb ethernet then?
Sorry but I don't understand. You've asked me that can I not enable USB ethernet by default.
I think you misunderstood. I was never against enabling the USB ethernet. I was against enabling it before the USB ethernet code is in, so it won't break bisectability.
If I did really say so, I'm sorry for the confusion.
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
So you want from me to split h2200 patches? I mean to prepare 2
patches: 1st one only adding support for device and 2nd one adding support for ethernet?Oh, that would work nicely, good idea.
Ok, I will prepare them. But not sooner than tommorow.
Take your time ... PXA won't run anywhere anyway. btw. you're polish? I might actually find you some old PXA device.
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
Yes, I'm polish. I've one: pxa25x.
I have a pile of PXA boards here ... I think you can make do with the pxa255 for now and I'll see if I can find something for you.
Ok, so for now we will focus on pxa255 :-)
I need to focus on whole 2xx series, I had 3xx support in the works, but Intel/Marvell did such a shitty job there on the bootrom I couldn't get the whole series work properly.
Quoted 1 line
?ukasz Da?ek
Best regards,
Marek Vasut