drivers/net/cris/eth_v10.c:1715:2: error: too many arguments to function 'e100rxtx_interrupt'

DISCUSSION Fengguang Wu 3 participants 6 messages Sep 28, 2012 – Oct 6, 2012

Subsystems (3)

Networking Network drivers Kernel janitors

lore

Share & tools

lore

Fengguang Wu

author

2012-09-28 13:06 UTC #0 lore raw

Hi Jesper,

FYI, a rather old build bug that's introduced by

bafef0a cris build fixes: update eth_v10.c ethernet driver

All error/warnings:

drivers/net/cris/eth_v10.c: In function 'e100_netpoll':
drivers/net/cris/eth_v10.c:1715:2: error: too many arguments to function 'e100rxtx_interrupt' drivers/net/cris/eth_v10.c:1131:1: note: declared here

vim +1715 drivers/net/cris/eth_v10.c

^1da177e (Linus Torvalds 2005-04-16  1710) 
bafef0ae (Jesper Nilsson 2007-11-14  1711) #ifdef CONFIG_NET_POLL_CONTROLLER
bafef0ae (Jesper Nilsson 2007-11-14  1712) static void
bafef0ae (Jesper Nilsson 2007-11-14  1713) e100_netpoll(struct net_device* netdev)
bafef0ae (Jesper Nilsson 2007-11-14  1714) {
bafef0ae (Jesper Nilsson 2007-11-14 @1715) 	e100rxtx_interrupt(NETWORK_DMA_TX_IRQ_NBR, netdev, NULL);
bafef0ae (Jesper Nilsson 2007-11-14  1716) }
bafef0ae (Jesper Nilsson 2007-11-14  1717) #endif
bafef0ae (Jesper Nilsson 2007-11-14  1718) 
^1da177e (Linus Torvalds 2005-04-16  1719) static int
^1da177e (Linus Torvalds 2005-04-16  1720) etrax_init_module(void)
^1da177e (Linus Torvalds 2005-04-16  1721) {
^1da177e (Linus Torvalds 2005-04-16  1722) 	return etrax_ethernet_init();
^1da177e (Linus Torvalds 2005-04-16  1723) }

---
0-DAY kernel build testing backend Open Source Technology Centre
Fengguang Wu, Yuanhan Liu Intel Corporation

Jesper Nilsson

2012-10-03 10:46 UTC #1 lore raw

Quoted 1 line · Fengguang Wu

Hi Jesper,

Hi!

Quoted 9 lines

FYI, a rather old build bug that's introduced by
bafef0a cris build fixes: update eth_v10.c ethernet driver
All error/warnings:
drivers/net/cris/eth_v10.c: In function 'e100_netpoll':
drivers/net/cris/eth_v10.c:1715:2: error: too many arguments to function 'e100rxtx_interrupt' drivers/net/cris/eth_v10.c:1131:1: note: declared here

Yep, I can't figure out why the followup patches never reached mainline, but we have fixes for exactly that in our in-house tree. I'll push some move patches after this merge window.

Quoted 16 lines

vim +1715 drivers/net/cris/eth_v10.c

^1da177e (Linus Torvalds 2005-04-16  1710) 
bafef0ae (Jesper Nilsson 2007-11-14  1711) #ifdef CONFIG_NET_POLL_CONTROLLER
bafef0ae (Jesper Nilsson 2007-11-14  1712) static void
bafef0ae (Jesper Nilsson 2007-11-14  1713) e100_netpoll(struct net_device* netdev)
bafef0ae (Jesper Nilsson 2007-11-14  1714) {
bafef0ae (Jesper Nilsson 2007-11-14 @1715) 	e100rxtx_interrupt(NETWORK_DMA_TX_IRQ_NBR, netdev, NULL);
bafef0ae (Jesper Nilsson 2007-11-14  1716) }
bafef0ae (Jesper Nilsson 2007-11-14  1717) #endif
bafef0ae (Jesper Nilsson 2007-11-14  1718) 
^1da177e (Linus Torvalds 2005-04-16  1719) static int
^1da177e (Linus Torvalds 2005-04-16  1720) etrax_init_module(void)
^1da177e (Linus Torvalds 2005-04-16  1721) {
^1da177e (Linus Torvalds 2005-04-16  1722) 	return etrax_ethernet_init();
^1da177e (Linus Torvalds 2005-04-16  1723) }

Thanks!

/^JN - Jesper Nilsson

Signature · 1 line

               Jesper Nilsson -- [email protected]

David Miller

maintainer

2012-10-03 18:40 UTC #2 lore raw

From: Jesper Nilsson <[email protected]>
Date: Wed, 3 Oct 2012 12:46:52 +0200

Quoted 11 lines · Fengguang Wu

Quoted 1 line
Hi Jesper,
Hi!
Quoted 6 lines
FYI, a rather old build bug that's introduced by
bafef0a cris build fixes: update eth_v10.c ethernet driver
All error/warnings:

Quoted 7 lines

Quoted 3 lines
drivers/net/cris/eth_v10.c: In function 'e100_netpoll':
drivers/net/cris/eth_v10.c:1715:2: error: too many arguments to function 'e100rxtx_interrupt' drivers/net/cris/eth_v10.c:1131:1: note: declared here
Yep, I can't figure out why the followup patches never reached mainline, but we have fixes for exactly that in our in-house tree. I'll push some move patches after this merge window.

It's a bug fix, even worse a build fix, why want until after the merge window?

Jesper Nilsson

2012-10-03 20:26 UTC #3 lore raw

Quoted 18 lines · David Miller

From: Jesper Nilsson <[email protected]>
Date: Wed, 3 Oct 2012 12:46:52 +0200
Quoted 15 lines · Fengguang Wu
Quoted 1 line
Hi Jesper,
Hi!
Quoted 9 lines
FYI, a rather old build bug that's introduced by
bafef0a cris build fixes: update eth_v10.c ethernet driver
All error/warnings:
drivers/net/cris/eth_v10.c: In function 'e100_netpoll':
drivers/net/cris/eth_v10.c:1715:2: error: too many arguments to function 'e100rxtx_interrupt' drivers/net/cris/eth_v10.c:1131:1: note: declared here

Quoted 6 lines

Quoted 3 lines
Yep, I can't figure out why the followup patches never reached mainline, but we have fixes for exactly that in our in-house tree. I'll push some move patches after this merge window.
It's a bug fix, even worse a build fix, why want until after the merge window?

Aye, true, I'll just have to make sure I don't get any other change from the inhouse tree.

/^JN - Jesper Nilsson

Signature · 1 line

               Jesper Nilsson -- [email protected]

Jesper Nilsson

2012-10-05 21:24 UTC #4 lore raw

Quoted 23 lines · Jesper Nilsson

Quoted 22 lines · David Miller
From: Jesper Nilsson <[email protected]>
Date: Wed, 3 Oct 2012 12:46:52 +0200
Quoted 18 lines · Fengguang Wu
Quoted 1 line
Hi Jesper,
Hi!
Quoted 9 lines
FYI, a rather old build bug that's introduced by
bafef0a cris build fixes: update eth_v10.c ethernet driver
All error/warnings:
drivers/net/cris/eth_v10.c: In function 'e100_netpoll':
drivers/net/cris/eth_v10.c:1715:2: error: too many arguments to function 'e100rxtx_interrupt' drivers/net/cris/eth_v10.c:1131:1: note: declared here
Yep, I can't figure out why the followup patches never reached mainline, but we have fixes for exactly that in our in-house tree. I'll push some move patches after this merge window.

Quoted 5 lines

Quoted 2 lines
It's a bug fix, even worse a build fix, why want until after the merge window?
Aye, true, I'll just have to make sure I don't get any other change from the inhouse tree.

Turns out this was already fixed in mainline since August.

/^JN - Jesper Nilsson

Signature · 1 line

               Jesper Nilsson -- [email protected]

Fengguang Wu

author

2012-10-06 01:07 UTC #5 lore raw

Quoted 24 lines · Jesper Nilsson

Quoted 23 lines · Jesper Nilsson
Quoted 22 lines · David Miller
From: Jesper Nilsson <[email protected]>
Date: Wed, 3 Oct 2012 12:46:52 +0200
Quoted 18 lines · Fengguang Wu
Quoted 1 line
Hi Jesper,
Hi!
Quoted 9 lines
FYI, a rather old build bug that's introduced by
bafef0a cris build fixes: update eth_v10.c ethernet driver
All error/warnings:
drivers/net/cris/eth_v10.c: In function 'e100_netpoll':
drivers/net/cris/eth_v10.c:1715:2: error: too many arguments to function 'e100rxtx_interrupt' drivers/net/cris/eth_v10.c:1131:1: note: declared here
Yep, I can't figure out why the followup patches never reached mainline, but we have fixes for exactly that in our in-house tree. I'll push some move patches after this merge window.

Quoted 7 lines

Quoted 5 lines
Quoted 2 lines
It's a bug fix, even worse a build fix, why want until after the merge window?
Aye, true, I'll just have to make sure I don't get any other change from the inhouse tree.
Turns out this was already fixed in mainline since August.

Embarrassing.. It must be testing some git tree that's based on one upstream HEAD sometime between where the bug was introduced and where it's fixed.

Thanks,
Fengguang