Skip to contentSkip to conversation

ARM: OMAP: Move plat/dma*.h, omap-secure.h headers as part of single zImage work

PATCH Superseded Lokesh Vutla 5 participants 17 messages Sep 28, 2012 – Oct 1, 2012

Subsystems (17)
Arm (32-bit) Media (V4L/DVB) USB Arm sub-architectures +13 more subsystems

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Lokesh Vutla

author
#0 lore raw

cover ARM: OMAP: Move plat/dma*.h, omap-secure.h headers as part of single zImage work

Patch 1:
Dropping the file plat/dma44xx.h as none of the dma channel definitions are used.
Patch 2:
Moving plat/dma.h to platform_data/dma-omap.h
Patch 3:
Move omap_reserve() locally to mach-omap1/2
This helps in moving plat/omap-secure.h locally to mach-omap2
Patch 4:
Move plat/omap-secure.h locally to mach-omap2

Lokesh Vutla (4):
ARM: OMAP: DMA: Removing plat/dma-44xx.h
ARM: OMAP: DMA: Move plat/dma hearder to platform_data/dma-omap
ARM: OMAP: Move omap_reserve() locally to mach-omap1/2
ARM: OMAP: Move plat/omap-secure.h locally to mach-omap2

 arch/arm/mach-omap1/board-h2.c                     |    2 +-
 arch/arm/mach-omap1/board-h3.c                     |    2 +-
 arch/arm/mach-omap1/board-palmte.c                 |    2 +-
 arch/arm/mach-omap1/board-palmtt.c                 |    2 +-
 arch/arm/mach-omap1/board-palmz71.c                |    2 +-
 arch/arm/mach-omap1/board-sx1.c                    |    2 +-
 arch/arm/mach-omap1/common.h                       |    3 +
 arch/arm/mach-omap1/devices.c                      |    2 +-
 arch/arm/mach-omap1/dma.c                          |    2 +-
 arch/arm/mach-omap1/io.c                           |    2 +-
 arch/arm/mach-omap1/lcd_dma.c                      |    3 +-
 arch/arm/mach-omap1/mcbsp.c                        |    2 +-
 arch/arm/mach-omap1/pm.c                           |    2 +-
 arch/arm/mach-omap2/board-3430sdp.c                |    2 +-
 arch/arm/mach-omap2/board-h4.c                     |    2 +-
 arch/arm/mach-omap2/board-rx51-peripherals.c       |    2 +-
 arch/arm/mach-omap2/board-rx51.c                   |    2 +-
 arch/arm/mach-omap2/common.c                       |   20 +++
 arch/arm/mach-omap2/common.h                       |    1 +
 arch/arm/mach-omap2/devices.c                      |    2 +-
 arch/arm/mach-omap2/dma.c                          |    2 +-
 arch/arm/mach-omap2/io.c                           |    2 +-
 arch/arm/mach-omap2/mcbsp.c                        |    2 +-
 arch/arm/mach-omap2/omap-secure.c                  |    1 -
 arch/arm/mach-omap2/omap-secure.h                  |    7 +
 arch/arm/mach-omap2/omap4-common.c                 |    2 +-
 arch/arm/mach-omap2/omap_hwmod_2420_data.c         |    2 +-
 arch/arm/mach-omap2/omap_hwmod_2430_data.c         |    2 +-
 .../mach-omap2/omap_hwmod_2xxx_3xxx_ipblock_data.c |    3 +-
 arch/arm/mach-omap2/omap_hwmod_2xxx_ipblock_data.c |    2 +-
 arch/arm/mach-omap2/omap_hwmod_33xx_data.c         |    2 +-
 arch/arm/mach-omap2/omap_hwmod_3xxx_data.c         |    2 +-
 arch/arm/mach-omap2/omap_hwmod_44xx_data.c         |    2 +-
 arch/arm/mach-omap2/pm24xx.c                       |    2 +-
 arch/arm/mach-omap2/pm34xx.c                       |    2 +-
 arch/arm/mach-omap2/serial.c                       |    2 +-
 arch/arm/plat-omap/common.c                        |   21 +--
 arch/arm/plat-omap/dma.c                           |    2 +-
 arch/arm/plat-omap/include/plat/common.h           |    1 -
 arch/arm/plat-omap/include/plat/dma-44xx.h         |  147 --------------------
 arch/arm/plat-omap/include/plat/omap-secure.h      |   14 --
 drivers/crypto/omap-aes.c                          |    2 +-
 drivers/crypto/omap-sham.c                         |    3 +-
 drivers/dma/omap-dma.c                             |    2 +-
 drivers/media/platform/omap/omap_vout.c            |    2 +-
 drivers/media/platform/omap/omap_vout_vrfb.c       |    2 +-
 drivers/media/platform/omap3isp/ispstat.h          |    3 +-
 drivers/media/platform/soc_camera/omap1_camera.c   |    4 +-
 drivers/mmc/host/omap.c                            |    2 +-
 drivers/mtd/nand/omap2.c                           |    2 +-
 drivers/mtd/onenand/omap2.c                        |    2 +-
 drivers/usb/gadget/omap_udc.c                      |    3 +-
 drivers/usb/musb/tusb6010_omap.c                   |    2 +-
 drivers/video/omap/lcdc.c                          |    2 +-
 drivers/video/omap/omapfb_main.c                   |    3 +-
 drivers/video/omap/sossi.c                         |    3 +-
 .../linux/platform_data/dma-omap.h                 |    5 +-
 57 files changed, 83 insertions(+), 240 deletions(-)
 delete mode 100644 arch/arm/plat-omap/include/plat/dma-44xx.h
 delete mode 100644 arch/arm/plat-omap/include/plat/omap-secure.h
 rename arch/arm/plat-omap/include/plat/dma.h => include/linux/platform_data/dma-omap.h (99%)
Signature · 1 line
1.7.10.4
author
#1 lore raw

PATCH 1/4 ARM: OMAP: DMA: Removing plat/dma-44xx.h

None of the DMA channel definitions defined in
plat/dma-44xx.h are used. So removing it.

Signed-off-by Lokesh Vutla <[email protected]>
Acked-by Santosh Shilimkar <[email protected]>
---
 arch/arm/plat-omap/include/plat/dma-44xx.h |  147 ----------------------------
 arch/arm/plat-omap/include/plat/dma.h      |    3 -
 2 files changed, 150 deletions(-)
 delete mode 100644 arch/arm/plat-omap/include/plat/dma-44xx.h
arch/arm/plat-omap/include/plat/dma-44xx.h deleted +0 -0
deleted file mode 100644
index 1f767cb..0000000
arch/arm/plat-omap/include/plat/dma.h +0 -3
index 0a87b05..e413bd8 100644
@@ -28,9 +28,6 @@
  * the omap drivers hwmod adapted.
  */
 
-/* Move omap4 specific defines to dma-44xx.h */
-#include "dma-44xx.h"
-
 #define INT_DMA_LCD			25
 
 /* DMA channels for omap1 */
Signature · 1 line
1.7.10.4
author
#2 lore raw

PATCH 2/4 ARM: OMAP: DMA: Move plat/dma hearder to platform_data/dma-omap

In reply to Lokesh Vutla

Move plat/dma.h header to platform_data/dma-omap.h as part of the single zImage work.

Signed-off-by Lokesh Vutla <[email protected]>
Acked-by Santosh Shilimkar <[email protected]>
---
 arch/arm/mach-omap1/board-h2.c                                     |    2 +-
 arch/arm/mach-omap1/board-h3.c                                     |    2 +-
 arch/arm/mach-omap1/board-palmte.c                                 |    2 +-
 arch/arm/mach-omap1/board-palmtt.c                                 |    2 +-
 arch/arm/mach-omap1/board-palmz71.c                                |    2 +-
 arch/arm/mach-omap1/board-sx1.c                                    |    2 +-
 arch/arm/mach-omap1/devices.c                                      |    2 +-
 arch/arm/mach-omap1/dma.c                                          |    2 +-
 arch/arm/mach-omap1/io.c                                           |    2 +-
 arch/arm/mach-omap1/lcd_dma.c                                      |    3 +--
 arch/arm/mach-omap1/mcbsp.c                                        |    2 +-
 arch/arm/mach-omap1/pm.c                                           |    2 +-
 arch/arm/mach-omap2/board-3430sdp.c                                |    2 +-
 arch/arm/mach-omap2/board-h4.c                                     |    2 +-
 arch/arm/mach-omap2/board-rx51-peripherals.c                       |    2 +-
 arch/arm/mach-omap2/board-rx51.c                                   |    2 +-
 arch/arm/mach-omap2/devices.c                                      |    2 +-
 arch/arm/mach-omap2/dma.c                                          |    2 +-
 arch/arm/mach-omap2/io.c                                           |    2 +-
 arch/arm/mach-omap2/mcbsp.c                                        |    2 +-
 arch/arm/mach-omap2/omap_hwmod_2420_data.c                         |    2 +-
 arch/arm/mach-omap2/omap_hwmod_2430_data.c                         |    2 +-
 arch/arm/mach-omap2/omap_hwmod_2xxx_3xxx_ipblock_data.c            |    3 ++-
 arch/arm/mach-omap2/omap_hwmod_2xxx_ipblock_data.c                 |    2 +-
 arch/arm/mach-omap2/omap_hwmod_33xx_data.c                         |    2 +-
 arch/arm/mach-omap2/omap_hwmod_3xxx_data.c                         |    2 +-
 arch/arm/mach-omap2/omap_hwmod_44xx_data.c                         |    2 +-
 arch/arm/mach-omap2/pm24xx.c                                       |    2 +-
 arch/arm/mach-omap2/pm34xx.c                                       |    2 +-
 arch/arm/mach-omap2/serial.c                                       |    2 +-
 arch/arm/plat-omap/common.c                                        |    2 +-
 arch/arm/plat-omap/dma.c                                           |    2 +-
 drivers/crypto/omap-aes.c                                          |    2 +-
 drivers/crypto/omap-sham.c                                         |    3 ++-
 drivers/dma/omap-dma.c                                             |    2 +-
 drivers/media/platform/omap/omap_vout.c                            |    2 +-
 drivers/media/platform/omap/omap_vout_vrfb.c                       |    2 +-
 drivers/media/platform/omap3isp/ispstat.h                          |    3 ++-
 drivers/media/platform/soc_camera/omap1_camera.c                   |    4 +---
 drivers/mmc/host/omap.c                                            |    2 +-
 drivers/mtd/nand/omap2.c                                           |    2 +-
 drivers/mtd/onenand/omap2.c                                        |    2 +-
 drivers/usb/gadget/omap_udc.c                                      |    3 +--
 drivers/usb/musb/tusb6010_omap.c                                   |    2 +-
 drivers/video/omap/lcdc.c                                          |    2 +-
 drivers/video/omap/omapfb_main.c                                   |    3 +--
 drivers/video/omap/sossi.c                                         |    3 +--
 .../include/plat/dma.h => include/linux/platform_data/dma-omap.h   |    2 +-
 48 files changed, 51 insertions(+), 54 deletions(-)
 rename arch/arm/plat-omap/include/plat/dma.h => include/linux/platform_data/dma-omap.h (99%)
arch/arm/mach-omap1/board-h2.c +1 -1
index a2e53e1..d567bf2 100644
@@ -33,13 +33,13 @@
 #include <linux/omapfb.h>
 #include <linux/leds.h>
 #include <linux/platform_data/gpio-omap.h>
+#include <linux/platform_data/dma-omap.h>
 
 #include <asm/mach-types.h>
 #include <asm/mach/arch.h>
 #include <asm/mach/map.h>
 
 #include <mach/mux.h>
-#include <plat/dma.h>
 #include <plat/tc.h>
 #include <mach/irda.h>
 #include <linux/platform_data/keypad-omap.h>
arch/arm/mach-omap1/board-h3.c +1 -1
index fa98327..ad533bd 100644
@@ -33,6 +33,7 @@
 #include <linux/omapfb.h>
 #include <linux/leds.h>
 #include <linux/platform_data/gpio-omap.h>
+#include <linux/platform_data/dma-omap.h>
 
 #include <asm/setup.h>
 #include <asm/page.h>

@@ -43,7 +44,6 @@
 #include <mach/mux.h>
 #include <plat/tc.h>
 #include <linux/platform_data/keypad-omap.h>
-#include <plat/dma.h>
 #include <mach/flash.h>
 
 #include <mach/hardware.h>
arch/arm/mach-omap1/board-palmte.c +1 -1
index 1c578d5..8018ed9 100644
@@ -29,6 +29,7 @@
 #include <linux/apm-emulation.h>
 #include <linux/omapfb.h>
 #include <linux/platform_data/omap1_bl.h>
+#include <linux/platform_data/dma-omap.h>
 
 #include <asm/mach-types.h>
 #include <asm/mach/arch.h>

@@ -37,7 +38,6 @@
 #include <mach/flash.h>
 #include <mach/mux.h>
 #include <plat/tc.h>
-#include <plat/dma.h>
 #include <mach/irda.h>
 #include <linux/platform_data/keypad-omap.h>
arch/arm/mach-omap1/board-palmtt.c +1 -1
index 9715809..2ecb8d5 100644
@@ -28,6 +28,7 @@
 #include <linux/spi/spi.h>
 #include <linux/spi/ads7846.h>
 #include <linux/platform_data/omap1_bl.h>
+#include <linux/platform_data/dma-omap.h>
 
 #include <asm/mach-types.h>
 #include <asm/mach/arch.h>

@@ -36,7 +37,6 @@
 #include <plat/led.h>
 #include <mach/flash.h>
 #include <mach/mux.h>
-#include <plat/dma.h>
 #include <plat/tc.h>
 #include <mach/irda.h>
 #include <linux/platform_data/keypad-omap.h>
arch/arm/mach-omap1/board-palmz71.c +1 -1
index e311032..a48a941 100644
@@ -31,6 +31,7 @@
 #include <linux/spi/spi.h>
 #include <linux/spi/ads7846.h>
 #include <linux/platform_data/omap1_bl.h>
+#include <linux/platform_data/dma-omap.h>
 
 #include <asm/mach-types.h>
 #include <asm/mach/arch.h>

@@ -38,7 +39,6 @@
 
 #include <mach/flash.h>
 #include <mach/mux.h>
-#include <plat/dma.h>
 #include <plat/tc.h>
 #include <mach/irda.h>
 #include <linux/platform_data/keypad-omap.h>
arch/arm/mach-omap1/board-sx1.c +1 -1
index 13bf2cc..dcc63ee 100644
@@ -29,6 +29,7 @@
 #include <linux/export.h>
 #include <linux/omapfb.h>
 #include <linux/platform_data/keypad-omap.h>
+#include <linux/platform_data/dma-omap.h>
 
 #include <asm/mach-types.h>
 #include <asm/mach/arch.h>

@@ -36,7 +37,6 @@
 
 #include <mach/flash.h>
 #include <mach/mux.h>
-#include <plat/dma.h>
 #include <mach/irda.h>
 #include <plat/tc.h>
 #include <mach/board-sx1.h>
arch/arm/mach-omap1/devices.c +1 -1
index 0cc54dd..b050980 100644
@@ -16,12 +16,12 @@
 #include <linux/init.h>
 #include <linux/platform_device.h>
 #include <linux/spi/spi.h>
+#include <linux/platform_data/dma-omap.h>
 
 #include <asm/mach/map.h>
 
 #include <plat/tc.h>
 #include <mach/mux.h>
-#include <plat/dma.h>
 #include <plat/mmc.h>
 
 #include <mach/omap7xx.h>
arch/arm/mach-omap1/dma.c +1 -1
index 29007fe..a81a659 100644
@@ -24,8 +24,8 @@
 #include <linux/init.h>
 #include <linux/device.h>
 #include <linux/io.h>
+#include <linux/platform_data/dma-omap.h>
 
-#include <plat/dma.h>
 #include <plat/tc.h>
 
 #include <mach/irqs.h>
arch/arm/mach-omap1/io.c +1 -1
index 6a5baab..1b129c9 100644
@@ -12,13 +12,13 @@
 #include <linux/kernel.h>
 #include <linux/init.h>
 #include <linux/io.h>
+#include <linux/platform_data/dma-omap.h>
 
 #include <asm/tlb.h>
 #include <asm/mach/map.h>
 
 #include <mach/mux.h>
 #include <plat/tc.h>
-#include <plat/dma.h>
 
 #include "iomap.h"
 #include "common.h"
arch/arm/mach-omap1/lcd_dma.c +1 -2
index ed42628..b5cc8c8 100644
@@ -26,8 +26,7 @@
 #include <linux/spinlock.h>
 #include <linux/interrupt.h>
 #include <linux/io.h>
-
-#include <plat/dma.h>
+#include <linux/platform_data/dma-omap.h>
 
 #include <mach/hardware.h>
 #include <mach/lcdc.h>
arch/arm/mach-omap1/mcbsp.c +1 -1
index bdc2e75..5e65d4a 100644
@@ -18,8 +18,8 @@
 #include <linux/io.h>
 #include <linux/platform_device.h>
 #include <linux/slab.h>
+#include <linux/platform_data/dma-omap.h>
 
-#include <plat/dma.h>
 #include <mach/mux.h>
 #include <plat/cpu.h>
 #include <linux/platform_data/asoc-ti-mcbsp.h>
arch/arm/mach-omap1/pm.c +1 -1
index 47ec161..223c748 100644
@@ -43,6 +43,7 @@
 #include <linux/module.h>
 #include <linux/io.h>
 #include <linux/atomic.h>
+#include <linux/platform_data/dma-omap.h>
 
 #include <asm/system_misc.h>
 #include <asm/irq.h>

@@ -54,7 +55,6 @@
 #include <plat/sram.h>
 #include <plat/tc.h>
 #include <mach/mux.h>
-#include <plat/dma.h>
 #include <plat/dmtimer.h>
 
 #include <mach/irqs.h>
arch/arm/mach-omap2/board-3430sdp.c +1 -1
index 96cd369..a05e9aa 100644
@@ -25,6 +25,7 @@
 #include <linux/gpio.h>
 #include <linux/mmc/host.h>
 #include <linux/platform_data/spi-omap2-mcspi.h>
+#include <linux/platform_data/dma-omap.h>
 
 #include <asm/mach-types.h>
 #include <asm/mach/arch.h>

@@ -32,7 +33,6 @@
 
 #include <plat/usb.h>
 #include "common.h"
-#include <plat/dma.h>
 #include <plat/gpmc.h>
 #include <video/omapdss.h>
 #include <video/omap-panel-tfp410.h>
arch/arm/mach-omap2/board-h4.c +1 -1
index f6c48dd..4b6d000 100644
@@ -26,13 +26,13 @@
 #include <linux/clk.h>
 #include <linux/io.h>
 #include <linux/input/matrix_keypad.h>
+#include <linux/platform_data/dma-omap.h>
 
 #include <asm/mach-types.h>
 #include <asm/mach/arch.h>
 #include <asm/mach/map.h>
 
 #include <plat/menelaus.h>
-#include <plat/dma.h>
 #include <plat/gpmc.h>
 #include "debug-devices.h"
arch/arm/mach-omap2/board-rx51-peripherals.c +1 -1
index ed85fb8..7393361 100644
@@ -27,11 +27,11 @@
 #include <linux/power/isp1704_charger.h>
 #include <linux/platform_data/spi-omap2-mcspi.h>
 #include <linux/platform_data/mtd-onenand-omap2.h>
+#include <linux/platform_data/dma-omap.h>
 
 #include <asm/system_info.h>
 
 #include "common.h"
-#include <plat/dma.h>
 #include <plat/gpmc.h>
 #include <plat/omap-pm.h>
 #include "gpmc-smc91x.h"
arch/arm/mach-omap2/board-rx51.c +1 -1
index 7bbb05d..351f249 100644
@@ -18,13 +18,13 @@
 #include <linux/gpio.h>
 #include <linux/leds.h>
 #include <linux/platform_data/spi-omap2-mcspi.h>
+#include <linux/platform_data/dma-omap.h>
 
 #include <asm/mach-types.h>
 #include <asm/mach/arch.h>
 #include <asm/mach/map.h>
 
 #include "common.h"
-#include <plat/dma.h>
 #include <plat/gpmc.h>
 #include <plat/usb.h>
arch/arm/mach-omap2/devices.c +1 -1
index d092d2a8..6979ee5 100644
@@ -19,12 +19,12 @@
 #include <linux/of.h>
 #include <linux/pinctrl/machine.h>
 #include <linux/platform_data/omap4-keypad.h>
+#include <linux/platform_data/dma-omap.h>
 
 #include <asm/mach-types.h>
 #include <asm/mach/map.h>
 
 #include "iomap.h"
-#include <plat/dma.h>
 #include <plat/omap_hwmod.h>
 #include <plat/omap_device.h>
 #include "omap4-keypad.h"
arch/arm/mach-omap2/dma.c +1 -1
index ff75abe..0d35896 100644
@@ -27,10 +27,10 @@
 #include <linux/module.h>
 #include <linux/init.h>
 #include <linux/device.h>
+#include <linux/platform_data/dma-omap.h>
 
 #include <plat/omap_hwmod.h>
 #include <plat/omap_device.h>
-#include <plat/dma.h>
 
 #define OMAP2_DMA_STRIDE	0x60
arch/arm/mach-omap2/io.c +1 -1
index 4234d28..b837e31 100644
@@ -21,6 +21,7 @@
 #include <linux/init.h>
 #include <linux/io.h>
 #include <linux/clk.h>
+#include <linux/platform_data/dma-omap.h>
 
 #include <asm/tlb.h>
 #include <asm/mach/map.h>

@@ -31,7 +32,6 @@
 #include <plat/omap-pm.h>
 #include <plat/omap_hwmod.h>
 #include <plat/multi.h>
-#include <plat/dma.h>
 
 #include "soc.h"
 #include "iomap.h"
arch/arm/mach-omap2/mcbsp.c +1 -1
index 37f8f94..a6cada4 100644
@@ -19,8 +19,8 @@
 #include <linux/platform_device.h>
 #include <linux/slab.h>
 #include <linux/platform_data/asoc-ti-mcbsp.h>
+#include <linux/platform_data/dma-omap.h>
 
-#include <plat/dma.h>
 #include <plat/omap_device.h>
 #include <linux/pm_runtime.h>
arch/arm/mach-omap2/omap_hwmod_2420_data.c +1 -1
index 10575a1..e1b437b 100644
@@ -13,9 +13,9 @@
  * XXX these should be marked initdata for multi-OMAP kernels
  */
 #include <linux/platform_data/spi-omap2-mcspi.h>
+#include <linux/platform_data/dma-omap.h>
 
 #include <plat/omap_hwmod.h>
-#include <plat/dma.h>
 #include <plat/serial.h>
 #include <plat/i2c.h>
 #include <plat/dmtimer.h>
arch/arm/mach-omap2/omap_hwmod_2430_data.c +1 -1
index 60de70f..c69a109 100644
@@ -14,9 +14,9 @@
  */
 #include <linux/platform_data/asoc-ti-mcbsp.h>
 #include <linux/platform_data/spi-omap2-mcspi.h>
+#include <linux/platform_data/dma-omap.h>
 
 #include <plat/omap_hwmod.h>
-#include <plat/dma.h>
 #include <plat/serial.h>
 #include <plat/i2c.h>
 #include <plat/dmtimer.h>
arch/arm/mach-omap2/omap_hwmod_2xxx_3xxx_ipblock_data.c +2 -1
index 8851bbb..a0d1153 100644
@@ -9,9 +9,10 @@
  * it under the terms of the GNU General Public License version 2 as
  * published by the Free Software Foundation.
  */
+#include <linux/platform_data/dma-omap.h>
+
 #include <plat/omap_hwmod.h>
 #include <plat/serial.h>
-#include <plat/dma.h>
 #include <plat/common.h>
 #include "hdq1w.h"
arch/arm/mach-omap2/omap_hwmod_2xxx_ipblock_data.c +1 -1
index feeb401..7941119 100644
@@ -11,9 +11,9 @@
 #include <plat/omap_hwmod.h>
 #include <plat/serial.h>
 #include <linux/platform_data/gpio-omap.h>
-#include <plat/dma.h>
 #include <plat/dmtimer.h>
 #include <linux/platform_data/spi-omap2-mcspi.h>
+#include <linux/platform_data/dma-omap.h>
 
 #include "omap_hwmod_common_data.h"
 #include "cm-regbits-24xx.h"
arch/arm/mach-omap2/omap_hwmod_33xx_data.c +1 -1
index 59d5c1c..8a182aa 100644
@@ -13,12 +13,12 @@
  * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
  * GNU General Public License for more details.
  */
+#include <linux/platform_data/dma-omap.h>
 
 #include <plat/omap_hwmod.h>
 #include <plat/cpu.h>
 #include <linux/platform_data/gpio-omap.h>
 #include <linux/platform_data/spi-omap2-mcspi.h>
-#include <plat/dma.h>
 #include <plat/mmc.h>
 #include <plat/i2c.h>
arch/arm/mach-omap2/omap_hwmod_3xxx_data.c +1 -1
index 94b38af..ab85cdd 100644
@@ -16,9 +16,9 @@
  */
 #include <linux/power/smartreflex.h>
 #include <linux/platform_data/gpio-omap.h>
+#include <linux/platform_data/dma-omap.h>
 
 #include <plat/omap_hwmod.h>
-#include <plat/dma.h>
 #include <plat/serial.h>
 #include "l3_3xxx.h"
 #include "l4_3xxx.h"
arch/arm/mach-omap2/omap_hwmod_44xx_data.c +1 -1
index 4c92f23..b361380 100644
@@ -21,10 +21,10 @@
 #include <linux/io.h>
 #include <linux/platform_data/gpio-omap.h>
 #include <linux/power/smartreflex.h>
+#include <linux/platform_data/dma-omap.h>
 
 #include <plat/omap_hwmod.h>
 #include <plat/i2c.h>
-#include <plat/dma.h>
 #include <linux/platform_data/spi-omap2-mcspi.h>
 #include <linux/platform_data/asoc-ti-mcbsp.h>
 #include <plat/mmc.h>
arch/arm/mach-omap2/pm24xx.c +1 -1
index 8af6cd6..37c6392 100644
@@ -30,6 +30,7 @@
 #include <linux/time.h>
 #include <linux/gpio.h>
 #include <linux/platform_data/gpio-omap.h>
+#include <linux/platform_data/dma-omap.h>
 
 #include <asm/mach/time.h>
 #include <asm/mach/irq.h>

@@ -38,7 +39,6 @@
 
 #include <plat/clock.h>
 #include <plat/sram.h>
-#include <plat/dma.h>
 
 #include "common.h"
 #include "prm2xxx_3xxx.h"
arch/arm/mach-omap2/pm34xx.c +1 -1
index ba670db..3eba16c 100644
@@ -29,6 +29,7 @@
 #include <linux/delay.h>
 #include <linux/slab.h>
 #include <linux/platform_data/gpio-omap.h>
+#include <linux/platform_data/dma-omap.h>
 
 #include <trace/events/power.h>
 

@@ -41,7 +42,6 @@
 #include <plat/sdrc.h>
 #include <plat/prcm.h>
 #include <plat/gpmc.h>
-#include <plat/dma.h>
 
 #include "common.h"
 #include "cm2xxx_3xxx.h"
arch/arm/mach-omap2/serial.c +1 -1
index 0405c81..014dff7 100644
@@ -26,10 +26,10 @@
 #include <linux/slab.h>
 #include <linux/pm_runtime.h>
 #include <linux/console.h>
+#include <linux/platform_data/dma-omap.h>
 
 #include <plat/omap-serial.h>
 #include "common.h"
-#include <plat/dma.h>
 #include <plat/omap_hwmod.h>
 #include <plat/omap_device.h>
 #include <plat/omap-pm.h>
arch/arm/plat-omap/common.c +1 -1
index 111315a..18a837f 100644
@@ -15,11 +15,11 @@
 #include <linux/init.h>
 #include <linux/io.h>
 #include <linux/dma-mapping.h>
+#include <linux/platform_data/dma-omap.h>
 
 #include <plat/common.h>
 #include <plat/vram.h>
 #include <linux/platform_data/dsp-omap.h>
-#include <plat/dma.h>
 
 #include <plat/omap-secure.h>
arch/arm/plat-omap/dma.c +1 -1
index c76ed8b..aa12fc4 100644
@@ -35,9 +35,9 @@
 #include <linux/io.h>
 #include <linux/slab.h>
 #include <linux/delay.h>
+#include <linux/platform_data/dma-omap.h>
 
 #include <plat/cpu.h>
-#include <plat/dma.h>
 #include <plat/tc.h>
 
 /*
drivers/crypto/omap-aes.c +1 -1
index 093a8af..91fbc56 100644
@@ -26,11 +26,11 @@
 #include <linux/io.h>
 #include <linux/crypto.h>
 #include <linux/interrupt.h>
+#include <linux/platform_data/dma-omap.h>
 #include <crypto/scatterwalk.h>
 #include <crypto/aes.h>
 
 #include <plat/cpu.h>
-#include <plat/dma.h>
 
 /* OMAP TRM gives bitfields as start:end, where start is the higher bit
    number. For example 7:0 */
drivers/crypto/omap-sham.c +2 -1
index a3fd6fc..f523337 100644
@@ -31,6 +31,8 @@
 #include <linux/delay.h>
 #include <linux/crypto.h>
 #include <linux/cryptohash.h>
+#include <linux/platform_data/dma-omap.h>
+
 #include <crypto/scatterwalk.h>
 #include <crypto/algapi.h>
 #include <crypto/sha.h>

@@ -38,7 +40,6 @@
 #include <crypto/internal/hash.h>
 
 #include <plat/cpu.h>
-#include <plat/dma.h>
 #include <mach/irqs.h>
 
 #define SHA_REG_DIGEST(x)		(0x00 + ((x) * 0x04))
drivers/dma/omap-dma.c +1 -1
index bb2d8e7..b87cf89 100644
@@ -16,11 +16,11 @@
 #include <linux/platform_device.h>
 #include <linux/slab.h>
 #include <linux/spinlock.h>
+#include <linux/platform_data/dma-omap.h>
 
 #include "virt-dma.h"
 
 #include <plat/cpu.h>
-#include <plat/dma.h>
 
 struct omap_dmadev {
 	struct dma_device ddev;
drivers/media/platform/omap/omap_vout.c +1 -1
index c9783fb..54340c7 100644
@@ -39,13 +39,13 @@
 #include <linux/videodev2.h>
 #include <linux/dma-mapping.h>
 #include <linux/slab.h>
+#include <linux/platform_data/dma-omap.h>
 
 #include <media/videobuf-dma-contig.h>
 #include <media/v4l2-device.h>
 #include <media/v4l2-ioctl.h>
 
 #include <plat/cpu.h>
-#include <plat/dma.h>
 #include <plat/vrfb.h>
 #include <video/omapdss.h>
drivers/media/platform/omap/omap_vout_vrfb.c +1 -1
index 4be26abf6c..cb1ec32 100644
@@ -12,11 +12,11 @@
 #include <linux/sched.h>
 #include <linux/platform_device.h>
 #include <linux/videodev2.h>
+#include <linux/platform_data/dma-omap.h>
 
 #include <media/videobuf-dma-contig.h>
 #include <media/v4l2-device.h>
 
-#include <plat/dma.h>
 #include <plat/vrfb.h>
 
 #include "omap_voutdef.h"
drivers/media/platform/omap3isp/ispstat.h +2 -1
index 9b7c865..e36b939 100644
@@ -30,7 +30,8 @@
 
 #include <linux/types.h>
 #include <linux/omap3isp.h>
-#include <plat/dma.h>
+#include <linux/platform_data/dma-omap.h>
+
 #include <media/v4l2-event.h>
 
 #include "isp.h"
drivers/media/platform/soc_camera/omap1_camera.c +1 -3
index fa08c76..46c22c2 100644
@@ -27,6 +27,7 @@
 #include <linux/module.h>
 #include <linux/platform_device.h>
 #include <linux/slab.h>
+#include <linux/platform_data/dma-omap.h>
 
 #include <media/omap1_camera.h>
 #include <media/soc_camera.h>

@@ -34,9 +35,6 @@
 #include <media/videobuf-dma-contig.h>
 #include <media/videobuf-dma-sg.h>
 
-#include <plat/dma.h>
-
-
 #define DRIVER_NAME		"omap1-camera"
 #define DRIVER_VERSION		"0.0.2"
drivers/mmc/host/omap.c +1 -1
index 48ad361..fe0765b 100644
@@ -28,9 +28,9 @@
 #include <linux/clk.h>
 #include <linux/scatterlist.h>
 #include <linux/slab.h>
+#include <linux/platform_data/dma-omap.h>
 
 #include <plat/mmc.h>
-#include <plat/dma.h>
 
 #define	OMAP_MMC_REG_CMD	0x00
 #define	OMAP_MMC_REG_ARGL	0x01
drivers/mtd/nand/omap2.c +1 -1
index 5b31386..b885c6b 100644
@@ -22,12 +22,12 @@
 #include <linux/omap-dma.h>
 #include <linux/io.h>
 #include <linux/slab.h>
+#include <linux/platform_data/dma-omap.h>
 
 #ifdef CONFIG_MTD_NAND_OMAP_BCH
 #include <linux/bch.h>
 #endif
 
-#include <plat/dma.h>
 #include <plat/gpmc.h>
 #include <linux/platform_data/mtd-nand-omap2.h>
drivers/mtd/onenand/omap2.c +1 -1
index 1961be9..9c474b0 100644
@@ -36,13 +36,13 @@
 #include <linux/io.h>
 #include <linux/slab.h>
 #include <linux/regulator/consumer.h>
+#include <linux/platform_data/dma-omap.h>
 
 #include <asm/mach/flash.h>
 #include <plat/gpmc.h>
 #include <linux/platform_data/mtd-onenand-omap2.h>
 #include <asm/gpio.h>
 
-#include <plat/dma.h>
 #include <plat/cpu.h>
 
 #define DRIVER_NAME "omap2-onenand"
drivers/usb/gadget/omap_udc.c +1 -2
index 2a4749c..fc28da8 100644
@@ -38,14 +38,13 @@
 #include <linux/err.h>
 #include <linux/prefetch.h>
 #include <linux/io.h>
+#include <linux/platform_data/dma-omap.h>
 
 #include <asm/byteorder.h>
 #include <asm/irq.h>
 #include <asm/unaligned.h>
 #include <asm/mach-types.h>
 
-#include <plat/dma.h>
-
 #include <mach/usb.h>
 
 #include "omap_udc.h"
drivers/usb/musb/tusb6010_omap.c +1 -1
index 7a62b95..b8c5828 100644
@@ -16,7 +16,7 @@
 #include <linux/platform_device.h>
 #include <linux/dma-mapping.h>
 #include <linux/slab.h>
-#include <plat/dma.h>
+#include <linux/platform_data/dma-omap.h>
 
 #include "musb_core.h"
 #include "tusb6010.h"
drivers/video/omap/lcdc.c +1 -1
index 7767338..c6f82b3 100644
@@ -29,9 +29,9 @@
 #include <linux/vmalloc.h>
 #include <linux/clk.h>
 #include <linux/gfp.h>
+#include <linux/platform_data/dma-omap.h>
 
 #include <mach/lcdc.h>
-#include <plat/dma.h>
 
 #include <asm/mach-types.h>
drivers/video/omap/omapfb_main.c +1 -2
index 4351c43..22e321b 100644
@@ -29,8 +29,7 @@
 #include <linux/slab.h>
 #include <linux/uaccess.h>
 #include <linux/module.h>
-
-#include <plat/dma.h>
+#include <linux/platform_data/dma-omap.h>
 
 #include "omapfb.h"
 #include "lcdc.h"
drivers/video/omap/sossi.c +1 -2
index f79c137..f857574 100644
@@ -24,8 +24,7 @@
 #include <linux/irq.h>
 #include <linux/io.h>
 #include <linux/interrupt.h>
-
-#include <plat/dma.h>
+#include <linux/platform_data/dma-omap.h>
 
 #include "omapfb.h"
 #include "lcdc.h"
include/linux/platform_data/dma-omap.h renamed from arch/arm/plat-omap/include/plat/dma.h +1 -1
similarity index 99%
rename from arch/arm/plat-omap/include/plat/dma.h
rename to include/linux/platform_data/dma-omap.h
index e413bd8..366ca27 100644
@@ -1,5 +1,5 @@
 /*
- *  arch/arm/plat-omap/include/mach/dma.h
+ *  OMAP DMA handling defines and function
  *
  *  Copyright (C) 2003 Nokia Corporation
  *  Author: Juha Yrj?l? <[email protected]>
Signature · 1 line
1.7.10.4
maintainer
#3 lore raw

PATCH 2/4 ARM: OMAP: DMA: Move plat/dma hearder to platform_data/dma-omap

Quoted 2 lines · Lokesh Vutla

Move plat/dma.h header to platform_data/dma-omap.h as part of the single zImage work.

Hmm there's no platform data in this header, just exported things for drivers to use. So it should not be placed into platform_data.

Maybe it should be #include <asm/mach/dma-omap.h> for now?

Regards,

Tony

#4 lore raw

PATCH 2/4 ARM: OMAP: DMA: Move plat/dma hearder to platform_data/dma-omap

Quoted 11 lines · Tony Lindgren
Quoted 2 lines · Lokesh Vutla

Move plat/dma.h header to platform_data/dma-omap.h as part of the single zImage work.

Hmm there's no platform data in this header, just exported things for drivers to use. So it should not be placed into platform_data.

Maybe it should be #include <asm/mach/dma-omap.h> for now?

I wasn't sure either when the file was placed under platform-data. I agree for now we can keep it mach layer but than means OMAP1 and OMAP2+ DMA header and source code needs to be split. That is not so straight forward.

With DMA engine conversion hopefully, we might get rid of the header eventually, but for now not sure whether we should go ahead and follow the splitting part.

Thoughts ?

Regards
Santosh

maintainer
#5 lore raw

PATCH 2/4 ARM: OMAP: DMA: Move plat/dma hearder to platform_data/dma-omap

Quoted 10 lines · Shilimkar, Santosh
Quoted 9 lines · Tony Lindgren
Quoted 2 lines · Lokesh Vutla

Move plat/dma.h header to platform_data/dma-omap.h as part of the single zImage work.

Hmm there's no platform data in this header, just exported things for drivers to use. So it should not be placed into platform_data.

Quoted 6 lines
Quoted 2 lines

Maybe it should be #include <asm/mach/dma-omap.h> for now?

I wasn't sure either when the file was placed under platform-data. I agree for now we can keep it mach layer but than means OMAP1 and OMAP2+ DMA header and source code needs to be split. That is not so straight forward.

No need for that, the path I'm suggesting is located under arch/arm/include/asm/mach, it's not same as include <mach/dma-omap.h>.

Quoted 5 lines

With DMA engine conversion hopefully, we might get rid of the header eventually, but for now not sure whether we should go ahead and follow the splitting part.

Thoughts ?

No need for splitting anything :)

The other possible location would be just include <linux/dma-omap.h>, but as we all know that will be going away, <asm/mach/dma-omap.h> is probably better.

Tony

#6 lore raw

PATCH 2/4 ARM: OMAP: DMA: Move plat/dma hearder to platform_data/dma-omap

Quoted 13 lines · Tony Lindgren
Quoted 12 lines · Shilimkar, Santosh
Quoted 11 lines · Tony Lindgren
Quoted 2 lines · Lokesh Vutla

Move plat/dma.h header to platform_data/dma-omap.h as part of the single zImage work.

Hmm there's no platform data in this header, just exported things for drivers to use. So it should not be placed into platform_data.

Maybe it should be #include <asm/mach/dma-omap.h> for now?

Quoted 8 lines
Quoted 4 lines

I wasn't sure either when the file was placed under platform-data. I agree for now we can keep it mach layer but than means OMAP1 and OMAP2+ DMA header and source code needs to be split. That is not so straight forward.

No need for that, the path I'm suggesting is located under arch/arm/include/asm/mach, it's not same as include <mach/dma-omap.h>.

That sound ok.

Quoted 4 lines
Quoted 4 lines

With DMA engine conversion hopefully, we might get rid of the header eventually, but for now not sure whether we should go ahead and follow the splitting part.

Quoted 8 lines
Quoted 1 line

Thoughts ?

No need for splitting anything :)

The other possible location would be just include <linux/dma-omap.h>, but as we all know that will be going away, <asm/mach/dma-omap.h> is probably better.

Agree. I missed the "arch/arm/include/asm/mach" path. Thanks.

Regards
Santosh

#7 lore raw

PATCH 2/4 ARM: OMAP: DMA: Move plat/dma hearder to platform_data/dma-omap

In reply to Tony Lindgren
Quoted 25 lines · Tony Lindgren
Quoted 10 lines · Shilimkar, Santosh
Quoted 9 lines · Tony Lindgren
Quoted 2 lines · Lokesh Vutla

Move plat/dma.h header to platform_data/dma-omap.h as part of the single zImage work.

Hmm there's no platform data in this header, just exported things for drivers to use. So it should not be placed into platform_data.

Quoted 6 lines
Quoted 2 lines

Maybe it should be #include <asm/mach/dma-omap.h> for now?

I wasn't sure either when the file was placed under platform-data. I agree for now we can keep it mach layer but than means OMAP1 and OMAP2+ DMA header and source code needs to be split. That is not so straight forward.

No need for that, the path I'm suggesting is located under arch/arm/include/asm/mach, it's not same as include <mach/dma-omap.h>.

Quoted 4 lines

With DMA engine conversion hopefully, we might get rid of the header eventually, but for now not sure whether we should go ahead and follow the splitting part.

Quoted 7 lines
Quoted 1 line

Thoughts ?

No need for splitting anything :)

The other possible location would be just include <linux/dma-omap.h>, but as we all know that will be going away, <asm/mach/dma-omap.h> is probably better.

No, not asm/mach/anything, please. Let's try to get headers into the right place second time around.

This header appears to contain:

1. definitions for DMA signals, used by drivers.

This can be eliminated by using DT, platform data, or IORESOURCE_DMA (that's in preference order) which then means that these definitions can live in a header file in arch/arm/mach-omap*/ if at all.

2. data definitions and structures used by drivers using the legacy OMAP DMA API.

So, it doesn't contain platform data (as said above). It's not an API definition between core ARM code and ARM platform code, so that rules out arch/arm/include/asm/mach. Obviously arch/arm/include/asm is out of the question too.

I don't think we have a clear cut place for this to live - and lets be clear that this file will eventually be going away _anyway_ when OMAP is converted 100% to DMA engine.

So, where to put the file? At the moment, I don't know, it doesn't seem to have an obvious home other than where it currently is, which then gets in the way of the single kernel work.

#8 lore raw

PATCH 2/4 ARM: OMAP: DMA: Move plat/dma hearder to platform_data/dma-omap

Quoted 53 lines · Russell King - ARM Linux
Quoted 25 lines · Tony Lindgren
Quoted 10 lines · Shilimkar, Santosh
Quoted 9 lines · Tony Lindgren
Quoted 2 lines · Lokesh Vutla

Move plat/dma.h header to platform_data/dma-omap.h as part of the single zImage work.

Hmm there's no platform data in this header, just exported things for drivers to use. So it should not be placed into platform_data.

Quoted 6 lines
Quoted 2 lines

Maybe it should be #include <asm/mach/dma-omap.h> for now?

I wasn't sure either when the file was placed under platform-data. I agree for now we can keep it mach layer but than means OMAP1 and OMAP2+ DMA header and source code needs to be split. That is not so straight forward.

No need for that, the path I'm suggesting is located under arch/arm/include/asm/mach, it's not same as include <mach/dma-omap.h>.

Quoted 4 lines

With DMA engine conversion hopefully, we might get rid of the header eventually, but for now not sure whether we should go ahead and follow the splitting part.

Quoted 7 lines
Quoted 1 line

Thoughts ?

No need for splitting anything :)

The other possible location would be just include <linux/dma-omap.h>, but as we all know that will be going away, <asm/mach/dma-omap.h> is probably better.

No, not asm/mach/anything, please. Let's try to get headers into the right place second time around.

This header appears to contain:

1. definitions for DMA signals, used by drivers.

This can be eliminated by using DT, platform data, or IORESOURCE_DMA (that's in preference order) which then means that these definitions can live in a header file in arch/arm/mach-omap*/ if at all.

2. data definitions and structures used by drivers using the legacy OMAP DMA API.

So, it doesn't contain platform data (as said above). It's not an API definition between core ARM code and ARM platform code, so that rules out arch/arm/include/asm/mach. Obviously arch/arm/include/asm is out of the question too.

Quoted 7 lines

I don't think we have a clear cut place for this to live - and lets be clear that this file will eventually be going away _anyway_ when OMAP is converted 100% to DMA engine.

So, where to put the file? At the moment, I don't know, it doesn't seem to have an obvious home other than where it currently is, which then gets in the way of the single kernel work.

I am having the same problem with the OMAP dmtimer platform driver that the legacy DMA driver has. It is slightly worse as currently it is pure custom platform driver. Obviously long-term it would be best to create a generic timer driver in drivers/timer/ that other devices and architectures could use but we are a long way from that.

I know that this is ugly and has probably already been shot-down, but as a short-term fix, has creating arch/arm/plat-omap/include/plat-omap been NAK'ed for such problematic drivers?

Cheers
Jon

maintainer
#9 lore raw

PATCH 2/4 ARM: OMAP: DMA: Move plat/dma hearder to platform_data/dma-omap

Quoted 69 lines · Jon Hunter
Quoted 53 lines · Russell King - ARM Linux
Quoted 25 lines · Tony Lindgren
Quoted 10 lines · Shilimkar, Santosh
Quoted 9 lines · Tony Lindgren
Quoted 2 lines · Lokesh Vutla

Move plat/dma.h header to platform_data/dma-omap.h as part of the single zImage work.

Hmm there's no platform data in this header, just exported things for drivers to use. So it should not be placed into platform_data.

Quoted 6 lines
Quoted 2 lines

Maybe it should be #include <asm/mach/dma-omap.h> for now?

I wasn't sure either when the file was placed under platform-data. I agree for now we can keep it mach layer but than means OMAP1 and OMAP2+ DMA header and source code needs to be split. That is not so straight forward.

No need for that, the path I'm suggesting is located under arch/arm/include/asm/mach, it's not same as include <mach/dma-omap.h>.

Quoted 4 lines

With DMA engine conversion hopefully, we might get rid of the header eventually, but for now not sure whether we should go ahead and follow the splitting part.

Quoted 7 lines
Quoted 1 line

Thoughts ?

No need for splitting anything :)

The other possible location would be just include <linux/dma-omap.h>, but as we all know that will be going away, <asm/mach/dma-omap.h> is probably better.

No, not asm/mach/anything, please. Let's try to get headers into the right place second time around.

This header appears to contain:

1. definitions for DMA signals, used by drivers.

This can be eliminated by using DT, platform data, or IORESOURCE_DMA (that's in preference order) which then means that these definitions can live in a header file in arch/arm/mach-omap*/ if at all.

2. data definitions and structures used by drivers using the legacy OMAP DMA API.

So, it doesn't contain platform data (as said above). It's not an API definition between core ARM code and ARM platform code, so that rules out arch/arm/include/asm/mach. Obviously arch/arm/include/asm is out of the question too.

Quoted 7 lines

I don't think we have a clear cut place for this to live - and lets be clear that this file will eventually be going away _anyway_ when OMAP is converted 100% to DMA engine.

So, where to put the file? At the moment, I don't know, it doesn't seem to have an obvious home other than where it currently is, which then gets in the way of the single kernel work.

I am having the same problem with the OMAP dmtimer platform driver that the legacy DMA driver has. It is slightly worse as currently it is pure custom platform driver. Obviously long-term it would be best to create a generic timer driver in drivers/timer/ that other devices and architectures could use but we are a long way from that.

Quoted 3 lines

I know that this is ugly and has probably already been shot-down, but as a short-term fix, has creating arch/arm/plat-omap/include/plat-omap been NAK'ed for such problematic drivers?

Sounds like that's the way to go then. What we did not want to do is just move all the files blindly there, but for these files that seems like the way to go until they are just regular device drivers.

Regards,

Tony

author
#10 lore raw

PATCH 2/4 ARM: OMAP: DMA: Move plat/dma hearder to platform_data/dma-omap

Quoted 70 lines · Tony Lindgren
Quoted 69 lines · Jon Hunter
Quoted 53 lines · Russell King - ARM Linux
Quoted 25 lines · Tony Lindgren
Quoted 10 lines · Shilimkar, Santosh
Quoted 9 lines · Tony Lindgren
Quoted 2 lines · Lokesh Vutla

Move plat/dma.h header to platform_data/dma-omap.h as part of the single zImage work.

Hmm there's no platform data in this header, just exported things for drivers to use. So it should not be placed into platform_data.

Quoted 6 lines
Quoted 2 lines

Maybe it should be #include <asm/mach/dma-omap.h> for now?

I wasn't sure either when the file was placed under platform-data. I agree for now we can keep it mach layer but than means OMAP1 and OMAP2+ DMA header and source code needs to be split. That is not so straight forward.

No need for that, the path I'm suggesting is located under arch/arm/include/asm/mach, it's not same as include <mach/dma-omap.h>.

Quoted 4 lines

With DMA engine conversion hopefully, we might get rid of the header eventually, but for now not sure whether we should go ahead and follow the splitting part.

Quoted 7 lines
Quoted 1 line

Thoughts ?

No need for splitting anything :)

The other possible location would be just include <linux/dma-omap.h>, but as we all know that will be going away, <asm/mach/dma-omap.h> is probably better.

No, not asm/mach/anything, please. Let's try to get headers into the right place second time around.

This header appears to contain:

1. definitions for DMA signals, used by drivers.

This can be eliminated by using DT, platform data, or IORESOURCE_DMA (that's in preference order) which then means that these definitions can live in a header file in arch/arm/mach-omap*/ if at all.

2. data definitions and structures used by drivers using the legacy OMAP DMA API.

So, it doesn't contain platform data (as said above). It's not an API definition between core ARM code and ARM platform code, so that rules out arch/arm/include/asm/mach. Obviously arch/arm/include/asm is out of the question too.

Quoted 7 lines

I don't think we have a clear cut place for this to live - and lets be clear that this file will eventually be going away _anyway_ when OMAP is converted 100% to DMA engine.

So, where to put the file? At the moment, I don't know, it doesn't seem to have an obvious home other than where it currently is, which then gets in the way of the single kernel work.

I am having the same problem with the OMAP dmtimer platform driver that the legacy DMA driver has. It is slightly worse as currently it is pure custom platform driver. Obviously long-term it would be best to create a generic timer driver in drivers/timer/ that other devices and architectures could use but we are a long way from that.

Quoted 7 lines
Quoted 3 lines

I know that this is ugly and has probably already been shot-down, but as a short-term fix, has creating arch/arm/plat-omap/include/plat-omap been NAK'ed for such problematic drivers?

Sounds like that's the way to go then. What we did not want to do is just move all the files blindly there, but for these files that seems like the way to go until they are just regular device drivers.

Ok, Ill follow this. ll move plat/dma.h to plat-omap/dma-omap.h

Thanks
Lokesh

Quoted 4 lines

Regards,

Tony

author
#11 lore raw

PATCH 3/4 ARM: OMAP: Move omap_reserve() locally to mach-omap1/2

In reply to Lokesh Vutla

omap_reserve() is a stub for omap1. So creating a stub locally in mach-omap1. And moving the definition to mach-omap2.
This helps in moving plat/omap_secure.h local to mach-omap2

Signed-off-by Lokesh Vutla <[email protected]>
Acked-by Santosh Shilimkar <[email protected]>
---
 arch/arm/mach-omap1/common.h             |    3 +++
 arch/arm/mach-omap2/common.c             |   20 ++++++++++++++++++++
 arch/arm/mach-omap2/common.h             |    1 +
 arch/arm/plat-omap/common.c              |   17 -----------------
 arch/arm/plat-omap/include/plat/common.h |    1 -
 5 files changed, 24 insertions(+), 18 deletions(-)
arch/arm/mach-omap1/common.h +3 -0
index c2552b2..f7b01f1 100644
@@ -90,4 +90,7 @@ extern int ocpi_enable(void);
 static inline int ocpi_enable(void) { return 0; }
 #endif
 
+static inline void omap_reserve(void)
+{ }
+
 #endif /* __ARCH_ARM_MACH_OMAP1_COMMON_H */
arch/arm/mach-omap2/common.c +20 -0
index 17950c6..4ce0d63 100644
@@ -16,8 +16,11 @@
 #include <linux/init.h>
 #include <linux/clk.h>
 #include <linux/io.h>
+#include <linux/platform_data/dsp-omap.h>
 
 #include <plat/clock.h>
+#include <plat/omap-secure.h>
+#include <plat/vram.h>
 
 #include "soc.h"
 #include "iomap.h"

@@ -200,3 +203,20 @@ void __init omap5_map_io(void)
 	omap5_map_common_io();
 }
 #endif
+
+/*
+ * Stub function for OMAP2 so that common files
+ * continue to build when custom builds are used
+ */
+int __weak omap_secure_ram_reserve_memblock(void)
+{
+	return 0;
+}
+
+void __init omap_reserve(void)
+{
+	omap_vram_reserve_sdram_memblock();
+	omap_dsp_reserve_sdram_memblock();
+	omap_secure_ram_reserve_memblock();
+	omap_barrier_reserve_memblock();
+}
arch/arm/mach-omap2/common.h +1 -0
index 7045e4d..e84c589 100644
@@ -338,6 +338,7 @@ extern void omap_sdrc_init(struct omap_sdrc_params *sdrc_cs0,
 				      struct omap_sdrc_params *sdrc_cs1);
 struct omap2_hsmmc_info;
 extern int omap4_twl6030_hsmmc_init(struct omap2_hsmmc_info *controllers);
+extern void omap_reserve(void);
 
 #endif /* __ASSEMBLER__ */
 #endif /* __ARCH_ARM_MACH_OMAP2PLUS_COMMON_H */
arch/arm/plat-omap/common.c +0 -17
index 18a837f..8cd5c46 100644
@@ -23,26 +23,9 @@
 
 #include <plat/omap-secure.h>
 
-void __init omap_reserve(void)
-{
-	omap_vram_reserve_sdram_memblock();
-	omap_dsp_reserve_sdram_memblock();
-	omap_secure_ram_reserve_memblock();
-	omap_barrier_reserve_memblock();
-}
-
 void __init omap_init_consistent_dma_size(void)
 {
 #ifdef CONFIG_FB_OMAP_CONSISTENT_DMA_SIZE
 	init_consistent_dma_size(CONFIG_FB_OMAP_CONSISTENT_DMA_SIZE << 20);
 #endif
 }
-
-/*
- * Stub function for OMAP2 so that common files
- * continue to build when custom builds are used
- */
-int __weak omap_secure_ram_reserve_memblock(void)
-{
-	return 0;
-}
arch/arm/plat-omap/include/plat/common.h +0 -1
index d1cb6f5..cb337c3 100644
@@ -34,7 +34,6 @@ extern int __init omap_init_clocksource_32k(void __iomem *vbase);
 
 extern void __init omap_check_revision(void);
 
-extern void omap_reserve(void);
 extern int omap_dss_reset(struct omap_hwmod *);
 
 void omap_sram_init(void);
Signature · 1 line
1.7.10.4
#12 lore raw

PATCH 3/4 ARM: OMAP: Move omap_reserve() locally to mach-omap1/2

Quoted 21 lines · Lokesh Vutla

omap_reserve() is a stub for omap1. So creating a stub locally in mach-omap1. And moving the definition to mach-omap2.
This helps in moving plat/omap_secure.h local to mach-omap2

Signed-off-by Lokesh Vutla <[email protected]>
Acked-by Santosh Shilimkar <[email protected]>
---
 arch/arm/mach-omap1/common.h             |    3 +++
 arch/arm/mach-omap2/common.c             |   20 ++++++++++++++++++++
 arch/arm/mach-omap2/common.h             |    1 +
 arch/arm/plat-omap/common.c              |   17 -----------------
 arch/arm/plat-omap/include/plat/common.h |    1 -
 5 files changed, 24 insertions(+), 18 deletions(-)
arch/arm/mach-omap1/common.h +0 -0
index c2552b2..f7b01f1 100644

arch/arm/mach-omap1/common.h extern int ocpi_enable(void); · line 94

Quoted 5 lines
arch/arm/mach-omap1/common.h +2 -0
@@ -90,4 +90,7 @@ extern int ocpi_enable(void);
 static inline int ocpi_enable(void) { return 0; }
 #endif
 
+static inline void omap_reserve(void)
+{ }

This is the wrong approach. If OMAP1 doesn't need to do any reservation, then OMAP1 platforms should not be calling omap_reserve() and OMAP1 should not have this defined.

Just because OMAP2 does something one way does not mean OMAP1 needs to copy it in every detail.

#13 lore raw

PATCH 3/4 ARM: OMAP: Move omap_reserve() locally to mach-omap1/2

Quoted 33 lines · Russell King - ARM Linux
Quoted 21 lines · Lokesh Vutla

omap_reserve() is a stub for omap1. So creating a stub locally in mach-omap1. And moving the definition to mach-omap2.
This helps in moving plat/omap_secure.h local to mach-omap2

Signed-off-by Lokesh Vutla <[email protected]>
Acked-by Santosh Shilimkar <[email protected]>
---
 arch/arm/mach-omap1/common.h             |    3 +++
 arch/arm/mach-omap2/common.c             |   20 ++++++++++++++++++++
 arch/arm/mach-omap2/common.h             |    1 +
 arch/arm/plat-omap/common.c              |   17 -----------------
 arch/arm/plat-omap/include/plat/common.h |    1 -
 5 files changed, 24 insertions(+), 18 deletions(-)
arch/arm/mach-omap1/common.h +0 -0
index c2552b2..f7b01f1 100644

arch/arm/mach-omap1/common.h extern int ocpi_enable(void); · line 94

Quoted 5 lines
arch/arm/mach-omap1/common.h +2 -0
@@ -90,4 +90,7 @@ extern int ocpi_enable(void);
 static inline int ocpi_enable(void) { return 0; }
 #endif
 
+static inline void omap_reserve(void)
+{ }

This is the wrong approach. If OMAP1 doesn't need to do any reservation, then OMAP1 platforms should not be calling omap_reserve() and OMAP1 should not have this defined.

Quoted 2 lines

Just because OMAP2 does something one way does not mean OMAP1 needs to copy it in every detail.

This patch just updated the code as is. I mean the empty reserve callback already
exist before this patch.

But I do agree with you. I think we can drop the reserve callback completly from OMAP1 board files and then its easier to just make the omap_reserve() local to OMAP2+ machines.

Tony,
Are you ok in dropping OMAP1 reserve callback from all OMAP1 machines ?

Regards
Santosh

maintainer
#14 lore raw

PATCH 3/4 ARM: OMAP: Move omap_reserve() locally to mach-omap1/2

Quoted 42 lines · Shilimkar, Santosh
Quoted 33 lines · Russell King - ARM Linux
Quoted 21 lines · Lokesh Vutla

omap_reserve() is a stub for omap1. So creating a stub locally in mach-omap1. And moving the definition to mach-omap2.
This helps in moving plat/omap_secure.h local to mach-omap2

Signed-off-by Lokesh Vutla <[email protected]>
Acked-by Santosh Shilimkar <[email protected]>
---
 arch/arm/mach-omap1/common.h             |    3 +++
 arch/arm/mach-omap2/common.c             |   20 ++++++++++++++++++++
 arch/arm/mach-omap2/common.h             |    1 +
 arch/arm/plat-omap/common.c              |   17 -----------------
 arch/arm/plat-omap/include/plat/common.h |    1 -
 5 files changed, 24 insertions(+), 18 deletions(-)
arch/arm/mach-omap1/common.h +0 -0
index c2552b2..f7b01f1 100644

arch/arm/mach-omap1/common.h extern int ocpi_enable(void); · line 94

Quoted 5 lines
arch/arm/mach-omap1/common.h +2 -0
@@ -90,4 +90,7 @@ extern int ocpi_enable(void);
 static inline int ocpi_enable(void) { return 0; }
 #endif
 
+static inline void omap_reserve(void)
+{ }

This is the wrong approach. If OMAP1 doesn't need to do any reservation, then OMAP1 platforms should not be calling omap_reserve() and OMAP1 should not have this defined.

Quoted 2 lines

Just because OMAP2 does something one way does not mean OMAP1 needs to copy it in every detail.

This patch just updated the code as is. I mean the empty reserve callback already
exist before this patch.

Quoted 6 lines

But I do agree with you. I think we can drop the reserve callback completly from OMAP1 board files and then its easier to just make the omap_reserve() local to OMAP2+ machines.

Tony,
Are you ok in dropping OMAP1 reserve callback from all OMAP1 machines ?

Sure if it's not doing anything.

Regards,

Tony

author
#15 lore raw

PATCH 3/4 ARM: OMAP: Move omap_reserve() locally to mach-omap1/2

Quoted 43 lines · Tony Lindgren
Quoted 42 lines · Shilimkar, Santosh
Quoted 33 lines · Russell King - ARM Linux
Quoted 21 lines · Lokesh Vutla

omap_reserve() is a stub for omap1. So creating a stub locally in mach-omap1. And moving the definition to mach-omap2.
This helps in moving plat/omap_secure.h local to mach-omap2

Signed-off-by Lokesh Vutla <[email protected]>
Acked-by Santosh Shilimkar <[email protected]>
---
 arch/arm/mach-omap1/common.h             |    3 +++
 arch/arm/mach-omap2/common.c             |   20 ++++++++++++++++++++
 arch/arm/mach-omap2/common.h             |    1 +
 arch/arm/plat-omap/common.c              |   17 -----------------
 arch/arm/plat-omap/include/plat/common.h |    1 -
 5 files changed, 24 insertions(+), 18 deletions(-)
arch/arm/mach-omap1/common.h +0 -0
index c2552b2..f7b01f1 100644

arch/arm/mach-omap1/common.h extern int ocpi_enable(void); · line 94

Quoted 5 lines
arch/arm/mach-omap1/common.h +2 -0
@@ -90,4 +90,7 @@ extern int ocpi_enable(void);
 static inline int ocpi_enable(void) { return 0; }
 #endif
 
+static inline void omap_reserve(void)
+{ }

This is the wrong approach. If OMAP1 doesn't need to do any reservation, then OMAP1 platforms should not be calling omap_reserve() and OMAP1 should not have this defined.

Quoted 2 lines

Just because OMAP2 does something one way does not mean OMAP1 needs to copy it in every detail.

This patch just updated the code as is. I mean the empty reserve callback already
exist before this patch.

Quoted 8 lines
Quoted 6 lines

But I do agree with you. I think we can drop the reserve callback completly from OMAP1 board files and then its easier to just make the omap_reserve() local to OMAP2+ machines.

Tony,
Are you ok in dropping OMAP1 reserve callback from all OMAP1 machines ?

Sure if it's not doing anything.

Ok, Ill drop omap_reserve() callback from all OMAP1 machines and repost the patches..

Thanks
Lokesh

Quoted 4 lines

Regards,

Tony

author
#16 lore raw

PATCH 4/4 ARM: OMAP: Move plat/omap-secure.h locally to mach-omap2

In reply to Lokesh Vutla

Moving plat/omap-secure.h locally to mach-oamp2/
as part of single zImage work

Signed-off-by Lokesh Vutla <[email protected]>
Acked-by Santosh Shilimkar <[email protected]>
---
 arch/arm/mach-omap2/common.c                  |    2 +-
 arch/arm/mach-omap2/omap-secure.c             |    1 -
 arch/arm/mach-omap2/omap-secure.h             |    7 +++++++
 arch/arm/mach-omap2/omap4-common.c            |    2 +-
 arch/arm/plat-omap/common.c                   |    2 --
 arch/arm/plat-omap/include/plat/omap-secure.h |   14 --------------
 6 files changed, 9 insertions(+), 19 deletions(-)
 delete mode 100644 arch/arm/plat-omap/include/plat/omap-secure.h
arch/arm/mach-omap2/common.c +1 -1
index 4ce0d63..b0f21b7 100644
@@ -19,7 +19,6 @@
 #include <linux/platform_data/dsp-omap.h>
 
 #include <plat/clock.h>
-#include <plat/omap-secure.h>
 #include <plat/vram.h>
 
 #include "soc.h"

@@ -27,6 +26,7 @@
 #include "common.h"
 #include "sdrc.h"
 #include "control.h"
+#include "omap-secure.h"
 
 /* Global address base setup code */
arch/arm/mach-omap2/omap-secure.c +0 -1
index a004cb9..98624fe 100644
@@ -18,7 +18,6 @@
 #include <asm/cacheflush.h>
 #include <asm/memblock.h>
 
-#include <plat/omap-secure.h>
 #include "omap-secure.h"
 
 static phys_addr_t omap_secure_memblock_base;
arch/arm/mach-omap2/omap-secure.h +7 -0
index c90a435..0e72917 100644
@@ -52,6 +52,13 @@ extern u32 omap_secure_dispatcher(u32 idx, u32 flag, u32 nargs,
 				u32 arg1, u32 arg2, u32 arg3, u32 arg4);
 extern u32 omap_smc2(u32 id, u32 falg, u32 pargs);
 extern phys_addr_t omap_secure_ram_mempool_base(void);
+extern int omap_secure_ram_reserve_memblock(void);
 
+#ifdef CONFIG_OMAP4_ERRATA_I688
+extern int omap_barrier_reserve_memblock(void);
+#else
+static inline void omap_barrier_reserve_memblock(void)
+{ }
+#endif
 #endif /* __ASSEMBLER__ */
 #endif /* OMAP_ARCH_OMAP_SECURE_H */
arch/arm/mach-omap2/omap4-common.c +1 -1
index e1f2897..ae57b63 100644
@@ -26,7 +26,6 @@
 #include <asm/memblock.h>
 
 #include <plat/sram.h>
-#include <plat/omap-secure.h>
 #include <plat/mmc.h>
 
 #include "omap-wakeupgen.h"

@@ -35,6 +34,7 @@
 #include "common.h"
 #include "hsmmc.h"
 #include "omap4-sar-layout.h"
+#include "omap-secure.h"
 
 #ifdef CONFIG_CACHE_L2X0
 static void __iomem *l2cache_base;
arch/arm/plat-omap/common.c +0 -2
index 8cd5c46..6fdb8ff 100644
@@ -21,8 +21,6 @@
 #include <plat/vram.h>
 #include <linux/platform_data/dsp-omap.h>
 
-#include <plat/omap-secure.h>
-
 void __init omap_init_consistent_dma_size(void)
 {
 #ifdef CONFIG_FB_OMAP_CONSISTENT_DMA_SIZE
arch/arm/plat-omap/include/plat/omap-secure.h deleted +0 -0
deleted file mode 100644
index 0e4acd2..0000000
Signature · 1 line
1.7.10.4