Skip to contentSkip to conversation

Slightly amend mplayer options

PATCH New Valentine Barshak 2 participants 4 messages Sep 28, 2012 – Oct 4, 2012

lore
Share & tools
lore
#0 lore raw

cover Slightly amend mplayer options

These are a couple of mplayer nitpicks.

Valentine Barshak (2):
mplayer: Amend libmad selection
mplayer: Only enable IPv6 if BR2_INET_IPV6 is set

 package/multimedia/mplayer/mplayer.mk | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Thanks,
Val.

Signature · 1 line
1.7.11.4
#1 lore raw

PATCH 1/2 mplayer: Amend libmad selection

Do not set both --enable-mad and --disable-mad.

---
 package/multimedia/mplayer/mplayer.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/multimedia/mplayer/mplayer.mk +1 -1
index 05120bf..788beeb 100644
@@ -66,6 +66,7 @@ endif
 
 ifeq ($(BR2_PACKAGE_LIBMAD),y)
 MPLAYER_DEPENDENCIES += libmad
+MPLAYER_CONF_OPTS += --enable-mad
 else
 MPLAYER_CONF_OPTS += --disable-mad
 endif
@@ -121,7 +122,6 @@ define MPLAYER_CONFIGURE_CMDS
 		--extra-cflags="$(MPLAYER_CFLAGS)" \
 		--extra-ldflags="$(MPLAYER_LDFLAGS)" \
 		--yasm='' \
-		--enable-mad \
 		--enable-fbdev \
 		$(MPLAYER_CONF_OPTS) \
 		--enable-cross-compile \
Signature · 1 line
1.7.11.4
#2 lore raw

PATCH 2/2 mplayer: Only enable IPv6 if BR2_INET_IPV6 is set

In reply to Valentine Barshak

This fixes false positive IPv6 detection.

---
 package/multimedia/mplayer/mplayer.mk | 3 +++
 1 file changed, 3 insertions(+)
package/multimedia/mplayer/mplayer.mk +3 -0
index 788beeb..1a6b14f 100644
@@ -138,6 +138,9 @@ define MPLAYER_FIXUP_IPV6_MREQ_DETECTION
 endef
 
 MPLAYER_POST_CONFIGURE_HOOKS += MPLAYER_FIXUP_IPV6_MREQ_DETECTION
+MPLAYER_CONF_OPTS += --disable-inet6
+else
+MPLAYER_CONF_OPTS += --enable-inet6
 endif
 
 define MPLAYER_BUILD_CMDS
Signature · 1 line
1.7.11.4
#3 lore raw

cover Slightly amend mplayer options

In reply to Valentine Barshak
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Valentine" == Valentine Barshak <[email protected]> writes:

Valentine> These are a couple of mplayer nitpicks. Valentine> Valentine Barshak (2):
Valentine> mplayer: Amend libmad selection
Valentine> mplayer: Only enable IPv6 if BR2_INET_IPV6 is set

Committed both, thanks.

Signature · 1 line
Bye, Peter Korsgaard