ARM: arm1176: Define arch_cpu_init() for s3c64xx

From 0de61b9690c5f136ba5d3028be43877ea455d843 Mon Sep 17 00:00:00 2001
From: Ashok Kumar Reddy <[email protected]>
Date: Wed, 26 Sep 2012 23:44:59 +0530
Subject: [PATCH] ARM: arm1176: Define arch_cpu_init() for s3c64xx

arch_cpu_init() is removed from cpu level to SOC level for arm1176 in commit 4ea6d6b,the same is done for s3c64xx

Signed-off-by Ashok Kumar Reddy <[email protected]>

---
  arch/arm/cpu/arm1176/s3c64xx/Makefile |    2 +-
  arch/arm/cpu/arm1176/s3c64xx/init.c   |   26 ++++++++++++++++++++++++++
  2 files changed, 27 insertions(+), 1 deletion(-)

create mode 100644 arch/arm/cpu/arm1176/s3c64xx/init.c

arch/arm/cpu/arm1176/s3c64xx/Makefile +1 -1

index 0785b19..266a073 100644
@@ -31,7 +31,7 @@ LIB	= $(obj)lib$(SOC).o
  SOBJS	= reset.o
 
  COBJS-$(CONFIG_S3C6400)	+= cpu_init.o speed.o
-COBJS-y	+= timer.o
+COBJS-y	+= timer.o init.o
 
  OBJS	:= $(addprefix $(obj),$(SOBJS) $(COBJS-y))
 

arch/arm/cpu/arm1176/s3c64xx/init.c new file +26 -0

new file mode 100644
index 0000000..f113d8e
@@ -0,0 +1,26 @@
+/*
+ * (C) Copyright 2012 Ashok Kumar Reddy Kourla
+ * ashokkourla2000 at gmail.com
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include<common.h>
+
+int arch_cpu_init(void)
+{
+	icache_enable();
+
+	return 0;
+}

Hi Marek Vasut , Hi Stephen Warren

Please provide comments for the below patch, as i forgot to add you in cc for below mail.

Regards,
Ashok

Quoted 56 lines · Ashok Kumar Reddy

From 0de61b9690c5f136ba5d3028be43877ea455d843 Mon Sep 17 00:00:00 2001

From: Ashok Kumar Reddy <[email protected]>
Date: Wed, 26 Sep 2012 23:44:59 +0530
Subject: [PATCH] ARM: arm1176: Define arch_cpu_init() for s3c64xx

arch_cpu_init() is removed from cpu level to SOC level for arm1176 in commit 4ea6d6b,the same is done for s3c64xx

Signed-off-by Ashok Kumar Reddy <[email protected]>

---

  arch/arm/cpu/arm1176/s3c64xx/Makefile |    2 +-
  arch/arm/cpu/arm1176/s3c64xx/init.c   |   26 ++++++++++++++++++++++++++
  2 files changed, 27 insertions(+), 1 deletion(-)

create mode 100644 arch/arm/cpu/arm1176/s3c64xx/init.c

(quoted diff) +0 -0

b/arch/arm/cpu/arm1176/s3c64xx/Makefile index 0785b19..266a073 100644

arch/arm/cpu/arm1176/s3c64xx/Makefile +1 -1

@@ -31,7 +31,7 @@ LIB	= $(obj)lib$(SOC).o
 
  SOBJS	= reset.o
 
  COBJS-$(CONFIG_S3C6400)	+= cpu_init.o speed.o
 
-COBJS-y	+= timer.o
+COBJS-y	+= timer.o init.o
 

  OBJS	:= $(addprefix $(obj),$(SOBJS) $(COBJS-y))

(quoted diff) +0 -0

b/arch/arm/cpu/arm1176/s3c64xx/init.c new file mode 100644 index 0000000..f113d8e

arch/arm/cpu/arm1176/s3c64xx/init.c new file +18 -0

@@ -0,0 +1,26 @@
+/*
+ * (C) Copyright 2012 Ashok Kumar Reddy Kourla
+ * ashokkourla2000 at gmail.com
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+

arch/arm/cpu/arm1176/s3c64xx/init.c line 26

Quoted 8 lines

arch/arm/cpu/arm1176/s3c64xx/init.c new file +8 -0

+#include<common.h>
+
+int arch_cpu_init(void)
+{
+	icache_enable();
+
+	return 0;
+}

Dear Ashok Kumar Reddy,

Quoted 4 lines

Hi Marek Vasut , Hi Stephen Warren

Please provide comments for the below patch, as i forgot to add you in cc for below mail.

You CC wrong people, CCing Minkyu.

Anyway, this doesn't seem right, removing CONFIG_ICACHE_OFF from your config file should have the same impact, right?

Quoted 64 lines

Regards,
Ashok

Quoted 59 lines · Ashok Kumar Reddy

From 0de61b9690c5f136ba5d3028be43877ea455d843 Mon Sep 17 00:00:00 2001

From: Ashok Kumar Reddy <[email protected]>
Date: Wed, 26 Sep 2012 23:44:59 +0530
Subject: [PATCH] ARM: arm1176: Define arch_cpu_init() for s3c64xx

arch_cpu_init() is removed from cpu level to SOC level for arm1176 in commit 4ea6d6b,the same is done for s3c64xx

Signed-off-by Ashok Kumar Reddy <[email protected]>

---

   arch/arm/cpu/arm1176/s3c64xx/Makefile |    2 +-
   arch/arm/cpu/arm1176/s3c64xx/init.c   |   26 ++++++++++++++++++++++++++
   2 files changed, 27 insertions(+), 1 deletion(-)

create mode 100644 arch/arm/cpu/arm1176/s3c64xx/init.c

(quoted diff) +0 -0

b/arch/arm/cpu/arm1176/s3c64xx/Makefile index 0785b19..266a073 100644

arch/arm/cpu/arm1176/s3c64xx/Makefile +1 -1

@@ -31,7 +31,7 @@ LIB	= $(obj)lib$(SOC).o
 
   SOBJS	= reset.o
 
   COBJS-$(CONFIG_S3C6400)	+= cpu_init.o speed.o
 
-COBJS-y	+= timer.o
+COBJS-y	+= timer.o init.o
 

   OBJS	:= $(addprefix $(obj),$(SOBJS) $(COBJS-y))

(quoted diff) +0 -0

b/arch/arm/cpu/arm1176/s3c64xx/init.c new file mode 100644 index 0000000..f113d8e

arch/arm/cpu/arm1176/s3c64xx/init.c new file +21 -0

@@ -0,0 +1,26 @@
+/*
+ * (C) Copyright 2012 Ashok Kumar Reddy Kourla
+ * ashokkourla2000 at gmail.com
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include<common.h>
+
+int arch_cpu_init(void)

Quoted 5 lines

arch/arm/cpu/arm1176/s3c64xx/init.c line 26

Quoted 5 lines

arch/arm/cpu/arm1176/s3c64xx/init.c new file +5 -0

+{
+	icache_enable();
+
+	return 0;
+}

Best regards,
Marek Vasut

Hi Marek Vasut,

Quoted 7 lines · Marek Vasut

Dear Ashok Kumar Reddy,

Quoted 4 lines

Hi Marek Vasut , Hi Stephen Warren

Please provide comments for the below patch, as i forgot to add you in cc for below mail.

Quoted 4 lines

You CC wrong people, CCing Minkyu.

Anyway, this doesn't seem right, removing CONFIG_ICACHE_OFF from your config file should have the same impact, right?

CONFIG_ICACHE_OFF is valid for only blackfin as per grep in u-boot code, the icache enable is done in arch_cpu_init() for arm1176

Quoted 65 lines

Quoted 65 lines

Regards,
Ashok

Quoted 61 lines · Ashok Kumar Reddy

From 0de61b9690c5f136ba5d3028be43877ea455d843 Mon Sep 17 00:00:00 2001

From: Ashok Kumar Reddy <[email protected]>
Date: Wed, 26 Sep 2012 23:44:59 +0530
Subject: [PATCH] ARM: arm1176: Define arch_cpu_init() for s3c64xx

arch_cpu_init() is removed from cpu level to SOC level for arm1176 in commit 4ea6d6b,the same is done for s3c64xx

Signed-off-by Ashok Kumar Reddy <[email protected]>

---

   arch/arm/cpu/arm1176/s3c64xx/Makefile |    2 +-
   arch/arm/cpu/arm1176/s3c64xx/init.c   |   26

++++++++++++++++++++++++++ 2 files changed, 27 insertions(+), 1 deletion(-)
create mode 100644 arch/arm/cpu/arm1176/s3c64xx/init.c

(quoted diff) +0 -0

b/arch/arm/cpu/arm1176/s3c64xx/Makefile index 0785b19..266a073 100644

arch/arm/cpu/arm1176/s3c64xx/Makefile +1 -1

@@ -31,7 +31,7 @@ LIB	= $(obj)lib$(SOC).o
 
   SOBJS	= reset.o
 
   COBJS-$(CONFIG_S3C6400)	+= cpu_init.o speed.o
 
-COBJS-y	+= timer.o
+COBJS-y	+= timer.o init.o
 

   OBJS	:= $(addprefix $(obj),$(SOBJS) $(COBJS-y))

(quoted diff) +0 -0

b/arch/arm/cpu/arm1176/s3c64xx/init.c new file mode 100644 index 0000000..f113d8e

arch/arm/cpu/arm1176/s3c64xx/init.c new file +21 -0

@@ -0,0 +1,26 @@
+/*
+ * (C) Copyright 2012 Ashok Kumar Reddy Kourla
+ * ashokkourla2000 at gmail.com
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include<common.h>
+
+int arch_cpu_init(void)

Quoted 8 lines

Quoted 5 lines

arch/arm/cpu/arm1176/s3c64xx/init.c line 26

Quoted 5 lines

arch/arm/cpu/arm1176/s3c64xx/init.c new file +5 -0

+{
+	icache_enable();
+
+	return 0;
+}

Best regards,
Marek Vasut

Regards,
Ashok

From 0de61b9690c5f136ba5d3028be43877ea455d843 Mon Sep 17 00:00:00 2001
From: Ashok Kumar Reddy <[email protected]>
Date: Wed, 26 Sep 2012 23:44:59 +0530
Subject: [PATCH] ARM: arm1176: Define arch_cpu_init() for s3c64xx

arch_cpu_init() is removed from cpu level to SOC level for arm1176 in commit 4ea6d6b,the same is done for s3c64xx

Signed-off-by Ashok Kumar Reddy <[email protected]>

---
 arch/arm/cpu/arm1176/s3c64xx/Makefile |    2 +-
 arch/arm/cpu/arm1176/s3c64xx/init.c   |   26 ++++++++++++++++++++++++++
 2 files changed, 27 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm/cpu/arm1176/s3c64xx/init.c