Fix userspace compilation of ip_tables.h/ip6_tables.h in C++ mode
Subsystems (2)
PATCH 1/1 Fix userspace compilation of ip_tables.h/ip6_tables.h in C++ mode
The implicit cast from void * is not allowed for C++ compilers, and the arithmetic on void * generates warnings in C++ mode.
$ g++ -c t.cc ip_tables.h:221:24: warning: pointer of type 'void *' used in arithmetic ip_tables.h:221:24: error: invalid conversion from 'void*' to 'xt_entry_target*'
Signed-off-by Jason Gunthorpe <[email protected]>
--- include/linux/netfilter_ipv4/ip_tables.h | 2 +- include/linux/netfilter_ipv6/ip6_tables.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
include/linux/netfilter_ipv4/ip_tables.h +1 -1
@@ -226,7 +226,7 @@ struct ipt_get_entries {static __inline__struct xt_entry_target *ipt_get_target (struct ipt_entry *e) { -return (void *)e + e->target_offset; +return (struct xt_entry_target *)((__u8 *)e + e->target_offset); }/*
include/linux/netfilter_ipv6/ip6_tables.h +1 -1
@@ -263,7 +263,7 @@ struct ip6t_get_entries {static __inline__struct xt_entry_target *ip6t_get_target (struct ip6t_entry *e) { -return (void *)e + e->target_offset; +return (struct xt_entry_target *)((__u8 *)e + e->target_offset); }/*
Signature · 1 line
1.7.4.1
David Miller
maintainerFrom: Jason Gunthorpe <[email protected]>
Date: Sun, 30 Sep 2012 17:17:37 -0600
Quoted 8 lines
The implicit cast from void * is not allowed for C++ compilers, and the arithmetic on void * generates warnings in C++ mode.
$ g++ -c t.cc ip_tables.h:221:24: warning: pointer of type 'void *' used in arithmetic ip_tables.h:221:24: error: invalid conversion from 'void*' to 'xt_entry_target*'Signed-off-by Jason Gunthorpe <[email protected]>
Please post netfilter patches to [email protected]
Thank you.