max17042: missing assignment

PATCH Superseded Alan Cox 1 participant 1 message Oct 1, 2012

lore

Share & tools

lore

Alan Cox

author

2012-10-01 15:50 UTC #0 lore raw

PATCH 1/1 max17042: missing assignment

From: Alan Cox <[email protected]>

The second error check is unreachable because the lock function isn't assigned to ret

Signed-off-by Alan Cox <[email protected]>

---

 drivers/power/max17042_battery.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/power/max17042_battery.c +1 -1

index 74abc6c..73b432d 100644
@@ -572,7 +572,7 @@ static int max17042_init_chip(struct max17042_chip *chip)
 			__func__);
 		return -EIO;
 	}
-	max17042_verify_model_lock(chip);
+	ret = max17042_verify_model_lock(chip);
 	if (ret) {
 		dev_err(&chip->client->dev, "%s lock verify failed\n",
 			__func__);