Skip to contentSkip to conversation

nfsd: stricter endianness in reply cache hash

PATCH New J. Bruce Fields 1 participant 1 message Oct 1, 2012

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nfsd: stricter endianness in reply cache hash

Just a dumb patch to make u32/__be32 use more consistent, queuing for 3.7.--b.

commit 46056c57875540e945b9fc84042f2e4d7777b2d3

Author: J. Bruce Fields <[email protected]>
Date:   Fri Jul 27 11:57:00 2012 -0400

nfsd: stricter endianness in reply cache hash

Admittedly this is just to shut up sparse; the byte-swapping has no effect on the result.

fs/nfsd/nfscache.c +3 -3
index 2cbac34..6e5b8a8 100644
@@ -29,10 +29,10 @@ static int			cache_disabled = 1;
 /*
  * Calculate the hash index from an XID.
  */
-static inline u32 request_hash(u32 xid)
+static inline u32 request_hash(__be32 xid)
 {
-	u32 h = xid;
-	h ^= (xid >> 24);
+	u32 h = ntohl(xid);
+	h ^= (h >> 24);
 	return h & (HASHSIZE-1);
 }