Skip to contentSkip to conversation

u-boot/master slight regression with trats

U-Boot New Albert ARIBAUD 6 participants 16 messages Sep 29, 2012 – Oct 4, 2012

lore
Share & tools
lore

Albert ARIBAUD

author
#0 lore raw

Hello,

While merging u-boot-arm/master and u-boot/master I have noticed one slight regression apparently coming from u-boot:

$ cat LOG/trats.ERR 
cmd_fat.c: In function ?do_fat_fswrite?:
cmd_fat.c:178:8: warning: unused variable ?ep? [-Wunused-variable]

ep should have disappeared along with the code which used it, but somehow resurfaced (I suspect it did in a merge).

This warning is not seen in u-boot-arm.

Amicalement,

Signature · 1 line
Albert.
#1 lore raw

PATCH 1/1 cmd_fat.c: fix build warning

Commit cfda5aeab89d73779e26f0d34cf10f64caa67431 (cmd_fat: use common get_device_and_partition function) introduced a warning:
cmd_fat.c: In function 'do_fat_fswrite':
cmd_fat.c:178:8: warning: unused variable 'ep' [-Wunused-variable]

Fix it.

Signed-off-by Anatolij Gustschin <[email protected]>
---
 common/cmd_fat.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
common/cmd_fat.c +0 -1
index 55585c6..5a5698b 100644
@@ -175,7 +175,6 @@ static int do_fat_fswrite(cmd_tbl_t *cmdtp, int flag,
 	disk_partition_t info;
 	int dev = 0;
 	int part = 1;
-	char *ep;
 
 	if (argc < 5)
 		return cmd_usage(cmdtp);
Signature · 1 line
1.7.1
#2 lore raw

PATCH 1/1 cmd_fat.c: fix build warning

Quoted 6 lines · On Sat, 29 Sep 2012 12:52:55 +0200 Anatolij Gustschin <[email protected]> wrote:

Commit cfda5aeab89d73779e26f0d34cf10f64caa67431 (cmd_fat: use common get_device_and_partition function) introduced a warning:
cmd_fat.c: In function 'do_fat_fswrite':
cmd_fat.c:178:8: warning: unused variable 'ep' [-Wunused-variable]

Quoted 6 lines

Fix it.

Signed-off-by Anatolij Gustschin <[email protected]>
---
 common/cmd_fat.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
Reported-by Albert ARIBAUD <[email protected]>

I forgot to add attribution tag, so resending. patchwork hopefully will add it when picking the patch.

Thanks,
Anatolij

author
#3 lore raw

PATCH 1/1 cmd_fat.c: fix build warning

Hi Anatolij,

Quoted 16 lines · Anatolij Gustschin
Quoted 6 lines · On Sat, 29 Sep 2012 12:52:55 +0200 Anatolij Gustschin <[email protected]> wrote:

Commit cfda5aeab89d73779e26f0d34cf10f64caa67431 (cmd_fat: use common get_device_and_partition function) introduced a warning:
cmd_fat.c: In function 'do_fat_fswrite':
cmd_fat.c:178:8: warning: unused variable 'ep' [-Wunused-variable]

Quoted 6 lines

Fix it.

Signed-off-by Anatolij Gustschin <[email protected]>
---
 common/cmd_fat.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
Quoted 4 lines
Reported-by Albert ARIBAUD <[email protected]>

I forgot to add attribution tag, so resending. patchwork hopefully will add it when picking the patch.

For the record, it fixes the build issue. As the fix is trivial,

Tested-by Albert ARIBAUD <[email protected]>
Quoted 2 lines

Thanks,
Anatolij

Amicalement,

Signature · 1 line
Albert.
#4 lore raw

PATCH 1/1 cmd_fat.c: fix build warning

In reply to Anatolij Gustschin
Quoted 9 lines · Anatolij Gustschin

Commit cfda5aeab89d73779e26f0d34cf10f64caa67431 (cmd_fat: use common get_device_and_partition function) introduced a warning:
cmd_fat.c: In function 'do_fat_fswrite':
cmd_fat.c:178:8: warning: unused variable 'ep' [-Wunused-variable]

Fix it.

Signed-off-by Anatolij Gustschin <[email protected]>

Applied to u-boot/master, thanks (and patchwork picked up the tags)!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120929/7687c9fc/attachment.pgp>
author
#5 lore raw
In reply to Albert ARIBAUD

Hi all,

Quoted 9 lines · Albert ARIBAUD

Hello,

While merging u-boot-arm/master and u-boot/master I have noticed one slight regression apparently coming from u-boot:

$ cat LOG/trats.ERR 
cmd_fat.c: In function ?do_fat_fswrite?:
cmd_fat.c:178:8: warning: unused variable ?ep? [-Wunused-variable]
Quoted 6 lines

ep should have disappeared along with the code which used it, but somehow resurfaced (I suspect it did in a merge).

This warning is not seen in u-boot-arm.

Amicalement,

Seems Heungjun Kim <[email protected]> is now a dead address.

Anatolij, I see you've sent out a patch. Does it mean you would act as a maintainer for trats? Otherwise the board should be made orphan.

BTW, I'm not sure who should take your patch as a custodian, but my take is, as the issue is now in u-boot/master, its fix could be applied directly to u-boot/master. Tom?

Amicalement,

Signature · 1 line
Albert.
#6 lore raw

Hi all,

Quoted 17 lines · On Sat, 29 Sep 2012 17:17:48 +0200 Albert ARIBAUD <[email protected]>…

Hi all,

Quoted 12 lines · Albert ARIBAUD

Hello,

While merging u-boot-arm/master and u-boot/master I have noticed one slight regression apparently coming from u-boot:

$ cat LOG/trats.ERR 
cmd_fat.c: In function ?do_fat_fswrite?:
cmd_fat.c:178:8: warning: unused variable ?ep? [-Wunused-variable]

ep should have disappeared along with the code which used it, but somehow resurfaced (I suspect it did in a merge).

Quoted 8 lines
Quoted 3 lines

This warning is not seen in u-boot-arm.

Amicalement,

Seems Heungjun Kim <[email protected]> is now a dead address.

Anatolij, I see you've sent out a patch. Does it mean you would act as a maintainer for trats? Otherwise the board should be made orphan.

I do not have a trats board, so I can't do tests and act as a maintainer for it. Lukasz (on Cc) recently submitted some patches for trats, maybe he knows who could become new maintainer for trats board?

Thanks,
Anatolij

#7 lore raw

Hi all,

Quoted 23 lines
Quoted 19 lines · On Sat, 29 Sep 2012 17:17:48 +0200 Albert ARIBAUD <[email protected]>…

Hi all,

Quoted 14 lines · Albert ARIBAUD

Hello,

While merging u-boot-arm/master and u-boot/master I have noticed one slight regression apparently coming from u-boot:

$ cat LOG/trats.ERR 
cmd_fat.c: In function ?do_fat_fswrite?:
cmd_fat.c:178:8: warning: unused variable ?ep? [-Wunused-variable]

ep should have disappeared along with the code which used it, but somehow resurfaced (I suspect it did in a merge).

This warning is not seen in u-boot-arm.

Quoted 7 lines
Quoted 7 lines
Quoted 1 line

Amicalement,

Seems Heungjun Kim <[email protected]> is now a dead address.

Anatolij, I see you've sent out a patch. Does it mean you would act as a maintainer for trats?
Otherwise the board should be made orphan.

Dear all, I was on a holidays :-).

I can test if Trats is working. I posses one, so there is no problem with that :-).

I will fix Trats ASAP.

Quoted 5 lines

I do not have a trats board, so I can't do tests and act as a maintainer for it. Lukasz (on Cc) recently submitted some patches for trats, maybe he knows who could become new maintainer for trats board?

Signature · 5 lines
Best regards,

Lukasz Majewski

Samsung Poland R&D Center | Linux Platform Group
#8 lore raw

Hi Lukasz,

On Mon, 01 Oct 2012 11:21:59 +0200
Lukasz Majewski <[email protected]> wrote:
...

Quoted 6 lines
Quoted 5 lines
Quoted 5 lines

Seems Heungjun Kim <[email protected]> is now a dead address.

Anatolij, I see you've sent out a patch. Does it mean you would act as a maintainer for trats?
Otherwise the board should be made orphan.

Quoted 6 lines

Dear all, I was on a holidays :-).

I can test if Trats is working. I posses one, so there is no problem with that :-).

I will fix Trats ASAP.

Please note that Tom applied a warning fix into
git://git.denx.de/u-boot.git master

Thanks,
Anatolij

#9 lore raw
In reply to Lukasz Majewski

Hi all,

Quoted 34 lines
Quoted 25 lines
Quoted 20 lines · On Sat, 29 Sep 2012 17:17:48 +0200 Albert ARIBAUD <[email protected]>…

Hi all,

Quoted 15 lines · Albert ARIBAUD

Hello,

While merging u-boot-arm/master and u-boot/master I have noticed one slight regression apparently coming from u-boot:

$ cat LOG/trats.ERR 
cmd_fat.c: In function ?do_fat_fswrite?:
cmd_fat.c:178:8: warning: unused variable
?ep? [-Wunused-variable]

ep should have disappeared along with the code which used it, but somehow resurfaced (I suspect it did in a merge).

This warning is not seen in u-boot-arm.

Quoted 8 lines
Quoted 8 lines
Quoted 1 line

Amicalement,

Seems Heungjun Kim <[email protected]> is now a dead address.

Anatolij, I see you've sent out a patch. Does it mean you would act as a maintainer for trats?
Otherwise the board should be made orphan.

Quoted 6 lines

Dear all, I was on a holidays :-).

I can test if Trats is working. I posses one, so there is no problem with that :-).

I will fix Trats ASAP.

I've just tested TRATS with the newest origin/master (SHA1: 4668a086bb0a769b741e3a4ffab85f1c41c7cdb8 )

It builds without errors/warinigs

Quoted 7 lines
Quoted 7 lines

I do not have a trats board, so I can't do tests and act as a maintainer for it. Lukasz (on Cc) recently submitted some patches for trats, maybe he knows who could become new maintainer for trats board?

Signature · 5 lines
Best regards,

Lukasz Majewski

Samsung Poland R&D Center | Linux Platform Group
#10 lore raw
Quoted 41 lines · Lukasz Majewski

Hi all,

Quoted 39 lines
Quoted 25 lines
Quoted 20 lines · On Sat, 29 Sep 2012 17:17:48 +0200 Albert ARIBAUD <[email protected]>…

Hi all,

Quoted 15 lines · Albert ARIBAUD

Hello,

While merging u-boot-arm/master and u-boot/master I have noticed one slight regression apparently coming from u-boot:

$ cat LOG/trats.ERR 
cmd_fat.c: In function ???do_fat_fswrite???:
cmd_fat.c:178:8: warning: unused variable
???ep??? [-Wunused-variable]

ep should have disappeared along with the code which used it, but somehow resurfaced (I suspect it did in a merge).

This warning is not seen in u-boot-arm.

Quoted 8 lines
Quoted 8 lines
Quoted 1 line

Amicalement,

Seems Heungjun Kim <[email protected]> is now a dead address.

Anatolij, I see you've sent out a patch. Does it mean you would act as a maintainer for trats?
Otherwise the board should be made orphan.

Dear all, I was on a holidays :-).

I can test if Trats is working. I posses one, so there is no problem with that :-).

Quoted 13 lines
Quoted 1 line

I will fix Trats ASAP.

I've just tested TRATS with the newest origin/master (SHA1: 4668a086bb0a769b741e3a4ffab85f1c41c7cdb8 )

It builds without errors/warinigs

Quoted 6 lines
Quoted 6 lines

I do not have a trats board, so I can't do tests and act as a maintainer for it. Lukasz (on Cc) recently submitted some patches for trats, maybe he knows who could become new maintainer for trats board?

Ah, but would you be willing to take the MAINTAINER spot for the board? Thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20121001/763b7176/attachment.pgp>
#11 lore raw

Hi Tom,

Quoted 51 lines · Lukasz Majewski
Quoted 50 lines

Hi all,

Quoted 34 lines
Quoted 25 lines
Quoted 20 lines · On Sat, 29 Sep 2012 17:17:48 +0200 Albert ARIBAUD <[email protected]>…

Hi all,

Quoted 15 lines · Albert ARIBAUD

Hello,

While merging u-boot-arm/master and u-boot/master I have noticed one slight regression apparently coming from u-boot:

$ cat LOG/trats.ERR 
cmd_fat.c: In function ???do_fat_fswrite???:
cmd_fat.c:178:8: warning: unused variable
???ep??? [-Wunused-variable]

ep should have disappeared along with the code which used it, but somehow resurfaced (I suspect it did in a merge).

This warning is not seen in u-boot-arm.

Quoted 8 lines
Quoted 8 lines
Quoted 1 line

Amicalement,

Seems Heungjun Kim <[email protected]> is now a dead address.

Anatolij, I see you've sent out a patch. Does it mean you would act as a maintainer for trats?
Otherwise the board should be made orphan.

Quoted 6 lines

Dear all, I was on a holidays :-).

I can test if Trats is working. I posses one, so there is no problem with that :-).

I will fix Trats ASAP.

I've just tested TRATS with the newest origin/master (SHA1: 4668a086bb0a769b741e3a4ffab85f1c41c7cdb8 )

It builds without errors/warinigs

Quoted 2 lines
Quoted 2 lines
Quoted 8 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

I do not have a trats board, so I can't do tests and act as a maintainer for it. Lukasz (on Cc) recently submitted some patches for trats, maybe he knows who could become new maintainer for trats board?

Ah, but would you be willing to take the MAINTAINER spot for the board? Thanks!

I can serve as a maintainer for the board - I posses one and I actively develop and test code for it. No problem with that.

Signature · 5 lines
Best regards,

Lukasz Majewski

Samsung Poland R&D Center | Linux Platform Group
Acked-by
#12 lore raw
Quoted 58 lines · Lukasz Majewski

Hi Tom,

Quoted 56 lines · Lukasz Majewski
Quoted 54 lines

Hi all,

Quoted 34 lines
Quoted 25 lines
Quoted 20 lines · On Sat, 29 Sep 2012 17:17:48 +0200 Albert ARIBAUD <[email protected]>…

Hi all,

Quoted 15 lines · Albert ARIBAUD

Hello,

While merging u-boot-arm/master and u-boot/master I have noticed one slight regression apparently coming from u-boot:

$ cat LOG/trats.ERR
cmd_fat.c: In function ???do_fat_fswrite???:
cmd_fat.c:178:8: warning: unused variable
???ep??? [-Wunused-variable]

ep should have disappeared along with the code which used it, but somehow resurfaced (I suspect it did in a merge).

This warning is not seen in u-boot-arm.

Quoted 8 lines
Quoted 8 lines
Quoted 1 line

Amicalement,

Seems Heungjun Kim <[email protected]> is now a dead address.

Anatolij, I see you've sent out a patch. Does it mean you would act as a maintainer for trats?
Otherwise the board should be made orphan.

Quoted 6 lines

Dear all, I was on a holidays :-).

I can test if Trats is working. I posses one, so there is no problem with that :-).

I will fix Trats ASAP.

I've just tested TRATS with the newest origin/master (SHA1: 4668a086bb0a769b741e3a4ffab85f1c41c7cdb8 )

It builds without errors/warinigs

Quoted 6 lines
Quoted 6 lines

I do not have a trats board, so I can't do tests and act as a maintainer for it. Lukasz (on Cc) recently submitted some patches for trats, maybe he knows who could become new maintainer for trats board?

Quoted 6 lines
Quoted 3 lines

Ah, but would you be willing to take the MAINTAINER spot for the board? Thanks!

I can serve as a maintainer for the board - I posses one and I actively develop and test code for it. No problem with that.

Acked-by Kyungmin Park <[email protected]>

Note that Mr. Kim left the company and Lukasz can take over trats board support.

Thank you,
Kyungmin Park

Quoted 12 lines

--
Best regards,

Lukasz Majewski

Samsung Poland R&D Center | Linux Platform Group
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

#13 lore raw

PATCH 1/1 MAINTAINERS: New maintainer for Samsung's Trats development board.

Signed-off-by Lukasz Majewski <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>
---
 MAINTAINERS |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
MAINTAINERS +1 -1
index aa54fe1..eb96035 100644
@@ -727,7 +727,7 @@ Chander Kashyap <[email protected]>
 	SMDKV310		ARM ARMV7 (EXYNOS4210 SoC)
 	SMDK5250		ARM ARMV7 (EXYNOS5250 SoC)
 
-Heungjun Kim <[email protected]>
+Lukasz Majewski <[email protected]>
 
 	trats			ARM ARMV7 (EXYNOS4210 SoC)
Signature · 1 line
1.7.2.3
#14 lore raw

[U-Boot] MAINTAINERS: New maintainer for Samsung's Trats development board.

Quoted 6 lines · Lukasz Majewski
Signed-off-by Lukasz Majewski <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>

---
MAINTAINERS | 2 +-

 1 files changed, 1 insertions(+), 1 deletions(-)

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20121002/8d5d3cd2/attachment.pgp>
#15 lore raw

[U-Boot] MAINTAINERS: New maintainer for Samsung's Trats development board.

Dear Tom and Lukasz,

Quoted 11 lines · Tom Rini
Quoted 6 lines · Lukasz Majewski
Signed-off-by Lukasz Majewski <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>

---
MAINTAINERS | 2 +-

 1 files changed, 1 insertions(+), 1 deletions(-)

Applied to u-boot/master, thanks!

We need to keep this list to Alphabetical.
So, Lukasz's name should be moved to "M" section.

Thanks.
Minkyu Kang.

Signature · 2 lines
from. prom.
www.promsoft.net