ARM: OMAP: remove clock files in arch/arm/plat-omap
Subsystems (10)
Paul Walmsley
maintainercover ARM: OMAP: remove clock files in arch/arm/plat-omap
Remove clock-related header and C files from arch/arm/plat-omap. The intention is to support people working on the ARM single kernel image project, since the 'plat' symlink will no longer be available for OMAP-shared files.
Intended for 3.8 cleanup.
---
plat_clock_removal_cleanup_3.8
text data bss dec hex filename
5392024 346692 121276 5859992 596a98 vmlinux.omap1_defconfig
7342851 694332 5613708 13650891 d04bcb vmlinux.omap2plus_defconfig.orig
7342623 694292 5613708 13650623 d04abf vmlinux.omap2plus_defconfig
Paul Walmsley (6):
OMAPDSS: remove unnecessary plat/clock.h includes
staging: tidspbridge: remove unnecessary include of <plat/clock.h>
cpufreq: OMAP: remove unnecessary include of plat/clock.h
ARM: OMAP: duplicate plat-omap/clock.c into mach-omap[12]/clock.c
ARM: OMAP: remove plat/clock.h
ARM: OMAP: clock: split plat/clkdev_omap.h into OMAP1/2 files
arch/arm/mach-omap1/board-nokia770.c | 2 arch/arm/mach-omap1/clock.c | 502 ++++++++++++++++++ arch/arm/mach-omap1/clock.h | 178 +++++++ arch/arm/mach-omap1/clock_data.c | 13 arch/arm/mach-omap1/opp_data.c | 2 arch/arm/mach-omap1/pm.c | 2 arch/arm/mach-omap2/clkt2xxx_apll.c | 2 arch/arm/mach-omap2/clkt2xxx_dpll.c | 2 arch/arm/mach-omap2/clkt2xxx_dpllcore.c | 2 arch/arm/mach-omap2/clkt2xxx_osc.c | 2 arch/arm/mach-omap2/clkt2xxx_sys.c | 2 arch/arm/mach-omap2/clkt2xxx_virt_prcm_set.c | 2 arch/arm/mach-omap2/clkt34xx_dpll3m2.c | 2 arch/arm/mach-omap2/clkt_clksel.c | 2 arch/arm/mach-omap2/clkt_dpll.c | 2 arch/arm/mach-omap2/clkt_iclk.c | 2 arch/arm/mach-omap2/clock.c | 519 +++++++++++++++++++ arch/arm/mach-omap2/clock.h | 317 ++++++++++++ arch/arm/mach-omap2/clock2420_data.c | 4 arch/arm/mach-omap2/clock2430.c | 2 arch/arm/mach-omap2/clock2430_data.c | 4 arch/arm/mach-omap2/clock2xxx.c | 2 arch/arm/mach-omap2/clock33xx_data.c | 3 arch/arm/mach-omap2/clock34xx.c | 2 arch/arm/mach-omap2/clock3517.c | 2 arch/arm/mach-omap2/clock36xx.c | 2 arch/arm/mach-omap2/clock3xxx.c | 2 arch/arm/mach-omap2/clock3xxx_data.c | 4 arch/arm/mach-omap2/clock44xx_data.c | 4 arch/arm/mach-omap2/clockdomain.c | 2 arch/arm/mach-omap2/clockdomain.h | 2 arch/arm/mach-omap2/common.c | 2 arch/arm/mach-omap2/dpll3xxx.c | 2 arch/arm/mach-omap2/dpll44xx.c | 2 arch/arm/mach-omap2/omap_hwmod.c | 2 arch/arm/mach-omap2/pm-debug.c | 2 arch/arm/mach-omap2/pm24xx.c | 2 arch/arm/mach-omap2/sdram-nokia.c | 2 arch/arm/mach-omap2/sdrc.c | 2 arch/arm/mach-omap2/sdrc2xxx.c | 2 arch/arm/plat-omap/Makefile | 2 arch/arm/plat-omap/clock.c | 544 -------------------- arch/arm/plat-omap/counter_32k.c | 1 arch/arm/plat-omap/include/plat/clock.h | 309 ----------- arch/arm/plat-omap/omap_device.c | 1 drivers/cpufreq/omap-cpufreq.c | 1 .../tidspbridge/include/dspbridge/host_os.h | 1 drivers/video/omap2/dss/dispc.c | 1 drivers/video/omap2/dss/dsi.c | 1 drivers/video/omap2/dss/dss.c | 1 50 files changed, 1536 insertions(+), 934 deletions(-) delete mode 100644 arch/arm/plat-omap/clock.c delete mode 100644 arch/arm/plat-omap/include/plat/clock.h
Paul Walmsley
maintainerPATCH 1/6 OMAPDSS: remove unnecessary plat/clock.h includes
The OMAP DSS video drivers include <plat/clock.h> but don't use any information from that file. These includes are causing problems with ARM single image kernels - remove them.
--- drivers/video/omap2/dss/dispc.c | 1 - drivers/video/omap2/dss/dsi.c | 1 - drivers/video/omap2/dss/dss.c | 1 - 3 files changed, 3 deletions(-)
drivers/video/omap2/dss/dispc.c +0 -1
@@ -38,7 +38,6 @@#include <linux/pm_runtime.h> #include <plat/cpu.h> -#include <plat/clock.h> #include <video/omapdss.h>
drivers/video/omap2/dss/dsi.c +0 -1
@@ -41,7 +41,6 @@#include <video/omapdss.h> #include <video/mipi_display.h> -#include <plat/clock.h> #include "dss.h" #include "dss_features.h"
drivers/video/omap2/dss/dss.c +0 -1
@@ -35,7 +35,6 @@#include <video/omapdss.h> #include <plat/cpu.h> -#include <plat/clock.h> #include "dss.h" #include "dss_features.h"
PATCH 1/6 OMAPDSS: remove unnecessary plat/clock.h includes
Quoted 11 lines · Paul Walmsley
The OMAP DSS video drivers include <
plat/clock.h> but don't use any information from that file. These includes are causing problems with ARM single image kernels - remove them.Signed-off-by Paul Walmsley <[email protected]>Cc Tomi Valkeinen <[email protected]>--- drivers/video/omap2/dss/dispc.c | 1 - drivers/video/omap2/dss/dsi.c | 1 - drivers/video/omap2/dss/dss.c | 1 - 3 files changed, 3 deletions(-)
Hi Paul. I already have the below patch in omapdss branch, and it's also in linux-next.
Tomi
commit fe6a466283cf1ced93360bd5f5055d6543021a6a
Author: Tomi Valkeinen <[email protected]> Date: Thu Aug 30 10:52:47 2012 +0300
OMAPDSS: remove unnecessary includes
Remove unnecessary includes from omapdss.
drivers/video/omap2/dss/dispc.c +0 -2
@@ -37,8 +37,6 @@#include <linux/platform_device.h> #include <linux/pm_runtime.h> -#include <plat/clock.h> -#include <video/omapdss.h> #include "dss.h"
drivers/video/omap2/dss/dpi.c +0 -1
@@ -31,7 +31,6 @@#include <linux/regulator/consumer.h> #include <video/omapdss.h> -#include <plat/cpu.h> #include "dss.h" #include "dss_features.h"
drivers/video/omap2/dss/dsi.c +0 -1
@@ -41,7 +41,6 @@#include <video/omapdss.h> #include <video/mipi_display.h> -#include <plat/clock.h> #include "dss.h" #include "dss_features.h"
drivers/video/omap2/dss/dss.c +0 -1
@@ -36,7 +36,6 @@#include <video/omapdss.h> #include <plat/cpu.h> -#include <plat/clock.h> #include "dss.h" #include "dss_features.h"
drivers/video/omap2/dss/overlay.c +0 -1
@@ -32,7 +32,6 @@#include <linux/slab.h> #include <video/omapdss.h> -#include <plat/cpu.h> #include "dss.h" #include "dss_features.h"
drivers/video/omap2/dss/venc.c +0 -1
@@ -36,7 +36,6 @@#include <linux/pm_runtime.h> #include <video/omapdss.h> -#include <plat/cpu.h> #include "dss.h" #include "dss_features.h"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120928/5c20fc3f/attachment-0001.sig>
Paul Walmsley
maintainerPATCH 1/6 OMAPDSS: remove unnecessary plat/clock.h includes
Hi Tomi,
Quoted 13 lines · Tomi Valkeinen
Quoted 11 lines · Paul Walmsley
The OMAP DSS video drivers include <
plat/clock.h> but don't use any information from that file. These includes are causing problems with ARM single image kernels - remove them.Signed-off-by Paul Walmsley <[email protected]>Cc Tomi Valkeinen <[email protected]>--- drivers/video/omap2/dss/dispc.c | 1 - drivers/video/omap2/dss/dsi.c | 1 - drivers/video/omap2/dss/dss.c | 1 - 3 files changed, 3 deletions(-)
Quoted 2 lines
Hi Paul. I already have the below patch in omapdss branch, and it's also in linux-next.
thanks, will drop this one.
- Paul
Paul Walmsley
maintainerPATCH 2/6 staging: tidspbridge: remove unnecessary include of <plat/clock.h>
In reply to Paul WalmsleyThe DSPBridge driver includes arch/arm/plat-omap/include/plat/clock.h. All of the <plat/ ...> includes are causing problems with the ARM single image kernel effort. Remove this one.
--- .../tidspbridge/include/dspbridge/host_os.h | 1 - 1 file changed, 1 deletion(-)
drivers/staging/tidspbridge/include/dspbridge/host_os.h +0 -1
@@ -40,7 +40,6 @@#include <linux/vmalloc.h> #include <linux/ioport.h> #include <linux/platform_device.h> -#include <plat/clock.h> #include <linux/clk.h> #include <plat/mailbox.h> #include <linux/pagemap.h>
Paul Walmsley
maintainerPATCH 3/6 cpufreq: OMAP: remove unnecessary include of plat/clock.h
In reply to Paul WalmsleyRemove an unnecessary include of arch/arm/plat-omap/include/plat/clock.h to facilitate the ARM single kernel image work.
--- drivers/cpufreq/omap-cpufreq.c | 1 - 1 file changed, 1 deletion(-)
drivers/cpufreq/omap-cpufreq.c +0 -1
@@ -30,7 +30,6 @@#include <asm/smp_plat.h> #include <asm/cpu.h> -#include <plat/clock.h> #include <plat/omap-pm.h> #include <plat/common.h> #include <plat/omap_device.h>
Paul Walmsley
maintainerPATCH 4/6 ARM: OMAP: duplicate plat-omap/clock.c into mach-omap[12]/clock.c
In reply to Paul WalmsleyDuplicate arch/arm/plat-omap/clock.c into arch/arm/mach-omap1/clock.c and arch/arm/mach-omap2/clock.c. This is to support people who are working on the ARM single image kernel and the OMAP common clock framework conversion.
--- arch/arm/mach-omap1/clock.c | 499 +++++++++++++++++++++++++++++++ arch/arm/mach-omap1/clock_data.c | 10 - arch/arm/mach-omap2/clock.c | 517 ++++++++++++++++++++++++++++++++ arch/arm/mach-omap2/clock2420_data.c | 2 arch/arm/mach-omap2/clock2430_data.c | 2 arch/arm/mach-omap2/clock33xx_data.c | 2 arch/arm/mach-omap2/clock3xxx_data.c | 2 arch/arm/mach-omap2/clock44xx_data.c | 2 arch/arm/plat-omap/Makefile | 2 arch/arm/plat-omap/clock.c | 544 ---------------------------------- 10 files changed, 1010 insertions(+), 572 deletions(-) delete mode 100644 arch/arm/plat-omap/clock.c
arch/arm/mach-omap1/clock.c +499 -0
@@ -12,6 +12,7 @@* published by the Free Software Foundation. */ #include <linux/kernel.h> +#include <linux/export.h> #include <linux/list.h> #include <linux/errno.h> #include <linux/err.h>
@@ -36,6 +37,10 @@__u32 arm_idlect1_mask;struct clk *api_ck_p, *ck_dpll1_p, *ck_ref_p; +static LIST_HEAD (clocks); +static DEFINE_MUTEX (clocks_mutex); +static DEFINE_SPINLOCK (clockfw_lock); +/* * Omap1 specific clock functions */
@@ -607,3 +612,497 @@ void omap1_clk_disable_unused(struct clk *clk) }#endif + + +int clk_enable (struct clk *clk) +{ +unsigned long flags; +int ret; + +if (clk ==NULL ||IS_ERR (clk)) +return -EINVAL ; + +spin_lock_irqsave (&clockfw_lock, flags); + ret =omap1_clk_enable (clk); +spin_unlock_irqrestore (&clockfw_lock, flags); + +return ret; +} +EXPORT_SYMBOL (clk_enable); + +void clk_disable (struct clk *clk) +{ +unsigned long flags; + +if (clk ==NULL ||IS_ERR (clk)) +return ; + +spin_lock_irqsave (&clockfw_lock, flags); +if (clk->usecount ==0 ) { +pr_err ("Trying disable clock %s with 0 usecount\n" , + clk->name); +WARN_ON (1 ); + goto out; + } + +omap1_clk_disable (clk); + +out: +spin_unlock_irqrestore (&clockfw_lock, flags); +} +EXPORT_SYMBOL (clk_disable); + +unsigned long clk_get_rate (struct clk *clk) +{ +unsigned long flags; +unsigned long ret; + +if (clk ==NULL ||IS_ERR (clk)) +return 0 ; + +spin_lock_irqsave (&clockfw_lock, flags); + ret = clk->rate; +spin_unlock_irqrestore (&clockfw_lock, flags); + +return ret; +} +EXPORT_SYMBOL (clk_get_rate); + +/* +* Optional clock functions defined in include/linux/clk.h +*/ + +long clk_round_rate (struct clk *clk,unsigned long rate) +{ +unsigned long flags; +long ret; + +if (clk ==NULL ||IS_ERR (clk)) +return 0 ; + +spin_lock_irqsave (&clockfw_lock, flags); + ret =omap1_clk_round_rate (clk, rate); +spin_unlock_irqrestore (&clockfw_lock, flags); + +return ret; +} +EXPORT_SYMBOL (clk_round_rate); + +int clk_set_rate (struct clk *clk,unsigned long rate) +{ +unsigned long flags; +int ret = -EINVAL ; + +if (clk ==NULL ||IS_ERR (clk)) +return ret; + +spin_lock_irqsave (&clockfw_lock, flags); + ret =omap1_clk_set_rate (clk, rate); +if (ret ==0 ) +propagate_rate (clk); +spin_unlock_irqrestore (&clockfw_lock, flags); + +return ret; +} +EXPORT_SYMBOL (clk_set_rate); + +int clk_set_parent (struct clk *clk,struct clk *parent) +{ +WARN_ONCE (1 ,"clk_set_parent() not implemented for OMAP1\n" ); + +return -EINVAL ; +} +EXPORT_SYMBOL (clk_set_parent); + +struct clk *clk_get_parent (struct clk *clk) +{ +return clk->parent; +} +EXPORT_SYMBOL (clk_get_parent); + +/* +* OMAP specific clock functions shared between omap1 and omap2 +*/ + +int __initdata mpurate; + +/* +* By default we use the rate set by the bootloader. +* You can override this with mpurate= cmdline option. +*/ +static int __init omap_clk_setup (char *str) +{ +get_option (&str, &mpurate); + +if (!mpurate) +return 1 ; + +if (mpurate <1000 ) + mpurate *=1000000 ; + +return 1 ; +} +__setup ("mpurate=" , omap_clk_setup); + +/* Used for clocks that always have same value as the parent clock */ +unsigned long followparent_recalc (struct clk *clk) +{ +return clk->parent->rate; +} + +/* +* Used for clocks that have the same value as the parent clock, +* divided by some factor +*/ +unsigned long omap_fixed_divisor_recalc (struct clk *clk) +{ +WARN_ON (!clk->fixed_div); + +return clk->parent->rate / clk->fixed_div; +} + +void clk_reparent (struct clk *child,struct clk *parent) +{ +list_del_init (&child->sibling); +if (parent) +list_add (&child->sibling, &parent->children); + child->parent = parent; + +/* now do the debugfs renaming to reattach the child +to the proper parent */ +} + +/* Propagate rate to children */ +void propagate_rate (struct clk *tclk) +{ +struct clk *clkp; + +list_for_each_entry (clkp, &tclk->children, sibling) { +if (clkp->recalc) + clkp->rate = clkp->recalc (clkp); +propagate_rate (clkp); + } +} + +static LIST_HEAD (root_clks); + +/** +* recalculate_root_clocks - recalculate and propagate all root clocks +* +* Recalculates all root clocks (clocks with no parent), which if the +* clock's .recalc is set correctly, should also propagate their rates. +* Called at init. +*/ +void recalculate_root_clocks (void ) +{ +struct clk *clkp; + +list_for_each_entry (clkp, &root_clks, sibling) { +if (clkp->recalc) + clkp->rate = clkp->recalc (clkp); +propagate_rate (clkp); + } +} + +/** +* clk_preinit - initialize any fields in the struct clk before clk init +* @clk: struct clk * to initialize +* +* Initialize any struct clk fields needed before normal clk initialization +* can run. No return value. +*/ +void clk_preinit (struct clk *clk) +{ +INIT_LIST_HEAD (&clk->children); +} + +int clk_register (struct clk *clk) +{ +if (clk ==NULL ||IS_ERR (clk)) +return -EINVAL ; + +/* +* trap out already registered clocks +*/ +if (clk->node.next || clk->node.prev) +return 0 ; + +mutex_lock (&clocks_mutex); +if (clk->parent) +list_add (&clk->sibling, &clk->parent->children); +else +list_add (&clk->sibling, &root_clks); + +list_add (&clk->node, &clocks); +if (clk->init) + clk->init (clk); +mutex_unlock (&clocks_mutex); + +return 0 ; +} +EXPORT_SYMBOL (clk_register); + +void clk_unregister (struct clk *clk) +{ +if (clk ==NULL ||IS_ERR (clk)) +return ; + +mutex_lock (&clocks_mutex); +list_del (&clk->sibling); +list_del (&clk->node); +mutex_unlock (&clocks_mutex); +} +EXPORT_SYMBOL (clk_unregister); + +void clk_enable_init_clocks (void ) +{ +struct clk *clkp; + +list_for_each_entry (clkp, &clocks, node) +if (clkp->flags &ENABLE_ON_INIT ) +clk_enable (clkp); +} + +/** +* omap_clk_get_by_name - locate OMAP struct clk by its name +* @name: name of the struct clk to locate +* +* Locate an OMAP struct clk by its name. Assumes that struct clk +* names are unique. Returns NULL if not found or a pointer to the +* struct clk if found. +*/ +struct clk *omap_clk_get_by_name (const char *name) +{ +struct clk *c; +struct clk *ret =NULL ; + +mutex_lock (&clocks_mutex); + +list_for_each_entry (c, &clocks, node) { +if (!strcmp (c->name, name)) { + ret = c; +break ; + } + } + +mutex_unlock (&clocks_mutex); + +return ret; +} + +int omap_clk_enable_autoidle_all (void ) +{ +struct clk *c; +unsigned long flags; + +spin_lock_irqsave (&clockfw_lock, flags); + +list_for_each_entry (c, &clocks, node) +if (c->ops->allow_idle) + c->ops->allow_idle (c); + +spin_unlock_irqrestore (&clockfw_lock, flags); + +return 0 ; +} + +int omap_clk_disable_autoidle_all (void ) +{ +struct clk *c; +unsigned long flags; + +spin_lock_irqsave (&clockfw_lock, flags); + +list_for_each_entry (c, &clocks, node) +if (c->ops->deny_idle) + c->ops->deny_idle (c); + +spin_unlock_irqrestore (&clockfw_lock, flags); + +return 0 ; +} + +/* +* Low level helpers +*/ +static int clkll_enable_null (struct clk *clk) +{ +return 0 ; +} + +static void clkll_disable_null (struct clk *clk) +{ +} + +const struct clkops clkops_null = { + .enable = clkll_enable_null, + .disable = clkll_disable_null, +}; + +/* +* Dummy clock +* +* Used for clock aliases that are needed on some OMAPs, but not others +*/ +struct clk dummy_ck = { + .name ="dummy" , + .ops = &clkops_null, +}; + +/* +* +*/ + +#ifdef CONFIG_OMAP_RESET_CLOCKS +/* +* Disable any unused clocks left on by the bootloader +*/ +static int __init clk_disable_unused (void ) +{ +struct clk *ck; +unsigned long flags; + +pr_info ("clock: disabling unused clocks to save power\n" ); + +spin_lock_irqsave (&clockfw_lock, flags); +list_for_each_entry (ck, &clocks, node) { +if (ck->ops == &clkops_null) +continue ; + +if (ck->usecount >0 || !ck->enable_reg) +continue ; + +omap1_clk_disable_unused (ck); + } +spin_unlock_irqrestore (&clockfw_lock, flags); + +return 0 ; +} +late_initcall (clk_disable_unused); +late_initcall (omap_clk_enable_autoidle_all); +#endif + +#if defined(CONFIG_PM_DEBUG ) && defined(CONFIG_DEBUG_FS ) +/* +* debugfs support to trace clock tree hierarchy and attributes +*/ + +#include <linux/debugfs.h> +#include <linux/seq_file.h> + +static struct dentry *clk_debugfs_root; + +static int clk_dbg_show_summary (struct seq_file *s,void *unused) +{ +struct clk *c; +struct clk *pa; + +mutex_lock (&clocks_mutex); +seq_printf (s,"%-30s %-30s %-10s %s\n" , +"clock-name" ,"parent-name" ,"rate" ,"use-count" ); + +list_for_each_entry (c, &clocks, node) { + pa = c->parent; +seq_printf (s,"%-30s %-30s %-10lu %d\n" , + c->name, pa ? pa->name :"none" , c->rate, + c->usecount); + } +mutex_unlock (&clocks_mutex); + +return 0 ; +} + +static int clk_dbg_open (struct inode *inode,struct file *file) +{ +return single_open (file, clk_dbg_show_summary, inode->i_private); +} + +static const struct file_operations debug_clock_fops = { + .open = clk_dbg_open, + .read = seq_read, + .llseek = seq_lseek, + .release = single_release, +}; + +static int clk_debugfs_register_one (struct clk *c) +{ +int err; +struct dentry *d; +struct clk *pa = c->parent; + + d =debugfs_create_dir (c->name, pa ? pa->dent : clk_debugfs_root); +if (!d) +return -ENOMEM ; + c->dent = d; + + d =debugfs_create_u8 ("usecount" ,S_IRUGO , c->dent, (u8 *)&c->usecount); +if (!d) { + err = -ENOMEM ; + goto err_out; + } + d =debugfs_create_u32 ("rate" ,S_IRUGO , c->dent, (u32 *)&c->rate); +if (!d) { + err = -ENOMEM ; + goto err_out; + } + d =debugfs_create_x32 ("flags" ,S_IRUGO , c->dent, (u32 *)&c->flags); +if (!d) { + err = -ENOMEM ; + goto err_out; + } +return 0 ; + +err_out: +debugfs_remove_recursive (c->dent); +return err; +} + +static int clk_debugfs_register (struct clk *c) +{ +int err; +struct clk *pa = c->parent; + +if (pa && !pa->dent) { + err =clk_debugfs_register (pa); +if (err) +return err; + } + +if (!c->dent) { + err =clk_debugfs_register_one (c); +if (err) +return err; + } +return 0 ; +} + +static int __init clk_debugfs_init (void ) +{ +struct clk *c; +struct dentry *d; +int err; + + d =debugfs_create_dir ("clock" ,NULL ); +if (!d) +return -ENOMEM ; + clk_debugfs_root = d; + +list_for_each_entry (c, &clocks, node) { + err =clk_debugfs_register (c); +if (err) + goto err_out; + } + + d =debugfs_create_file ("summary" ,S_IRUGO , + d,NULL , &debug_clock_fops); +if (!d) +return -ENOMEM ; + +return 0 ; +err_out: +debugfs_remove_recursive (clk_debugfs_root); +return err; +} +late_initcall (clk_debugfs_init); + +#endif /* defined(CONFIG_PM_DEBUG) && defined(CONFIG_DEBUG_FS) */
arch/arm/mach-omap1/clock_data.c +0 -10
@@ -765,14 +765,6 @@ static struct omap_clk omap_clks[] = {* init */ -static struct clk_functions omap1_clk_functions = { - .clk_enable = omap1_clk_enable, - .clk_disable = omap1_clk_disable, - .clk_round_rate = omap1_clk_round_rate, - .clk_set_rate = omap1_clk_set_rate, - .clk_disable_unused = omap1_clk_disable_unused, -}; -static void __init omap1_show_rates (void ) { pr_notice("Clocking rate (xtal/DPLL1/MPU): %ld.%01ld/%ld.%01ld/%ld.%01ld MHz\n",
@@ -803,8 +795,6 @@ int __init omap1_clk_init(void)if (!cpu_is_omap15xx ())omap_writew (0 ,SOFT_REQ_REG2 ); -clk_init (&omap1_clk_functions); -/* By default all idlect1 clocks are allowed to idle */ arm_idlect1_mask = ~0 ;
arch/arm/mach-omap2/clock.c +510 -7
534 lines not on this page · raw message
arch/arm/mach-omap2/clock2420_data.c +0 -2
@@ -1935,8 +1935,6 @@ int __init omap2420_clk_init(void) cpu_mask =RATE_IN_242X ; rate_table = omap2420_rate_table; -clk_init (&omap2_clk_functions); -for (c = omap2420_clks; c < omap2420_clks +ARRAY_SIZE (omap2420_clks); c++)clk_preinit (c->lk.clk);
arch/arm/mach-omap2/clock2430_data.c +0 -2
@@ -2034,8 +2034,6 @@ int __init omap2430_clk_init(void) cpu_mask =RATE_IN_243X ; rate_table = omap2430_rate_table; -clk_init (&omap2_clk_functions); -for (c = omap2430_clks; c < omap2430_clks +ARRAY_SIZE (omap2430_clks); c++)clk_preinit (c->lk.clk);
arch/arm/mach-omap2/clock33xx_data.c +0 -2
@@ -1083,8 +1083,6 @@ int __init am33xx_clk_init(void) cpu_clkflg =CK_AM33XX ; } -clk_init (&omap2_clk_functions); -for (c = am33xx_clks; c < am33xx_clks +ARRAY_SIZE (am33xx_clks); c++)clk_preinit (c->lk.clk);
arch/arm/mach-omap2/clock3xxx_data.c +0 -2
@@ -3573,8 +3573,6 @@ int __init omap3xxx_clk_init(void)else dpll4_dd = dpll4_dd_34xx; -clk_init (&omap2_clk_functions); -for (c = omap3xxx_clks; c < omap3xxx_clks +ARRAY_SIZE (omap3xxx_clks); c++)clk_preinit (c->lk.clk);
arch/arm/mach-omap2/clock44xx_data.c +0 -2
@@ -3366,8 +3366,6 @@ int __init omap4xxx_clk_init(void)return 0 ; } -clk_init (&omap2_clk_functions); -/* * Must stay commented until all OMAP SoC drivers are * converted to runtime PM, or drivers may start crashing
arch/arm/plat-omap/Makefile +1 -1
@@ -3,7 +3,7 @@ # # Common support -obj-y := common.o sram.o clock.o dma.o mux.o fb.o counter_32k.o +obj-y := common.o sram.o dma.o mux.o fb.o counter_32k.o obj-m := obj-n := obj- :=
arch/arm/plat-omap/clock.c deleted +0 -544
544 lines not on this page · raw message
Paul Walmsley
maintainerPATCH 5/6 ARM: OMAP: remove plat/clock.h
In reply to Paul WalmsleyRemove arch/arm/plat-omap/include/plat/clock.h by merging it into arch/arm/mach-omap1/clock.h and arch/arm/mach-omap2/clock.h. The goal here is to facilitate ARM single image kernels by removing includes via the "plat/" symlink.
--- arch/arm/mach-omap1/board-nokia770.c | 2 arch/arm/mach-omap1/clock.c | 2 arch/arm/mach-omap1/clock.h | 153 +++++++++++++ arch/arm/mach-omap1/clock_data.c | 2 arch/arm/mach-omap1/pm.c | 2 arch/arm/mach-omap2/clkt2xxx_apll.c | 2 arch/arm/mach-omap2/clkt2xxx_dpll.c | 2 arch/arm/mach-omap2/clkt2xxx_dpllcore.c | 2 arch/arm/mach-omap2/clkt2xxx_osc.c | 2 arch/arm/mach-omap2/clkt2xxx_sys.c | 2 arch/arm/mach-omap2/clkt2xxx_virt_prcm_set.c | 2 arch/arm/mach-omap2/clkt34xx_dpll3m2.c | 2 arch/arm/mach-omap2/clkt_clksel.c | 2 arch/arm/mach-omap2/clkt_dpll.c | 2 arch/arm/mach-omap2/clkt_iclk.c | 2 arch/arm/mach-omap2/clock.c | 2 arch/arm/mach-omap2/clock.h | 284 ++++++++++++++++++++++++ arch/arm/mach-omap2/clock2430.c | 2 arch/arm/mach-omap2/clock2xxx.c | 2 arch/arm/mach-omap2/clock34xx.c | 2 arch/arm/mach-omap2/clock3517.c | 2 arch/arm/mach-omap2/clock36xx.c | 2 arch/arm/mach-omap2/clock3xxx.c | 2 arch/arm/mach-omap2/clockdomain.c | 2 arch/arm/mach-omap2/clockdomain.h | 2 arch/arm/mach-omap2/common.c | 2 arch/arm/mach-omap2/dpll3xxx.c | 2 arch/arm/mach-omap2/dpll44xx.c | 2 arch/arm/mach-omap2/omap_hwmod.c | 2 arch/arm/mach-omap2/pm-debug.c | 2 arch/arm/mach-omap2/pm24xx.c | 2 arch/arm/mach-omap2/sdram-nokia.c | 2 arch/arm/mach-omap2/sdrc.c | 2 arch/arm/mach-omap2/sdrc2xxx.c | 2 arch/arm/plat-omap/counter_32k.c | 1 arch/arm/plat-omap/include/plat/clock.h | 309 -------------------------- arch/arm/plat-omap/omap_device.c | 1 37 files changed, 467 insertions(+), 345 deletions(-) delete mode 100644 arch/arm/plat-omap/include/plat/clock.h
arch/arm/mach-omap1/board-nokia770.c +1 -1
@@ -29,7 +29,7 @@#include <plat/keypad.h> #include <plat/lcd_mipid.h> #include <plat/mmc.h> -#include <plat/clock.h> +#include "clock.h" #include <mach/hardware.h> #include <mach/usb.h>
arch/arm/mach-omap1/clock.c +1 -1
@@ -24,7 +24,7 @@#include <plat/cpu.h> #include <plat/usb.h> -#include <plat/clock.h> +#include "clock.h" #include <plat/sram.h> #include <plat/clkdev_omap.h>
arch/arm/mach-omap1/clock.h +152 -1
160 lines not on this page · raw message
arch/arm/mach-omap1/clock_data.c +1 -1
@@ -22,7 +22,7 @@#include <asm/mach-types.h> /* for machine_is_* */ -#include <plat/clock.h> +#include "clock.h" #include <plat/cpu.h> #include <plat/clkdev_omap.h> #include <plat/sram.h> /* for omap_sram_reprogram_clock() */
arch/arm/mach-omap1/pm.c +1 -1
@@ -50,7 +50,7 @@#include <asm/mach/irq.h> #include <plat/cpu.h> -#include <plat/clock.h> +#include "clock.h" #include <plat/sram.h> #include <plat/tc.h> #include <plat/mux.h>
arch/arm/mach-omap2/clkt2xxx_apll.c +1 -1
@@ -21,7 +21,7 @@#include <linux/clk.h> #include <linux/io.h> -#include <plat/clock.h> +#include "clock.h" #include <plat/prcm.h> #include "clock.h"
arch/arm/mach-omap2/clkt2xxx_dpll.c +1 -1
@@ -14,7 +14,7 @@#include <linux/clk.h> #include <linux/io.h> -#include <plat/clock.h> +#include "clock.h" #include "clock.h" #include "cm2xxx_3xxx.h"
arch/arm/mach-omap2/clkt2xxx_dpllcore.c +1 -1
@@ -25,7 +25,7 @@#include <linux/clk.h> #include <linux/io.h> -#include <plat/clock.h> +#include "clock.h" #include <plat/sram.h> #include <plat/sdrc.h>
arch/arm/mach-omap2/clkt2xxx_osc.c +1 -1
@@ -23,7 +23,7 @@#include <linux/clk.h> #include <linux/io.h> -#include <plat/clock.h> +#include "clock.h" #include "clock.h" #include "clock2xxx.h"
arch/arm/mach-omap2/clkt2xxx_sys.c +1 -1
@@ -22,7 +22,7 @@#include <linux/clk.h> #include <linux/io.h> -#include <plat/clock.h> +#include "clock.h" #include "clock.h" #include "clock2xxx.h"
arch/arm/mach-omap2/clkt2xxx_virt_prcm_set.c +1 -1
@@ -33,7 +33,7 @@#include <linux/cpufreq.h> #include <linux/slab.h> -#include <plat/clock.h> +#include "clock.h" #include <plat/sram.h> #include <plat/sdrc.h>
arch/arm/mach-omap2/clkt34xx_dpll3m2.c +1 -1
@@ -21,7 +21,7 @@#include <linux/clk.h> #include <linux/io.h> -#include <plat/clock.h> +#include "clock.h" #include <plat/sram.h> #include <plat/sdrc.h>
arch/arm/mach-omap2/clkt_clksel.c +1 -1
@@ -45,7 +45,7 @@#include <linux/io.h> #include <linux/bug.h> -#include <plat/clock.h> +#include "clock.h" #include "clock.h"
arch/arm/mach-omap2/clkt_dpll.c +1 -1
@@ -21,7 +21,7 @@#include <asm/div64.h> -#include <plat/clock.h> +#include "clock.h" #include "soc.h" #include "clock.h"
arch/arm/mach-omap2/clkt_iclk.c +1 -1
@@ -14,7 +14,7 @@#include <linux/clk.h> #include <linux/io.h> -#include <plat/clock.h> +#include "clock.h" #include <plat/prcm.h> #include "clock.h"
arch/arm/mach-omap2/clock.c +1 -1
@@ -26,7 +26,7 @@#include <asm/cpu.h> -#include <plat/clock.h> +#include "clock.h" #include <plat/prcm.h> #include <trace/events/power.h>
arch/arm/mach-omap2/clock.h +283 -1
291 lines not on this page · raw message
arch/arm/mach-omap2/clock2430.c +1 -1
@@ -21,7 +21,7 @@#include <linux/clk.h> #include <linux/io.h> -#include <plat/clock.h> +#include "clock.h" #include "soc.h" #include "iomap.h"
arch/arm/mach-omap2/clock2xxx.c +1 -1
@@ -22,7 +22,7 @@#include <linux/clk.h> #include <linux/io.h> -#include <plat/clock.h> +#include "clock.h" #include "soc.h" #include "clock.h"
arch/arm/mach-omap2/clock34xx.c +1 -1
@@ -21,7 +21,7 @@#include <linux/clk.h> #include <linux/io.h> -#include <plat/clock.h> +#include "clock.h" #include "clock.h" #include "clock34xx.h"
arch/arm/mach-omap2/clock3517.c +1 -1
@@ -21,7 +21,7 @@#include <linux/clk.h> #include <linux/io.h> -#include <plat/clock.h> +#include "clock.h" #include "clock.h" #include "clock3517.h"
arch/arm/mach-omap2/clock36xx.c +1 -1
@@ -22,7 +22,7 @@#include <linux/clk.h> #include <linux/io.h> -#include <plat/clock.h> +#include "clock.h" #include "clock.h" #include "clock36xx.h"
arch/arm/mach-omap2/clock3xxx.c +1 -1
@@ -21,7 +21,7 @@#include <linux/clk.h> #include <linux/io.h> -#include <plat/clock.h> +#include "clock.h" #include "soc.h" #include "clock.h"
arch/arm/mach-omap2/clockdomain.c +1 -1
@@ -27,7 +27,7 @@#include <linux/bitops.h> -#include <plat/clock.h> +#include "clock.h" #include "clockdomain.h" /* clkdm_list contains all registered struct clockdomains */
arch/arm/mach-omap2/clockdomain.h +1 -1
@@ -18,7 +18,7 @@#include <linux/spinlock.h> #include "powerdomain.h" -#include <plat/clock.h> +#include "clock.h" #include <plat/omap_hwmod.h> #include <plat/cpu.h>
arch/arm/mach-omap2/common.c +1 -1
@@ -18,7 +18,7 @@#include <linux/io.h> #include <plat/mux.h> -#include <plat/clock.h> +#include "clock.h" #include "soc.h" #include "iomap.h"
arch/arm/mach-omap2/dpll3xxx.c +1 -1
@@ -28,7 +28,7 @@#include <linux/bitops.h> #include <linux/clkdev.h> -#include <plat/clock.h> +#include "clock.h" #include "soc.h" #include "clock.h"
arch/arm/mach-omap2/dpll44xx.c +1 -1
@@ -15,7 +15,7 @@#include <linux/io.h> #include <linux/bitops.h> -#include <plat/clock.h> +#include "clock.h" #include "soc.h" #include "clock.h"
arch/arm/mach-omap2/omap_hwmod.c +1 -1
@@ -139,7 +139,7 @@#include <linux/slab.h> #include <linux/bootmem.h> -#include <plat/clock.h> +#include "clock.h" #include <plat/omap_hwmod.h> #include <plat/prcm.h>
arch/arm/mach-omap2/pm-debug.c +1 -1
@@ -27,7 +27,7 @@#include <linux/module.h> #include <linux/slab.h> -#include <plat/clock.h> +#include "clock.h" #include "powerdomain.h" #include "clockdomain.h" #include <plat/dmtimer.h>
arch/arm/mach-omap2/pm24xx.c +1 -1
@@ -36,7 +36,7 @@#include <asm/mach-types.h> #include <asm/system_misc.h> -#include <plat/clock.h> +#include "clock.h" #include <plat/sram.h> #include <plat/dma.h>
arch/arm/mach-omap2/sdram-nokia.c +1 -1
@@ -18,7 +18,7 @@#include <linux/io.h> #include "common.h" -#include <plat/clock.h> +#include "clock.h" #include <plat/sdrc.h> #include "sdram-nokia.h"
arch/arm/mach-omap2/sdrc.c +1 -1
@@ -24,7 +24,7 @@#include <linux/io.h> #include "common.h" -#include <plat/clock.h> +#include "clock.h" #include <plat/sram.h> #include <plat/sdrc.h>
arch/arm/mach-omap2/sdrc2xxx.c +1 -1
@@ -24,7 +24,7 @@#include <linux/clk.h> #include <linux/io.h> -#include <plat/clock.h> +#include "clock.h" #include <plat/sram.h> #include <plat/sdrc.h>
arch/arm/plat-omap/counter_32k.c +0 -1
@@ -23,7 +23,6 @@#include <asm/sched_clock.h> #include <plat/common.h> -#include <plat/clock.h> /* OMAP2_32KSYNCNT_CR_OFF: offset of 32ksync counter register */ #define OMAP2_32KSYNCNT_REV_OFF 0x0
arch/arm/plat-omap/include/plat/clock.h deleted +0 -309
309 lines not on this page · raw message
arch/arm/plat-omap/omap_device.c +0 -1
@@ -91,7 +91,6 @@#include <plat/omap_device.h> #include <plat/omap_hwmod.h> -#include <plat/clock.h> /* These parameters are passed to _omap_device_{de,}activate() */ #define USE_WAKEUP_LAT 0
Tony Lindgren
maintainerPATCH 5/6 ARM: OMAP: remove plat/clock.h
Quoted 4 lines · Paul Walmsley
Remove
arch/arm/plat-omap/include/plat/clock.hby merging it intoarch/arm/mach-omap1/clock.handarch/arm/mach-omap2/clock.h. The goal here is to facilitate ARM single image kernels by removing includes via the "plat/" symlink.
Looks like this adds some duplicate #include "clock.h", we already have it in many places, so plat/clock.h changes can be just dropped.
I've applied your patches locally with the other plat header cleanup and fixed up the issue keeping the existing clock.h. Updated patch below for what I have, probably won't apply to your branch without conflicts right now.
But you can see where the duplicates are with:
$ grep -rc 'include "clock.h"' arch/arm/*omap*/* | grep ":2"
Anyways, let's wait few days before we do some immutable branch as we still have the late patches missing from the mainline kernel.
Regards,
Tony
From: Paul Walmsley <[email protected]>
Date: Thu, 27 Sep 2012 10:33:34 -0600
Subject: [PATCH] ARM: OMAP: remove plat/clock.h
Remove arch/arm/plat-omap/include/plat/clock.h by merging it into arch/arm/mach-omap1/clock.h and arch/arm/mach-omap2/clock.h. The goal here is to facilitate ARM single image kernels by removing includes via the "plat/" symlink.
arch/arm/mach-omap1/board-nokia770.c +1 -1
@@ -29,12 +29,12 @@#include <asm/mach/map.h> #include <mach/mux.h> -#include <plat/clock.h> #include <mach/hardware.h> #include <mach/usb.h> #include "common.h" +#include "clock.h" #include "mmc.h" #define ADS7846_PENDOWN_GPIO 15
arch/arm/mach-omap1/clock.c +0 -1
@@ -24,7 +24,6 @@#include <plat/cpu.h> #include <plat/usb.h> -#include <plat/clock.h> #include <plat/clkdev_omap.h> #include <mach/hardware.h>
arch/arm/mach-omap1/clock.h +152 -1
160 lines not on this page · raw message
arch/arm/mach-omap1/clock_data.c +0 -1
@@ -22,7 +22,6 @@#include <asm/mach-types.h> /* for machine_is_* */ -#include <plat/clock.h> #include <plat/cpu.h> #include <plat/clkdev_omap.h>
arch/arm/mach-omap1/pm.c +1 -2
@@ -49,8 +49,6 @@#include <asm/mach/time.h> #include <asm/mach/irq.h> -#include <plat/cpu.h> -#include <plat/clock.h> #include <mach/tc.h> #include <mach/mux.h> #include <plat/dmtimer.h>
@@ -61,6 +59,7 @@#include "../plat-omap/sram.h" #include "iomap.h" +#include "clock.h" #include "pm.h" static unsigned int arm_sleep_save[ARM_SLEEP_SAVE_SIZE ];
arch/arm/mach-omap2/clkt2xxx_apll.c +0 -1
@@ -21,7 +21,6 @@#include <linux/clk.h> #include <linux/io.h> -#include <plat/clock.h> #include <plat/prcm.h> #include "clock.h"
arch/arm/mach-omap2/clkt2xxx_dpll.c +0 -2
@@ -14,8 +14,6 @@#include <linux/clk.h> #include <linux/io.h> -#include <plat/clock.h> -#include "clock.h" #include "cm2xxx_3xxx.h" #include "cm-regbits-24xx.h"
arch/arm/mach-omap2/clkt2xxx_dpllcore.c +0 -1
@@ -25,7 +25,6 @@#include <linux/clk.h> #include <linux/io.h> -#include <plat/clock.h> #include <plat/sdrc.h> #include "../plat-omap/sram.h"
arch/arm/mach-omap2/clkt2xxx_osc.c +0 -2
@@ -23,8 +23,6 @@#include <linux/clk.h> #include <linux/io.h> -#include <plat/clock.h> -#include "clock.h" #include "clock2xxx.h" #include "prm2xxx_3xxx.h"
arch/arm/mach-omap2/clkt2xxx_sys.c +0 -2
@@ -22,8 +22,6 @@#include <linux/clk.h> #include <linux/io.h> -#include <plat/clock.h> -#include "clock.h" #include "clock2xxx.h" #include "prm2xxx_3xxx.h"
arch/arm/mach-omap2/clkt2xxx_virt_prcm_set.c +0 -1
@@ -33,7 +33,6 @@#include <linux/cpufreq.h> #include <linux/slab.h> -#include <plat/clock.h> #include <plat/sdrc.h> #include "../plat-omap/sram.h"
arch/arm/mach-omap2/clkt34xx_dpll3m2.c +0 -1
@@ -21,7 +21,6 @@#include <linux/clk.h> #include <linux/io.h> -#include <plat/clock.h> #include <plat/sdrc.h> #include "../plat-omap/sram.h"
arch/arm/mach-omap2/clkt_clksel.c +0 -2
@@ -45,8 +45,6 @@#include <linux/io.h> #include <linux/bug.h> -#include <plat/clock.h> -#include "clock.h" /* Private functions */
arch/arm/mach-omap2/clkt_dpll.c +0 -2
@@ -21,8 +21,6 @@#include <asm/div64.h> -#include <plat/clock.h> -#include "soc.h" #include "clock.h" #include "cm-regbits-24xx.h"
arch/arm/mach-omap2/clkt_iclk.c +0 -1
@@ -14,7 +14,6 @@#include <linux/clk.h> #include <linux/io.h> -#include <plat/clock.h> #include <plat/prcm.h> #include "clock.h"
arch/arm/mach-omap2/clock.c +0 -1
@@ -26,7 +26,6 @@#include <asm/cpu.h> -#include <plat/clock.h> #include <plat/prcm.h> #include <trace/events/power.h>
arch/arm/mach-omap2/clock.h +283 -1
291 lines not on this page · raw message
arch/arm/mach-omap2/clock2430.c +0 -2
@@ -21,8 +21,6 @@#include <linux/clk.h> #include <linux/io.h> -#include <plat/clock.h> -#include "soc.h" #include "iomap.h" #include "clock.h"
arch/arm/mach-omap2/clock2xxx.c +0 -2
@@ -22,8 +22,6 @@#include <linux/clk.h> #include <linux/io.h> -#include <plat/clock.h> -#include "soc.h" #include "clock.h" #include "clock2xxx.h"
arch/arm/mach-omap2/clock34xx.c +0 -2
@@ -21,8 +21,6 @@#include <linux/clk.h> #include <linux/io.h> -#include <plat/clock.h> -#include "clock.h" #include "clock34xx.h" #include "cm2xxx_3xxx.h"
arch/arm/mach-omap2/clock3517.c +0 -2
@@ -21,8 +21,6 @@#include <linux/clk.h> #include <linux/io.h> -#include <plat/clock.h> -#include "clock.h" #include "clock3517.h" #include "cm2xxx_3xxx.h"
arch/arm/mach-omap2/clock36xx.c +0 -2
@@ -22,8 +22,6 @@#include <linux/clk.h> #include <linux/io.h> -#include <plat/clock.h> -#include "clock.h" #include "clock36xx.h"
arch/arm/mach-omap2/clock3xxx.c +0 -2
@@ -21,8 +21,6 @@#include <linux/clk.h> #include <linux/io.h> -#include <plat/clock.h> -#include "soc.h" #include "clock.h" #include "clock3xxx.h"
arch/arm/mach-omap2/clockdomain.c +1 -1
@@ -27,7 +27,7 @@#include <linux/bitops.h> -#include <plat/clock.h> +#include "clock.h" #include "clockdomain.h" /* clkdm_list contains all registered struct clockdomains */
arch/arm/mach-omap2/clockdomain.h +1 -1
@@ -18,7 +18,7 @@#include <linux/spinlock.h> #include "powerdomain.h" -#include <plat/clock.h> +#include "clock.h" #include <plat/omap_hwmod.h> #include <plat/cpu.h>
arch/arm/mach-omap2/common.c +1 -1
@@ -18,12 +18,12 @@#include <linux/io.h> #include <linux/platform_data/dsp-omap.h> -#include <plat/clock.h> #include <plat/vram.h> #include "soc.h" #include "iomap.h" #include "common.h" +#include "clock.h" #include "sdrc.h" #include "control.h" #include "omap-secure.h"
arch/arm/mach-omap2/dpll3xxx.c +0 -2
@@ -28,8 +28,6 @@#include <linux/bitops.h> #include <linux/clkdev.h> -#include <plat/clock.h> -#include "soc.h" #include "clock.h" #include "cm2xxx_3xxx.h"
arch/arm/mach-omap2/dpll44xx.c +0 -2
@@ -15,8 +15,6 @@#include <linux/io.h> #include <linux/bitops.h> -#include <plat/clock.h> -#include "soc.h" #include "clock.h" #include "clock44xx.h"
arch/arm/mach-omap2/omap_hwmod.c +1 -1
@@ -139,7 +139,7 @@#include <linux/slab.h> #include <linux/bootmem.h> -#include <plat/clock.h> +#include "clock.h" #include <plat/omap_hwmod.h> #include <plat/prcm.h>
arch/arm/mach-omap2/pm-debug.c +1 -1
@@ -27,7 +27,7 @@#include <linux/module.h> #include <linux/slab.h> -#include <plat/clock.h> +#include "clock.h" #include "powerdomain.h" #include "clockdomain.h" #include <plat/dmtimer.h>
arch/arm/mach-omap2/pm24xx.c +1 -1
@@ -36,12 +36,12 @@#include <asm/mach-types.h> #include <asm/system_misc.h> -#include <plat/clock.h> #include <plat-omap/dma-omap.h> #include "../plat-omap/sram.h" #include "common.h" +#include "clock.h" #include "prm2xxx_3xxx.h" #include "prm-regbits-24xx.h" #include "cm2xxx_3xxx.h"
arch/arm/mach-omap2/sdram-nokia.c +1 -1
@@ -18,7 +18,7 @@#include <linux/io.h> #include "common.h" -#include <plat/clock.h> +#include "clock.h" #include <plat/sdrc.h> #include "sdram-nokia.h"
arch/arm/mach-omap2/sdrc.c +4 -3
@@ -23,11 +23,12 @@#include <linux/clk.h> #include <linux/io.h> -#include "common.h" -#include <plat/clock.h> +#include <plat/sdrc.h> +#include "../plat-omap/sram.h" -#include <plat/sdrc.h> +#include "common.h" +#include "clock.h" #include "sdrc.h" static struct omap_sdrc_params *sdrc_init_params_cs0, *sdrc_init_params_cs1;
arch/arm/mach-omap2/sdrc2xxx.c +0 -1
@@ -24,7 +24,6 @@#include <linux/clk.h> #include <linux/io.h> -#include <plat/clock.h> #include "../plat-omap/sram.h" #include <plat/sdrc.h>
arch/arm/plat-omap/counter_32k.c +0 -1
@@ -23,7 +23,6 @@#include <asm/sched_clock.h> #include "common.h" -#include <plat/clock.h> /* OMAP2_32KSYNCNT_CR_OFF: offset of 32ksync counter register */ #define OMAP2_32KSYNCNT_REV_OFF 0x0
arch/arm/plat-omap/include/plat/clock.h deleted +0 -309
309 lines not on this page · raw message
arch/arm/plat-omap/omap_device.c +0 -1
@@ -91,7 +91,6 @@#include <plat/omap_device.h> #include <plat/omap_hwmod.h> -#include <plat/clock.h> /* These parameters are passed to _omap_device_{de,}activate() */ #define USE_WAKEUP_LAT 0
Paul Walmsley
maintainerPATCH 5/6 ARM: OMAP: remove plat/clock.h
Quoted 3 lines · Tony Lindgren
But you can see where the duplicates are with:
$ grep -rc 'include "clock.h"' arch/arm/*omap*/* | grep ":2"
OK thanks. Updated the patch here, and planning to wait until 3.7-rc1 is out before sending a pull request for 3.8 cleanup.
- Paul
From: Paul Walmsley <[email protected]>
Date: Wed, 26 Sep 2012 17:55:04 -0600
Subject: [PATCH] ARM: OMAP: remove plat/clock.h
Remove arch/arm/plat-omap/include/plat/clock.h by merging it into arch/arm/mach-omap1/clock.h and arch/arm/mach-omap2/clock.h. The goal here is to facilitate ARM single image kernels by removing includes via the "plat/" symlink.
--- arch/arm/mach-omap1/board-nokia770.c | 2 +- arch/arm/mach-omap1/clock.c | 1 - arch/arm/mach-omap1/clock.h | 153 ++++++++++++- arch/arm/mach-omap1/clock_data.c | 1 - arch/arm/mach-omap1/pm.c | 2 +- arch/arm/mach-omap2/clkt2xxx_apll.c | 1 - arch/arm/mach-omap2/clkt2xxx_dpll.c | 2 - arch/arm/mach-omap2/clkt2xxx_dpllcore.c | 1 - arch/arm/mach-omap2/clkt2xxx_osc.c | 2 - arch/arm/mach-omap2/clkt2xxx_sys.c | 2 - arch/arm/mach-omap2/clkt2xxx_virt_prcm_set.c | 1 - arch/arm/mach-omap2/clkt34xx_dpll3m2.c | 1 - arch/arm/mach-omap2/clkt_clksel.c | 2 - arch/arm/mach-omap2/clkt_dpll.c | 2 - arch/arm/mach-omap2/clkt_iclk.c | 1 - arch/arm/mach-omap2/clock.c | 1 - arch/arm/mach-omap2/clock.h | 284 ++++++++++++++++++++++- arch/arm/mach-omap2/clock2430.c | 2 - arch/arm/mach-omap2/clock2xxx.c | 2 - arch/arm/mach-omap2/clock34xx.c | 2 - arch/arm/mach-omap2/clock3517.c | 2 - arch/arm/mach-omap2/clock36xx.c | 2 - arch/arm/mach-omap2/clock3xxx.c | 2 - arch/arm/mach-omap2/clockdomain.c | 2 +- arch/arm/mach-omap2/clockdomain.h | 2 +- arch/arm/mach-omap2/common.c | 2 +- arch/arm/mach-omap2/dpll3xxx.c | 2 - arch/arm/mach-omap2/dpll44xx.c | 2 - arch/arm/mach-omap2/omap_hwmod.c | 2 +- arch/arm/mach-omap2/pm-debug.c | 2 +- arch/arm/mach-omap2/pm24xx.c | 2 +- arch/arm/mach-omap2/sdram-nokia.c | 2 +- arch/arm/mach-omap2/sdrc.c | 2 +- arch/arm/mach-omap2/sdrc2xxx.c | 1 - arch/arm/plat-omap/counter_32k.c | 1 - arch/arm/plat-omap/include/plat/clock.h | 309 -------------------------- arch/arm/plat-omap/omap_device.c | 1 - 37 files changed, 445 insertions(+), 358 deletions(-) delete mode 100644 arch/arm/plat-omap/include/plat/clock.h
arch/arm/mach-omap1/board-nokia770.c +1 -1
@@ -29,7 +29,7 @@#include <plat/keypad.h> #include <plat/lcd_mipid.h> #include <plat/mmc.h> -#include <plat/clock.h> +#include "clock.h" #include <mach/hardware.h> #include <mach/usb.h>
arch/arm/mach-omap1/clock.c +0 -1
@@ -24,7 +24,6 @@#include <plat/cpu.h> #include <plat/usb.h> -#include <plat/clock.h> #include <plat/sram.h> #include <plat/clkdev_omap.h>
arch/arm/mach-omap1/clock.h +152 -1
160 lines not on this page · raw message
arch/arm/mach-omap1/clock_data.c +0 -1
@@ -22,7 +22,6 @@#include <asm/mach-types.h> /* for machine_is_* */ -#include <plat/clock.h> #include <plat/cpu.h> #include <plat/clkdev_omap.h> #include <plat/sram.h> /* for omap_sram_reprogram_clock() */
arch/arm/mach-omap1/pm.c +1 -1
@@ -50,7 +50,7 @@#include <asm/mach/irq.h> #include <plat/cpu.h> -#include <plat/clock.h> +#include "clock.h" #include <plat/sram.h> #include <plat/tc.h> #include <plat/mux.h>
arch/arm/mach-omap2/clkt2xxx_apll.c +0 -1
@@ -21,7 +21,6 @@#include <linux/clk.h> #include <linux/io.h> -#include <plat/clock.h> #include <plat/prcm.h> #include "clock.h"
arch/arm/mach-omap2/clkt2xxx_dpll.c +0 -2
@@ -14,8 +14,6 @@#include <linux/clk.h> #include <linux/io.h> -#include <plat/clock.h> -#include "clock.h" #include "cm2xxx_3xxx.h" #include "cm-regbits-24xx.h"
arch/arm/mach-omap2/clkt2xxx_dpllcore.c +0 -1
@@ -25,7 +25,6 @@#include <linux/clk.h> #include <linux/io.h> -#include <plat/clock.h> #include <plat/sram.h> #include <plat/sdrc.h>
arch/arm/mach-omap2/clkt2xxx_osc.c +0 -2
@@ -23,8 +23,6 @@#include <linux/clk.h> #include <linux/io.h> -#include <plat/clock.h> -#include "clock.h" #include "clock2xxx.h" #include "prm2xxx_3xxx.h"
arch/arm/mach-omap2/clkt2xxx_sys.c +0 -2
@@ -22,8 +22,6 @@#include <linux/clk.h> #include <linux/io.h> -#include <plat/clock.h> -#include "clock.h" #include "clock2xxx.h" #include "prm2xxx_3xxx.h"
arch/arm/mach-omap2/clkt2xxx_virt_prcm_set.c +0 -1
@@ -33,7 +33,6 @@#include <linux/cpufreq.h> #include <linux/slab.h> -#include <plat/clock.h> #include <plat/sram.h> #include <plat/sdrc.h>
arch/arm/mach-omap2/clkt34xx_dpll3m2.c +0 -1
@@ -21,7 +21,6 @@#include <linux/clk.h> #include <linux/io.h> -#include <plat/clock.h> #include <plat/sram.h> #include <plat/sdrc.h>
arch/arm/mach-omap2/clkt_clksel.c +0 -2
@@ -45,8 +45,6 @@#include <linux/io.h> #include <linux/bug.h> -#include <plat/clock.h> -#include "clock.h" /* Private functions */
arch/arm/mach-omap2/clkt_dpll.c +0 -2
@@ -21,8 +21,6 @@#include <asm/div64.h> -#include <plat/clock.h> -#include "soc.h" #include "clock.h" #include "cm-regbits-24xx.h"
arch/arm/mach-omap2/clkt_iclk.c +0 -1
@@ -14,7 +14,6 @@#include <linux/clk.h> #include <linux/io.h> -#include <plat/clock.h> #include <plat/prcm.h> #include "clock.h"
arch/arm/mach-omap2/clock.c +0 -1
@@ -26,7 +26,6 @@#include <asm/cpu.h> -#include <plat/clock.h> #include <plat/prcm.h> #include <trace/events/power.h>
arch/arm/mach-omap2/clock.h +283 -1
291 lines not on this page · raw message
arch/arm/mach-omap2/clock2430.c +0 -2
@@ -21,8 +21,6 @@#include <linux/clk.h> #include <linux/io.h> -#include <plat/clock.h> -#include "soc.h" #include "iomap.h" #include "clock.h"
arch/arm/mach-omap2/clock2xxx.c +0 -2
@@ -22,8 +22,6 @@#include <linux/clk.h> #include <linux/io.h> -#include <plat/clock.h> -#include "soc.h" #include "clock.h" #include "clock2xxx.h"
arch/arm/mach-omap2/clock34xx.c +0 -2
@@ -21,8 +21,6 @@#include <linux/clk.h> #include <linux/io.h> -#include <plat/clock.h> -#include "clock.h" #include "clock34xx.h" #include "cm2xxx_3xxx.h"
arch/arm/mach-omap2/clock3517.c +0 -2
@@ -21,8 +21,6 @@#include <linux/clk.h> #include <linux/io.h> -#include <plat/clock.h> -#include "clock.h" #include "clock3517.h" #include "cm2xxx_3xxx.h"
arch/arm/mach-omap2/clock36xx.c +0 -2
@@ -22,8 +22,6 @@#include <linux/clk.h> #include <linux/io.h> -#include <plat/clock.h> -#include "clock.h" #include "clock36xx.h"
arch/arm/mach-omap2/clock3xxx.c +0 -2
@@ -21,8 +21,6 @@#include <linux/clk.h> #include <linux/io.h> -#include <plat/clock.h> -#include "soc.h" #include "clock.h" #include "clock3xxx.h"
arch/arm/mach-omap2/clockdomain.c +1 -1
@@ -27,7 +27,7 @@#include <linux/bitops.h> -#include <plat/clock.h> +#include "clock.h" #include "clockdomain.h" /* clkdm_list contains all registered struct clockdomains */
arch/arm/mach-omap2/clockdomain.h +1 -1
@@ -18,7 +18,7 @@#include <linux/spinlock.h> #include "powerdomain.h" -#include <plat/clock.h> +#include "clock.h" #include <plat/omap_hwmod.h> #include <plat/cpu.h>
arch/arm/mach-omap2/common.c +1 -1
@@ -18,7 +18,7 @@#include <linux/io.h> #include <plat/mux.h> -#include <plat/clock.h> +#include "clock.h" #include "soc.h" #include "iomap.h"
arch/arm/mach-omap2/dpll3xxx.c +0 -2
@@ -28,8 +28,6 @@#include <linux/bitops.h> #include <linux/clkdev.h> -#include <plat/clock.h> -#include "soc.h" #include "clock.h" #include "cm2xxx_3xxx.h"
arch/arm/mach-omap2/dpll44xx.c +0 -2
@@ -15,8 +15,6 @@#include <linux/io.h> #include <linux/bitops.h> -#include <plat/clock.h> -#include "soc.h" #include "clock.h" #include "clock44xx.h"
arch/arm/mach-omap2/omap_hwmod.c +1 -1
@@ -139,7 +139,7 @@#include <linux/slab.h> #include <linux/bootmem.h> -#include <plat/clock.h> +#include "clock.h" #include <plat/omap_hwmod.h> #include <plat/prcm.h>
arch/arm/mach-omap2/pm-debug.c +1 -1
@@ -27,7 +27,7 @@#include <linux/module.h> #include <linux/slab.h> -#include <plat/clock.h> +#include "clock.h" #include "powerdomain.h" #include "clockdomain.h" #include <plat/dmtimer.h>
arch/arm/mach-omap2/pm24xx.c +1 -1
@@ -36,7 +36,7 @@#include <asm/mach-types.h> #include <asm/system_misc.h> -#include <plat/clock.h> +#include "clock.h" #include <plat/sram.h> #include <plat/dma.h>
arch/arm/mach-omap2/sdram-nokia.c +1 -1
@@ -18,7 +18,7 @@#include <linux/io.h> #include "common.h" -#include <plat/clock.h> +#include "clock.h" #include <plat/sdrc.h> #include "sdram-nokia.h"
arch/arm/mach-omap2/sdrc.c +1 -1
@@ -24,7 +24,7 @@#include <linux/io.h> #include "common.h" -#include <plat/clock.h> +#include "clock.h" #include <plat/sram.h> #include <plat/sdrc.h>
arch/arm/mach-omap2/sdrc2xxx.c +0 -1
@@ -24,7 +24,6 @@#include <linux/clk.h> #include <linux/io.h> -#include <plat/clock.h> #include <plat/sram.h> #include <plat/sdrc.h>
arch/arm/plat-omap/counter_32k.c +0 -1
@@ -23,7 +23,6 @@#include <asm/sched_clock.h> #include <plat/common.h> -#include <plat/clock.h> /* OMAP2_32KSYNCNT_CR_OFF: offset of 32ksync counter register */ #define OMAP2_32KSYNCNT_REV_OFF 0x0
arch/arm/plat-omap/include/plat/clock.h deleted +0 -309
309 lines not on this page · raw message
arch/arm/plat-omap/omap_device.c +0 -1
@@ -91,7 +91,6 @@#include <plat/omap_device.h> #include <plat/omap_hwmod.h> -#include <plat/clock.h> /* These parameters are passed to _omap_device_{de,}activate() */ #define USE_WAKEUP_LAT 0
Signature · 1 line
1.7.10.4
Paul Walmsley
maintainerPATCH 6/6 ARM: OMAP: clock: split plat/clkdev_omap.h into OMAP1/2 files
In reply to Paul WalmsleyTo facilitate the ARM single image work, split arch/arm/plat-omap/include/plat/clkdev_omap.h into the arch/arm/mach-omap1/clock.h and arch/arm/mach-omap2/clock.h files.
--- arch/arm/mach-omap1/clock.c | 1 - arch/arm/mach-omap1/clock.h | 25 +++++++++++++++++++++++++ arch/arm/mach-omap1/clock_data.c | 1 - arch/arm/mach-omap1/opp_data.c | 2 +- arch/arm/mach-omap2/clock.h | 33 +++++++++++++++++++++++++++++++++ arch/arm/mach-omap2/clock2420_data.c | 2 -- arch/arm/mach-omap2/clock2430_data.c | 2 -- arch/arm/mach-omap2/clock33xx_data.c | 1 - arch/arm/mach-omap2/clock3xxx_data.c | 2 -- arch/arm/mach-omap2/clock44xx_data.c | 2 -- 10 files changed, 59 insertions(+), 12 deletions(-)
arch/arm/mach-omap1/clock.c +0 -1
@@ -26,7 +26,6 @@#include <plat/usb.h> #include "clock.h" #include <plat/sram.h> -#include <plat/clkdev_omap.h> #include <mach/hardware.h>
arch/arm/mach-omap1/clock.h +25 -0
@@ -16,9 +16,34 @@#include <linux/clk.h> #include <linux/list.h> +#include <linux/clkdev.h> +struct module ;struct clk ; +struct omap_clk { +u16 cpu; +struct clk_lookup lk; +}; + +#define CLK (dev, con, ck, cp) \ + { \ + .cpu = cp, \ + .lk = { \ + .dev_id = dev, \ + .con_id = con, \ + .clk = ck, \ + }, \ + } + +/* Platform flags for the clkdev-OMAP integration code */ +#define CK_310 (1 << 0) +#define CK_7XX (1 << 1)/* 7xx, 850 */ +#define CK_1510 (1 << 2) +#define CK_16XX (1 << 3)/* 16xx, 17xx, 5912 */ +#define CK_1710 (1 << 4)/* 1710 extra for rate selection */ + +/* Temporary, needed during the common clock framework conversion */ #define __clk_get_name (clk) (clk->name)#define __clk_get_parent (clk) (clk->parent)
arch/arm/mach-omap1/clock_data.c +0 -1
@@ -24,7 +24,6 @@#include "clock.h" #include <plat/cpu.h> -#include <plat/clkdev_omap.h> #include <plat/sram.h> /* for omap_sram_reprogram_clock() */ #include <mach/hardware.h>
arch/arm/mach-omap1/opp_data.c +1 -1
@@ -10,7 +10,7 @@* published by the Free Software Foundation. */ -#include <plat/clkdev_omap.h> +#include "clock.h" #include "opp.h" /*-------------------------------------------------------------------------
arch/arm/mach-omap2/clock.h +33 -0
@@ -19,6 +19,39 @@#include <linux/kernel.h> #include <linux/list.h> +#include <linux/clkdev.h> + +struct omap_clk { +u16 cpu; +struct clk_lookup lk; +}; + +#define CLK (dev, con, ck, cp) \ + { \ + .cpu = cp, \ + .lk = { \ + .dev_id = dev, \ + .con_id = con, \ + .clk = ck, \ + }, \ + } + +/* Platform flags for the clkdev-OMAP integration code */ +#define CK_242X (1 << 0) +#define CK_243X (1 << 1)/* 243x, 253x */ +#define CK_3430ES1 (1 << 2)/* 34xxES1 only */ +#define CK_3430ES2PLUS (1 << 3)/* 34xxES2, ES3, non-Sitara 35xx only */ +#define CK_AM35XX (1 << 4)/* Sitara AM35xx */ +#define CK_36XX (1 << 5)/* 36xx/37xx-specific clocks */ +#define CK_443X (1 << 6) +#define CK_TI816X (1 << 7) +#define CK_446X (1 << 8) +#define CK_AM33XX (1 << 9)/* AM33xx specific clocks */ + + +#define CK_34XX (CK_3430ES1 | CK_3430ES2PLUS) +#define CK_3XXX (CK_34XX | CK_AM35XX | CK_36XX) +struct module ;struct clk ;struct clockdomain ;
arch/arm/mach-omap2/clock2420_data.c +0 -2
@@ -18,8 +18,6 @@#include <linux/clk.h> #include <linux/list.h> -#include <plat/clkdev_omap.h> -#include "soc.h" #include "iomap.h" #include "clock.h"
arch/arm/mach-omap2/clock2430_data.c +0 -2
@@ -17,8 +17,6 @@#include <linux/clk.h> #include <linux/list.h> -#include <plat/clkdev_omap.h> -#include "soc.h" #include "iomap.h" #include "clock.h"
arch/arm/mach-omap2/clock33xx_data.c +0 -1
@@ -17,7 +17,6 @@#include <linux/kernel.h> #include <linux/list.h> #include <linux/clk.h> -#include <plat/clkdev_omap.h> #include "am33xx.h" #include "iomap.h"
arch/arm/mach-omap2/clock3xxx_data.c +0 -2
@@ -21,8 +21,6 @@#include <linux/list.h> #include <linux/io.h> -#include <plat/clkdev_omap.h> -#include "soc.h" #include "iomap.h" #include "clock.h"
arch/arm/mach-omap2/clock44xx_data.c +0 -2
@@ -28,8 +28,6 @@#include <linux/clk.h> #include <linux/io.h> -#include <plat/clkdev_omap.h> -#include "soc.h" #include "iomap.h" #include "clock.h"