Skip to contentSkip to conversation

i2c: sh: Remove irq_wait function

PATCH New Nobuhiro Iwamatsu 3 participants 3 messages Oct 3, 2012 – Oct 4, 2012 I2C

lore
Share & tools
lore

Nobuhiro Iwamatsu

author
#0 lore raw

PATCH 1/1 i2c: sh: Remove irq_wait function

irq_wait function is not referred to from anywhere.

Reported-by Albert ARIBAUD <[email protected]>
Signed-off-by Nobuhiro Iwamatsu <[email protected]>
---
 drivers/i2c/sh_i2c.c |   16 ----------------
 1 file changed, 16 deletions(-)
drivers/i2c/sh_i2c.c +0 -16
index fd8cb92..3147123 100644
@@ -52,22 +52,6 @@ static u8 iccl, icch;
 
 #define IRQ_WAIT 1000
 
-static void irq_wait(struct sh_i2c *base)
-{
-	int i;
-	u8 status;
-
-	for (i = 0 ; i < IRQ_WAIT ; i++) {
-		status = readb(&base->icsr);
-		if (SH_IC_WAIT & status)
-			break;
-
-		udelay(10);
-	}
-
-	writeb(status & ~SH_IC_WAIT, &base->icsr);
-}
-
 static void irq_dte(struct sh_i2c *base)
 {
 	int i;
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 1/1 i2c: sh: Remove irq_wait function

Hello Nobuhiro,

Quoted 8 lines · Nobuhiro Iwamatsu

irq_wait function is not referred to from anywhere.

Reported-by Albert ARIBAUD <[email protected]>
Signed-off-by Nobuhiro Iwamatsu <[email protected]>
---
 drivers/i2c/sh_i2c.c |   16 ----------------
 1 file changed, 16 deletions(-)

Good catch!

Hmm.. for some reason, I could not find this patch in patchwork... Did you or Albert changed the state from it in patchwork?

bye,
Heiko

Signature · 2 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
#2 lore raw

PATCH 1/1 i2c: sh: Remove irq_wait function

Hi Heiko,

Quoted 8 lines · On Thu, 04 Oct 2012 08:25:55 +0200 hs at denx.de wrote:

Hello Nobuhiro,

Quoted 5 lines · Nobuhiro Iwamatsu

irq_wait function is not referred to from anywhere.

Reported-by Albert ARIBAUD <[email protected]>
Signed-off-by Nobuhiro Iwamatsu <[email protected]>
Quoted 8 lines
Quoted 3 lines
---
 drivers/i2c/sh_i2c.c |   16 ----------------
 1 file changed, 16 deletions(-)

Good catch!

Hmm.. for some reason, I could not find this patch in patchwork... Did you or Albert changed the state from it in patchwork?

this patch is already in u-boot-arm.git tree and the state on patchwork is accepted. Albert applied it directly, it seems.

Thanks,
Anatolij