Skip to contentSkip to conversation

New package liblog4c-localtime

PATCH New Alexander Varnin 4 participants 5 messages Oct 4, 2012 – Oct 5, 2012

lore
Share & tools
lore

Alexander Varnin

author
#0 lore raw

PATCH 1/1 New package liblog4c-localtime

---
 package/Config.in                                |    1 +
 package/liblog4c-localtime/Config.in             |    9 +++++++++
 package/liblog4c-localtime/liblog4c-localtime.mk |   11 +++++++++++
 3 files changed, 21 insertions(+), 0 deletions(-)
 create mode 100644 package/liblog4c-localtime/Config.in
 create mode 100644 package/liblog4c-localtime/liblog4c-localtime.mk
package/Config.in +1 -0
index 8a7c9c4..25752e5 100644
@@ -387,6 +387,7 @@ source "package/lttng-libust/Config.in"
 source "package/orc/Config.in"
 source "package/poco/Config.in"
 source "package/startup-notification/Config.in"
+source "package/liblog4c-localtime/Config.in"
 endmenu
 
 menu "Text and terminal handling"
package/liblog4c-localtime/Config.in new file +9 -0
new file mode 100644
index 0000000..58797be
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_LIBLOG4C
+	bool "liblog4c-localtime"
+	help
+	  Log4c is a library of C for flexible logging to files, syslog 
+	  and other destinations.
+	  This version is with localtime patch, to make lib show times in
+	  local timezone.
+
+	  https://github.com/rcmadruga/log4c-localtime
package/liblog4c-localtime/liblog4c-localtime.mk new file +11 -0
new file mode 100644
index 0000000..f0599c3
@@ -0,0 +1,11 @@
+ #############################################################
+ #
+ # liblog4c
+ #
+ #############################################################
+ LIBLOG4C_VERSION = 1.2.1
+ LIBLOG4C_SITE = git://github.com/rcmadruga/log4c-localtime.git
+ LIBLOG4C_INSTALL_STAGING = YES 
+
+ $(eval $(call AUTOTARGETS))
+
Signature · 1 line
1.7.2.5
author
#1 lore raw

PATCH 1/1 New package liblog4c-localtime

Hello. I'm working on old buildroot version 2012.02.
For some reason, this package doesn't get include in build, even when i check config in menuconfig. What else should i have to do, to make package building?

04.10.2012 13:08, Alexander Varnin ?????:

Quoted 52 lines
---
  package/Config.in                                |    1 +
  package/liblog4c-localtime/Config.in             |    9 +++++++++
  package/liblog4c-localtime/liblog4c-localtime.mk |   11 +++++++++++
  3 files changed, 21 insertions(+), 0 deletions(-)

create mode 100644 package/liblog4c-localtime/Config.in create mode 100644 package/liblog4c-localtime/liblog4c-localtime.mk

package/Config.in +1 -0
index 8a7c9c4..25752e5 100644
@@ -387,6 +387,7 @@ source "package/lttng-libust/Config.in"
  source "package/orc/Config.in"
  source "package/poco/Config.in"
  source "package/startup-notification/Config.in"
+source "package/liblog4c-localtime/Config.in"
  endmenu
 
  menu "Text and terminal handling"
package/liblog4c-localtime/Config.in new file +9 -0
new file mode 100644
index 0000000..58797be
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_LIBLOG4C
+	bool "liblog4c-localtime"
+	help
+	  Log4c is a library of C for flexible logging to files, syslog
+	  and other destinations.
+	  This version is with localtime patch, to make lib show times in
+	  local timezone.
+
+	  https://github.com/rcmadruga/log4c-localtime
package/liblog4c-localtime/liblog4c-localtime.mk new file +11 -0
new file mode 100644
index 0000000..f0599c3
@@ -0,0 +1,11 @@
+ #############################################################
+ #
+ # liblog4c
+ #
+ #############################################################
+ LIBLOG4C_VERSION = 1.2.1
+ LIBLOG4C_SITE = git://github.com/rcmadruga/log4c-localtime.git
+ LIBLOG4C_INSTALL_STAGING = YES
+
+ $(eval $(call AUTOTARGETS))
+
#2 lore raw

PATCH 1/1 New package liblog4c-localtime

Hi Alexander,

2012/10/4 Alexander Varnin <[email protected]>:

Quoted 7 lines

Hello. I'm working on old buildroot version 2012.02.
For some reason, this package doesn't get include in build, even when i check config in menuconfig. What else should i have to do, to make package building?

04.10.2012 13:08, Alexander Varnin ?????:

[...]

Quoted 10 lines
Quoted 10 lines
package/liblog4c-localtime/liblog4c-localtime.mk new file +3 -0
new file mode 100644
index 0000000..f0599c3
@@ -0,0 +1,11 @@
+ #############################################################
+ #
+ # liblog4c
Quoted 8 lines

package/liblog4c-localtime/liblog4c-localtime.mk line 11

Quoted 8 lines
package/liblog4c-localtime/liblog4c-localtime.mk new file +8 -0
+ #
+ #############################################################
+ LIBLOG4C_VERSION = 1.2.1
+ LIBLOG4C_SITE = git://github.com/rcmadruga/log4c-localtime.git
+ LIBLOG4C_INSTALL_STAGING = YES
+
+ $(eval $(call AUTOTARGETS))
+

The problem is the package name "liblog4c-localtime" does not match the match the make target translation, which should be "LIBLOG4C_LOCALTIME" instead of just "LIBLOG4C".

So, fix either the package name or the variables in the *.mk file, then it should work.

Regards,

Signature · 1 line
Sam
#3 lore raw

PATCH 1/1 New package liblog4c-localtime

Quoted 1 line · Samuel Martin
Quoted 1 line
Quoted 1 line

+ $(eval $(call AUTOTARGETS))

And also if you want us to apply this patch in the current Buildroot version, this has to be changed to:

$(eval $(autotools-package))

Thanks!

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#4 lore raw

PATCH 1/1 New package liblog4c-localtime

In reply to Alexander Varnin

On 04/10/12 11:08, Alexander Varnin wrote:

Add a Signed-off-by line for yourself. This is a short way for you to
assert that you are entitled to contribute the patch under buildroot's GPL license. See http://kerneltrap.org/files/Jeremy/DCO.txt for more details.

Quoted 26 lines
---
  package/Config.in                                |    1 +
  package/liblog4c-localtime/Config.in             |    9 +++++++++
  package/liblog4c-localtime/liblog4c-localtime.mk |   11 +++++++++++
  3 files changed, 21 insertions(+), 0 deletions(-)

create mode 100644 package/liblog4c-localtime/Config.in create mode 100644 package/liblog4c-localtime/liblog4c-localtime.mk

package/Config.in +1 -0
index 8a7c9c4..25752e5 100644
@@ -387,6 +387,7 @@ source "package/lttng-libust/Config.in"
  source "package/orc/Config.in"
  source "package/poco/Config.in"
  source "package/startup-notification/Config.in"
+source "package/liblog4c-localtime/Config.in"
  endmenu
 
  menu "Text and terminal handling"
package/liblog4c-localtime/Config.in new file +0 -0
new file mode 100644
index 0000000..58797be

package/liblog4c-localtime/Config.in line 9

Quoted 9 lines
package/liblog4c-localtime/Config.in new file +9 -0
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_LIBLOG4C
+	bool "liblog4c-localtime"
+	help
+	  Log4c is a library of C for flexible logging to files, syslog
+	  and other destinations.
+	  This version is with localtime patch, to make lib show times in
+	  local timezone.
+
+	  https://github.com/rcmadruga/log4c-localtime

Add the upstream URL as well: http://log4c.sourceforge.net/

package/liblog4c-localtime/liblog4c-localtime.mk line 7

Quoted 13 lines
package/liblog4c-localtime/liblog4c-localtime.mk new file +7 -0
new file mode 100644
index 0000000..f0599c3
@@ -0,0 +1,11 @@
+ #############################################################
+ #
+ # liblog4c
+ #
+ #############################################################
+ LIBLOG4C_VERSION = 1.2.1
+ LIBLOG4C_SITE = git://github.com/rcmadruga/log4c-localtime.git

There's also a tarball:
LIBLOG4C_LOCALTIME_VERSION = v1.0
LIBLOG4C_LOCALTIME_SITE = https://github.com/rcmadruga/log4c-localtime/tarball/v$(LIBLOG4C_LOCALTIME_VERSION)

package/liblog4c-localtime/liblog4c-localtime.mk line 11

Quoted 4 lines
package/liblog4c-localtime/liblog4c-localtime.mk new file +4 -0
+ LIBLOG4C_INSTALL_STAGING = YES
+
+ $(eval $(call AUTOTARGETS))
+

Spurious newline at the end.

It looks like it requires expat, so you need "select BR2_PACKAGE_EXPAT"
to Config.in, and "LIBLOG4C_LOCALTIME_DEPENDENCIES = expat" in .mk. You'll probably also need --disable-expattest for cross-compilation.

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F