Skip to contentSkip to conversation

ml507: Fix Xilinx uartlite driver hang

PATCH New Rommel Custodio 2 participants 2 messages Sep 24, 2012 – Oct 5, 2012 Arm/Zynq architecture

lore
Share & tools
lore

Rommel Custodio

author
#0 lore raw

PATCH v2 1/1 ml507: Fix Xilinx uartlite driver hang

The default configuration for ml507 will generate a hang() in the Xilinx uartlite driver.

userial_ports[] in drivers/serial/serial_xuartlite.c does not get initialized properly. CONFIG_SERIAL_BASE is unused. XILINX_UARTLITE_BASEADDR is used instead.

Signed-off-by Rommel Custodio <[email protected]>

---
Changes since v1:
- fixed the path, tabs got mangled causing the patch to fail

 include/configs/xilinx-ppc.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/configs/xilinx-ppc.h +1 -1
index 1235c37..2bdaa05 100644
@@ -118,7 +118,7 @@
 /* serial communication */
 #ifdef XPAR_UARTLITE_0_BASEADDR
 #define CONFIG_XILINX_UARTLITE
-#define CONFIG_SERIAL_BASE		XPAR_UARTLITE_0_BASEADDR
+#define XILINX_UARTLITE_BASEADDR	XPAR_UARTLITE_0_BASEADDR
 #define CONFIG_BAUDRATE			XPAR_UARTLITE_0_BAUDRATE
 #define CONFIG_SYS_BAUDRATE_TABLE	{ CONFIG_BAUDRATE }
 #else
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH v2 1/1 ml507: Fix Xilinx uartlite driver hang

Hi,

Quoted 20 lines · On Mon, 24 Sep 2012 23:27:05 +0000 (UTC) Rommel Custodio…

The default configuration for ml507 will generate a hang() in the Xilinx uartlite driver.

userial_ports[] in drivers/serial/serial_xuartlite.c does not get initialized properly. CONFIG_SERIAL_BASE is unused. XILINX_UARTLITE_BASEADDR is used instead.

Signed-off-by Rommel Custodio <[email protected]>

---
Changes since v1:
- fixed the path, tabs got mangled causing the patch to fail

 include/configs/xilinx-ppc.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/configs/xilinx-ppc.h +0 -0
index 1235c37..2bdaa05 100644

include/configs/xilinx-ppc.h line 124

Quoted 8 lines
include/configs/xilinx-ppc.h +1 -1
@@ -118,7 +118,7 @@
 /* serial communication */
 #ifdef XPAR_UARTLITE_0_BASEADDR
 #define CONFIG_XILINX_UARTLITE
-#define CONFIG_SERIAL_BASE		XPAR_UARTLITE_0_BASEADDR
+#define XILINX_UARTLITE_BASEADDR	XPAR_UARTLITE_0_BASEADDR
 #define CONFIG_BAUDRATE			XPAR_UARTLITE_0_BAUDRATE
 #define CONFIG_SYS_BAUDRATE_TABLE	{ CONFIG_BAUDRATE }
 #else

I think this patch is correct. Applied to staging/agust at denx.de.

Thanks,
Anatolij