usb id addition for Terratec Cinergy T Stick Dual rev. 2

This patch adds support for new Terratec Cinergy T Stick Dual rev. 2.

Signed-off-by Damien Bally <[email protected]>

I will NACK that initially because that USB ID already used by AF9015 driver. You have to explain / study what happens when AF9015 driver claims that device same time.

Quoted 4 lines

I will NACK that initially because that USB ID already used by AF9015 driver. You have to explain / study what happens when AF9015 driver claims that device same time.

Hi Antti

With the Cinergy stick alone, dvb_usb_af9015 is predictably loaded, but doesn't prevent dvb_usb_it913x from working nicely.

If an afatech 9015 stick is connected, such as an AverTV Volar Black HD (A850), it will be recognized and doesn't affect the other device.

*But* it runs into trouble if the two devices were connected at bootup, or if the Cinergy stick is inserted after the other one :

-----------------------------------------------------------------------

[    1.264018] usb 2-1: new high speed USB device using ehci_hcd and
address 2
[    1.382487] usb 2-1: New USB device found, idVendor=0ccd, idProduct=0099
[    1.382490] usb 2-1: New USB device strings: Mfr=1, Product=2,
SerialNumber=0
[    1.382492] usb 2-1: Product: DVB-T TV Stick
[    1.382494] usb 2-1: Manufacturer: ITE Technologies, Inc.
[    1.385073] input: ITE Technologies, Inc. DVB-T TV Stick as
/devices/pci0000:00/0000:00:1d.7/usb2/2-1/2-1:1.1/input/input1
[    1.385147] generic-usb 0003:0CCD:0099.0001: input,hidraw0: USB HID
v1.01 Keyboard [ITE Technologies, Inc. DVB-T TV Stick] on
usb-0000:00:1d.7-1 input1
[    5.045527] usbcore: registered new interface driver dvb_usb_it913x
[    5.147276] it913x: Chip Version=01 Chip Type=9135
[    5.147524] it913x: Firmware Version 33684956
[    5.148649] it913x: Remote HID mode NOT SUPPORTED
[    5.149024] it913x: Dual mode=3 Tuner Type=0
[    5.149028] usb 2-1: dvb_usbv2: found a 'ITE 9135(9006) Generic' in
warm state
[    5.149077] usb 2-1: dvb_usbv2: will pass the complete MPEG2
transport stream to the software demuxer
[    5.149307] DVB: registering new adapter (ITE 9135(9006) Generic)
[    5.174907] usb 1-4: dvb_usbv2: downloading firmware from file
'dvb-usb-af9015.fw'
[    5.241934] usb 1-4: dvb_usbv2: found a 'AverMedia AVerTV Volar Black
HD (A850)' in warm state
[    5.614827] usb 1-4: dvb_usbv2: will pass the complete MPEG2
transport stream to the software demuxer
[    5.614866] DVB: registering new adapter (AverMedia AVerTV Volar
Black HD (A850))
[    5.710026] af9013: firmware version 4.95.0.0
[    5.712151] DVB: registering adapter 1 frontend 0 (Afatech AF9013)...
[    5.813139] MXL5005S: Attached at address 0xc6
[    5.818896] usb 1-4: dvb_usbv2: 'AverMedia AVerTV Volar Black HD
(A850)' successfully initialized and connected
[    7.266161] usb 2-1: dvb_usbv2: 2nd usb_bulk_msg() failed=-110
[    7.266247] it913x-fe: ADF table value    :00
[    9.267200] usb 2-1: dvb_usbv2: 2nd usb_bulk_msg() failed=-110
[   11.267153] usb 2-1: dvb_usbv2: 2nd usb_bulk_msg() failed=-110
[   13.267250] usb 2-1: dvb_usbv2: 2nd usb_bulk_msg() failed=-110
[   15.267089] usb 2-1: dvb_usbv2: 2nd usb_bulk_msg() failed=-110
[   17.267162] usb 2-1: dvb_usbv2: 2nd usb_bulk_msg() failed=-110
[   19.267139] usb 2-1: dvb_usbv2: 2nd usb_bulk_msg() failed=-110
[   19.267218] it913x-fe: Crystal Frequency :12000000 Adc Frequency
:20250000 ADC X2: 01
[   19.267296] usb 2-1: dvb_usbv2: 'ITE 9135(9006) Generic' error while
loading driver (-19)
[   19.267472] usb 2-1: dvb_usbv2: 'ITE 9135(9006) Generic' successfully

deinitialized and disconnected
-----------------------------------------------------------------------

I'm unfortunately not able to rewrite the driver, but I'm willing to provide any information about the device to help its correct identification. Here is what lsusb yields :
-----------------------------------------------------------------------
Bus 002 Device 003: ID 0ccd:0099 TerraTec Electronic GmbH Device Descriptor:
bLength 18
bDescriptorType 1
bcdUSB 2.00

   bDeviceClass            0 (Defined at Interface level)
   bDeviceSubClass         0
   bDeviceProtocol         0
   bMaxPacketSize0        64
   idVendor           0x0ccd TerraTec Electronic GmbH
   idProduct          0x0099
   bcdDevice            2.00
   iManufacturer           1 ITE Technologies, Inc.
   iProduct                2 DVB-T TV Stick
   iSerial                 0
   bNumConfigurations      1

Configuration Descriptor:
bLength 9
bDescriptorType 2
wTotalLength 71
bNumInterfaces 2
bConfigurationValue 1
iConfiguration 0
bmAttributes 0x80
(Bus Powered)
MaxPower 500mA
Interface Descriptor:
bLength 9
bDescriptorType 4
bInterfaceNumber 0
bAlternateSetting 0
bNumEndpoints 4
bInterfaceClass 255 Vendor Specific Class
bInterfaceSubClass 0
bInterfaceProtocol 0
iInterface 0
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x81 EP 1 IN
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0200 1x 512 bytes
bInterval 0
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x02 EP 2 OUT
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0200 1x 512 bytes
bInterval 0
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x84 EP 4 IN
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0200 1x 512 bytes
bInterval 0
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x85 EP 5 IN
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0200 1x 512 bytes
bInterval 0
Interface Descriptor:
bLength 9
bDescriptorType 4
bInterfaceNumber 1
bAlternateSetting 0
bNumEndpoints 1
bInterfaceClass 3 Human Interface Device
bInterfaceSubClass 0 No Subclass
bInterfaceProtocol 1 Keyboard
iInterface 0
HID Device Descriptor:
bLength 9
bDescriptorType 33
bcdHID 1.01
bCountryCode 0 Not supported
bNumDescriptors 1
bDescriptorType 34 Report
wDescriptorLength 65
Report Descriptors:
** UNAVAILABLE **
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x83 EP 3 IN
bmAttributes 3
Transfer Type Interrupt
Synch Type None
Usage Type Data
wMaxPacketSize 0x0040 1x 64 bytes
bInterval 10
Device Qualifier (for other device speed):
bLength 10
bDescriptorType 6
bcdUSB 2.00

   bDeviceClass            0 (Defined at Interface level)
   bDeviceSubClass         0
   bDeviceProtocol         0

bMaxPacketSize0 64
bNumConfigurations 1
Device Status: 0x0000
(Bus Powered)

Hope that helps...

Damien

I am not sure what you do here but let it be clear.
There is same ID used by af9015 and it913x. Both drivers are loaded when that ID appears. What I understand *both* drivers, af9015 and it913x should detect if device is correct or not. If device is af9015 then it913x should reject it with -ENODEV most likely without a I/O. If device is it913x then af9015 should reject the device similarly. And you must find out how to do that. It is not acceptable both drivers starts doing I/O for same device same time.

Quoted 4 lines

I'm unfortunately not able to rewrite the driver, but I'm willing to provide any information about the device to help its correct identification.

Quoted 7 lines · Damien Bally

Quoted 4 lines

I will NACK that initially because that USB ID already used by AF9015 driver. You have to explain / study what happens when AF9015 driver claims that device same time.

Hi Antti

Quoted 8 lines

With the Cinergy stick alone, dvb_usb_af9015 is predictably loaded, but doesn't prevent dvb_usb_it913x from working nicely.

If an afatech 9015 stick is connected, such as an AverTV Volar Black HD (A850), it will be recognized and doesn't affect the other device.

*But* it runs into trouble if the two devices were connected at bootup, or if the Cinergy stick is inserted after the other one :

I am not sure what you do here but let it be clear.
There is same ID used by af9015 and it913x. Both drivers are loaded when that ID appears. What I understand *both* drivers, af9015 and it913x should detect if device is correct or not. If device is af9015 then it913x should reject it with -ENODEV most likely without a I/O. If device is it913x then af9015 should reject the device similarly. And you must find out how to do that. It is not acceptable both drivers starts doing I/O for same device same time.

regards
Antti

Quoted 177 lines

-----------------------------------------------------------------------

[    1.264018] usb 2-1: new high speed USB device using ehci_hcd and
address 2
[    1.382487] usb 2-1: New USB device found, idVendor=0ccd, idProduct=0099
[    1.382490] usb 2-1: New USB device strings: Mfr=1, Product=2,
SerialNumber=0
[    1.382492] usb 2-1: Product: DVB-T TV Stick
[    1.382494] usb 2-1: Manufacturer: ITE Technologies, Inc.
[    1.385073] input: ITE Technologies, Inc. DVB-T TV Stick as
/devices/pci0000:00/0000:00:1d.7/usb2/2-1/2-1:1.1/input/input1
[    1.385147] generic-usb 0003:0CCD:0099.0001: input,hidraw0: USB HID
v1.01 Keyboard [ITE Technologies, Inc. DVB-T TV Stick] on
usb-0000:00:1d.7-1 input1
[    5.045527] usbcore: registered new interface driver dvb_usb_it913x
[    5.147276] it913x: Chip Version=01 Chip Type=9135
[    5.147524] it913x: Firmware Version 33684956
[    5.148649] it913x: Remote HID mode NOT SUPPORTED
[    5.149024] it913x: Dual mode=3 Tuner Type=0
[    5.149028] usb 2-1: dvb_usbv2: found a 'ITE 9135(9006) Generic' in
warm state
[    5.149077] usb 2-1: dvb_usbv2: will pass the complete MPEG2
transport stream to the software demuxer
[    5.149307] DVB: registering new adapter (ITE 9135(9006) Generic)
[    5.174907] usb 1-4: dvb_usbv2: downloading firmware from file
'dvb-usb-af9015.fw'
[    5.241934] usb 1-4: dvb_usbv2: found a 'AverMedia AVerTV Volar Black
HD (A850)' in warm state
[    5.614827] usb 1-4: dvb_usbv2: will pass the complete MPEG2
transport stream to the software demuxer
[    5.614866] DVB: registering new adapter (AverMedia AVerTV Volar
Black HD (A850))
[    5.710026] af9013: firmware version 4.95.0.0
[    5.712151] DVB: registering adapter 1 frontend 0 (Afatech AF9013)...
[    5.813139] MXL5005S: Attached at address 0xc6
[    5.818896] usb 1-4: dvb_usbv2: 'AverMedia AVerTV Volar Black HD
(A850)' successfully initialized and connected
[    7.266161] usb 2-1: dvb_usbv2: 2nd usb_bulk_msg() failed=-110
[    7.266247] it913x-fe: ADF table value    :00
[    9.267200] usb 2-1: dvb_usbv2: 2nd usb_bulk_msg() failed=-110
[   11.267153] usb 2-1: dvb_usbv2: 2nd usb_bulk_msg() failed=-110
[   13.267250] usb 2-1: dvb_usbv2: 2nd usb_bulk_msg() failed=-110
[   15.267089] usb 2-1: dvb_usbv2: 2nd usb_bulk_msg() failed=-110
[   17.267162] usb 2-1: dvb_usbv2: 2nd usb_bulk_msg() failed=-110
[   19.267139] usb 2-1: dvb_usbv2: 2nd usb_bulk_msg() failed=-110
[   19.267218] it913x-fe: Crystal Frequency :12000000 Adc Frequency
:20250000 ADC X2: 01
[   19.267296] usb 2-1: dvb_usbv2: 'ITE 9135(9006) Generic' error while
loading driver (-19)
[   19.267472] usb 2-1: dvb_usbv2: 'ITE 9135(9006) Generic' successfully

deinitialized and disconnected
-----------------------------------------------------------------------

I'm unfortunately not able to rewrite the driver, but I'm willing to provide any information about the device to help its correct identification. Here is what lsusb yields :
-----------------------------------------------------------------------
Bus 002 Device 003: ID 0ccd:0099 TerraTec Electronic GmbH Device Descriptor:
bLength 18
bDescriptorType 1
bcdUSB 2.00

   bDeviceClass            0 (Defined at Interface level)
   bDeviceSubClass         0
   bDeviceProtocol         0
   bMaxPacketSize0        64
   idVendor           0x0ccd TerraTec Electronic GmbH
   idProduct          0x0099
   bcdDevice            2.00
   iManufacturer           1 ITE Technologies, Inc.
   iProduct                2 DVB-T TV Stick
   iSerial                 0
   bNumConfigurations      1

Configuration Descriptor:
bLength 9
bDescriptorType 2
wTotalLength 71
bNumInterfaces 2
bConfigurationValue 1
iConfiguration 0
bmAttributes 0x80
(Bus Powered)
MaxPower 500mA
Interface Descriptor:
bLength 9
bDescriptorType 4
bInterfaceNumber 0
bAlternateSetting 0
bNumEndpoints 4
bInterfaceClass 255 Vendor Specific Class
bInterfaceSubClass 0
bInterfaceProtocol 0
iInterface 0
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x81 EP 1 IN
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0200 1x 512 bytes
bInterval 0
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x02 EP 2 OUT
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0200 1x 512 bytes
bInterval 0
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x84 EP 4 IN
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0200 1x 512 bytes
bInterval 0
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x85 EP 5 IN
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0200 1x 512 bytes
bInterval 0
Interface Descriptor:
bLength 9
bDescriptorType 4
bInterfaceNumber 1
bAlternateSetting 0
bNumEndpoints 1
bInterfaceClass 3 Human Interface Device
bInterfaceSubClass 0 No Subclass
bInterfaceProtocol 1 Keyboard
iInterface 0
HID Device Descriptor:
bLength 9
bDescriptorType 33
bcdHID 1.01
bCountryCode 0 Not supported
bNumDescriptors 1
bDescriptorType 34 Report
wDescriptorLength 65
Report Descriptors:
** UNAVAILABLE **
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x83 EP 3 IN
bmAttributes 3
Transfer Type Interrupt
Synch Type None
Usage Type Data
wMaxPacketSize 0x0040 1x 64 bytes
bInterval 10
Device Qualifier (for other device speed):
bLength 10
bDescriptorType 6
bcdUSB 2.00

   bDeviceClass            0 (Defined at Interface level)
   bDeviceSubClass         0
   bDeviceProtocol         0

bMaxPacketSize0 64
bNumConfigurations 1
Device Status: 0x0000
(Bus Powered)

Hope that helps...

Damien

Quoted 17 lines · Damien Bally

Quoted 7 lines

Quoted 4 lines

I will NACK that initially because that USB ID already used by AF9015 driver. You have to explain / study what happens when AF9015 driver claims that device same time.

Hi Antti

Quoted 8 lines

With the Cinergy stick alone, dvb_usb_af9015 is predictably loaded, but doesn't prevent dvb_usb_it913x from working nicely.

If an afatech 9015 stick is connected, such as an AverTV Volar Black HD (A850), it will be recognized and doesn't affect the other device.

*But* it runs into trouble if the two devices were connected at bootup, or if the Cinergy stick is inserted after the other one :

Quoted 9 lines

I am not sure what you do here but let it be clear.
There is same ID used by af9015 and it913x. Both drivers are loaded when that ID appears. What I understand *both* drivers, af9015 and it913x should detect if device is correct or not. If device is af9015 then it913x should reject it with -ENODEV most likely without a I/O. If device is it913x then af9015 should reject the device similarly. And you must find out how to do that. It is not acceptable both drivers starts doing I/O for same device same time.

Hi All

Which module is loaded first depends on the order in

/lib/modules/$(uname -r)/modules.usbmap

Its is likely that af9015 will be first, so the it913x will need to be loaded first by added it to /etc/modules.

from Damien's email:

idVendor 0x0ccd TerraTec Electronic GmbH
idProduct 0x0099
bcdDevice 2.00
iManufacturer 1 ITE Technologies, Inc.
iProduct 2 DVB-T TV Stick
iSerial 0

If the af9015 variant uses another bcdDevice, the fix should be simple.

It seems that the it931x variant has bcdDevice equal to 2.00,

Quoted 9 lines

from Damien's email:

idVendor 0x0ccd TerraTec Electronic GmbH
idProduct 0x0099
bcdDevice 2.00
iManufacturer 1 ITE Technologies, Inc.
iProduct 2 DVB-T TV Stick
iSerial 0

Quoted 1 line

If the af9015 variant uses another bcdDevice, the fix should be simple.

Alas, according to
http://www.linuxtv.org/wiki/index.php/TerraTec_Cinergy_T_USB_Dual_RC the af9015 variant appears to have the same bcdDevice. I join both lsusb outputs for comparison.

Em Sun, 30 Sep 2012 19:36:50 +0200
Damien Bally <[email protected]> escreveu:

Quoted 13 lines · Mauro Carvalho Chehab

It seems that the it931x variant has bcdDevice equal to 2.00,

Quoted 9 lines

from Damien's email:

idVendor 0x0ccd TerraTec Electronic GmbH
idProduct 0x0099
bcdDevice 2.00
iManufacturer 1 ITE Technologies, Inc.
iProduct 2 DVB-T TV Stick
iSerial 0

Quoted 6 lines

Quoted 1 line

If the af9015 variant uses another bcdDevice, the fix should be simple.

Alas, according to
http://www.linuxtv.org/wiki/index.php/TerraTec_Cinergy_T_USB_Dual_RC the af9015 variant appears to have the same bcdDevice. I join both lsusb outputs for comparison.

Well, then the alternative is to let both drivers to handle this USB ID, and add a code there on each of them that will check if the device is the right one, perhaps by looking at iProduct string. If the driver doesn't recognize it, it should return -ENODEV at .probe() time. The USB core will call the second driver.

Quoted 23 lines

Em Sun, 30 Sep 2012 19:36:50 +0200
Damien Bally <[email protected]> escreveu:

Quoted 13 lines · Mauro Carvalho Chehab

It seems that the it931x variant has bcdDevice equal to 2.00,

Quoted 9 lines

from Damien's email:

idVendor 0x0ccd TerraTec Electronic GmbH
idProduct 0x0099
bcdDevice 2.00
iManufacturer 1 ITE Technologies, Inc.
iProduct 2 DVB-T TV Stick
iSerial 0

Quoted 6 lines

Quoted 1 line

If the af9015 variant uses another bcdDevice, the fix should be simple.

Alas, according to
http://www.linuxtv.org/wiki/index.php/TerraTec_Cinergy_T_USB_Dual_RC the af9015 variant appears to have the same bcdDevice. I join both lsusb outputs for comparison.

Quoted 5 lines

Well, then the alternative is to let both drivers to handle this USB ID, and add a code there on each of them that will check if the device is the right one, perhaps by looking at iProduct string. If the driver doesn't recognize it, it should return -ENODEV at .probe() time. The USB core will call the second driver.

It is the easiest solution, but there should be very careful. Those strings could change from device to device. I used earlier af9015 eeprom hash (those string as coming from the eeprom) to map TerraTec dual remote controller and git bug report quite soon as it didn't worked. After I looked the reason I found out they was changed some not meaningful value.

t. Antti

Em Mon, 01 Oct 2012 14:21:34 +0300
Antti Palosaari <[email protected]> escreveu:

Quoted 30 lines · Mauro Carvalho Chehab

Quoted 23 lines

Em Sun, 30 Sep 2012 19:36:50 +0200
Damien Bally <[email protected]> escreveu:

Quoted 13 lines · Mauro Carvalho Chehab

It seems that the it931x variant has bcdDevice equal to 2.00,

Quoted 9 lines

from Damien's email:

idVendor 0x0ccd TerraTec Electronic GmbH
idProduct 0x0099
bcdDevice 2.00
iManufacturer 1 ITE Technologies, Inc.
iProduct 2 DVB-T TV Stick
iSerial 0

Quoted 6 lines

Quoted 1 line

If the af9015 variant uses another bcdDevice, the fix should be simple.

Alas, according to
http://www.linuxtv.org/wiki/index.php/TerraTec_Cinergy_T_USB_Dual_RC the af9015 variant appears to have the same bcdDevice. I join both lsusb outputs for comparison.

Quoted 5 lines

Well, then the alternative is to let both drivers to handle this USB ID, and add a code there on each of them that will check if the device is the right one, perhaps by looking at iProduct string. If the driver doesn't recognize it, it should return -ENODEV at .probe() time. The USB core will call the second driver.

Quoted 6 lines

It is the easiest solution, but there should be very careful. Those strings could change from device to device. I used earlier af9015 eeprom hash (those string as coming from the eeprom) to map TerraTec dual remote controller and git bug report quite soon as it didn't worked. After I looked the reason I found out they was changed some not meaningful value.

Yeah, those strings can change, especially when vendors don't care enough to use a different USB ID/bcdDevice for different models. Yet, seems to be the cleaner approach, among the alternatives.

Quoted 40 lines · Mauro Carvalho Chehab

Em Mon, 01 Oct 2012 14:21:34 +0300
Antti Palosaari <[email protected]> escreveu:

Quoted 30 lines · Mauro Carvalho Chehab

Quoted 23 lines

Em Sun, 30 Sep 2012 19:36:50 +0200
Damien Bally <[email protected]> escreveu:

Quoted 13 lines · Mauro Carvalho Chehab

It seems that the it931x variant has bcdDevice equal to 2.00,

Quoted 9 lines

from Damien's email:

idVendor 0x0ccd TerraTec Electronic GmbH
idProduct 0x0099
bcdDevice 2.00
iManufacturer 1 ITE Technologies, Inc.
iProduct 2 DVB-T TV Stick
iSerial 0

Quoted 6 lines

Quoted 1 line

If the af9015 variant uses another bcdDevice, the fix should be simple.

Alas, according to
http://www.linuxtv.org/wiki/index.php/TerraTec_Cinergy_T_USB_Dual_RC the af9015 variant appears to have the same bcdDevice. I join both lsusb outputs for comparison.

Quoted 5 lines

Well, then the alternative is to let both drivers to handle this USB ID, and add a code there on each of them that will check if the device is the right one, perhaps by looking at iProduct string. If the driver doesn't recognize it, it should return -ENODEV at .probe() time. The USB core will call the second driver.

Quoted 6 lines

It is the easiest solution, but there should be very careful. Those strings could change from device to device. I used earlier af9015 eeprom hash (those string as coming from the eeprom) to map TerraTec dual remote controller and git bug report quite soon as it didn't worked. After I looked the reason I found out they was changed some not meaningful value.

Quoted 3 lines

Yeah, those strings can change, especially when vendors don't care enough to use a different USB ID/bcdDevice for different models. Yet, seems to be the cleaner approach, among the alternatives.

Damien, care to test?
http://git.linuxtv.org/anttip/media_tree.git/shortlog/refs/heads/it9135_tuner

I split tuner out from IT9135 driver and due to that AF9035 driver supports IT9135 too (difference between AF9035 and IT9135 is integrated RF-tuner). I added iManufacturer based checks for both AF9015 and AF9035 drivers

Quoted 48 lines · Antti Palosaari

Quoted 40 lines · Mauro Carvalho Chehab

Em Mon, 01 Oct 2012 14:21:34 +0300
Antti Palosaari <[email protected]> escreveu:

Quoted 30 lines · Mauro Carvalho Chehab

Quoted 23 lines

Em Sun, 30 Sep 2012 19:36:50 +0200
Damien Bally <[email protected]> escreveu:

Quoted 13 lines · Mauro Carvalho Chehab

It seems that the it931x variant has bcdDevice equal to 2.00,

Quoted 9 lines

from Damien's email:

idVendor 0x0ccd TerraTec Electronic GmbH
idProduct 0x0099
bcdDevice 2.00
iManufacturer 1 ITE Technologies, Inc.
iProduct 2 DVB-T TV Stick
iSerial 0

Quoted 6 lines

Quoted 1 line

If the af9015 variant uses another bcdDevice, the fix should be simple.

Alas, according to
http://www.linuxtv.org/wiki/index.php/TerraTec_Cinergy_T_USB_Dual_RC the af9015 variant appears to have the same bcdDevice. I join both lsusb outputs for comparison.

Quoted 5 lines

Well, then the alternative is to let both drivers to handle this USB ID, and add a code there on each of them that will check if the device is the right one, perhaps by looking at iProduct string. If the driver doesn't recognize it, it should return -ENODEV at .probe() time. The USB core will call the second driver.

Quoted 6 lines

It is the easiest solution, but there should be very careful. Those strings could change from device to device. I used earlier af9015 eeprom hash (those string as coming from the eeprom) to map TerraTec dual remote controller and git bug report quite soon as it didn't worked. After I looked the reason I found out they was changed some not meaningful value.

Quoted 3 lines

Yeah, those strings can change, especially when vendors don't care enough to use a different USB ID/bcdDevice for different models. Yet, seems to be the cleaner approach, among the alternatives.

Damien, care to test?
http://git.linuxtv.org/anttip/media_tree.git/shortlog/refs/heads/it9135_tuner

Quoted 4 lines

I split tuner out from IT9135 driver and due to that AF9035 driver supports IT9135 too (difference between AF9035 and IT9135 is integrated RF-tuner). I added iManufacturer based checks for both AF9015 and AF9035 drivers

I can't see the point of adding this to the af9035/af9033 driver. It is going to turn into one enormous blob.

The it913x is a stable driver and has it own entity moving forward.

The only thing that needs to happen is the id is added to it913x driver and if it doesn't apply drop it.

Nack.