Skip to contentSkip to conversation

ARM: picoxcell: remove unnecessary header common.h

PATCH Superseded Tobias Klauser 2 participants 2 messages Oct 5, 2012 – Oct 8, 2012

Subsystems (2)
Arm (32-bit) Arm sub-architectures
lore
Share & tools
lore

Tobias Klauser

author
#0 lore raw

PATCH 1/1 ARM: picoxcell: remove unnecessary header common.h

Since commit 66314223 ("ARM: socfpga: initial support for Altera's SOCFPGA platform") struct sys_timer dw_apb_timer is an extern in <linux/dw_apb_timer.h>, so there is no need for common.h anymore, instead directly #include <asm/mach/time.h> in common.c

Signed-off-by Tobias Klauser <[email protected]>
---
 arch/arm/mach-picoxcell/common.c |    3 +--
 arch/arm/mach-picoxcell/common.h |   17 -----------------
 2 files changed, 1 insertions(+), 19 deletions(-)
 delete mode 100644 arch/arm/mach-picoxcell/common.h
arch/arm/mach-picoxcell/common.c +1 -2
index f6c0849..bc36f12 100644
@@ -19,8 +19,7 @@
 #include <asm/mach/arch.h>
 #include <asm/hardware/vic.h>
 #include <asm/mach/map.h>
-
-#include "common.h"
+#include <asm/mach/time.h>
 
 #define PHYS_TO_IO(x)			(((x) & 0x00ffffff) | 0xfe000000)
 #define PICOXCELL_PERIPH_BASE		0x80000000
arch/arm/mach-picoxcell/common.h deleted +0 -17
deleted file mode 100644
index a65cb02..0000000
@@ -1,17 +0,0 @@
-/*
- * Copyright (c) 2011 Picochip Ltd., Jamie Iles
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License version 2 as
- * published by the Free Software Foundation.
- *
- * All enquiries to support at picochip.com
- */
-#ifndef __PICOXCELL_COMMON_H__
-#define __PICOXCELL_COMMON_H__
-
-#include <asm/mach/time.h>
-
-extern struct sys_timer dw_apb_timer;
-
-#endif /* __PICOXCELL_COMMON_H__ */
Signature · 1 line
1.7.5.4
#1 lore raw

PATCH 1/1 ARM: picoxcell: remove unnecessary header common.h

Looks good, thanks Tobias!

Quoted 6 lines · Tobias Klauser

Since commit 66314223 ("ARM: socfpga: initial support for Altera's SOCFPGA platform") struct sys_timer dw_apb_timer is an extern in <linux/dw_apb_timer.h>, so there is no need for common.h anymore, instead directly #include <asm/mach/time.h> in common.c

Signed-off-by Tobias Klauser <[email protected]>
Acked-by Jamie Iles <[email protected]>