Skip to contentSkip to conversation

mtd: m25p80: fix missing MTD module owner

PATCH In review Grégor Boirie 3 participants 3 messages Oct 8, 2012 – Oct 11, 2012 Memory technology devices (MTD)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mtd: m25p80: fix missing MTD module owner

Marek,

Sorry about that. I didn't really mean to submit an official patch at first...
Nevermind, please find one just below.

Regards,
gregor

---
 drivers/mtd/devices/m25p80.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/mtd/devices/m25p80.c +0 -0
index 1924d24..06beb3f 100644
@@ -873,6 +873,7 @@ static int __devinit m25p_probe(struct spi_device *spi)
 	else
 		flash->mtd.name = dev_name(&spi->dev);
 +	flash->mtd.owner = THIS_MODULE;
 	flash->mtd.type = MTD_NORFLASH;
 	flash->mtd.writesize = 1;
 	flash->mtd.flags = MTD_CAP_NORFLASH;
Signature · 1 line
1.7.4.1
#1 lore raw

Dear Grégor Boirie,

Quoted 4 lines

Marek,

Sorry about that. I didn't really mean to submit an official patch at first...

No no, nothing to be sorry about actually, we're really grateful you spotted the issue and reported it!

Quoted 1 line

Nevermind, please find one just below.

Actually, can you try one more time and after commiting the change to your local git tree, do "git send-email --to="[email protected]" HEAD~1" please?

Also, it is a good idea to add "Cc: Name Surname <[email protected]>" lines to the patch description just before the Signed-off-by line so that the people who will end up applying it are CCed. That's at least Artem.

Quoted 12 lines

Regards,
gregor

---
 drivers/mtd/devices/m25p80.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/mtd/devices/m25p80.c +0 -0
index 1924d24..06beb3f 100644

drivers/mtd/devices/m25p80.c static int __devinit m25p_probe(struct spi_device *spi) · line 878

Quoted 6 lines
drivers/mtd/devices/m25p80.c +0 -0
@@ -873,6 +873,7 @@ static int __devinit m25p_probe(struct spi_device *spi)
 	else
 		flash->mtd.name = dev_name(&spi->dev);
 +	flash->mtd.owner = THIS_MODULE;
 	flash->mtd.type = MTD_NORFLASH;
 	flash->mtd.writesize = 1;
 	flash->mtd.flags = MTD_CAP_NORFLASH;

Best regards,
Marek Vasut

#2 lore raw
In reply to Grégor Boirie
Quoted 5 lines · Grégor Boirie

Marek,

Sorry about that. I didn't really mean to submit an official patch at first...
Nevermind, please find one just below.

It misses a nice commit message and Signed-off-by. Please, try again. Or I can do it for you if you want (please, let me know), but then I will be the patch author.

Also, please add the stable tree tag there, as this is a bugfix which is worth having in -stable.

Signature · 2 lines
Best Regards,
Artem Bityutskiy