fix btrfs-progs build
Hello everybody,
man pages for btrfs-progs are compressed by gzip by default. In Makefile the variable GZIP is use, this evaluates to 'gzip gzip' on my system. From man gzip:
Quoted 3 lines
The environment variable GZIP can hold a set of default options for gzip. These options are interpreted first and can be overwritten by explicit command line parameters.
So using any other variable name fixes this. Patch is attached.
Signature · 3 lines
main(a){char*c=/* Schoene Gruesse */"B?IJj;MEH"
"CX:;",b;for(a/* Chris get my mail address: */=0;b=c[a++];)
putchar(b-1/(/* gcc -o sig sig.c && ./sig */b/42*2-3)*42);}man/Makefile +7 -7
@@ -1,4 +1,4 @@ -GZIP=gzip +GZIPCMD=gzip INSTALL= install prefix ?= /usr/local
@@ -12,22 +12,22 @@ MANPAGES = mkfs.btrfs.8.gz btrfsctl.8.gz btrfsck.8.gz btrfs-image.8.gz \ all: $(MANPAGES) mkfs.btrfs.8.gz: mkfs.btrfs.8.in - $(GZIP) -n -c mkfs.btrfs.8.in > mkfs.btrfs.8.gz + $(GZIPCMD) -n -c mkfs.btrfs.8.in > mkfs.btrfs.8.gz btrfs.8.gz: btrfs.8.in - $(GZIP) -n -c btrfs.8.in > btrfs.8.gz + $(GZIPCMD) -n -c btrfs.8.in > btrfs.8.gz btrfsctl.8.gz: btrfsctl.8.in - $(GZIP) -n -c btrfsctl.8.in > btrfsctl.8.gz + $(GZIPCMD) -n -c btrfsctl.8.in > btrfsctl.8.gz btrfsck.8.gz: btrfsck.8.in - $(GZIP) -n -c btrfsck.8.in > btrfsck.8.gz + $(GZIPCMD) -n -c btrfsck.8.in > btrfsck.8.gz btrfs-image.8.gz: btrfs-image.8.in - $(GZIP) -n -c btrfs-image.8.in > btrfs-image.8.gz + $(GZIPCMD) -n -c btrfs-image.8.in > btrfs-image.8.gz btrfs-show.8.gz: btrfs-show.8.in - $(GZIP) -n -c btrfs-show.8.in > btrfs-show.8.gz + $(GZIPCMD) -n -c btrfs-show.8.in > btrfs-show.8.gz clean : rm -f $(MANPAGES)
Quoted 11 lines · Christian Hesse
Hello everybody,
man pages for btrfs-progs are compressed by gzip by default. In
Makefilethe variable GZIP is use, this evaluates to 'gzip gzip' on my system. From man gzip:Quoted 3 lines
The environment variable GZIP can hold a set of default options for gzip. These options are interpreted first and can be overwritten by explicit command line parameters.
So using any other variable name fixes this. Patch is attached.
Ok, which system is this? Just curious, I'll pull in the patch.
-chris
Chris Mason <[email protected]> on Mon, 2012/10/08 10:29:
Quoted 7 lines · Christian Hesse
Quoted 6 lines
Hello everybody,
man pages for btrfs-progs are compressed by gzip by default. In
Makefilethe variable GZIP is use, this evaluates to 'gzip gzip' on my system. From man gzip:
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
The environment variable GZIP can hold a set of default options for gzip. These options are interpreted first and can be overwritten by explicit command line parameters.
So using any other variable name fixes this. Patch is attached.
Ok, which system is this? Just curious, I'll pull in the patch.
This is Arch Linux with gzip 1.5-1.
Signature · 3 lines
main(a){char*c=/* Schoene Gruesse */"B?IJj;MEH"
"CX:;",b;for(a/* Chris get my mail address: */=0;b=c[a++];)
putchar(b-1/(/* gcc -o sig sig.c && ./sig */b/42*2-3)*42);}Quoted 12 lines · Christian Hesse
Chris Mason <[email protected]> on Mon, 2012/10/08 10:29:
Quoted 11 lines · Christian Hesse
Quoted 10 lines
Hello everybody,
man pages for btrfs-progs are compressed by gzip by default. In
Makefilethe variable GZIP is use, this evaluates to 'gzip gzip' on my system. From man gzip:Quoted 3 lines
The environment variable GZIP can hold a set of default options for gzip. These options are interpreted first and can be overwritten by explicit command line parameters.
Quoted 5 lines
Quoted 3 lines
Quoted 1 line
So using any other variable name fixes this. Patch is attached.
Ok, which system is this? Just curious, I'll pull in the patch.
This is Arch Linux with gzip 1.5-1.
Strange, I'm running running arch linux with gzip 1.5-1 and it builds. I wonder if something else is expanding it. I'll take the patch regardless, there's no reason to add build problems when we don't need to.
-chris
Chris Mason <[email protected]> on Mon, 2012/10/08 10:33:
Quoted 15 lines · Christian Hesse
Quoted 14 lines
Chris Mason <[email protected]> on Mon, 2012/10/08 10:29:
Quoted 13 lines · Christian Hesse
Quoted 11 lines
Hello everybody,
man pages for btrfs-progs are compressed by gzip by default. In
Makefilethe variable GZIP is use, this evaluates to 'gzip gzip' on my system. From man gzip:Quoted 3 lines
The environment variable GZIP can hold a set of default options for gzip. These options are interpreted first and can be overwritten by explicit command line parameters.
So using any other variable name fixes this. Patch is attached.
Quoted 8 lines
Quoted 3 lines
Quoted 1 line
Ok, which system is this? Just curious, I'll pull in the patch.
This is Arch Linux with gzip 1.5-1.
Strange, I'm running running arch linux with gzip 1.5-1 and it builds. I wonder if something else is expanding it. I'll take the patch regardless, there's no reason to add build problems when we don't need to.
This happens if you have exported GZIP to your environment. So probably most people are not effected.
Signature · 3 lines
main(a){char*c=/* Schoene Gruesse */"B?IJj;MEH"
"CX:;",b;for(a/* Chris get my mail address: */=0;b=c[a++];)
putchar(b-1/(/* gcc -o sig sig.c && ./sig */b/42*2-3)*42);}