arm: make FORCE_MAX_ZONEORDER configurable for TI AM33XX

PATCH New yegorslists at googlemail.com 5 participants 10 messages Jul 3, 2012 – Oct 8, 2012 Arm (32-bit)

lore

Share & tools

lore

yegorslists at googlemail.com

author

2012-07-03 14:20 UTC #0 lore raw

PATCH 1/1 arm: make FORCE_MAX_ZONEORDER configurable for TI AM33XX

From: Yegor Yefremov <[email protected]>

FORCE_MAX_ZONEORDER of 12 is needed to allocation more than 4MB of consistent DMA memory (da8xx frame buffer driver).

Signed-off-by Dejan Gacnik <[email protected]>

Signed-off-by Yegor Yefremov <[email protected]>

---
 arch/arm/Kconfig |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

arch/arm/Kconfig +3 -2

index e876819..ff14c1e 100644
@@ -1725,8 +1725,9 @@ config HW_PERF_EVENTS
 source "mm/Kconfig"
 
 config FORCE_MAX_ZONEORDER
-	int "Maximum zone order" if ARCH_SHMOBILE
-	range 11 64 if ARCH_SHMOBILE
+	int "Maximum zone order"
+	depends on ARCH_SHMOBILE || SOC_AM33XX
+	range 11 64 if ARCH_SHMOBILE || SOC_AM33XX
 	default "9" if SA1111
 	default "11"
 	help

Signature · 1 line

1.7.7

Tony Lindgren

2012-09-24 17:18 UTC #1 lore raw

PATCH 1/1 arm: make FORCE_MAX_ZONEORDER configurable for TI AM33XX

Quoted 4 lines · yegorslists at googlemail.com

From: Yegor Yefremov <[email protected]>
FORCE_MAX_ZONEORDER of 12 is needed to allocation more than 4MB of consistent DMA memory (da8xx frame buffer driver).

Sorry for the delay on this one, looks like this one is still valid. I'll apply it.

Regards,

Tony

Quoted 29 lines

Signed-off-by Dejan Gacnik <[email protected]>

Signed-off-by Yegor Yefremov <[email protected]>

---
 arch/arm/Kconfig |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

arch/arm/Kconfig +3 -2

index e876819..ff14c1e 100644
@@ -1725,8 +1725,9 @@ config HW_PERF_EVENTS
 source "mm/Kconfig"
 
 config FORCE_MAX_ZONEORDER
-	int "Maximum zone order" if ARCH_SHMOBILE
-	range 11 64 if ARCH_SHMOBILE
+	int "Maximum zone order"
+	depends on ARCH_SHMOBILE || SOC_AM33XX
+	range 11 64 if ARCH_SHMOBILE || SOC_AM33XX
 	default "9" if SA1111
 	default "11"
 	help

Signature · 6 lines

1.7.7

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Yegor Yefremov

author

2012-09-24 19:05 UTC #2 lore raw

PATCH 1/1 arm: make FORCE_MAX_ZONEORDER configurable for TI AM33XX

Quoted 8 lines · Tony Lindgren

Quoted 4 lines · yegorslists at googlemail.com
From: Yegor Yefremov <[email protected]>
FORCE_MAX_ZONEORDER of 12 is needed to allocation more than 4MB of consistent DMA memory (da8xx frame buffer driver).
Sorry for the delay on this one, looks like this one is still valid. I'll apply it.

Thanks.

Yegor

Quoted 29 lines

Quoted 29 lines
Signed-off-by Dejan Gacnik <[email protected]>
Signed-off-by Yegor Yefremov <[email protected]>
---
 arch/arm/Kconfig |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
arch/arm/Kconfig +3 -3
index e876819..ff14c1e 100644
@@ -1725,8 +1725,9 @@ config HW_PERF_EVENTS
 source "mm/Kconfig"
 
 config FORCE_MAX_ZONEORDER
-     int "Maximum zone order" if ARCH_SHMOBILE
-     range 11 64 if ARCH_SHMOBILE
+     int "Maximum zone order"
+     depends on ARCH_SHMOBILE || SOC_AM33XX
+     range 11 64 if ARCH_SHMOBILE || SOC_AM33XX
      default "9" if SA1111
      default "11"
      help
--
1.7.7
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

Russell King - ARM Linux

2012-09-24 23:16 UTC #3 lore raw

PATCH 1/1 arm: make FORCE_MAX_ZONEORDER configurable for TI AM33XX

Quoted 27 lines · Yegor Yefremov

Quoted 8 lines · Tony Lindgren
Quoted 4 lines · yegorslists at googlemail.com
From: Yegor Yefremov <[email protected]>
FORCE_MAX_ZONEORDER of 12 is needed to allocation more than 4MB of consistent DMA memory (da8xx frame buffer driver).
Sorry for the delay on this one, looks like this one is still valid. I'll apply it.
Thanks.
Yegor
Quoted 13 lines
Quoted 13 lines
Signed-off-by Dejan Gacnik <[email protected]>
Signed-off-by Yegor Yefremov <[email protected]>
---
 arch/arm/Kconfig |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
arch/arm/Kconfig +0 -0
index e876819..ff14c1e 100644
@@ -1725,8 +1725,9 @@ config HW_PERF_EVENTS
 source "mm/Kconfig"
 

Quoted 8 lines

arch/arm/Kconfig config HW_PERF_EVENTS · line 1732

Quoted 8 lines

arch/arm/Kconfig +3 -2

 config FORCE_MAX_ZONEORDER
-     int "Maximum zone order" if ARCH_SHMOBILE
-     range 11 64 if ARCH_SHMOBILE
+     int "Maximum zone order"
+     depends on ARCH_SHMOBILE || SOC_AM33XX
+     range 11 64 if ARCH_SHMOBILE || SOC_AM33XX
      default "9" if SA1111
      default "11"

NAK. This patch breaks SA1111 platforms. To see why, read the patch.

Tony Lindgren

2012-09-25 00:37 UTC #4 lore raw

PATCH 1/1 arm: make FORCE_MAX_ZONEORDER configurable for TI AM33XX

Quoted 28 lines · Russell King - ARM Linux

Quoted 27 lines · Yegor Yefremov
Quoted 8 lines · Tony Lindgren
Quoted 4 lines · yegorslists at googlemail.com
From: Yegor Yefremov <[email protected]>
FORCE_MAX_ZONEORDER of 12 is needed to allocation more than 4MB of consistent DMA memory (da8xx frame buffer driver).
Sorry for the delay on this one, looks like this one is still valid. I'll apply it.
Thanks.
Yegor
Quoted 13 lines
Quoted 13 lines
Signed-off-by Dejan Gacnik <[email protected]>
Signed-off-by Yegor Yefremov <[email protected]>
---
 arch/arm/Kconfig |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
arch/arm/Kconfig +0 -0
index e876819..ff14c1e 100644
@@ -1725,8 +1725,9 @@ config HW_PERF_EVENTS
 source "mm/Kconfig"
 

Quoted 10 lines

Quoted 8 lines
Quoted 8 lines
arch/arm/Kconfig config HW_PERF_EVENTS · line 1732
Quoted 8 lines
arch/arm/Kconfig +3 -2
 config FORCE_MAX_ZONEORDER
-     int "Maximum zone order" if ARCH_SHMOBILE
-     range 11 64 if ARCH_SHMOBILE
+     int "Maximum zone order"
+     depends on ARCH_SHMOBILE || SOC_AM33XX
+     range 11 64 if ARCH_SHMOBILE || SOC_AM33XX
      default "9" if SA1111
      default "11"
NAK. This patch breaks SA1111 platforms. To see why, read the patch.

OK let's drop this.

Tony

Yegor Yefremov

2012-09-25 08:05 UTC #5 lore raw

PATCH 1/1 arm: make FORCE_MAX_ZONEORDER configurable for TI AM33XX

Quoted 40 lines · Tony Lindgren

Quoted 28 lines · Russell King - ARM Linux
Quoted 27 lines · Yegor Yefremov
Quoted 8 lines · Tony Lindgren
Quoted 4 lines · yegorslists at googlemail.com
From: Yegor Yefremov <[email protected]>
FORCE_MAX_ZONEORDER of 12 is needed to allocation more than 4MB of consistent DMA memory (da8xx frame buffer driver).
Sorry for the delay on this one, looks like this one is still valid. I'll apply it.
Thanks.
Yegor
Quoted 13 lines
Quoted 13 lines
Signed-off-by Dejan Gacnik <[email protected]>
Signed-off-by Yegor Yefremov <[email protected]>
---
 arch/arm/Kconfig |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
arch/arm/Kconfig +0 -0
index e876819..ff14c1e 100644
@@ -1725,8 +1725,9 @@ config HW_PERF_EVENTS
 source "mm/Kconfig"
 
Quoted 10 lines
Quoted 8 lines
Quoted 8 lines
arch/arm/Kconfig config HW_PERF_EVENTS · line 1732
Quoted 8 lines
arch/arm/Kconfig +3 -2
 config FORCE_MAX_ZONEORDER
-     int "Maximum zone order" if ARCH_SHMOBILE
-     range 11 64 if ARCH_SHMOBILE
+     int "Maximum zone order"
+     depends on ARCH_SHMOBILE || SOC_AM33XX
+     range 11 64 if ARCH_SHMOBILE || SOC_AM33XX
      default "9" if SA1111
      default "11"
NAK. This patch breaks SA1111 platforms. To see why, read the patch.

Quoted 1 line

OK let's drop this.

How should I change the patch to make it proper? SA1111 is broken anyway:

config FORCE_MAX_ZONEORDER
int "Maximum zone order" if ARCH_SHMOBILE
range 11 64 if ARCH_SHMOBILE
default "9" if SA1111
default "11"

AFAIK if ARCH_SHMOBILE defines dependency on ARCH_SHMOBILE, so SA1111 won't be evaluated (at least if I select SA1111 include/generated/autoconf.h shows "11"). If I add SA1111 to dependency list like this:

depends on ARCH_SHMOBILE || SOC_AM33XX || SA1111

the prompt in "Kernel features" becomes visible, but it doesn't have the default value of "9", but "11".

Am I missing something?

Yegor

Russell King - ARM Linux

2012-09-25 08:14 UTC #6 lore raw

PATCH 1/1 arm: make FORCE_MAX_ZONEORDER configurable for TI AM33XX

Quoted 1 line · Yegor Yefremov

How should I change the patch to make it proper? SA1111 is broken anyway:

No it isn't. This is what it produces _today_, and has done for the last 5-10 years without modification

# CONFIG_CLEANCACHE is not set
# CONFIG_FRONTSWAP is not set
CONFIG_FORCE_MAX_ZONEORDER=9
CONFIG_LEDS=y
CONFIG_LEDS_CPU=y

Quoted 7 lines

config FORCE_MAX_ZONEORDER
int "Maximum zone order" if ARCH_SHMOBILE
range 11 64 if ARCH_SHMOBILE
default "9" if SA1111
default "11"
AFAIK if ARCH_SHMOBILE defines dependency on ARCH_SHMOBILE,

No it doens't.

int "Maximum zone order" if ARCH_SHMOBILE

is far from being the same as:

int "Maximum zone order"
depends on ARCH_SHMOBILE

The former defines a condition upon which the option is offered in GUIs - or to put it another way, it defines the visibility of the option.

The latter defines a dependency which must be met for the option to be both visible and appear in the resulting configuration file.

Quoted 1 line

so SA1111 won't be evaluated (at least if I select SA1111

And did you check that SA1111 remains selected? I bet you didn't. Or maybe you tested your patched version. Whatever. The original works, and has been known to work for years. Your patch breaks it. It's really as simple as that.

Yegor Yefremov

2012-09-25 08:28 UTC #7 lore raw

PATCH 1/1 arm: make FORCE_MAX_ZONEORDER configurable for TI AM33XX

Quoted 30 lines · Russell King - ARM Linux

Quoted 1 line · Yegor Yefremov
How should I change the patch to make it proper? SA1111 is broken anyway:
No it isn't. This is what it produces _today_, and has done for the last 5-10 years without modification
# CONFIG_CLEANCACHE is not set
# CONFIG_FRONTSWAP is not set
CONFIG_FORCE_MAX_ZONEORDER=9
CONFIG_LEDS=y
CONFIG_LEDS_CPU=y
Quoted 7 lines
config FORCE_MAX_ZONEORDER
int "Maximum zone order" if ARCH_SHMOBILE
range 11 64 if ARCH_SHMOBILE
default "9" if SA1111
default "11"
AFAIK if ARCH_SHMOBILE defines dependency on ARCH_SHMOBILE,
No it doens't.
int "Maximum zone order" if ARCH_SHMOBILE
is far from being the same as:
int "Maximum zone order"
depends on ARCH_SHMOBILE
The former defines a condition upon which the option is offered in GUIs - or to put it another way, it defines the visibility of the option.

Quoted 8 lines

The latter defines a dependency which must be met for the option to be both visible and appear in the resulting configuration file.
Quoted 1 line
so SA1111 won't be evaluated (at least if I select SA1111
And did you check that SA1111 remains selected? I bet you didn't. Or maybe you tested your patched version. Whatever. The original works, and has been known to work for years. Your patch breaks it. It's really as simple as that.

Thanks for explanation. I think I've got it now. Please review the v2 version.

Yegor

Dejan Gačnik

2012-09-27 14:12 UTC #8 lore raw

PATCH 1/1 arm: make FORCE_MAX_ZONEORDER configurable for TI AM33XX

Dear Tony

Thank you for applying this patch. I am quite new in such things as is posting patched to the community, therefore Yegor help me on this manner.

Anyway, I have one more challenging question/request.

I and my colleagues have developed a brand new very enhanced board having AM35xx CPU, 512MB DDR2, DVI, true dual Ethernet support (not using PRUSS), CAN, SPI, I2C, 7 USBs, etc?Board is already materialized and operational.

According to our board we have create new machine type in the kernel (version: linux-3.2-psp04.06.00.07.sdk) and all other required stuff to support our board, modify some things, like adding support for dual eth, etc. Our goal is to provide this new board to the market (let say with large quantity) and therefore I am wondering how to start or if it is even possible to transfer our kernel change the main stream of this distro? During this kernel modification process we have been looking to not changing anything in kernel, what could affect other machine types.

Thank you for you answer, and looking forward to receive your replay.

Best regards,
Dejan

2012/9/25 Yegor Yefremov <[email protected]>

Quoted 41 lines · Russell King - ARM Linux

Quoted 2 lines · Yegor Yefremov
Quoted 1 line
How should I change the patch to make it proper? SA1111 is broken
anyway:
Quoted 28 lines
No it isn't. This is what it produces _today_, and has done for the last 5-10 years without modification
# CONFIG_CLEANCACHE is not set
# CONFIG_FRONTSWAP is not set
CONFIG_FORCE_MAX_ZONEORDER=9
CONFIG_LEDS=y
CONFIG_LEDS_CPU=y
Quoted 7 lines
config FORCE_MAX_ZONEORDER
int "Maximum zone order" if ARCH_SHMOBILE
range 11 64 if ARCH_SHMOBILE
default "9" if SA1111
default "11"
AFAIK if ARCH_SHMOBILE defines dependency on ARCH_SHMOBILE,
No it doens't.
int "Maximum zone order" if ARCH_SHMOBILE
is far from being the same as:
int "Maximum zone order"
depends on ARCH_SHMOBILE
The former defines a condition upon which the option is offered in GUIs - or to put it another way, it defines the visibility of the option.
Quoted 8 lines
The latter defines a dependency which must be met for the option to be both visible and appear in the resulting configuration file.
Quoted 1 line
so SA1111 won't be evaluated (at least if I select SA1111
And did you check that SA1111 remains selected? I bet you didn't. Or maybe you tested your patched version. Whatever. The original works, and has been known to work for years. Your patch breaks it. It's really as simple as that.

Quoted 6 lines

Thanks for explanation. I think I've got it now. Please review the v2 version.
Yegor

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120927/0d880bab/attachment-0001.html>

Tony Lindgren

2012-10-08 20:55 UTC #9 lore raw

PATCH 1/1 arm: make FORCE_MAX_ZONEORDER configurable for TI AM33XX

Quoted 6 lines · Dejan Ga?nik

I and my colleagues have developed a brand new very enhanced board having AM35xx CPU, 512MB DDR2, DVI, true dual Ethernet support (not using PRUSS), CAN, SPI, I2C, 7 USBs, etc?Board is already materialized and operational.

Quoted 8 lines

According to our board we have create new machine type in the kernel (version: linux-3.2-psp04.06.00.07.sdk) and all other required stuff to support our board, modify some things, like adding support for dual eth, etc. Our goal is to provide this new board to the market (let say with large quantity) and therefore I am wondering how to start or if it is even possible to transfer our kernel change the main stream of this distro? During this kernel modification process we have been looking to not changing anything in kernel, what could affect other machine types.

For the mainline kernel, you should go with device tree based booting to start with, we are no longer adding new board-*.c files. For older distro kernels you need to maintain a separate board-*.c file until we have moved everything to use device tree and distros are using that kernel.

Regards,

Tony