ARM: OMAP2+: Round of the carve out memory requested to section_size

PATCH New R Sricharan 3 participants 3 messages Sep 12, 2012 – Oct 8, 2012

Subsystems (3)

Arm (32-bit) Arm sub-architectures OMAP2+ support

lore

Share & tools

lore

R Sricharan

author

2012-09-12 07:14 UTC #0 lore raw

PATCH v2 1/1 ARM: OMAP2+: Round of the carve out memory requested to section_size

memblock_steal tries to reserve physical memory during boot. When the requested size is not aligned on the section size then, the remaining memory available for lowmem becomes unaligned on the section boundary. There is a issue with this, which is discussed in the thread below.

https://lkml.org/lkml/2012/6/28/112

The final conclusion from the thread seems to
be align the memblock_steal calls on the SECTION boundary. The issue comes out when LPAE is enabled, where the section size is 2MB.

Boot tested this on OMAP5 evm with and without LPAE.

Signed-off-by R Sricharan <[email protected]>

---
[V2] Corrected the subject and added one more description line.

 arch/arm/mach-omap2/omap-secure.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

arch/arm/mach-omap2/omap-secure.c +2 -2

index d9ae4a5..26edfec 100644
@@ -61,8 +61,8 @@ int __init omap_secure_ram_reserve_memblock(void)
 {
 	u32 size = OMAP_SECURE_RAM_STORAGE;
 
-	size = ALIGN(size, SZ_1M);
-	omap_secure_memblock_base = arm_memblock_steal(size, SZ_1M);
+	size = ALIGN(size, SECTION_SIZE);
+	omap_secure_memblock_base = arm_memblock_steal(size, SECTION_SIZE);
 
 	return 0;
 }

Signature · 1 line

1.7.9.5

Shilimkar, Santosh

2012-09-28 06:33 UTC #1 lore raw

PATCH v2 1/1 ARM: OMAP2+: Round of the carve out memory requested to section_size

Quoted 13 lines · R Sricharan

memblock_steal tries to reserve physical memory during boot. When the requested size is not aligned on the section size then, the remaining memory available for lowmem becomes unaligned on the section boundary. There is a issue with this, which is discussed in the thread below.
https://lkml.org/lkml/2012/6/28/112
The final conclusion from the thread seems to
be align the memblock_steal calls on the SECTION boundary. The issue comes out when LPAE is enabled, where the section size is 2MB.

Quoted 6 lines

Boot tested this on OMAP5 evm with and without LPAE.
Signed-off-by R Sricharan <[email protected]>
---
[V2] Corrected the subject and added one more description line.

Looks good.

Acked-by Santosh Shilimkar <[email protected]>

Tony,
Can you take this into your next "fixes-noncritical" queue please ?

Regards,
Santosh

Tony Lindgren

maintainer

2012-10-08 21:05 UTC #2 lore raw

PATCH v2 1/1 ARM: OMAP2+: Round of the carve out memory requested to section_size

Quoted 20 lines · Shilimkar, Santosh

Quoted 13 lines · R Sricharan
memblock_steal tries to reserve physical memory during boot. When the requested size is not aligned on the section size then, the remaining memory available for lowmem becomes unaligned on the section boundary. There is a issue with this, which is discussed in the thread below.
https://lkml.org/lkml/2012/6/28/112
The final conclusion from the thread seems to
be align the memblock_steal calls on the SECTION boundary. The issue comes out when LPAE is enabled, where the section size is 2MB.
Quoted 6 lines
Boot tested this on OMAP5 evm with and without LPAE.
Signed-off-by R Sricharan <[email protected]>
---
[V2] Corrected the subject and added one more description line.

Quoted 5 lines

Looks good.
Acked-by Santosh Shilimkar <[email protected]>
Tony,
Can you take this into your next "fixes-noncritical" queue please ?

Applying it now into fixes for the -rc cycle.

Regards,

Tony