Skip to contentSkip to conversation

ARM: OMAP: OMAP_DEBUG_LEDS needs to select LEDS_CLASS

PATCH In review Axel Lin 3 participants 5 messages Sep 18, 2012 – Oct 8, 2012

Subsystems (2)
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 ARM: OMAP: OMAP_DEBUG_LEDS needs to select LEDS_CLASS

This fixes below build error when CONFIG_LEDS_CLASS is not set.

LD init/built-in.o
arch/arm/plat-omap/built-in.o: In function `fpga_probe':
arch/arm/plat-omap/debug-leds.c:113: undefined reference to `led_classdev_register'
make: *** [vmlinux] Error 1

---
 arch/arm/plat-omap/Kconfig |    1 +
 1 file changed, 1 insertion(+)
arch/arm/plat-omap/Kconfig +1 -0
index ca83a76..c262781 100644
@@ -43,6 +43,7 @@ config OMAP_DEBUG_DEVICES
 
 config OMAP_DEBUG_LEDS
 	def_bool y if NEW_LEDS
+	select LEDS_CLASS
 	depends on OMAP_DEBUG_DEVICES
 
 config POWER_AVS_OMAP
Signature · 1 line
1.7.9.5
#1 lore raw
Quoted 7 lines · Axel Lin

This fixes below build error when CONFIG_LEDS_CLASS is not set.

LD init/built-in.o
arch/arm/plat-omap/built-in.o: In function `fpga_probe':
arch/arm/plat-omap/debug-leds.c:113: undefined reference to `led_classdev_register'
make: *** [vmlinux] Error 1

Thanks for posting this. But I think Tony has already fixed it in mainline:
--
commit 359f64f7b3997e94ee71039b5fcdc1278b9b77c4

Author: Tony Lindgren <[email protected]>
Date:   Wed Sep 15 10:18:51 2010 -0700

omap: Fix compile dependency to LEDS_CLASS

If we LEDS_CLASS is not selected, we will get undefined reference to `led_classdev_register'.

--

-Bryan

Quoted 22 lines
---
 arch/arm/plat-omap/Kconfig |    1 +
 1 file changed, 1 insertion(+)
arch/arm/plat-omap/Kconfig +1 -1
index ca83a76..c262781 100644
@@ -43,6 +43,7 @@ config OMAP_DEBUG_DEVICES
 
 config OMAP_DEBUG_LEDS
        def_bool y if NEW_LEDS
+       select LEDS_CLASS
        depends on OMAP_DEBUG_DEVICES
 
 config POWER_AVS_OMAP
--

1.7.9.5

Signature · 4 lines
Bryan Wu <[email protected]>
Kernel Developer    +86.186-168-78255 Mobile
Canonical Ltd.      www.canonical.com
Ubuntu - Linux for human beings | www.ubuntu.com
author
#2 lore raw

2012/9/18 Bryan Wu <[email protected]>:

Quoted 15 lines · Axel Lin
Quoted 7 lines

This fixes below build error when CONFIG_LEDS_CLASS is not set.

LD init/built-in.o
arch/arm/plat-omap/built-in.o: In function `fpga_probe':
arch/arm/plat-omap/debug-leds.c:113: undefined reference to `led_classdev_register'
make: *** [vmlinux] Error 1

Thanks for posting this. But I think Tony has already fixed it in mainline:
--
commit 359f64f7b3997e94ee71039b5fcdc1278b9b77c4

Author: Tony Lindgren <[email protected]>
Date:   Wed Sep 15 10:18:51 2010 -0700
Quoted 6 lines

omap: Fix compile dependency to LEDS_CLASS

If we LEDS_CLASS is not selected, we will get undefined reference to `led_classdev_register'.

Commit 359f64f7b was commited on Sep 15 2010. This patch is against current linux-next tree.
I got the build error on linux-next tree (next-20120917).

Regards,
Axel

#3 lore raw
Quoted 18 lines · Axel Lin

2012/9/18 Bryan Wu <[email protected]>:

Quoted 17 lines · Axel Lin
Quoted 7 lines

This fixes below build error when CONFIG_LEDS_CLASS is not set.

LD init/built-in.o
arch/arm/plat-omap/built-in.o: In function `fpga_probe':
arch/arm/plat-omap/debug-leds.c:113: undefined reference to `led_classdev_register'
make: *** [vmlinux] Error 1

Thanks for posting this. But I think Tony has already fixed it in mainline:
--
commit 359f64f7b3997e94ee71039b5fcdc1278b9b77c4

Author: Tony Lindgren <[email protected]>
Date:   Wed Sep 15 10:18:51 2010 -0700

omap: Fix compile dependency to LEDS_CLASS

Quoted 9 lines
Quoted 4 lines

If we LEDS_CLASS is not selected, we will get undefined reference to `led_classdev_register'.

Commit 359f64f7b was commited on Sep 15 2010. This patch is against current linux-next tree.
I got the build error on linux-next tree (next-20120917).

Obviously, linux-next is not updated to latest mainline, -:D

Thanks,

Signature · 4 lines
Bryan Wu <[email protected]>
Kernel Developer    +86.186-168-78255 Mobile
Canonical Ltd.      www.canonical.com
Ubuntu - Linux for human beings | www.ubuntu.com
#4 lore raw
Quoted 22 lines · Bryan Wu
Quoted 21 lines · Axel Lin

2012/9/18 Bryan Wu <[email protected]>:

Quoted 20 lines · Axel Lin
Quoted 7 lines

This fixes below build error when CONFIG_LEDS_CLASS is not set.

LD init/built-in.o
arch/arm/plat-omap/built-in.o: In function `fpga_probe':
arch/arm/plat-omap/debug-leds.c:113: undefined reference to `led_classdev_register'
make: *** [vmlinux] Error 1

Thanks for posting this. But I think Tony has already fixed it in mainline:
--
commit 359f64f7b3997e94ee71039b5fcdc1278b9b77c4

Author: Tony Lindgren <[email protected]>
Date:   Wed Sep 15 10:18:51 2010 -0700

omap: Fix compile dependency to LEDS_CLASS

If we LEDS_CLASS is not selected, we will get undefined reference to `led_classdev_register'.

Quoted 8 lines
Quoted 6 lines
Quoted 1 line

Commit 359f64f7b was commited on Sep 15 2010. This patch is against current linux-next tree.
I got the build error on linux-next tree (next-20120917).

Obviously, linux-next is not updated to latest mainline, -:D

Thanks I'll apply this to fixes.

Regards,

Tony