Skip to contentSkip to conversation

OMAPDSS: fix return value check in create_dss_pdev()

PATCH New Wei Yongjun 2 participants 2 messages Sep 21, 2012 – Oct 8, 2012

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 OMAPDSS: fix return value check in create_dss_pdev()

From: Wei Yongjun <[email protected]>

In case of error, the function omap_device_alloc() returns ERR_PTR() not NULL pointer. The NULL test in the return value check should be replaced with IS_ERR().

dpatch engine is used to auto generated this patch.
(https://github.com/weiyj/dpatch)

---
 arch/arm/mach-omap2/display.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-omap2/display.c +1 -1
index af1ed7d..eb1bd01 100644
@@ -221,7 +221,7 @@ static struct platform_device *create_dss_pdev(const char *pdev_name,
 
 	ohs[0] = oh;
 	od = omap_device_alloc(pdev, ohs, 1, NULL, 0);
-	if (!od) {
+	if (IS_ERR(od)) {
 		pr_err("Could not alloc omap_device for %s\n", pdev_name);
 		r = -ENOMEM;
 		goto err;
maintainer
#1 lore raw

PATCH 1/1 OMAPDSS: fix return value check in create_dss_pdev()

Quoted 5 lines · Wei Yongjun

From: Wei Yongjun <[email protected]>

In case of error, the function omap_device_alloc() returns ERR_PTR() not NULL pointer. The NULL test in the return value check should be replaced with IS_ERR().

Thanks applying into omap fixes.

Regards,

Tony