Skip to contentSkip to conversation

ARM: OMAP: hsmmc: fix return value check in omap_hsmmc_init_one()

PATCH New Wei Yongjun 2 participants 2 messages Sep 21, 2012 – Oct 8, 2012

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: OMAP: hsmmc: fix return value check in omap_hsmmc_init_one()

From: Wei Yongjun <[email protected]>

In case of error, the function omap_device_alloc() returns ERR_PTR() not NULL pointer. The NULL test in the return value check should be replaced with IS_ERR().

dpatch engine is used to auto generated this patch.
(https://github.com/weiyj/dpatch)

---
 arch/arm/mach-omap2/hsmmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-omap2/hsmmc.c +1 -1
index a9675d8..95179fe 100644
@@ -522,7 +522,7 @@ static void __init omap_hsmmc_init_one(struct omap2_hsmmc_info *hsmmcinfo,
 	dev_set_name(&pdev->dev, "%s.%d", pdev->name, pdev->id);
 
 	od = omap_device_alloc(pdev, ohs, 1, NULL, 0);
-	if (!od) {
+	if (IS_ERR(od)) {
 		pr_err("Could not allocate od for %s\n", name);
 		goto put_pdev;
 	}
maintainer
#1 lore raw

PATCH 1/1 ARM: OMAP: hsmmc: fix return value check in omap_hsmmc_init_one()

Quoted 5 lines · Wei Yongjun

From: Wei Yongjun <[email protected]>

In case of error, the function omap_device_alloc() returns ERR_PTR() not NULL pointer. The NULL test in the return value check should be replaced with IS_ERR().

Thanks applying into omap fixes.

Regards,

Tony