ARM: OMAP: hsmmc: fix return value check in omap_hsmmc_init_one()
Subsystems (3)
PATCH 1/1 ARM: OMAP: hsmmc: fix return value check in omap_hsmmc_init_one()
From: Wei Yongjun <[email protected]>
In case of error, the function omap_device_alloc() returns ERR_PTR() not NULL pointer. The NULL test in the return value check should be replaced with IS_ERR().
dpatch engine is used to auto generated this patch.
(https://github.com/weiyj/dpatch)
Signed-off-by Wei Yongjun <[email protected]>
--- arch/arm/mach-omap2/hsmmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-omap2/hsmmc.c +1 -1
@@ -522,7 +522,7 @@ static void __init omap_hsmmc_init_one(struct omap2_hsmmc_info *hsmmcinfo,dev_set_name (&pdev->dev,"%s.%d" , pdev->name, pdev->id); od =omap_device_alloc (pdev, ohs,1 ,NULL ,0 ); -if (!od) { +if (IS_ERR (od)) {pr_err ("Could not allocate od for %s\n" , name); goto put_pdev; }
Tony Lindgren
maintainerPATCH 1/1 ARM: OMAP: hsmmc: fix return value check in omap_hsmmc_init_one()
Quoted 5 lines · Wei Yongjun
From: Wei Yongjun <[email protected]>
In case of error, the function
omap_device_alloc()returnsERR_PTR()not NULL pointer. The NULL test in the return value check should be replaced withIS_ERR().
Thanks applying into omap fixes.
Regards,
Tony