Skip to contentSkip to conversation

ARM: OMAP: Fix dependency for OMAP_DEBUG_LEDS

PATCH In review Axel Lin 2 participants 2 messages Oct 7, 2012 – Oct 8, 2012

Subsystems (2)
Arm (32-bit) Arm sub-architectures
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH v2 1/1 ARM: OMAP: Fix dependency for OMAP_DEBUG_LEDS

This fixes below build error when CONFIG_LEDS_CLASS is not set.

LD init/built-in.o
arch/arm/plat-omap/built-in.o: In function `fpga_probe':
arch/arm/plat-omap/debug-leds.c:113: undefined reference to led_classdev_register' arch/arm/plat-omap/debug-leds.c:113: undefined reference to led_classdev_register' arch/arm/plat-omap/debug-leds.c:113: undefined reference to led_classdev_register' arch/arm/plat-omap/debug-leds.c:113: undefined reference to led_classdev_register' arch/arm/plat-omap/debug-leds.c:113: undefined reference to led_classdev_register' arch/arm/plat-omap/built-in.o:arch/arm/plat-omap/debug-leds.c:113: more undefined references to led_classdev_register' follow
make: *** [vmlinux] Error 1

Signed-off-by Axel Lin <[email protected]>
---
 arch/arm/plat-omap/Kconfig |    1 +
 1 file changed, 1 insertion(+)
arch/arm/plat-omap/Kconfig +1 -0
index ca83a76..c262781 100644
@@ -43,6 +43,7 @@ config OMAP_DEBUG_DEVICES
 
 config OMAP_DEBUG_LEDS
 	def_bool y if NEW_LEDS
+	select LEDS_CLASS
 	depends on OMAP_DEBUG_DEVICES
 
 config POWER_AVS_OMAP
Signature · 1 line
1.7.9.5
#1 lore raw
Quoted 12 lines · Axel Lin

This fixes below build error when CONFIG_LEDS_CLASS is not set.

LD init/built-in.o
arch/arm/plat-omap/built-in.o: In function `fpga_probe':
arch/arm/plat-omap/debug-leds.c:113: undefined reference to led_classdev_register' arch/arm/plat-omap/debug-leds.c:113: undefined reference to led_classdev_register' arch/arm/plat-omap/debug-leds.c:113: undefined reference to led_classdev_register' arch/arm/plat-omap/debug-leds.c:113: undefined reference to led_classdev_register' arch/arm/plat-omap/debug-leds.c:113: undefined reference to led_classdev_register' arch/arm/plat-omap/built-in.o:arch/arm/plat-omap/debug-leds.c:113: more undefined references to led_classdev_register' follow
make: *** [vmlinux] Error 1

Quoted 1 line
Signed-off-by Axel Lin <[email protected]>

Thanks looks like I have already an earlier version of the same patch from you already queued.

Regards,

Tony

Quoted 21 lines
---
 arch/arm/plat-omap/Kconfig |    1 +
 1 file changed, 1 insertion(+)
arch/arm/plat-omap/Kconfig +1 -0
index ca83a76..c262781 100644
@@ -43,6 +43,7 @@ config OMAP_DEBUG_DEVICES
 
 config OMAP_DEBUG_LEDS
 	def_bool y if NEW_LEDS
+	select LEDS_CLASS
 	depends on OMAP_DEBUG_DEVICES
 
 config POWER_AVS_OMAP
Signature · 1 line
1.7.9.5