ARM: dts: imx28: add the `clock-names` for gpmi-nand

PATCH New Huang Shijie 5 participants 10 messages Oct 10, 2012 – Oct 25, 2012

Subsystems (3)

Device tree bindings Arm i.MX and Layerscape Memory technology devices (MTD)

lore

Share & tools

lore

Huang Shijie

author

2012-10-10 02:44 UTC #0 lore raw

PATCH 1/1 ARM: dts: imx28: add the `clock-names` for gpmi-nand

The current DT node misses the clocks-names item for gpmi-nand. So the gpmi-nand driver could not find the proper clock.

This patch fixes this issue.

Signed-off-by Huang Shijie <[email protected]>

---
 arch/arm/boot/dts/imx28.dtsi |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

arch/arm/boot/dts/imx28.dtsi +1 -0

index e16d631..55c57ea 100644
@@ -85,6 +85,7 @@
 				interrupts = <88>, <41>;
 				interrupt-names = "gpmi-dma", "bch";
 				clocks = <&clks 50>;
+				clock-names = "gpmi_io";
 				fsl,gpmi-dma-channel = <4>;
 				status = "disabled";
 			};

Signature · 1 line

1.7.0.4

Fabio Estevam

reviewer

2012-10-10 04:54 UTC #1 lore raw

PATCH 1/1 ARM: dts: imx28: add the `clock-names` for gpmi-nand

Hi Huang,

Quoted 6 lines · Huang Shijie

The current DT node misses the clocks-names item for gpmi-nand. So the gpmi-nand driver could not find the proper clock.
This patch fixes this issue.
Signed-off-by Huang Shijie <[email protected]>

Thanks for the fix.

Could you please also fix mx23 in the same patch?

Regards,

Fabio Estevam

Huang Shijie

author

2012-10-10 05:01 UTC #2 lore raw

PATCH 1/1 ARM: dts: imx28: add the `clock-names` for gpmi-nand

? 2012?10?10? 12:54, Fabio Estevam ??:

Quoted 6 lines

Hi Huang,
Quoted 3 lines · Huang Shijie
The current DT node misses the clocks-names item for gpmi-nand. So the gpmi-nand driver could not find the proper clock.

Quoted 6 lines

Quoted 3 lines
This patch fixes this issue.
Signed-off-by Huang Shijie<[email protected]>
Thanks for the fix.
Could you please also fix mx23 in the same patch?

I am just fixing it now. :)

Huang Shijie

Quoted 4 lines

Regards,
Fabio Estevam

Huang Shijie

author

2012-10-10 06:15 UTC #3 lore raw

PATCH 1/1 ARM: dts: mxs: add the `clock-names` for gpmi-nand

In reply to Fabio Estevam

The current DT nodes for mx23/mx28 miss the clocks-names item for gpmi-nand. So the gpmi-nand driver could not find the proper clock.

This patch fixes this issue.

Signed-off-by Huang Shijie <[email protected]>

---
 arch/arm/boot/dts/imx23.dtsi |    1 +
 arch/arm/boot/dts/imx28.dtsi |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)

arch/arm/boot/dts/imx23.dtsi +1 -0

index 9ca4ca7..6d31aa3 100644
@@ -69,6 +69,7 @@
 				interrupts = <13>, <56>;
 				interrupt-names = "gpmi-dma", "bch";
 				clocks = <&clks 34>;
+				clock-names = "gpmi_io";
 				fsl,gpmi-dma-channel = <4>;
 				status = "disabled";
 			};

arch/arm/boot/dts/imx28.dtsi +1 -0

index e16d631..55c57ea 100644
@@ -85,6 +85,7 @@
 				interrupts = <88>, <41>;
 				interrupt-names = "gpmi-dma", "bch";
 				clocks = <&clks 50>;
+				clock-names = "gpmi_io";
 				fsl,gpmi-dma-channel = <4>;
 				status = "disabled";
 			};

Signature · 1 line

1.7.0.4

Marek Vasut

2012-10-10 10:37 UTC #4 lore raw

PATCH 1/1 ARM: dts: mxs: add the `clock-names` for gpmi-nand

Dear Huang Shijie,

Quoted 6 lines

The current DT nodes for mx23/mx28 miss the clocks-names item for gpmi-nand. So the gpmi-nand driver could not find the proper clock.
This patch fixes this issue.
Signed-off-by Huang Shijie <[email protected]>

[...]

One more rant: Can you discard that weird backtick in the patch subject? Maybe use '' ?

Best regards,
Marek Vasut

Huang Shijie

author

2012-10-10 10:27 UTC #5 lore raw

PATCH 1/1 ARM: dts: mxs: add the "clock-names" for gpmi-nand

The current DT nodes for mx23/mx28 miss the clocks-names item for gpmi-nand. So the gpmi-nand driver could not find the proper clock.

This patch fixes this issue.

Signed-off-by Huang Shijie <[email protected]>

---
 arch/arm/boot/dts/imx23.dtsi |    1 +
 arch/arm/boot/dts/imx28.dtsi |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)

arch/arm/boot/dts/imx23.dtsi +1 -0

index 9ca4ca7..6d31aa3 100644
@@ -69,6 +69,7 @@
 				interrupts = <13>, <56>;
 				interrupt-names = "gpmi-dma", "bch";
 				clocks = <&clks 34>;
+				clock-names = "gpmi_io";
 				fsl,gpmi-dma-channel = <4>;
 				status = "disabled";
 			};

arch/arm/boot/dts/imx28.dtsi +1 -0

index e16d631..55c57ea 100644
@@ -85,6 +85,7 @@
 				interrupts = <88>, <41>;
 				interrupt-names = "gpmi-dma", "bch";
 				clocks = <&clks 50>;
+				clock-names = "gpmi_io";
 				fsl,gpmi-dma-channel = <4>;
 				status = "disabled";
 			};

Signature · 1 line

1.7.0.4

Marek Vasut

2012-10-10 11:34 UTC #6 lore raw

PATCH 1/1 ARM: dts: mxs: add the "clock-names" for gpmi-nand

Dear Huang Shijie,

Quoted 6 lines

The current DT nodes for mx23/mx28 miss the clocks-names item for gpmi-nand. So the gpmi-nand driver could not find the proper clock.
This patch fixes this issue.
Signed-off-by Huang Shijie <[email protected]>

[...]

Reviewed-by Marek Vasut <[email protected]>

I will test later today.

Best regards,
Marek Vasut

Shawn Guo

Applied

2012-10-11 07:49 UTC #7 lore raw

PATCH 1/1 ARM: dts: mxs: add the "clock-names" for gpmi-nand

In reply to Huang Shijie

Quoted 6 lines · Huang Shijie

The current DT nodes for mx23/mx28 miss the clocks-names item for gpmi-nand. So the gpmi-nand driver could not find the proper clock.
This patch fixes this issue.
Signed-off-by Huang Shijie <[email protected]>

Applied, thanks.

Shawn

Shawn Guo

2012-10-25 07:16 UTC #8 lore raw

PATCH 1/1 ARM: dts: mxs: add the "clock-names" for gpmi-nand

In reply to Huang Shijie

Hi Arnd, Olof,

Can you please apply this fix for -rc? Otherwise, please let me know if you prefer to get a pull request from me.

Shawn

Quoted 39 lines · Huang Shijie

The current DT nodes for mx23/mx28 miss the clocks-names item for gpmi-nand. So the gpmi-nand driver could not find the proper clock.

This patch fixes this issue.

Signed-off-by Huang Shijie <[email protected]>

---
 arch/arm/boot/dts/imx23.dtsi |    1 +
 arch/arm/boot/dts/imx28.dtsi |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)

arch/arm/boot/dts/imx23.dtsi +1 -0

index 9ca4ca7..6d31aa3 100644
@@ -69,6 +69,7 @@
 				interrupts = <13>, <56>;
 				interrupt-names = "gpmi-dma", "bch";
 				clocks = <&clks 34>;
+				clock-names = "gpmi_io";
 				fsl,gpmi-dma-channel = <4>;
 				status = "disabled";
 			};

arch/arm/boot/dts/imx28.dtsi +1 -0

index e16d631..55c57ea 100644
@@ -85,6 +85,7 @@
 				interrupts = <88>, <41>;
 				interrupt-names = "gpmi-dma", "bch";
 				clocks = <&clks 50>;
+				clock-names = "gpmi_io";
 				fsl,gpmi-dma-channel = <4>;
 				status = "disabled";
 			};

Signature · 1 line

1.7.0.4

Arnd Bergmann

Applied

2012-10-25 13:23 UTC #9 lore raw

PATCH 1/1 ARM: dts: mxs: add the "clock-names" for gpmi-nand

Quoted 6 lines · Shawn Guo

Hi Arnd, Olof,
Can you please apply this fix for -rc? Otherwise, please let me know if you prefer to get a pull request from me.

Applied to fixes branch, and added your Ack as well as the Review tag from Marek.

Arnd