Skip to contentSkip to conversation

clean up csv report formatter

PATCH New Sergey Senozhatsky 1 participant 1 message Oct 11, 2012

lore
Share & tools
lore

Sergey Senozhatsky

author
#0 lore raw

PATCH 1/1 clean up csv report formatter

[PATCH] clean up csv report formatter

Do not re-define/re-implement unused basic formatter functions in csv reporter (e.g. report_formatter_csv::finish_report()).

Signed-off-by Sergey Senozhatsky <sergey.senozhatsky(a)gmail.com>

---

 src/report/report-formatter-csv.cpp | 40 -------------------------------------
 src/report/report-formatter-csv.h   |  8 --------
 2 files changed, 48 deletions(-)
src/report/report-formatter-csv.cpp +0 -40
index 9b154b5..37ac86b 100644
@@ -45,14 +45,6 @@ report_formatter_csv::report_formatter_csv()
 /* ************************************************************************ */
 
 void
-report_formatter_csv::finish_report()
-{
-	/* Do nothing special */
-}
-
-/* ************************************************************************ */
-
-void
 report_formatter_csv::add_doc_header()
 {
 	add_header(report_csv_header, 1);

@@ -75,22 +67,6 @@ report_formatter_csv::add_header(const char *header, int level)
 /* ************************************************************************ */
 
 void
-report_formatter_csv::begin_section(section_type stype)
-{
-	/* Do nothing special */
-}
-
-/* ************************************************************************ */
-
-void
-report_formatter_csv::end_section()
-{
-	/* Do nothing special */
-}
-
-/* ************************************************************************ */
-
-void
 report_formatter_csv::begin_table(table_type ttype)
 {
 	add_exact("\n");

@@ -163,14 +139,6 @@ report_formatter_csv::end_cell()
 /* ************************************************************************ */
 
 void
-report_formatter_csv::add_empty_cell()
-{
-	/* Do nothing special */
-}
-
-/* ************************************************************************ */
-
-void
 report_formatter_csv::begin_paragraph()
 {
 	text_start = result.length();

@@ -213,11 +181,3 @@ report_formatter_csv::escape_string(const char *str)
 
 	return res;
 }
-
-/* ************************************************************************ */
-
-void
-report_formatter_csv::set_cpu_number(int nr UNUSED)
-{
-	/* Do nothing */
-}
src/report/report-formatter-csv.h +0 -8
index 8dd2976..8db9839 100644
@@ -49,13 +49,8 @@ class report_formatter_csv: public report_formatter_string_base
 public:
 	report_formatter_csv();
 
-	void finish_report();
-
 	void add_header(const char *header, int level);
 
-	void begin_section(section_type stype);
-	void end_section();
-
 	void begin_table(table_type ttype);
 	void end_table();
 

@@ -64,13 +59,10 @@ public:
 
 	void begin_cell(cell_type ctype);
 	void end_cell();
-	void add_empty_cell();
 
 	void begin_paragraph();
 	void end_paragraph();
 
-	void set_cpu_number(int nr);
-
 private:
 	void add_doc_header();