ARM: OMAP4: Fix twd_local_timer_register regression
Subsystems (3)
Tony Lindgren
maintainerPATCH 1/1 ARM: OMAP4: Fix twd_local_timer_register regression
Commit 7d7e1eba (ARM: OMAP2+: Prepare for irqs.h removal) changed the interrupts to allow enabling sparse IRQ, but accidentally added the omap3 INTC base to the local IRQ. This causes the following:
twd: can't register interrupt 45 (-22)twd_local_timer_register failed -22
The right fix is to not add any base, as it is a local timer. For the OMAP44XX_IRQ_LOCALWDT we had defined earlier there are no users, so no need to fix that.
arch/arm/mach-omap2/timer.c +1 -1
@@ -467,7 +467,7 @@ OMAP_SYS_TIMER(3_am33xx)#ifdef CONFIG_ARCH_OMAP4 #ifdef CONFIG_LOCAL_TIMERS static DEFINE_TWD_LOCAL_TIMER(twd_local_timer, - OMAP44XX_LOCAL_TWD_BASE, 29 + OMAP_INTC_START); + OMAP44XX_LOCAL_TWD_BASE, 29);#endif static void __init omap4_timer_init (void )
PATCH 1/1 ARM: OMAP4: Fix twd_local_timer_register regression
Quoted 8 lines · Tony Lindgren
Commit
7d7e1eba(ARM: OMAP2+: Prepare forirqs.hremoval) changed the interrupts to allow enabling sparse IRQ, but accidentally added the omap3 INTC base to the local IRQ. This causes the following:twd: can't register interrupt 45 (-22)
twd_local_timer_registerfailed -22
Quoted 7 lines
The right fix is to not add any base, as it is a local timer. For the
OMAP44XX_IRQ_LOCALWDTwe had defined earlier there are no users, so no need to fix that.Reported-by Russell King <[email protected]>Signed-off-by Tony Lindgren <[email protected]>