rgmanager: Fix return code when a service would deadlock
PATCH 1/1 rgmanager: Fix return code when a service would deadlock
When we detect that starting a service would cause a deadlock, return 0 instead of -1. This fixes a crash that occurred when -1 was returned.
Resolves: rhbz#861157
Signed-off-by Ryan McCabe <[email protected]>
--- rgmanager/src/daemons/rg_thread.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
rgmanager/src/daemons/rg_thread.c +1 -1
@@ -756,7 +756,7 @@ rt_enqueue_request(const char *resgroupname, int request,logt_print (LOG_DEBUG ,"Failed to queue %d request for %s: Would block\n" , request, resgroupname); -return -1 ; +return 0 ; } ret = rq_queue_request(resgroup->rt_queue, resgroup->rt_name,
Signature · 1 line
1.7.11.7
PATCH 1/1 rgmanager: Fix return code when a service would deadlock
ACK
Quoted 24 lines · Ryan McCabe
When we detect that starting a service would cause a deadlock, return 0 instead of -1. This fixes a crash that occurred when -1 was returned.
Resolves: rhbz#861157
Signed-off-by Ryan McCabe <[email protected]>--- rgmanager/src/daemons/rg_thread.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)rgmanager/src/daemons/rg_thread.c +1
-1@@ -756,7 +756,7 @@ rt_enqueue_request(const char *resgroupname, int request,logt_print (LOG_DEBUG ,"Failed to queue %d request for %s: Would block\n" , request, resgroupname); -return -1 ; +return 0 ; } ret = rq_queue_request(resgroup->rt_queue, resgroup->rt_name,