Skip to contentSkip to conversation

kbuild: Remove reference to uninitialised variable

PATCH In review Charles Keepax 2 participants 2 messages Oct 15, 2012 – Nov 20, 2012 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kbuild: Remove reference to uninitialised variable

Verbose output variable is unnecessary because the command's echo is already surpressed. Additionally because the block defines skip-makefile the variable Q is not defined within the makefile, which can cause problems if Q is defined in the users environment.

---
 Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Makefile +1 -1
index a687963..2a7be73 100644
@@ -124,7 +124,7 @@ $(if $(KBUILD_OUTPUT),, \
 PHONY += $(MAKECMDGOALS) sub-make
 
 $(filter-out _all sub-make $(CURDIR)/Makefile, $(MAKECMDGOALS)) _all: sub-make
-	$(Q)@:
+	@:
 
 sub-make: FORCE
 	$(if $(KBUILD_VERBOSE:1=),@)$(MAKE) -C $(KBUILD_OUTPUT) \
Signature · 1 line
1.7.2.5
#1 lore raw
Quoted 6 lines · Charles Keepax

Verbose output variable is unnecessary because the command's echo is already surpressed. Additionally because the block defines skip-makefile the variable Q is not defined within the makefile, which can cause problems if Q is defined in the users environment.

Applied to kbuild.git#kbuild, thanks.

Michal