Skip to contentSkip to conversation

Lots of trans->state != IWL_TRANS_FW_ALIVE warnings

DISCUSSION Stanislaw Gruszka 2 participants 8 messages Oct 15, 2012 – Oct 17, 2012 Networking drivers (wireless)

lore
Share & tools
lore
#0 lore raw

On Fedora (3.5 and 3.6 kernels) we are currently overwhelmed by tons of iwlwifi warnings at iwlagn_mac_flush() and iwl_dvm_send_cmd() reports.

iwlagn_mac_flush warning is triggered at:

static inline int iwl_trans_wait_tx_queue_empty(struct iwl_trans *trans)

{
        WARN_ONCE(trans->state != IWL_TRANS_FW_ALIVE,
                  "%s bad state = %d", __func__, trans->state);

        return trans->ops->wait_tx_queue_empty(trans);
}

We have 2 instances of this issue:

- started at ieee80211_scan()
https://bugzilla.redhat.com/show_bug.cgi?id=866013
- started at ieee80211_sta_monitor_work()
https://bugzilla.redhat.com/show_bug.cgi?id=861753

iwl_dvm_send_cmd is triggered at:

static inline int iwl_trans_send_cmd(struct iwl_trans *trans,
struct iwl_host_cmd *cmd)

{
        WARN_ONCE(trans->state != IWL_TRANS_FW_ALIVE,
                  "%s bad state = %d", __func__, trans->state);

        return trans->ops->send_cmd(trans, cmd);
}

And have 3 instances:

- started at ieee80211_set_disassoc()
https://bugzilla.redhat.com/show_bug.cgi?id=861599
- started at ieee80211_restart_work()
https://bugzilla.redhat.com/show_bug.cgi?id=865072
- started at ieee80211_auth()
https://bugzilla.redhat.com/show_bug.cgi?id=866015

Can those be fixed in some reasonable time ?

I'm not sure if they are related with some user visible problem like disconnects.

I'll probably revert f0d120af8f55649571c681f49c920b0822050fa5 on Fedora, just to stop getting those warnings ...

Stanislaw

#1 lore raw
Quoted 29 lines

On Fedora (3.5 and 3.6 kernels) we are currently overwhelmed by tons of iwlwifi warnings at iwlagn_mac_flush() and iwl_dvm_send_cmd() reports.

iwlagn_mac_flush warning is triggered at:

static inline int iwl_trans_wait_tx_queue_empty(struct iwl_trans *trans) {
        WARN_ONCE(trans->state != IWL_TRANS_FW_ALIVE,
                  "%s bad state = %d", __func__, trans->state);

        return trans->ops->wait_tx_queue_empty(trans);
}

We have 2 instances of this issue:

- started at ieee80211_scan()
https://bugzilla.redhat.com/show_bug.cgi?id=866013
- started at ieee80211_sta_monitor_work()
https://bugzilla.redhat.com/show_bug.cgi?id=861753

iwl_dvm_send_cmd is triggered at:

static inline int iwl_trans_send_cmd(struct iwl_trans *trans,

                                struct iwl_host_cmd *cmd) {
        WARN_ONCE(trans->state != IWL_TRANS_FW_ALIVE,
                  "%s bad state = %d", __func__, trans->state);

        return trans->ops->send_cmd(trans, cmd); }
Quoted 9 lines

And have 3 instances:

- started at ieee80211_set_disassoc()
https://bugzilla.redhat.com/show_bug.cgi?id=861599
- started at ieee80211_restart_work()
https://bugzilla.redhat.com/show_bug.cgi?id=865072
- started at ieee80211_auth()
https://bugzilla.redhat.com/show_bug.cgi?id=866015

I glanced at the bugs and I can only see the trace dump. I am pretty sure there is an issue before the dump - fw assert of something like that. Can it be possible to get the full log?

Quoted 4 lines

Can those be fixed in some reasonable time ?

I'm not sure if they are related with some user visible problem like disconnects.

Well... if the fw isn't ALIVE then something bad happens, bad enough to get disconnected, yes.

Quoted 4 lines

I'll probably revert f0d120af8f55649571c681f49c920b0822050fa5 on Fedora, just to stop getting those warnings ...

You will stop get the warnings, but that of course won't solve anything else.
---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.

#2 lore raw
In reply to Stanislaw Gruszka
Quoted 41 lines
Quoted 4 lines

On Fedora (3.5 and 3.6 kernels) we are currently overwhelmed by tons of iwlwifi warnings at iwlagn_mac_flush() and iwl_dvm_send_cmd()

reports.

Quoted 26 lines

iwlagn_mac_flush warning is triggered at:

static inline int iwl_trans_wait_tx_queue_empty(struct iwl_trans *trans) {
        WARN_ONCE(trans->state != IWL_TRANS_FW_ALIVE,
                  "%s bad state = %d", __func__, trans->state);

        return trans->ops->wait_tx_queue_empty(trans);
}

We have 2 instances of this issue:

- started at ieee80211_scan()
https://bugzilla.redhat.com/show_bug.cgi?id=866013
- started at ieee80211_sta_monitor_work()
https://bugzilla.redhat.com/show_bug.cgi?id=861753

iwl_dvm_send_cmd is triggered at:

static inline int iwl_trans_send_cmd(struct iwl_trans *trans,

                                struct iwl_host_cmd *cmd) {
        WARN_ONCE(trans->state != IWL_TRANS_FW_ALIVE,
                  "%s bad state = %d", __func__, trans->state);

        return trans->ops->send_cmd(trans, cmd); }
Quoted 9 lines

And have 3 instances:

- started at ieee80211_set_disassoc()
https://bugzilla.redhat.com/show_bug.cgi?id=861599
- started at ieee80211_restart_work()
https://bugzilla.redhat.com/show_bug.cgi?id=865072
- started at ieee80211_auth()
https://bugzilla.redhat.com/show_bug.cgi?id=866015

Quoted 4 lines

I glanced at the bugs and I can only see the trace dump. I am pretty sure there is an issue before the dump - fw assert of something like that. Can it be possible to get the full log?

Can you ask people to try the attached patch? This will let us know where the fw is brought down.

Quoted 5 lines
Quoted 4 lines

Can those be fixed in some reasonable time ?

I'm not sure if they are related with some user visible problem like disconnects.

Quoted 8 lines

Well... if the fw isn't ALIVE then something bad happens, bad enough to get disconnected, yes.

Quoted 4 lines

I'll probably revert f0d120af8f55649571c681f49c920b0822050fa5 on Fedora, just to stop getting those warnings ...

You will stop get the warnings, but that of course won't solve anything else.

---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.

From e7db3736c850e5aff9a1a0cfc0d4c11d2ce93914 Mon Sep 17 00:00:00 2001
From: Emmanuel Grumbach <[email protected]>
Date: Mon, 15 Oct 2012 20:04:55 +0200
Subject: [PATCH] iwlwifi: print state changes in transport layer

This will help to debug...

---
 drivers/net/wireless/iwlwifi/iwl-debug.h |    2 ++
 drivers/net/wireless/iwlwifi/iwl-trans.h |    6 ++++++
 2 files changed, 8 insertions(+), 0 deletions(-)
drivers/net/wireless/iwlwifi/iwl-debug.h +2 -0
index 7ae181a..727b520 100644
@@ -126,6 +126,7 @@ do {                                            			\
 /* 0x0000F000 - 0x00001000 */
 #define IWL_DL_ASSOC		0x00001000
 #define IWL_DL_DROP		0x00002000
+#define IWL_DL_TRANS		0x00004000
 #define IWL_DL_COEX		0x00008000
 /* 0x000F0000 - 0x00010000 */
 #define IWL_DL_FW		0x00010000
@@ -183,5 +184,6 @@ do {                                            			\
 #define IWL_DEBUG_RADIO(p, f, a...)	IWL_DEBUG(p, IWL_DL_RADIO, f, ## a)
 #define IWL_DEBUG_POWER(p, f, a...)	IWL_DEBUG(p, IWL_DL_POWER, f, ## a)
 #define IWL_DEBUG_11H(p, f, a...)	IWL_DEBUG(p, IWL_DL_11H, f, ## a)
+#define IWL_DEBUG_TRANS(p, f, a...)	IWL_DEBUG(p, IWL_DL_TRANS, f, ## a)
 
 #endif
drivers/net/wireless/iwlwifi/iwl-trans.h +6 -0
index 695b8d5..d6d6e12 100644
@@ -508,6 +508,8 @@ static inline void iwl_trans_stop_hw(struct iwl_trans *trans,
 
 	trans->ops->stop_hw(trans, op_mode_leaving);
 
+	IWL_DEBUG_TRANS(trans, "trans->state: %d -> %d\n",
+			trans->state, IWL_TRANS_NO_FW);
 	trans->state = IWL_TRANS_NO_FW;
 }
 
@@ -515,6 +517,8 @@ static inline void iwl_trans_fw_alive(struct iwl_trans *trans)
 {
 	might_sleep();
 
+	IWL_DEBUG_TRANS(trans, "trans->state: %d -> %d\n",
+			trans->state, IWL_TRANS_FW_ALIVE);
 	trans->state = IWL_TRANS_FW_ALIVE;
 
 	trans->ops->fw_alive(trans);
@@ -536,6 +540,8 @@ static inline void iwl_trans_stop_device(struct iwl_trans *trans)
 
 	trans->ops->stop_device(trans);
 
+	IWL_DEBUG_TRANS(trans, "trans->state: %d -> %d\n",
+			trans->state, IWL_TRANS_NO_FW);
 	trans->state = IWL_TRANS_NO_FW;
 }
 
Signature · 1 line
1.7.1
#3 lore raw
Quoted 7 lines · Emmanuel
Quoted 4 lines

I glanced at the bugs and I can only see the trace dump. I am pretty sure there is an issue before the dump - fw assert of something like that. Can it be possible to get the full log?

Can you ask people to try the attached patch? This will let us know where the fw is brought down.

Yes, I'll build kernel with that patch and request for test and dmesg.

Stanislaw

#4 lore raw
Quoted 10 lines · Stanislaw Gruszka
Quoted 7 lines · Emmanuel
Quoted 4 lines

I glanced at the bugs and I can only see the trace dump. I am pretty sure there is an issue before the dump - fw assert of something like that. Can it be possible to get the full log?

Can you ask people to try the attached patch? This will let us know where the fw is brought down.

Yes, I'll build kernel with that patch and request for test and dmesg.

debug=0x400 is enough or do you want also some other flags?

Stanislaw

#5 lore raw
Quoted 8 lines · Stanislaw Gruszka
Quoted 6 lines · Emmanuel
Quoted 5 lines
Quoted 4 lines

I glanced at the bugs and I can only see the trace dump. I am pretty sure there is an issue before the dump - fw assert of something like that. Can it be possible to get the full log?

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

Can you ask people to try the attached patch? This will let us know where the fw is brought down.

Yes, I'll build kernel with that patch and request for test and dmesg.

debug=0x400 is enough or do you want also some other flags?

0x400 should be enough, but 0x403 would be better :-)
---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.

#6 lore raw
Quoted 8 lines · Emmanuel
Quoted 8 lines · Stanislaw Gruszka
Quoted 6 lines · Emmanuel
Quoted 5 lines
Quoted 4 lines

I glanced at the bugs and I can only see the trace dump. I am pretty sure there is an issue before the dump - fw assert of something like that. Can it be possible to get the full log?

Quoted 8 lines
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

Can you ask people to try the attached patch? This will let us know where the fw is brought down.

Yes, I'll build kernel with that patch and request for test and dmesg.

debug=0x400 is enough or do you want also some other flags?

0x400 should be enough, but 0x403 would be better :-)

There is some feedback from user with micocode errors here
https://bugzilla.redhat.com/show_bug.cgi?id=866013

Emmanuel, perhaps you could CC to those bug report I provided links earlier, so I'll not need to mail you, when someone will add additional info to those reports ?

Thanks
Stanislaw

#7 lore raw
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 9 lines
Quoted 7 lines
Quoted 4 lines

I glanced at the bugs and I can only see the trace dump. I am pretty sure there is an issue before the dump - fw assert of something like that. Can it be possible to get the full log?

Can you ask people to try the attached patch? This will let us know where the fw is brought down.

Yes, I'll build kernel with that patch and request for test and dmesg.

Quoted 8 lines
Quoted 3 lines
Quoted 2 lines

debug=0x400 is enough or do you want also some other flags?

0x400 should be enough, but 0x403 would be better :-)

There is some feedback from user with micocode errors here
https://bugzilla.redhat.com/show_bug.cgi?id=866013

Ok, this is what I suspected. SYSASSERT before the WARNING....
So we have 2 issues here - the SYSASSERT and the reset.
BTW - do we have any insight on the NIC used - although I am pretty sure it doesn't matter much.

Quoted 4 lines

Emmanuel, perhaps you could CC to those bug report I provided links earlier, so I'll not need to mail you, when someone will add additional info to those reports ?

I will check :-)

Quoted 2 lines

Thanks
Stanislaw

---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.