drm/nouveau: remove redundant comments listing classes
Subsystems (3)
PATCH 1/1 drm/nouveau: remove redundant comments listing classes
--- drivers/gpu/drm/nouveau/core/include/core/class.h | 31 +++-------------------- 1 file changed, 4 insertions(+), 27 deletions(-)
drivers/gpu/drm/nouveau/core/include/core/class.h +4 -27
@@ -1,10 +1,7 @@#ifndef __NOUVEAU_CLASS_H__#define __NOUVEAU_CLASS_H__ -/* Device class -* -* 0080: NV_DEVICE -*/ +/* Device class */ #define NV_DEVICE_CLASS 0x00000080#define NV_DEVICE_DISABLE_IDENTIFY 0x0000000000000001ULL
@@ -30,12 +27,7 @@ struct nv_device_class {u64 debug0;/* as above, but *internal* ids, and *NOT* ABI */ }; -/* DMA object classes -* -* 0002: NV_DMA_FROM_MEMORY -* 0003: NV_DMA_TO_MEMORY -* 003d: NV_DMA_IN_MEMORY -*/ +/* DMA object classes */ #define NV_DMA_FROM_MEMORY_CLASS 0x00000002#define NV_DMA_TO_MEMORY_CLASS 0x00000003#define NV_DMA_IN_MEMORY_CLASS 0x0000003d
@@ -59,15 +51,7 @@ struct nv_dma_class {u64 limit; }; -/* DMA FIFO channel classes -* -* 006b: NV03_CHANNEL_DMA -* 006e: NV10_CHANNEL_DMA -* 176e: NV17_CHANNEL_DMA -* 406e: NV40_CHANNEL_DMA -* 506e: NV50_CHANNEL_DMA -* 826e: NV84_CHANNEL_DMA -*/ +/* DMA FIFO channel classes */ #define NV03_CHANNEL_DMA_CLASS 0x0000006b#define NV10_CHANNEL_DMA_CLASS 0x0000006e#define NV17_CHANNEL_DMA_CLASS 0x0000176e
@@ -81,14 +65,7 @@ struct nv03_channel_dma_class {u64 offset; }; -/* Indirect FIFO channel classes -* -* 506f: NV50_CHANNEL_IND -* 826f: NV84_CHANNEL_IND -* 906f: NVC0_CHANNEL_IND -* a06f: NVE0_CHANNEL_IND -*/ - +/* Indirect FIFO channel classes */ #define NV50_CHANNEL_IND_CLASS 0x0000506f#define NV84_CHANNEL_IND_CLASS 0x0000826f#define NVC0_CHANNEL_IND_CLASS 0x0000906f
Signature · 1 line
1.7.12
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 1 line · Marcin Slusarz
Signed-off-by Marcin Slusarz <[email protected]>
NACK on this one. I did ponder doing such a thing myself when I first added the defines for the class names too, and decided against it as this will (at some point) become a user-facing header, and I was planning on documenting the differences between class revisions in the commented blocks.
Ben.
Quoted 74 lines
--- drivers/gpu/drm/nouveau/core/include/core/class.h | 31 +++-------------------- 1 file changed, 4 insertions(+), 27 deletions(-)drivers/gpu/drm/nouveau/core/include/core/class.h +4
-27@@ -1,10 +1,7 @@#ifndef __NOUVEAU_CLASS_H__#define __NOUVEAU_CLASS_H__ -/* Device class -* -* 0080: NV_DEVICE -*/ +/* Device class */ #define NV_DEVICE_CLASS 0x00000080#define NV_DEVICE_DISABLE_IDENTIFY 0x0000000000000001ULL@@ -30,12 +27,7 @@ struct nv_device_class {u64 debug0;/* as above, but *internal* ids, and *NOT* ABI */ }; -/* DMA object classes -* -* 0002: NV_DMA_FROM_MEMORY -* 0003: NV_DMA_TO_MEMORY -* 003d: NV_DMA_IN_MEMORY -*/ +/* DMA object classes */ #define NV_DMA_FROM_MEMORY_CLASS 0x00000002#define NV_DMA_TO_MEMORY_CLASS 0x00000003#define NV_DMA_IN_MEMORY_CLASS 0x0000003d@@ -59,15 +51,7 @@ struct nv_dma_class {u64 limit; }; -/* DMA FIFO channel classes -* -* 006b: NV03_CHANNEL_DMA -* 006e: NV10_CHANNEL_DMA -* 176e: NV17_CHANNEL_DMA -* 406e: NV40_CHANNEL_DMA -* 506e: NV50_CHANNEL_DMA -* 826e: NV84_CHANNEL_DMA -*/ +/* DMA FIFO channel classes */ #define NV03_CHANNEL_DMA_CLASS 0x0000006b#define NV10_CHANNEL_DMA_CLASS 0x0000006e#define NV17_CHANNEL_DMA_CLASS 0x0000176e@@ -81,14 +65,7 @@ struct nv03_channel_dma_class {u64 offset; }; -/* Indirect FIFO channel classes -* -* 506f: NV50_CHANNEL_IND -* 826f: NV84_CHANNEL_IND -* 906f: NVC0_CHANNEL_IND -* a06f: NVE0_CHANNEL_IND -*/ - +/* Indirect FIFO channel classes */ #define NV50_CHANNEL_IND_CLASS 0x0000506f#define NV84_CHANNEL_IND_CLASS 0x0000826f#define NVC0_CHANNEL_IND_CLASS 0x0000906fSignature · 6 lines
1.7.12 _______________________________________________ Nouveau mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/nouveau
A message that is not in the archive (sent off-list or not yet received): 20121017043215.GB4049-yqdYmcOkqV0XGNroddHbYwC/[email protected]
17 paź 2012 06:33, "Ben Skeggs" <[email protected]> napisał(a):
Quoted 8 lines · Marcin Slusarz
Quoted 1 line
Signed-off-by Marcin Slusarz <[email protected]>NACK on this one. I did ponder doing such a thing myself when I first added the defines for the class names too, and decided against it as this will (at some point) become a user-facing header, and I was planning on documenting the differences between class revisions in the commented blocks.
I'm not against documentation, of course, but right now these comments are useless. Can't they be added with real content later?
Marcin
_______________________________________________
Nouveau mailing list [email protected]
http://lists.freedesktop.org/mailman/listinfo/nouveau