*ERROR* Timed out waiting for forcewake old ack to clear.?
Subsystems (2)
Hallo all,
i get on Asus Zenbook UX32A [IVB] fallowing errors:
[ 4.464893] [drm:__gen6_gt_force_wake_mt_get] *ERROR* Timed out waiting for forcewake old ack to clear. [ 6678.604211] [drm:__gen6_gt_force_wake_mt_get] *ERROR* Timed out waiting for forcewake old ack to clear. [ 9144.381337] [drm:__gen6_gt_force_wake_mt_get] *ERROR* Timed out waiting for forcewake old ack to clear. [ 9189.374375] [drm:__gen6_gt_force_wake_mt_get] *ERROR* Timed out waiting for forcewake old ack to clear.
I get it after resume from suspend to ram.
Is it some thing you need to know?
Hardware:intel_stepping
Vendor: 0x8086, Device: 0x0166, Revision: 0x09 (??) render clock: unknown sampler clock: unknown
Intel(R) Core(TM) i5-3317U CPU @ 1.70GHz
i use custom kernel: master linus (16.10.2012) + intel-drm-fixes (16.10.2012)
Signature · 2 lines
Regards, Oleksij
Quoted 10 lines · On Wed, 17 Oct 2012 08:17:51 +0200 Oleksij Rempel…
Hallo all,
i get on Asus Zenbook UX32A [IVB] fallowing errors:
[ 4.464893] [drm:__gen6_gt_force_wake_mt_get] *ERROR* Timed out waiting for forcewake old ack to clear. [ 6678.604211] [drm:__gen6_gt_force_wake_mt_get] *ERROR* Timed out waiting for forcewake old ack to clear. [ 9144.381337] [drm:__gen6_gt_force_wake_mt_get] *ERROR* Timed out waiting for forcewake old ack to clear. [ 9189.374375] [drm:__gen6_gt_force_wake_mt_get] *ERROR* Timed out
Quoted 4 lines
waiting for forcewake old ack to clear.
I get it after resume from suspend to ram.
Is it some thing you need to know?
Is this a regression?
Quoted 10 lines
Hardware:
intel_stepping
Vendor:0x8086, Device:0x0166, Revision:0x09(??) render clock: unknown sampler clock: unknownIntel(R) Core(TM) i5-3317U CPU @ 1.70GHz
i use custom kernel: master linus (16.10.2012) + intel-drm-fixes (16.10.2012)
Quoted 15 lines · Ben Widawsky
Quoted 12 lines · On Wed, 17 Oct 2012 08:17:51 +0200 Oleksij Rempel…
Hallo all,
i get on Asus Zenbook UX32A [IVB] fallowing errors:
[ 4.464893] [drm:__gen6_gt_force_wake_mt_get] *ERROR* Timed out waiting for forcewake old ack to clear. [ 6678.604211] [drm:__gen6_gt_force_wake_mt_get] *ERROR* Timed out waiting for forcewake old ack to clear. [ 9144.381337] [drm:__gen6_gt_force_wake_mt_get] *ERROR* Timed out waiting for forcewake old ack to clear. [ 9189.374375] [drm:__gen6_gt_force_wake_mt_get] *ERROR* Timed outwaiting for forcewake old ack to clear.
Quoted 4 lines
Quoted 2 lines
I get it after resume from suspend to ram.
Is it some thing you need to know?Is this a regression?
No, the issue appears to be that we do not sanitise the forcewake upon takeover from BIOS and as such we leave it with RC6 suspended and no pending clear of the forcewake. The timeout of the first wait after boot/resume is to be expected.
I believe Mika Kuoppala was volunteered to write a small patch to address this...
-Chris
Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre
PATCH 1/1 drm/i915: Clear FORCEWAKE when taking over from BIOS
In reply to Oleksij RempelSome BIOSes may forcibly suspend RC6 during their operation which trigger a warning as we find the hardware in a perplexing state upon first use. So far that appears to be the worst symptom as fortuituously we use the same values as the BIOS for programming the FORCEWAKE register.
--- drivers/gpu/drm/i915/i915_drv.c | 2 ++ drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/intel_pm.c | 32 ++++++++++++++++++++++++++++++++ 3 files changed, 35 insertions(+)
drivers/gpu/drm/i915/i915_drv.c +2 -0
@@ -526,6 +526,8 @@ static int i915_drm_thaw(struct drm_device *dev)struct drm_i915_private *dev_priv = dev->dev_private;int error =0 ; +intel_gt_reset (dev); +if (drm_core_check_feature (dev,DRIVER_MODESET )) {mutex_lock (&dev->struct_mutex);i915_gem_restore_gtt_mappings (dev);
drivers/gpu/drm/i915/i915_drv.h +1 -0
@@ -1300,6 +1300,7 @@ void i915_handle_error(struct drm_device *dev, bool wedged);extern void intel_irq_init (struct drm_device *dev);extern void intel_gt_init (struct drm_device *dev); +extern void intel_gt_reset (struct drm_device *dev);void i915_error_state_free (struct kref *error_ref);
drivers/gpu/drm/i915/intel_pm.c +32 -0
@@ -3999,6 +3999,12 @@ static void __gen6_gt_wait_for_thread_c0(struct drm_i915_private *dev_priv)DRM_ERROR ("GT thread status wait timed out\n" ); } +static void __gen6_gt_force_wake_reset (struct drm_i915_private *dev_priv) +{ +I915_WRITE_NOTRACE (FORCEWAKE ,0 ); +POSTING_READ (ECOBUS );/* something from same cacheline, but !FORCEWAKE */ +} +static void __gen6_gt_force_wake_get (struct drm_i915_private *dev_priv) {u32 forcewake_ack;
@@ -4022,6 +4028,12 @@ static void __gen6_gt_force_wake_get(struct drm_i915_private *dev_priv)__gen6_gt_wait_for_thread_c0 (dev_priv); } +static void __gen6_gt_force_wake_mt_reset (struct drm_i915_private *dev_priv) +{ +I915_WRITE_NOTRACE (FORCEWAKE_MT ,_MASKED_BIT_DISABLE (0xffff )); +POSTING_READ (ECOBUS );/* something from same cacheline, but !FORCEWAKE */ +} +static void __gen6_gt_force_wake_mt_get (struct drm_i915_private *dev_priv) {u32 forcewake_ack;
@@ -4117,6 +4129,11 @@ int __gen6_gt_wait_for_fifo(struct drm_i915_private *dev_priv)return ret; } +static void vlv_force_wake_reset (struct drm_i915_private *dev_priv) +{ +I915_WRITE_NOTRACE (FORCEWAKE_VLV ,_MASKED_BIT_DISABLE (0xffff )); +} +static void vlv_force_wake_get (struct drm_i915_private *dev_priv) { if (wait_for_atomic((I915_READ_NOTRACE(FORCEWAKE_ACK_VLV) & 1) == 0,
@@ -4139,12 +4156,27 @@ static void vlv_force_wake_put(struct drm_i915_private *dev_priv)gen6_gt_check_fifodbg (dev_priv); } +void intel_gt_reset (struct drm_device *dev) +{ +struct drm_i915_private *dev_priv = dev->dev_private; + +if (IS_VALLEYVIEW (dev)) { +vlv_force_wake_reset (dev_priv); + }else if (INTEL_INFO (dev)->gen >=6 ) { +__gen6_gt_force_wake_reset (dev_priv); +if (IS_IVYBRIDGE (dev) ||IS_HASWELL (dev)) +__gen6_gt_force_wake_mt_reset (dev_priv); + } +} +void intel_gt_init (struct drm_device *dev) {struct drm_i915_private *dev_priv = dev->dev_private;spin_lock_init (&dev_priv->gt_lock); +intel_gt_reset (dev); +if (IS_VALLEYVIEW (dev)) { dev_priv->gt.force_wake_get = vlv_force_wake_get; dev_priv->gt.force_wake_put = vlv_force_wake_put;
Signature · 1 line
1.7.10.4
Re: [PATCH] drm/i915: Clear FORCEWAKE when taking over from BIOS
Quoted 81 lines · Chris Wilson
Some BIOSes may forcibly suspend RC6 during their operation which trigger a warning as we find the hardware in a perplexing state upon first use. So far that appears to be the worst symptom as fortuituously we use the same values as the BIOS for programming the FORCEWAKE register.
Reported-by <[email protected]>Signed-off-by Chris Wilson <[email protected]>--- drivers/gpu/drm/i915/i915_drv.c | 2 ++ drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/intel_pm.c | 32 ++++++++++++++++++++++++++++++++ 3 files changed, 35 insertions(+)drivers/gpu/drm/i915/i915_drv.c +2
-0@@ -526,6 +526,8 @@ static int i915_drm_thaw(struct drm_device *dev)struct drm_i915_private *dev_priv = dev->dev_private;int error =0 ; +intel_gt_reset (dev); +if (drm_core_check_feature (dev,DRIVER_MODESET )) {mutex_lock (&dev->struct_mutex);i915_gem_restore_gtt_mappings (dev);drivers/gpu/drm/i915/i915_drv.h +1
-0@@ -1300,6 +1300,7 @@ void i915_handle_error(struct drm_device *dev, bool wedged);extern void intel_irq_init (struct drm_device *dev);extern void intel_gt_init (struct drm_device *dev); +extern void intel_gt_reset (struct drm_device *dev);void i915_error_state_free (struct kref *error_ref);drivers/gpu/drm/i915/intel_pm.c +17
-0@@ -3999,6 +3999,12 @@ static void __gen6_gt_wait_for_thread_c0(struct drm_i915_private *dev_priv)DRM_ERROR ("GT thread status wait timed out\n" ); } +static void __gen6_gt_force_wake_reset (struct drm_i915_private *dev_priv) +{ +I915_WRITE_NOTRACE (FORCEWAKE ,0 ); +POSTING_READ (ECOBUS );/* something from same cacheline, but !FORCEWAKE */ +} +static void __gen6_gt_force_wake_get (struct drm_i915_private *dev_priv) {u32 forcewake_ack;@@ -4022,6 +4028,12 @@ static void __gen6_gt_force_wake_get(struct drm_i915_private *dev_priv)__gen6_gt_wait_for_thread_c0 (dev_priv); } +static void __gen6_gt_force_wake_mt_reset (struct drm_i915_private *dev_priv) +{ +I915_WRITE_NOTRACE (FORCEWAKE_MT ,_MASKED_BIT_DISABLE (0xffff )); +POSTING_READ (ECOBUS );/* something from same cacheline, but !FORCEWAKE */ +} +static void __gen6_gt_force_wake_mt_get (struct drm_i915_private *dev_priv) {u32 forcewake_ack;@@ -4117,6 +4129,11 @@ int __gen6_gt_wait_for_fifo(struct drm_i915_private *dev_priv)return ret; } +static void vlv_force_wake_reset (struct drm_i915_private *dev_priv) +{ +I915_WRITE_NOTRACE (FORCEWAKE_VLV ,_MASKED_BIT_DISABLE (0xffff )); +} +static void vlv_force_wake_get (struct drm_i915_private *dev_priv) { if (wait_for_atomic((I915_READ_NOTRACE(FORCEWAKE_ACK_VLV) & 1) == 0,
drivers/gpu/drm/i915/intel_pm.c static void vlv_force_wake_put(struct drm_i915_private *dev_priv) · line 4161
Quoted 6 lines
drivers/gpu/drm/i915/intel_pm.c +3
-0@@ -4139,12 +4156,27 @@ static void vlv_force_wake_put(struct drm_i915_private *dev_priv)gen6_gt_check_fifodbg (dev_priv); } +void intel_gt_reset (struct drm_device *dev) +{ +struct drm_i915_private *dev_priv = dev->dev_private;
Would it be possible to call in here:
if (HAS_FORCE_WAKE(dev))
dev_priv->gt.force_wake_put(dev_priv);and get rid of the per gen forcewake resets?
Quoted 26 lines
drivers/gpu/drm/i915/intel_pm.c +11
-0+ +if (IS_VALLEYVIEW (dev)) { +vlv_force_wake_reset (dev_priv); + }else if (INTEL_INFO (dev)->gen >=6 ) { +__gen6_gt_force_wake_reset (dev_priv); +if (IS_IVYBRIDGE (dev) ||IS_HASWELL (dev)) +__gen6_gt_force_wake_mt_reset (dev_priv); + } +}void intel_gt_init (struct drm_device *dev) {struct drm_i915_private *dev_priv = dev->dev_private;spin_lock_init (&dev_priv->gt_lock); +intel_gt_reset (dev); +if (IS_VALLEYVIEW (dev)) { dev_priv->gt.force_wake_get = vlv_force_wake_get; dev_priv->gt.force_wake_put = vlv_force_wake_put;Signature · 5 lines
1.7.10.4 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki
Business Identity Code: 0357606 - 4
Domiciled in Helsinki
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
Re: [PATCH] drm/i915: Clear FORCEWAKE when taking over from BIOS
Quoted 6 lines · Mika Kuoppala
Would it be possible to call in here:
if (HAS_FORCE_WAKE(dev)) dev_priv->gt.force_wake_put(dev_priv);and get rid of the per gen forcewake resets?
No. Perhaps I would have better gone with intel_gt_sanitize(), as the purpose is not to undo our own settings of the forcewake but undo that of nefarious foreign interests such as the BIOS. As such we need to explicitly clear the register rather than clear a bit. -Chris
Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre
Mika Kuoppala
Reviewed-byRe: [PATCH] drm/i915: Clear FORCEWAKE when taking over from BIOS
Quoted 6 lines · Chris Wilson
Quoted 5 lines · Mika Kuoppala
Would it be possible to call in here:
if (HAS_FORCE_WAKE(dev)) dev_priv->gt.force_wake_put(dev_priv);
Quoted 7 lines
Quoted 1 line
and get rid of the per gen forcewake resets?
No. Perhaps I would have better gone with
intel_gt_sanitize(), as the purpose is not to undo our own settings of the forcewake but undo that of nefarious foreign interests such as the BIOS. As such we need to explicitly clear the register rather than clear a bit. -Chris
Thanks for explanation.
Quoted 2 lines
Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre
---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki
Business Identity Code: 0357606 - 4
Domiciled in Helsinki
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
Re: [PATCH] drm/i915: Clear FORCEWAKE when taking over from BIOS
In reply to Chris WilsonTested. No error.
Thank you.
Am 18.10.2012 12:46, schrieb Chris Wilson:
Quoted 109 lines
Some BIOSes may forcibly suspend RC6 during their operation which trigger a warning as we find the hardware in a perplexing state upon first use. So far that appears to be the worst symptom as fortuituously we use the same values as the BIOS for programming the FORCEWAKE register.
Reported-by <[email protected]>Signed-off-by Chris Wilson <[email protected]>--- drivers/gpu/drm/i915/i915_drv.c | 2 ++ drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/intel_pm.c | 32 ++++++++++++++++++++++++++++++++ 3 files changed, 35 insertions(+)drivers/gpu/drm/i915/i915_drv.c +2
-0@@ -526,6 +526,8 @@ static int i915_drm_thaw(struct drm_device *dev)struct drm_i915_private *dev_priv = dev->dev_private;int error =0 ; +intel_gt_reset (dev); +if (drm_core_check_feature (dev,DRIVER_MODESET )) {mutex_lock (&dev->struct_mutex);i915_gem_restore_gtt_mappings (dev);drivers/gpu/drm/i915/i915_drv.h +1
-0@@ -1300,6 +1300,7 @@ void i915_handle_error(struct drm_device *dev, bool wedged);extern void intel_irq_init (struct drm_device *dev);extern void intel_gt_init (struct drm_device *dev); +extern void intel_gt_reset (struct drm_device *dev);void i915_error_state_free (struct kref *error_ref);drivers/gpu/drm/i915/intel_pm.c +32
-0@@ -3999,6 +3999,12 @@ static void __gen6_gt_wait_for_thread_c0(struct drm_i915_private *dev_priv)DRM_ERROR ("GT thread status wait timed out\n" ); } +static void __gen6_gt_force_wake_reset (struct drm_i915_private *dev_priv) +{ +I915_WRITE_NOTRACE (FORCEWAKE ,0 ); +POSTING_READ (ECOBUS );/* something from same cacheline, but !FORCEWAKE */ +} +static void __gen6_gt_force_wake_get (struct drm_i915_private *dev_priv) {u32 forcewake_ack;@@ -4022,6 +4028,12 @@ static void __gen6_gt_force_wake_get(struct drm_i915_private *dev_priv)__gen6_gt_wait_for_thread_c0 (dev_priv); } +static void __gen6_gt_force_wake_mt_reset (struct drm_i915_private *dev_priv) +{ +I915_WRITE_NOTRACE (FORCEWAKE_MT ,_MASKED_BIT_DISABLE (0xffff )); +POSTING_READ (ECOBUS );/* something from same cacheline, but !FORCEWAKE */ +} +static void __gen6_gt_force_wake_mt_get (struct drm_i915_private *dev_priv) {u32 forcewake_ack;@@ -4117,6 +4129,11 @@ int __gen6_gt_wait_for_fifo(struct drm_i915_private *dev_priv)return ret; } +static void vlv_force_wake_reset (struct drm_i915_private *dev_priv) +{ +I915_WRITE_NOTRACE (FORCEWAKE_VLV ,_MASKED_BIT_DISABLE (0xffff )); +} +static void vlv_force_wake_get (struct drm_i915_private *dev_priv) { if (wait_for_atomic((I915_READ_NOTRACE(FORCEWAKE_ACK_VLV) & 1) == 0,@@ -4139,12 +4156,27 @@ static void vlv_force_wake_put(struct drm_i915_private *dev_priv)gen6_gt_check_fifodbg (dev_priv); } +void intel_gt_reset (struct drm_device *dev) +{ +struct drm_i915_private *dev_priv = dev->dev_private; + +if (IS_VALLEYVIEW (dev)) { +vlv_force_wake_reset (dev_priv); + }else if (INTEL_INFO (dev)->gen >=6 ) { +__gen6_gt_force_wake_reset (dev_priv); +if (IS_IVYBRIDGE (dev) ||IS_HASWELL (dev)) +__gen6_gt_force_wake_mt_reset (dev_priv); + } +} +void intel_gt_init (struct drm_device *dev) {struct drm_i915_private *dev_priv = dev->dev_private;spin_lock_init (&dev_priv->gt_lock); +intel_gt_reset (dev); +if (IS_VALLEYVIEW (dev)) { dev_priv->gt.force_wake_get = vlv_force_wake_get; dev_priv->gt.force_wake_put = vlv_force_wake_put;
Signature · 2 lines
Regards, Oleksij