Skip to contentSkip to conversation

serial: ifx6x60: del_timer_sync must not be called in interrupt context.

PATCH In review Jun Chen 3 participants 3 messages Oct 19, 2012 TTY layer and serial drivers

lore
Share & tools
lore

Jun Chen

author
#0 lore raw

PATCH 1/1 serial: ifx6x60: del_timer_sync must not be called in interrupt context.

This patch make use of del_timer instead of del_timer_sync in the interrupt context.
The spi_timer function don't use any resources that may release after running del_timer,
so using the del_timer is also safe and enough in this context.

---
 drivers/tty/serial/ifx6x60.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/tty/serial/ifx6x60.c +1 -1
index 5b9bc19..769396a 100644
@@ -826,7 +826,7 @@ error_ret:
 static void ifx_spi_handle_srdy(struct ifx_spi_device *ifx_dev)
 {
 	if (test_bit(IFX_SPI_STATE_TIMER_PENDING, &ifx_dev->flags)) {
-		del_timer_sync(&ifx_dev->spi_timer);
+		del_timer(&ifx_dev->spi_timer);
 		clear_bit(IFX_SPI_STATE_TIMER_PENDING, &ifx_dev->flags);
 	}
 
Signature · 1 line
1.7.4.1
#1 lore raw
Quoted 11 lines

-----Original Message-----
From: Chen, Jun D
Sent: Friday, October 19, 2012 9:52 PM
To: [email protected]
Cc: [email protected]; Gorby, Russ; Liu, Chuansheng; Bi, Chao
Subject: [PATCH] serial: ifx6x60: del_timer_sync must not be called in interrupt context.

Quoted 7 lines

This patch make use of del_timer instead of del_timer_sync in the interrupt context.
The spi_timer function don't use any resources that may release after running del_timer,
so using the del_timer is also safe and enough in this context.

It has been tested on our medfield platform.