serial: ifx6x60: del_timer_sync must not be called in interrupt context.
PATCH 1/1 serial: ifx6x60: del_timer_sync must not be called in interrupt context.
This patch make use of del_timer instead of del_timer_sync in the interrupt context.
The spi_timer function don't use any resources that may release after running del_timer,
so using the del_timer is also safe and enough in this context.
--- drivers/tty/serial/ifx6x60.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/tty/serial/ifx6x60.c +1 -1
@@ -826,7 +826,7 @@ error_ret:static void ifx_spi_handle_srdy (struct ifx_spi_device *ifx_dev) {if (test_bit (IFX_SPI_STATE_TIMER_PENDING , &ifx_dev->flags)) { -del_timer_sync (&ifx_dev->spi_timer); +del_timer (&ifx_dev->spi_timer);clear_bit (IFX_SPI_STATE_TIMER_PENDING , &ifx_dev->flags); }
Signature · 1 line
1.7.4.1
Quoted 11 lines
-----Original Message-----
From: Chen, Jun D
Sent: Friday, October 19, 2012 9:52 PM
To: [email protected]
Cc: [email protected]; Gorby, Russ; Liu, Chuansheng; Bi, Chao
Subject: [PATCH] serial: ifx6x60:del_timer_syncmust not be called in interrupt context.
Quoted 7 lines
This patch make use of
del_timerinstead ofdel_timer_syncin the interrupt context.
Thespi_timerfunction don't use any resources that may release after runningdel_timer,
so using thedel_timeris also safe and enough in this context.Signed-off-by Chen Jun <[email protected]>
It has been tested on our medfield platform.
Quoted 8 lines · On Fri, 19 Oct 2012 09:51:30 -0400 Jun Chen <[email protected]> wrote:
This patch make use of
del_timerinstead ofdel_timer_syncin the interrupt context.
Thespi_timerfunction don't use any resources that may release after runningdel_timer,
so using thedel_timeris also safe and enough in this context.Signed-off-by Chen Jun <[email protected]>