Skip to contentSkip to conversation

HACK: fix return value of serial_assign to get printfs working again

PATCH New Allen Martin 2 participants 2 messages Oct 20, 2012

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 HACK: fix return value of serial_assign to get printfs working again

This reverts a recent change to serial_assign() that broke printfs on tegra. I don't think this is the real fix, but I'm just putting this out for others who want to test tegra patches for the other regressions.

---
 drivers/serial/serial.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/serial/serial.c +1 -1
index e0886d5..f1c55bf 100644
@@ -268,7 +268,7 @@ int serial_assign(const char *name)
 		return 0;
 	}
 
-	return -EINVAL;
+	return 1;
 }
 
 /**
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 1/1 HACK: fix return value of serial_assign to get printfs working again

Dear Allen Martin,

Quoted 6 lines

This reverts a recent change to serial_assign() that broke printfs on tegra. I don't think this is the real fix, but I'm just putting this out for others who want to test tegra patches for the other regressions.

Indeed, NAK. Please fix iomux.c, see the comment on how serial_assign() is (mis)used there. Thanks!

Quoted 9 lines
---
 drivers/serial/serial.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/serial/serial.c +0 -0
index e0886d5..f1c55bf 100644

drivers/serial/serial.c int serial_assign(const char *name) · line 274

Quoted 8 lines
drivers/serial/serial.c +1 -1
@@ -268,7 +268,7 @@ int serial_assign(const char *name)
 		return 0;
 	}
 
-	return -EINVAL;
+	return 1;
 }
 
 /**

Best regards,
Marek Vasut