ARM/dts: omap3: Fix mcbsp2/3 hwmods to be able to probe the drivers for audio

PATCH New Peter Ujfalusi 3 participants 4 messages Oct 18, 2012 – Oct 22, 2012 Device tree bindings

lore

Share & tools

lore

Peter Ujfalusi

author

2012-10-18 09:25 UTC #0 lore raw

PATCH 1/1 ARM/dts: omap3: Fix mcbsp2/3 hwmods to be able to probe the drivers for audio

Fixes the following errors:

[    2.318084] omap-mcbsp 49022000.mcbsp: invalid rx DMA channel
[    2.324432] omap-mcbsp 49024000.mcbsp: invalid rx DMA channel

Which is because we failed to link the sidetone hwmod for McBSP2/3. The missing sidetone hwmod link will prevent omap_device_alloc() to append the DMA resources since we - accidentally - end up having the same number of resources provided from DT (IO/IRQ) as we have in hwmod for the McBSP ports without the ST resources.

Signed-off-by Peter Ujfalusi <[email protected]>

---

Hi Tony, Benoit,

Can you please take this patch for 3.7 since if we boot with DT audio will not work on BeagleBoard and on boards which uses McBSP2 or 3 for audio.

Thank you,
Peter

 arch/arm/boot/dts/omap3.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

arch/arm/boot/dts/omap3.dtsi +2 -2

index f38ea87..696e929 100644
@@ -257,7 +257,7 @@
 			interrupt-names = "common", "tx", "rx", "sidetone";
 			interrupt-parent = <&intc>;
 			ti,buffer-size = <1280>;
-			ti,hwmods = "mcbsp2";
+			ti,hwmods = "mcbsp2", "mcbsp2_sidetone";
 		};
 
 		mcbsp3: mcbsp at 49024000 {

@@ -272,7 +272,7 @@
 			interrupt-names = "common", "tx", "rx", "sidetone";
 			interrupt-parent = <&intc>;
 			ti,buffer-size = <128>;
-			ti,hwmods = "mcbsp3";
+			ti,hwmods = "mcbsp3", "mcbsp3_sidetone";
 		};
 
 		mcbsp4: mcbsp at 49026000 {

Signature · 1 line

1.7.12.3

Benoit Cousson

2012-10-18 10:00 UTC #1 lore raw

PATCH 1/1 ARM/dts: omap3: Fix mcbsp2/3 hwmods to be able to probe the drivers for audio

Quoted 11 lines · Peter Ujfalusi

Fixes the following errors:
[    2.318084] omap-mcbsp 49022000.mcbsp: invalid rx DMA channel
[    2.324432] omap-mcbsp 49024000.mcbsp: invalid rx DMA channel
Which is because we failed to link the sidetone hwmod for McBSP2/3. The missing sidetone hwmod link will prevent omap_device_alloc() to append the DMA resources since we - accidentally - end up having the same number of resources provided from DT (IO/IRQ) as we have in hwmod for the McBSP ports without the ST resources.
Signed-off-by Peter Ujfalusi <[email protected]>

Acked-by Benoit Cousson <[email protected]>

Regards,
Benoit

Quoted 36 lines

---

Hi Tony, Benoit,

Can you please take this patch for 3.7 since if we boot with DT audio will not work on BeagleBoard and on boards which uses McBSP2 or 3 for audio.

Thank you,
Peter

 arch/arm/boot/dts/omap3.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

arch/arm/boot/dts/omap3.dtsi +2 -2

index f38ea87..696e929 100644
@@ -257,7 +257,7 @@
 			interrupt-names = "common", "tx", "rx", "sidetone";
 			interrupt-parent = <&intc>;
 			ti,buffer-size = <1280>;
-			ti,hwmods = "mcbsp2";
+			ti,hwmods = "mcbsp2", "mcbsp2_sidetone";
 		};
 
 		mcbsp3: mcbsp at 49024000 {

@@ -272,7 +272,7 @@
 			interrupt-names = "common", "tx", "rx", "sidetone";
 			interrupt-parent = <&intc>;
 			ti,buffer-size = <128>;
-			ti,hwmods = "mcbsp3";
+			ti,hwmods = "mcbsp3", "mcbsp3_sidetone";
 		};
 
 		mcbsp4: mcbsp at 49026000 {

Péter Ujfalusi

author

2012-10-22 11:41 UTC #2 lore raw

PATCH 1/1 ARM/dts: omap3: Fix mcbsp2/3 hwmods to be able to probe the drivers for audio

Hi Tony,

Quoted 11 lines · Benoit Cousson

Quoted 10 lines · Peter Ujfalusi
Fixes the following errors:
[    2.318084] omap-mcbsp 49022000.mcbsp: invalid rx DMA channel
[    2.324432] omap-mcbsp 49024000.mcbsp: invalid rx DMA channel
Which is because we failed to link the sidetone hwmod for McBSP2/3. The missing sidetone hwmod link will prevent omap_device_alloc() to append the DMA resources since we - accidentally - end up having the same number of resources provided from DT (IO/IRQ) as we have in hwmod for the McBSP ports without the ST resources.

Quoted 3 lines

Quoted 1 line
Signed-off-by Peter Ujfalusi <[email protected]>
Acked-by Benoit Cousson <[email protected]>

Can you take this patch for -rc3?

Thanks,
P?ter

Quoted 41 lines

Regards,
Benoit

Quoted 36 lines

---

Hi Tony, Benoit,

Can you please take this patch for 3.7 since if we boot with DT audio will not work on BeagleBoard and on boards which uses McBSP2 or 3 for audio.

Thank you,
Peter

 arch/arm/boot/dts/omap3.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

arch/arm/boot/dts/omap3.dtsi +2 -2

index f38ea87..696e929 100644
@@ -257,7 +257,7 @@
 			interrupt-names = "common", "tx", "rx", "sidetone";
 			interrupt-parent = <&intc>;
 			ti,buffer-size = <1280>;
-			ti,hwmods = "mcbsp2";
+			ti,hwmods = "mcbsp2", "mcbsp2_sidetone";
 		};
 
 		mcbsp3: mcbsp at 49024000 {

@@ -272,7 +272,7 @@
 			interrupt-names = "common", "tx", "rx", "sidetone";
 			interrupt-parent = <&intc>;
 			ti,buffer-size = <128>;
-			ti,hwmods = "mcbsp3";
+			ti,hwmods = "mcbsp3", "mcbsp3_sidetone";
 		};
 
 		mcbsp4: mcbsp at 49026000 {

Tony Lindgren

2012-10-22 20:38 UTC #3 lore raw

PATCH 1/1 ARM/dts: omap3: Fix mcbsp2/3 hwmods to be able to probe the drivers for audio

Quoted 14 lines · P?ter Ujfalusi

Hi Tony,
Quoted 11 lines · Benoit Cousson
Quoted 10 lines · Peter Ujfalusi
Fixes the following errors:
[    2.318084] omap-mcbsp 49022000.mcbsp: invalid rx DMA channel
[    2.324432] omap-mcbsp 49024000.mcbsp: invalid rx DMA channel
Which is because we failed to link the sidetone hwmod for McBSP2/3. The missing sidetone hwmod link will prevent omap_device_alloc() to append the DMA resources since we - accidentally - end up having the same number of resources provided from DT (IO/IRQ) as we have in hwmod for the McBSP ports without the ST resources.

Quoted 5 lines

Quoted 3 lines
Quoted 1 line
Signed-off-by Peter Ujfalusi <[email protected]>
Acked-by Benoit Cousson <[email protected]>
Can you take this patch for -rc3?

Thanks will apply into omap-for-v3.7-rc2/fixes.

Regards,

Tony