ARM: boot: Fix usage of kecho

PATCH New Fabio Estevam 3 participants 5 messages Oct 24, 2012 – Nov 12, 2012 Arm (32-bit)

lore

Share & tools

lore

Fabio Estevam

author

2012-10-24 18:37 UTC #0 lore raw

PATCH 1/1 ARM: boot: Fix usage of kecho

From: Fabio Estevam <[email protected]>

Since commit edc88ceb0 (ARM: be really quiet when building with 'make -s') the following output is generated when building a kernel for ARM:

echo ' Kernel: arch/arm/boot/Image is ready'
Kernel: arch/arm/boot/Image is ready
Building modules, stage 2.
echo ' Kernel: arch/arm/boot/zImage is ready'
Kernel: arch/arm/boot/zImage is ready

As per Documentation/kbuild/makefiles.txt the correct way of using kecho is '@$(kecho)'.

Make this change so no more unwanted 'echo' messages are displayed.

Signed-off-by Fabio Estevam <[email protected]>

---
 arch/arm/boot/Makefile  |   10 +++++-----
 arch/arm/tools/Makefile |    2 +-
 2 files changed, 6 insertions(+), 6 deletions(-)

arch/arm/boot/Makefile +5 -5

index f2aa09e..9137df5 100644
@@ -33,7 +33,7 @@ ifeq ($(CONFIG_XIP_KERNEL),y)
 
 $(obj)/xipImage: vmlinux FORCE
 	$(call if_changed,objcopy)
-	$(kecho) '  Kernel: $@ is ready (physical address: $(CONFIG_XIP_PHYS_ADDR))'
+	@$(kecho) '  Kernel: $@ is ready (physical address: $(CONFIG_XIP_PHYS_ADDR))'
 
 $(obj)/Image $(obj)/zImage: FORCE
 	@echo 'Kernel configured for XIP (CONFIG_XIP_KERNEL=y)'

@@ -48,14 +48,14 @@ $(obj)/xipImage: FORCE
 
 $(obj)/Image: vmlinux FORCE
 	$(call if_changed,objcopy)
-	$(kecho) '  Kernel: $@ is ready'
+	@$(kecho) '  Kernel: $@ is ready'
 
 $(obj)/compressed/vmlinux: $(obj)/Image FORCE
 	$(Q)$(MAKE) $(build)=$(obj)/compressed $@
 
 $(obj)/zImage:	$(obj)/compressed/vmlinux FORCE
 	$(call if_changed,objcopy)
-	$(kecho) '  Kernel: $@ is ready'
+	@$(kecho) '  Kernel: $@ is ready'
 
 endif

@@ -90,7 +90,7 @@ fi
 $(obj)/uImage:	$(obj)/zImage FORCE
 	@$(check_for_multiple_loadaddr)
 	$(call if_changed,uimage)
-	$(kecho) '  Image $@ is ready'
+	@$(kecho) '  Image $@ is ready'
 
 $(obj)/bootp/bootp: $(obj)/zImage initrd FORCE
 	$(Q)$(MAKE) $(build)=$(obj)/bootp $@

@@ -98,7 +98,7 @@ $(obj)/bootp/bootp: $(obj)/zImage initrd FORCE
 
 $(obj)/bootpImage: $(obj)/bootp/bootp FORCE
 	$(call if_changed,objcopy)
-	$(kecho) '  Kernel: $@ is ready'
+	@$(kecho) '  Kernel: $@ is ready'
 
 PHONY += initrd FORCE
 initrd:

arch/arm/tools/Makefile +1 -1

index cd60a81..32d05c8 100644
@@ -5,6 +5,6 @@
 #
 
 include/generated/mach-types.h: $(src)/gen-mach-types $(src)/mach-types
-	$(kecho) '  Generating $@'
+	@$(kecho) '  Generating $@'
 	@mkdir -p $(dir $@)
 	$(Q)$(AWK) -f $^ > $@ || { rm -f $@; /bin/false; }

Signature · 1 line

1.7.9.5

Nicolas Pitre

2012-10-24 18:45 UTC #1 lore raw

PATCH 1/1 ARM: boot: Fix usage of kecho

Quoted 11 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>
Since commit edc88ceb0 (ARM: be really quiet when building with 'make -s') the following output is generated when building a kernel for ARM:
echo ' Kernel: arch/arm/boot/Image is ready'
Kernel: arch/arm/boot/Image is ready
Building modules, stage 2.
echo ' Kernel: arch/arm/boot/zImage is ready'
Kernel: arch/arm/boot/zImage is ready

Quoted 6 lines

As per Documentation/kbuild/makefiles.txt the correct way of using kecho is '@$(kecho)'.
Make this change so no more unwanted 'echo' messages are displayed.
Signed-off-by Fabio Estevam <[email protected]>

Acked-by Nicolas Pitre <[email protected]>

Quoted 68 lines

---
 arch/arm/boot/Makefile  |   10 +++++-----
 arch/arm/tools/Makefile |    2 +-
 2 files changed, 6 insertions(+), 6 deletions(-)

arch/arm/boot/Makefile +5 -5

index f2aa09e..9137df5 100644
@@ -33,7 +33,7 @@ ifeq ($(CONFIG_XIP_KERNEL),y)
 
 $(obj)/xipImage: vmlinux FORCE
 	$(call if_changed,objcopy)
-	$(kecho) '  Kernel: $@ is ready (physical address: $(CONFIG_XIP_PHYS_ADDR))'
+	@$(kecho) '  Kernel: $@ is ready (physical address: $(CONFIG_XIP_PHYS_ADDR))'
 
 $(obj)/Image $(obj)/zImage: FORCE
 	@echo 'Kernel configured for XIP (CONFIG_XIP_KERNEL=y)'

@@ -48,14 +48,14 @@ $(obj)/xipImage: FORCE
 
 $(obj)/Image: vmlinux FORCE
 	$(call if_changed,objcopy)
-	$(kecho) '  Kernel: $@ is ready'
+	@$(kecho) '  Kernel: $@ is ready'
 
 $(obj)/compressed/vmlinux: $(obj)/Image FORCE
 	$(Q)$(MAKE) $(build)=$(obj)/compressed $@
 
 $(obj)/zImage:	$(obj)/compressed/vmlinux FORCE
 	$(call if_changed,objcopy)
-	$(kecho) '  Kernel: $@ is ready'
+	@$(kecho) '  Kernel: $@ is ready'
 
 endif

@@ -90,7 +90,7 @@ fi
 $(obj)/uImage:	$(obj)/zImage FORCE
 	@$(check_for_multiple_loadaddr)
 	$(call if_changed,uimage)
-	$(kecho) '  Image $@ is ready'
+	@$(kecho) '  Image $@ is ready'
 
 $(obj)/bootp/bootp: $(obj)/zImage initrd FORCE
 	$(Q)$(MAKE) $(build)=$(obj)/bootp $@

@@ -98,7 +98,7 @@ $(obj)/bootp/bootp: $(obj)/zImage initrd FORCE
 
 $(obj)/bootpImage: $(obj)/bootp/bootp FORCE
 	$(call if_changed,objcopy)
-	$(kecho) '  Kernel: $@ is ready'
+	@$(kecho) '  Kernel: $@ is ready'
 
 PHONY += initrd FORCE
 initrd:

arch/arm/tools/Makefile +1 -1

index cd60a81..32d05c8 100644
@@ -5,6 +5,6 @@
 #
 
 include/generated/mach-types.h: $(src)/gen-mach-types $(src)/mach-types
-	$(kecho) '  Generating $@'
+	@$(kecho) '  Generating $@'
 	@mkdir -p $(dir $@)
 	$(Q)$(AWK) -f $^ > $@ || { rm -f $@; /bin/false; }

Signature · 1 line

1.7.9.5

Arnd Bergmann

2012-10-24 19:28 UTC #2 lore raw

PATCH 1/1 ARM: boot: Fix usage of kecho

Quoted 13 lines · Nicolas Pitre

Quoted 11 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
Since commit edc88ceb0 (ARM: be really quiet when building with 'make -s') the following output is generated when building a kernel for ARM:
echo ' Kernel: arch/arm/boot/Image is ready'
Kernel: arch/arm/boot/Image is ready
Building modules, stage 2.
echo ' Kernel: arch/arm/boot/zImage is ready'
Kernel: arch/arm/boot/zImage is ready

Quoted 8 lines

Quoted 6 lines
As per Documentation/kbuild/makefiles.txt the correct way of using kecho is '@$(kecho)'.
Make this change so no more unwanted 'echo' messages are displayed.
Signed-off-by Fabio Estevam <[email protected]>
Acked-by Nicolas Pitre <[email protected]>

Acked-by Arnd Bergmann <[email protected]>

Sorry for this, I really should have tested without '-s'.

Arnd

Fabio Estevam

author

2012-11-12 22:09 UTC #3 lore raw

PATCH 1/1 ARM: boot: Fix usage of kecho

Hi Arnd,

Quoted 17 lines · Arnd Bergmann

Quoted 16 lines · Nicolas Pitre
Quoted 14 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
Since commit edc88ceb0 (ARM: be really quiet when building with 'make -s') the following output is generated when building a kernel for ARM:
echo ' Kernel: arch/arm/boot/Image is ready'
Kernel: arch/arm/boot/Image is ready
Building modules, stage 2.
echo ' Kernel: arch/arm/boot/zImage is ready'
Kernel: arch/arm/boot/zImage is ready
As per Documentation/kbuild/makefiles.txt the correct way of using kecho is '@$(kecho)'.

Quoted 7 lines

Quoted 5 lines
Quoted 3 lines
Make this change so no more unwanted 'echo' messages are displayed.
Signed-off-by Fabio Estevam <[email protected]>
Acked-by Nicolas Pitre <[email protected]>
Acked-by Arnd Bergmann <[email protected]>

Would this one go via arm-soc tree?

Regards,

Fabio Estevam

Arnd Bergmann

2012-11-12 22:24 UTC #4 lore raw

PATCH 1/1 ARM: boot: Fix usage of kecho

Quoted 16 lines · Fabio Estevam

Quoted 16 lines
Quoted 16 lines
Quoted 16 lines
From: Fabio Estevam <[email protected]>
Since commit edc88ceb0 (ARM: be really quiet when building with 'make -s') the following output is generated when building a kernel for ARM:
echo ' Kernel: arch/arm/boot/Image is ready'
Kernel: arch/arm/boot/Image is ready
Building modules, stage 2.
echo ' Kernel: arch/arm/boot/zImage is ready'
Kernel: arch/arm/boot/zImage is ready
As per Documentation/kbuild/makefiles.txt the correct way of using kecho is '@$(kecho)'.
Make this change so no more unwanted 'echo' messages are displayed.

Quoted 7 lines

Quoted 5 lines
Quoted 3 lines
Quoted 1 line
Signed-off-by Fabio Estevam <[email protected]>
Acked-by Nicolas Pitre <[email protected]>
Acked-by Arnd Bergmann <[email protected]>
Would this one go via arm-soc tree?

The correct way would be via Russell's tree, but since we're sending bug fix patches tomorrow through arm-soc and this one is getting embarrassingly old, I've applied it now.

Thanks for the reminder.

Arnd