Skip to content Skip to conversation

net/bluetooth/l2cap_core.c:4495:6: sparse: symbol 'l2cap_physical_cfm' was not declared. Should it be static?

PATCH In review Fengguang Wu 5 participants 6 messages Oct 24, 2012 – Oct 25, 2012

Subsystems (2)

Bluetooth drivers Bluetooth

Share & tools

Fengguang Wu

author

2012-10-24 21:55 UTC #0 lore raw

PATCH 12/33 net/bluetooth/l2cap_core.c:4495:6: sparse: symbol 'l2cap_physical_cfm' was not declared. Should it be static?

Hi Mat,

FYI, there are new sparse warnings show up in

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master
head:   77220c6582477e696e3f3a53634fb1bd73128e95
commit: 8eb200bd2f1c772dcb7f108f690ef03b054be04e [12/33] Bluetooth: Handle physical link completion

+ net/bluetooth/l2cap_core.c:4495:6: sparse: symbol 'l2cap_physical_cfm' was not declared. Should it be static?

Please consider folding the attached diff :-)

---
0-DAY kernel build testing backend Open Source Technology Center
Fengguang Wu, Yuanhan Liu Intel Corporation

net/bluetooth/l2cap_core.c +1 -1

index 898529d..24285e5 100644
@@ -4492,7 +4492,7 @@ static void l2cap_do_move_cancel(struct l2cap_chan *chan, int result)
 	l2cap_ertm_send(chan);
 }
 
-void l2cap_physical_cfm(struct l2cap_chan *chan, int result, u8 local_amp_id,
+static void l2cap_physical_cfm(struct l2cap_chan *chan, int result, u8 local_amp_id,
 			u8 remote_amp_id)
 {
 	BT_DBG("chan %p, result %d, local_amp_id %d, remote_amp_id %d",

Gustavo Padovan

2012-10-24 22:01 UTC #1 lore raw

Hi Fengguang,

Quoted 11 lines · Fengguang Wu

Hi Mat,
FYI, there are new sparse warnings show up in
tree:   git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master
head:   77220c6582477e696e3f3a53634fb1bd73128e95
commit: 8eb200bd2f1c772dcb7f108f690ef03b054be04e [12/33] Bluetooth: Handle physical link completion
+ net/bluetooth/l2cap_core.c:4495:6: sparse: symbol 'l2cap_physical_cfm' was not declared. Should it be static?
Please consider folding the attached diff :-)

Thanks a lot for finding this, but please can you send me a proper git formatted patch with Signed-off-by message so I can add your patch to bluetooth-next.

Gustavo

Fengguang Wu

author

2012-10-25 00:26 UTC #2 lore raw

PATCH 1/1 Bluetooth: l2cap_physical_cfm() can be static

Signed-off-by Fengguang Wu <[email protected]>

---
 net/bluetooth/l2cap_core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

net/bluetooth/l2cap_core.c +1 -1

@@ -4569,7 +4569,7 @@ static void l2cap_do_move_cancel(struct
 	l2cap_ertm_send(chan);
 }
 
-void l2cap_physical_cfm(struct l2cap_chan *chan, int result, u8 local_amp_id,
+static void l2cap_physical_cfm(struct l2cap_chan *chan, int result, u8 local_amp_id,
 			u8 remote_amp_id)
 {
 	BT_DBG("chan %p, result %d, local_amp_id %d, remote_amp_id %d",

Marcel Holtmann

maintainer

2012-10-25 01:55 UTC #3 lore raw

Re: [PATCH] Bluetooth: l2cap_physical_cfm() can be static

Hi Fengguang,

Quoted 8 lines

Signed-off-by Fengguang Wu <[email protected]>
---
 net/bluetooth/l2cap_core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

net/bluetooth/l2cap_core.c static void l2cap_do_move_cancel(struct · line 4573

Quoted 6 lines

net/bluetooth/l2cap_core.c +1 -1

@@ -4569,7 +4569,7 @@ static void l2cap_do_move_cancel(struct
 	l2cap_ertm_send(chan);
 }
 
-void l2cap_physical_cfm(struct l2cap_chan *chan, int result, u8 local_amp_id,
+static void l2cap_physical_cfm(struct l2cap_chan *chan, int result, u8 local_amp_id,
 			u8 remote_amp_id)

I rather wait for Mat to ACK or NACK this one. Maybe it is an oversight or we need that later on to be actually public.

Regards

Marcel

Andrei Emeltchenko

2012-10-25 07:13 UTC #4 lore raw

Re: [PATCH] Bluetooth: l2cap_physical_cfm() can be static

Hi,

Quoted 13 lines · Marcel Holtmann

Hi Fengguang,
Quoted 11 lines
Signed-off-by Fengguang Wu <[email protected]>
---
 net/bluetooth/l2cap_core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/bluetooth/l2cap_core.c +0 -0
@@ -4569,7 +4569,7 @@ static void l2cap_do_move_cancel(struct
 	l2cap_ertm_send(chan);
 }
 

Quoted 6 lines

net/bluetooth/l2cap_core.c static void l2cap_do_move_cancel(struct · line 4573
Quoted 3 lines
net/bluetooth/l2cap_core.c +1 -1
-void l2cap_physical_cfm(struct l2cap_chan *chan, int result, u8 local_amp_id,
+static void l2cap_physical_cfm(struct l2cap_chan *chan, int result, u8 local_amp_id,
 			u8 remote_amp_id)
I rather wait for Mat to ACK or NACK this one. Maybe it is an oversight or we need that later on to be actually public.

Agree with Marcel here. This shall be public.

Best regards
Andrei Emeltchenko

Mat Martineau

2012-10-25 15:29 UTC #5 lore raw

Re: [PATCH] Bluetooth: l2cap_physical_cfm() can be static

Hi -

Quoted 16 lines · Andrei Emeltchenko

Hi,
Quoted 13 lines · Marcel Holtmann
Hi Fengguang,
Quoted 11 lines
Signed-off-by Fengguang Wu <[email protected]>
---
 net/bluetooth/l2cap_core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/bluetooth/l2cap_core.c +0 -0
@@ -4569,7 +4569,7 @@ static void l2cap_do_move_cancel(struct
 	l2cap_ertm_send(chan);
 }
 

Quoted 8 lines

Quoted 6 lines
net/bluetooth/l2cap_core.c static void l2cap_do_move_cancel(struct · line 4573
Quoted 3 lines
net/bluetooth/l2cap_core.c +1 -1
-void l2cap_physical_cfm(struct l2cap_chan *chan, int result, u8 local_amp_id,
+static void l2cap_physical_cfm(struct l2cap_chan *chan, int result, u8 local_amp_id,
 			u8 remote_amp_id)
I rather wait for Mat to ACK or NACK this one. Maybe it is an oversight or we need that later on to be actually public.
Agree with Marcel here. This shall be public.

Yes, it does need to be public. Andrei will need to call it from the AMP physical link code, but I'm not sure exactly where (HCI event handling or somewhere in amp.c or a2mp.c).

--
Mat Martineau

Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation