usb: tegra: move Tegra EHCI implementation to correct place
Subsystems (4)
PATCH 1/1 usb: tegra: move Tegra EHCI implementation to correct place
Move the Tegra EHCI implementation to the correct directory in the tree. This code is specific to the Tegra EHCI controller, not to the Tegra SoC in general.
This is not just a move of the code, but also some small changes squashed in. Most notable:
- removed some unneeded parameters from function calls, to make functions more self contained
- decrease max controller count to 3, both Tegra 2 and 3 have at most 3 EHCI controllers, we can aleays increase this later if the need arises
- controllers only get activated at ehci_hcd_init time, not at board_usb_init, which is the more obvious init point and saves time if you are not going to use usb in your boot process at all
---
This patch is based on the u-boot-usb tree
I've tested this on the Colibri T20 platform with no functional regressions. All 3 USB controllers (both UTMI and ULPI) work as before the change.
--- arch/arm/cpu/armv7/tegra20/Makefile | 2 - .../tegra20/usb.c => drivers/usb/host/ehci-tegra.c | 210 +++++++++++---------- 2 Dateien ge?ndert, 109 Zeilen hinzugef?gt(+), 103 Zeilen entfernt(-) rename arch/arm/cpu/armv7/tegra20/usb.c => drivers/usb/host/ehci-tegra.c (87%)
arch/arm/cpu/armv7/tegra20/Makefile +0 -2
@@ -27,8 +27,6 @@ include $(TOPDIR)/config.mk LIB = $(obj)lib$(SOC).o -COBJS-$(CONFIG_USB_EHCI_TEGRA) += usb.o - COBJS := $(COBJS-y) SRCS := $(COBJS:.o=.c) OBJS := $(addprefix $(obj),$(COBJS))
drivers/usb/host/ehci-tegra.c renamed from arch/arm/cpu/armv7/tegra20/usb.c +109 -101
309 lines not on this page · raw message
Signature · 1 line
1.7.11.7
PATCH 1/1 usb: tegra: move Tegra EHCI implementation to correct place
Dear Lucas Stach,
Quoted 5 lines
Move the Tegra EHCI implementation to the correct directory in the tree. This code is specific to the Tegra EHCI controller, not to the Tegra SoC in general.
This is not just a move of the code, but also some small changes squashed
Unsquash them please, it's really hard to review. Also, use git format-patch -M -C to generate the patchset and to detect renames.
Quoted 8 lines
in. Most notable:
- removed some unneeded parameters from function calls, to make functions more self contained
- decrease max controller count to 3, both Tegra 2 and 3 have at most 3 EHCI controllers, we can aleays increase this later if the need arises
- controllers only get activated atehci_hcd_inittime, not atboard_usb_init, which is the more obvious init point and saves time if you are not going to use usb in your boot process at all
[...]
Best regards,
Marek Vasut
PATCH 1/1 usb: tegra: move Tegra EHCI implementation to correct place
Hi Marek,
Am Freitag, den 26.10.2012, 09:09 +0200 schrieb Marek Vasut:
Quoted 11 lines
Dear Lucas Stach,
Quoted 5 lines
Move the Tegra EHCI implementation to the correct directory in the tree. This code is specific to the Tegra EHCI controller, not to the Tegra SoC in general.
This is not just a move of the code, but also some small changes squashed
Unsquash them please, it's really hard to review. Also, use git format-patch -M -C to generate the patchset and to detect renames.
I've generated the patch with format-patch -B -M -C, so what you see is basically the diff of the original file with the new implementation. So the diff shows all the small changes I blather about.
The changes are squashed in because I did them while moving the implementation over, and I would like to avoid doing them in single patches as it's notably more work and IMHO with the current diff you can clearly see what changed. So please let me know if you are really that keen to have them as separate patches, but it may take me some while to respin this as I'm occupied with other things right now.
Thanks,
Lucas
Quoted 12 lines
Quoted 8 lines
in. Most notable:
- removed some unneeded parameters from function calls, to make functions more self contained
- decrease max controller count to 3, both Tegra 2 and 3 have at most 3 EHCI controllers, we can aleays increase this later if the need arises
- controllers only get activated atehci_hcd_inittime, not atboard_usb_init, which is the more obvious init point and saves time if you are not going to use usb in your boot process at all[...]
Best regards,
Marek Vasut
PATCH 1/1 usb: tegra: move Tegra EHCI implementation to correct place
Dear Lucas Stach,
Quoted 19 lines
Hi Marek,
Am Freitag, den 26.10.2012, 09:09 +0200 schrieb Marek Vasut:
Quoted 11 lines
Dear Lucas Stach,
Quoted 6 lines
Move the Tegra EHCI implementation to the correct directory in the tree. This code is specific to the Tegra EHCI controller, not to the Tegra SoC in general.
This is not just a move of the code, but also some small changes squashed
Unsquash them please, it's really hard to review. Also, use git format-patch -M -C to generate the patchset and to detect renames.
I've generated the patch with format-patch -B -M -C, so what you see is basically the diff of the original file with the new implementation. So the diff shows all the small changes I blather about.
Quoted 6 lines
The changes are squashed in because I did them while moving the implementation over, and I would like to avoid doing them in single patches as it's notably more work and IMHO with the current diff you can clearly see what changed. So please let me know if you are really that keen to have them as separate patches, but it may take me some while to respin this as I'm occupied with other things right now.
[...]
Let's do it properly please.
Best regards,
Marek Vasut
PATCH 1/1 usb: tegra: move Tegra EHCI implementation to correct place
Hi Lucas,
Quoted 27 lines · Marek Vasut
Dear Lucas Stach,
Quoted 19 lines
Hi Marek,
Am Freitag, den 26.10.2012, 09:09 +0200 schrieb Marek Vasut:
Quoted 11 lines
Dear Lucas Stach,
Quoted 6 lines
Move the Tegra EHCI implementation to the correct directory in the tree. This code is specific to the Tegra EHCI controller, not to the Tegra SoC in general.
This is not just a move of the code, but also some small changes squashed
Unsquash them please, it's really hard to review. Also, use git format-patch -M -C to generate the patchset and to detect renames.
I've generated the patch with format-patch -B -M -C, so what you see is basically the diff of the original file with the new implementation. So the diff shows all the small changes I blather about.
Quoted 6 lines
The changes are squashed in because I did them while moving the implementation over, and I would like to avoid doing them in single patches as it's notably more work and IMHO with the current diff you can clearly see what changed. So please let me know if you are really that keen to have them as separate patches, but it may take me some while to respin this as I'm occupied with other things right now.
Quoted 3 lines
[...]
Let's do it properly please.
Sorry, but I agree. I did start reviewing it, but stopped because really we shouldn't have so many things in one patch.
Regards,
Simon
Quoted 3 lines
Best regards,
Marek Vasut